Skip to contentSkip to conversation

xserver: xdm chats with accounts daemon over dbus

PATCH New Dominick Grift 2 participants 3 messages Sep 24, 2013 – Sep 26, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 10/20 xserver: xdm chats with accounts daemon over dbus

make xdm_t a dbus session bus client type so that unconfined_t can chat with it and acquire service on it

---
 policy/modules/services/xserver.te | 9 +++++++++
 1 file changed, 9 insertions(+)
policy/modules/services/xserver.te +9 -0
index 4f6d693..63298c5 100644
@@ -502,6 +502,10 @@ tunable_policy(`xdm_sysadm_login',`
 ')
 
 optional_policy(`
+	accountsd_dbus_chat(xdm_t)
+')
+
+optional_policy(`
 	alsa_domtrans(xdm_t)
 ')
 
@@ -514,6 +518,11 @@ optional_policy(`
 ')
 
 optional_policy(`
+	dbus_system_bus_client(xdm_t)
+	dbus_connect_system_bus(xdm_t)
+')
+
+optional_policy(`
 	# Talk to the console mouse server.
 	gpm_stream_connect(xdm_t)
 	gpm_setattr_gpmctl(xdm_t)
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 10/20 xserver: xdm chats with accounts daemon over dbus

Quoted 13 lines · Dominick Grift

make xdm_t a dbus session bus client type so that unconfined_t can chat with it and acquire service on it

---
 policy/modules/services/xserver.te | 9 +++++++++
 1 file changed, 9 insertions(+)
policy/modules/services/xserver.te +0 -0
index 4f6d693..63298c5 100644

policy/modules/services/xserver.te tunable_policy(`xdm_sysadm_login',` · line 506

Quoted 5 lines
policy/modules/services/xserver.te +2 -0
@@ -502,6 +502,10 @@ tunable_policy(`xdm_sysadm_login',`
 ')
 
 optional_policy(`
+	accountsd_dbus_chat(xdm_t)
+')

I think it makes more sense for this to be nested in the optional you added below for the dbus session bus.

Quoted 6 lines
policy/modules/services/xserver.te +1 -0
+optional_policy(`
 	alsa_domtrans(xdm_t)
 ')
 
@@ -514,6 +518,11 @@ optional_policy(`
 ')

policy/modules/services/xserver.te optional_policy(` · line 528

Quoted 10 lines
policy/modules/services/xserver.te +5 -0
 
 optional_policy(`
+	dbus_system_bus_client(xdm_t)
+	dbus_connect_system_bus(xdm_t)
+')
+
+optional_policy(`
 	# Talk to the console mouse server.
 	gpm_stream_connect(xdm_t)
 	gpm_setattr_gpmctl(xdm_t)

--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

#2 lore raw

PATCH 10/20 xserver: xdm chats with accounts daemon over dbus

Quoted 16 lines · Christopher J. PeBenito
Quoted 15 lines · Dominick Grift

make xdm_t a dbus session bus client type so that unconfined_t can chat with it and acquire service on it

---
 policy/modules/services/xserver.te | 9 +++++++++
 1 file changed, 9 insertions(+)
policy/modules/services/xserver.te +0 -0
index 4f6d693..63298c5 100644
@@ -502,6 +502,10 @@ tunable_policy(`xdm_sysadm_login',`
 ')
 
Quoted 6 lines

policy/modules/services/xserver.te tunable_policy(`xdm_sysadm_login',` · line 506

Quoted 3 lines
policy/modules/services/xserver.te +2 -0
 optional_policy(`
+	accountsd_dbus_chat(xdm_t)
+')

I think it makes more sense for this to be nested in the optional you added below for the dbus session bus.

Yes i noticed that as well and i will redo this

Quoted 24 lines
Quoted 7 lines
policy/modules/services/xserver.te +1 -0
+optional_policy(`
 	alsa_domtrans(xdm_t)
 ')
 
@@ -514,6 +518,11 @@ optional_policy(`
 ')

policy/modules/services/xserver.te optional_policy(` · line 528

Quoted 10 lines
policy/modules/services/xserver.te +5 -0
 
 optional_policy(`
+	dbus_system_bus_client(xdm_t)
+	dbus_connect_system_bus(xdm_t)
+')
+
+optional_policy(`
 	# Talk to the console mouse server.
 	gpm_stream_connect(xdm_t)
 	gpm_setattr_gpmctl(xdm_t)

--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com