Add a missing comma to the list of CEA VICs
PATCH 1/3 Add a missing comma to the list of CEA VICs
Signed-off-by Thomas Wood <[email protected]>
--- edid-decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
edid-decode.c +1 -1
@@ -649,7 +649,7 @@ static const char *edid_cea_modes[] = {"1440x240@60Hz" ,"1440x240@60Hz" ,"2880x480i@60Hz" , -"2880x480i@60Hz" +"2880x480i@60Hz" ,"2880x240@60Hz" ,"2880x240@60Hz" , "1440x480@60Hz",
Signature · 1 line
1.8.3.1
PATCH 2/3 Include the last VIC in the CEA video block
Signed-off-by Thomas Wood <[email protected]>
--- edid-decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
edid-decode.c +1 -1
@@ -711,7 +711,7 @@ cea_video_block(unsigned char *x)int i;int length = x[0 ] &0x1f ; -for (i =1 ; i < length; i++) { +for (i =1 ; i <= length; i++) {unsigned char vic = x[i] &0x7f ;unsigned char native = x[i] &0x80 ;const char *mode;
Signature · 1 line
1.8.3.1
PATCH 3/3 Print the correct VIC number next to the mode
In reply to Thomas WoodSigned-off-by Thomas Wood <[email protected]>
--- edid-decode.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
edid-decode.c +4 -3
@@ -715,10 +715,11 @@ cea_video_block(unsigned char *x)unsigned char vic = x[i] &0x7f ;unsigned char native = x[i] &0x80 ;const char *mode; +int index; - vic--; -if (vic <ARRAY_SIZE (edid_cea_modes)) - mode = edid_cea_modes[vic]; + index = vic -1 ; +if (index <ARRAY_SIZE (edid_cea_modes)) + mode = edid_cea_modes[index];else mode ="Unknown mode" ;
Signature · 1 line
1.8.3.1
Quoted 1 line · Thomas Wood
Signed-off-by Thomas Wood <[email protected]>
For the series (that fixes 2 embarassing bugs from me and 1 long standing one that wasn't parsing the last CEA VIC):
Reviewed-by Damien Lespiau <[email protected]>
Signature · 1 line
Damien
Quoted 1 line · Thomas Wood
Signed-off-by Thomas Wood <[email protected]>
Thanks for the series, all pushed with the virtual nod from Ajax on IRC.
Signature · 1 line
Damien