Skip to contentSkip to conversation

regulator: ti-abb: misc fixes

PATCH Applied Nishanth Menon 2 participants 5 messages Sep 27, 2013 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

cover regulator: ti-abb: misc fixes

The following are a couple of fixes for ti-abb regulator based on updated I documentation and tests.

Based on v3.12-rc2 tag. These fixes could be punted to 3.13-rc1 as the current OMAP support in master is not ready for use yet.

Nishanth Menon (2):
regulator: ti-abb: skip optional parameter for ldo-address
regulator: ti-abb: Fix bias voltage glitch in transition to bypass
mode with ldo voltage override

 drivers/regulator/ti-abb-regulator.c |   21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)
Signature · 4 lines
1.7.9.5

Regards,
Nishanth Menon
#1 lore raw

PATCH 1/2 regulator: ti-abb: skip optional parameter for ldo-address

On platforms like OMAP4460, LDO override is never used. Even though efuse determines the ABB bias mode to operate at, ABB voltage is preconfigured in internal efuse registers without the need for LDO override for bias voltage. So skip optional parameter if property is not present.

---
 drivers/regulator/ti-abb-regulator.c |    5 +++++
 1 file changed, 5 insertions(+)
drivers/regulator/ti-abb-regulator.c +5 -0
index d8e3e12..1e02805 100644
@@ -765,6 +765,11 @@ static int ti_abb_probe(struct platform_device *pdev)
 
 	pname = "ldo-address";
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
+	if (!res) {
+		dev_dbg(dev, "Missing '%s' IO resource\n", pname);
+		ret = -ENODEV;
+		goto skip_opt;
+	}
 	abb->ldo_base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(abb->ldo_base)) {
 		ret = PTR_ERR(abb->ldo_base);
Signature · 1 line
1.7.9.5
maintainer Applied
#2 lore raw

Re: [PATCH 1/2] regulator: ti-abb: skip optional parameter for ldo-address

Quoted 5 lines · Nishanth Menon

On platforms like OMAP4460, LDO override is never used. Even though efuse determines the ABB bias mode to operate at, ABB voltage is preconfigured in internal efuse registers without the need for LDO override for bias voltage. So skip optional parameter if property is not present.

Applied, thanks.

#3 lore raw

PATCH 2/2 regulator: ti-abb: Fix bias voltage glitch in transition to bypass mode with ldo voltage override

In reply to Nishanth Menon

As documented in Application Note SWPA117 v2.1(NDA), LDO override has a requirement that when switching from Bias active + override active mode(FBB/RBB) to Bypass(nominal) mode, LDO reset must be performed *after* LDO transitions to Bypass(nominal) mode.

The same rule in reverse applies when switching from a ABB bypass mode to ABB enabled - LDO override *must* be performed prior to transition to required ABB mode, if we do not do that, the same glitch takes place.

Currently while transitioning to ABB bypass, we reset the LDO overide prior to the transition which causes a few milliseconds where ABB LDO voltage could go all the way to 800mV(based on SoC process node), during this period, the delta voltage between VDD rail and VBB rail could cause the system to improperly function.

---
 drivers/regulator/ti-abb-regulator.c |   16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/regulator/ti-abb-regulator.c +14 -2
index 1e02805..b951a84 100644
@@ -279,8 +279,12 @@ static int ti_abb_set_opp(struct regulator_dev *rdev, struct ti_abb *abb,
 	ti_abb_rmw(regs->opp_sel_mask, info->opp_sel, regs->control_reg,
 		   abb->base);
 
-	/* program LDO VBB vset override if needed */
-	if (abb->ldo_base)
+	/*
+	 * program LDO VBB vset override if needed for !bypass mode
+	 * XXX: Do not switch sequence - for !bypass, LDO override reset *must*
+	 * be performed *before* switch to bias mode else VBB glitches.
+	 */
+	if (abb->ldo_base && info->opp_sel != TI_ABB_NOMINAL_OPP)
 		ti_abb_program_ldovbb(dev, abb, info);
 
 	/* Initiate ABB ldo change */
@@ -295,6 +299,14 @@ static int ti_abb_set_opp(struct regulator_dev *rdev, struct ti_abb *abb,
 	if (ret)
 		goto out;
 
+	/*
+	 * Reset LDO VBB vset override bypass mode
+	 * XXX: Do not switch sequence - for bypass, LDO override reset *must*
+	 * be performed *after* switch to bypass else VBB glitches.
+	 */
+	if (abb->ldo_base && info->opp_sel == TI_ABB_NOMINAL_OPP)
+		ti_abb_program_ldovbb(dev, abb, info);
+
 out:
 	return ret;
 }
Signature · 1 line
1.7.9.5
maintainer Applied
#4 lore raw

Re: [PATCH 2/2] regulator: ti-abb: Fix bias voltage glitch in transition to bypass mode with ldo voltage override

Quoted 4 lines · Nishanth Menon

As documented in Application Note SWPA117 v2.1(NDA), LDO override has a requirement that when switching from Bias active + override active mode(FBB/RBB) to Bypass(nominal) mode, LDO reset must be performed *after* LDO transitions to Bypass(nominal) mode.

Applied, thanks.