Skip to contentSkip to conversation

ARM: ux500: cpuidle: fix section mismatch

PATCH New Daniel Lezcano 2 participants 2 messages Sep 27, 2013 – Sep 29, 2013 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: ux500: cpuidle: fix section mismatch

The dbx500_cpuidle_probe is tagged as an __init section but the variable dbx500_cpuidle_plat_driver is not.

The dbx500_cpuidle_probe could not be declared as __init because of macro module_platform_driver builds the exit function, tags as __exit and this one refers to the dbx500_cpuidle_plat_driver which is an __initdata.

That leads to a section mismatch.

Fix it by removing the __init tag for the probe function.

---
 drivers/cpuidle/cpuidle-ux500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpuidle/cpuidle-ux500.c +1 -1
index e056465..5e35804 100644
@@ -111,7 +111,7 @@ static struct cpuidle_driver ux500_idle_driver = {
 	.state_count = 2,
 };
 
-static int __init dbx500_cpuidle_probe(struct platform_device *pdev)
+static int dbx500_cpuidle_probe(struct platform_device *pdev)
 {
 	/* Configure wake up reasons */
 	prcmu_enable_wakeups(PRCMU_WAKEUP(ARM) | PRCMU_WAKEUP(RTC) |
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: ux500: cpuidle: fix section mismatch

Quoted 7 lines · Daniel Lezcano

The dbx500_cpuidle_probe is tagged as an __init section but the variable dbx500_cpuidle_plat_driver is not.

The dbx500_cpuidle_probe could not be declared as __init because of macro module_platform_driver builds the exit function, tags as __exit and this one refers to the dbx500_cpuidle_plat_driver which is an __initdata.

Quoted 5 lines

That leads to a section mismatch.

Fix it by removing the __init tag for the probe function.

Sorry if I caused this and thanks for fixing it up!

Yours,
Linus Walleij