Skip to contentSkip to conversation

seutils: restorecon wants to read /run symbolic link

PATCH New Dominick Grift 2 participants 5 messages Sep 24, 2013 – Sep 27, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 4/20 seutils: restorecon wants to read /run symbolic link

Do not audit attempts by fixfiles to read all symbolic links

---
 policy/modules/system/selinuxutil.te | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
policy/modules/system/selinuxutil.te +1 -1
index 5622246..ff19d75 100644
@@ -552,7 +552,7 @@ files_read_etc_runtime_files(setfiles_t)
 files_read_etc_files(setfiles_t)
 files_list_all(setfiles_t)
 files_relabel_all_files(setfiles_t)
-files_read_usr_symlinks(setfiles_t)
+files_dontaudit_read_all_symlinks(setfiles_t)
 
 fs_getattr_xattr_fs(setfiles_t)
 fs_list_all(setfiles_t)
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 4/20 seutils: restorecon wants to read /run symbolic link

Quoted 12 lines · Dominick Grift

Do not audit attempts by fixfiles to read all symbolic links

---
 policy/modules/system/selinuxutil.te | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
policy/modules/system/selinuxutil.te +0 -0
index 5622246..ff19d75 100644

policy/modules/system/selinuxutil.te files_read_etc_runtime_files(setfiles_t) · line 558

Quoted 8 lines
policy/modules/system/selinuxutil.te +1 -1
@@ -552,7 +552,7 @@ files_read_etc_runtime_files(setfiles_t)
 files_read_etc_files(setfiles_t)
 files_list_all(setfiles_t)
 files_relabel_all_files(setfiles_t)
-files_read_usr_symlinks(setfiles_t)
+files_dontaudit_read_all_symlinks(setfiles_t)
 
 fs_getattr_xattr_fs(setfiles_t)
 fs_list_all(setfiles_t)

Can you further clarify this? Setfiles hasn't changed much in years, so I'm unclear on why this change is necessary.

--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

#2 lore raw

PATCH 4/20 seutils: restorecon wants to read /run symbolic link

Quoted 19 lines · Christopher J. PeBenito
Quoted 18 lines · Dominick Grift

Do not audit attempts by fixfiles to read all symbolic links

---
 policy/modules/system/selinuxutil.te | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
policy/modules/system/selinuxutil.te +1 -1
index 5622246..ff19d75 100644
@@ -552,7 +552,7 @@ files_read_etc_runtime_files(setfiles_t)
 files_read_etc_files(setfiles_t)
 files_list_all(setfiles_t)
 files_relabel_all_files(setfiles_t)
-files_read_usr_symlinks(setfiles_t)
+files_dontaudit_read_all_symlinks(setfiles_t)
 
Quoted 5 lines

policy/modules/system/selinuxutil.te files_read_etc_runtime_files(setfiles_t) · line 558

Quoted 2 lines
policy/modules/system/selinuxutil.te +0 -0
 fs_getattr_xattr_fs(setfiles_t)
 fs_list_all(setfiles_t)

Can you further clarify this? Setfiles hasn't changed much in years, so I'm unclear on why this change is necessary.

This is not so much related to setfiles

its related to recent changes of locations. for example /var/run -> /run, /bin -> /usr/bin etc.

So now /var/run is a symlink to /run.

setfiles doesnt follow symlinks so we might as well silently deny access to read all symlinks

Quoted 5 lines

--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

#3 lore raw

PATCH 4/20 seutils: restorecon wants to read /run symbolic link

Quoted 28 lines · Dominick Grift
Quoted 19 lines · Christopher J. PeBenito
Quoted 18 lines · Dominick Grift

Do not audit attempts by fixfiles to read all symbolic links

---
 policy/modules/system/selinuxutil.te | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
policy/modules/system/selinuxutil.te +1 -1
index 5622246..ff19d75 100644
@@ -552,7 +552,7 @@ files_read_etc_runtime_files(setfiles_t)
 files_read_etc_files(setfiles_t)
 files_list_all(setfiles_t)
 files_relabel_all_files(setfiles_t)
-files_read_usr_symlinks(setfiles_t)
+files_dontaudit_read_all_symlinks(setfiles_t)
 
Quoted 5 lines

policy/modules/system/selinuxutil.te files_read_etc_runtime_files(setfiles_t) · line 558

Quoted 2 lines
policy/modules/system/selinuxutil.te +0 -0
 fs_getattr_xattr_fs(setfiles_t)
 fs_list_all(setfiles_t)

Can you further clarify this? Setfiles hasn't changed much in years, so I'm unclear on why this change is necessary.

This is not so much related to setfiles

Quoted 7 lines

its related to recent changes of locations. for example /var/run -> /run, /bin -> /usr/bin etc.

So now /var/run is a symlink to /run.

setfiles doesnt follow symlinks so we might as well silently deny access to read all symlinks

I'm reluctant to remove the usr_t access, since it might be needed from one of the libs setfiles uses, rather than setfiles itself.

--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

#4 lore raw

PATCH 4/20 seutils: restorecon wants to read /run symbolic link

Quoted 32 lines · Christopher J. PeBenito
Quoted 31 lines · Dominick Grift
Quoted 19 lines · Christopher J. PeBenito
Quoted 18 lines · Dominick Grift

Do not audit attempts by fixfiles to read all symbolic links

---
 policy/modules/system/selinuxutil.te | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
policy/modules/system/selinuxutil.te +1 -1
index 5622246..ff19d75 100644
@@ -552,7 +552,7 @@ files_read_etc_runtime_files(setfiles_t)
 files_read_etc_files(setfiles_t)
 files_list_all(setfiles_t)
 files_relabel_all_files(setfiles_t)
-files_read_usr_symlinks(setfiles_t)
+files_dontaudit_read_all_symlinks(setfiles_t)
 
Quoted 5 lines

policy/modules/system/selinuxutil.te files_read_etc_runtime_files(setfiles_t) · line 558

Quoted 2 lines
policy/modules/system/selinuxutil.te +0 -0
 fs_getattr_xattr_fs(setfiles_t)
 fs_list_all(setfiles_t)

Can you further clarify this? Setfiles hasn't changed much in years, so I'm unclear on why this change is necessary.

This is not so much related to setfiles

its related to recent changes of locations. for example /var/run -> /run, /bin -> /usr/bin etc.

Quoted 7 lines
Quoted 4 lines

So now /var/run is a symlink to /run.

setfiles doesnt follow symlinks so we might as well silently deny access to read all symlinks

I'm reluctant to remove the usr_t access, since it might be needed from one of the libs setfiles uses, rather than setfiles itself.

ok thats fine , then please just add the donaudit for the others

Quoted 5 lines

--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com