Skip to contentSkip to conversation

thermal: bcm281xx: Add thermal driver

PATCH In review Wendy Ng 2 participants 10 messages Sep 27, 2013 – Oct 16, 2013

Subsystems (6)
lore
Share & tools
lore

Wendy Ng

author
#0 lore raw

v2 cover thermal: bcm281xx: Add thermal driver

This patch series adds the support of the thermal driver for Broadcom bcm281xx family of SoCs.

The change for this version of the patch is to work with the ARCH_BCM->ARCH_BCM_MOBILE renaming series as shown in the link below:
http://www.spinics.net/lists/arm-kernel/msg274963.html

Wendy Ng (3):
thermal: bcm281xx: Add thermal driver
ARM: bcm281xx: Turn on Thermal and HWMON drivers.
ARM: bcm281xx: Add thermal driver to device tree.

 .../bindings/thermal/bcm-kona-thermal.txt          |   18 +++
 arch/arm/boot/dts/bcm11351-brt.dts                 |    4 +-
 arch/arm/boot/dts/bcm11351.dtsi                    |    6 +
 arch/arm/boot/dts/bcm28155-ap.dts                  |    4 +
 arch/arm/configs/bcm_defconfig                     |    3 +-
 drivers/thermal/Kconfig                            |   10 ++
 drivers/thermal/Makefile                           |    1 +
 drivers/thermal/bcm_thermal.c                      |  170 ++++++++++++++++++++
 8 files changed, 214 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
 create mode 100644 drivers/thermal/bcm_thermal.c
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH v2 1/3 thermal: bcm281xx: Add thermal driver

This adds the support for reading out temperature from Broadcom bcm281xx SoCs.

---
 .../bindings/thermal/bcm-kona-thermal.txt          |   18 +++
 drivers/thermal/Kconfig                            |   10 ++
 drivers/thermal/Makefile                           |    1 +
 drivers/thermal/bcm_thermal.c                      |  170 ++++++++++++++++++++
 4 files changed, 199 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
 create mode 100644 drivers/thermal/bcm_thermal.c
Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt new file +18 -0
new file mode 100644
index 0000000..acca99e
@@ -0,0 +1,18 @@
+* Broadcom Kona Thermal Management Unit
+
+This version is for the BCM281xx family of SoCs.
+
+Required properties:
+- compatible : "brcm,bcm11351-thermal", "brcm,kona-thermal"
+- reg : Address range of the thermal register
+- thermal-name: this entry must be specified and it will be passed into
+thermal_zone_device_register().  This name will also be reported under Hwmon
+sysfs 'name' attribute.
+
+Example:
+	thermal@34008000 {
+		compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
+		reg = <0x34008000 0x0024>;
+		thermal-name = "bcm_kona_therm";
+		status = "disabled";
+	};
drivers/thermal/Kconfig +10 -0
index dbfc390..6a5341c 100644
@@ -134,6 +134,16 @@ config KIRKWOOD_THERMAL
 	  Support for the Kirkwood thermal sensor driver into the Linux thermal
 	  framework. Only kirkwood 88F6282 and 88F6283 have this sensor.
 
+config BCM_THERMAL
+	tristate "Temperature sensor on Broadcom BCM281xx family of SoCs"
+	depends on ARCH_BCM_MOBILE
+	default y
+	help
+	  If you say yes here you get support for TMU (Thermal Management
+	  Unit) on Broadcom BCM281xx family of SoCs. This provides thermal
+	  monitoring of CPU clusters, graphics, and SoC glue, but does not
+	  include monitoring of charger temperature.
+
 config DOVE_THERMAL
 	tristate "Temperature sensor on Marvell Dove SoCs"
 	depends on ARCH_DOVE
drivers/thermal/Makefile +1 -0
index 584b363..3ea8c1c 100644
@@ -21,6 +21,7 @@ obj-$(CONFIG_SPEAR_THERMAL)	+= spear_thermal.o
 obj-$(CONFIG_RCAR_THERMAL)	+= rcar_thermal.o
 obj-$(CONFIG_KIRKWOOD_THERMAL)  += kirkwood_thermal.o
 obj-y				+= samsung/
+obj-$(CONFIG_BCM_THERMAL)       += bcm_thermal.o
 obj-$(CONFIG_DOVE_THERMAL)  	+= dove_thermal.o
 obj-$(CONFIG_DB8500_THERMAL)	+= db8500_thermal.o
 obj-$(CONFIG_ARMADA_THERMAL)	+= armada_thermal.o
drivers/thermal/bcm_thermal.c new file +170 -0

170 lines not on this page · raw message

Signature · 7 lines
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
Quoted 21 lines · Wendy Ng

This adds the support for reading out temperature from Broadcom bcm281xx SoCs.

---
 .../bindings/thermal/bcm-kona-thermal.txt          |   18 +++
 drivers/thermal/Kconfig                            |   10 ++
 drivers/thermal/Makefile                           |    1 +
 drivers/thermal/bcm_thermal.c                      |  170 ++++++++++++++++++++
 4 files changed, 199 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
 create mode 100644 drivers/thermal/bcm_thermal.c
Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt new file +0 -0
new file mode 100644
index 0000000..acca99e

Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt line 3

Quoted 3 lines
Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt new file +3 -0
@@ -0,0 +1,18 @@
+* Broadcom Kona Thermal Management Unit
+
+This version is for the BCM281xx family of SoCs.

Might be worth describing the hardware a bit and also appending a link to its documentation for further details.

Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt line 10

Quoted 7 lines
Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt new file +7 -0
+
+Required properties:
+- compatible : "brcm,bcm11351-thermal", "brcm,kona-thermal"
+- reg : Address range of the thermal register
+- thermal-name: this entry must be specified and it will be passed into
+thermal_zone_device_register().  This name will also be reported under Hwmon
+sysfs 'name' attribute.

I guess by now you already remember my suggestion on this dt property. If you can drop it then we could proceed with this driver. But with it we are adding something specific to it that may be soon deprecated.

Quoted 13 lines
Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt new file +8 -0
+
+Example:
+	thermal@34008000 {
+		compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
+		reg = <0x34008000 0x0024>;
+		thermal-name = "bcm_kona_therm";
+		status = "disabled";
+	};
drivers/thermal/Kconfig +0 -0
index dbfc390..6a5341c 100644

drivers/thermal/Kconfig config KIRKWOOD_THERMAL · line 139

Quoted 6 lines
drivers/thermal/Kconfig +3 -0
@@ -134,6 +134,16 @@ config KIRKWOOD_THERMAL
 	  Support for the Kirkwood thermal sensor driver into the Linux thermal
 	  framework. Only kirkwood 88F6282 and 88F6283 have this sensor.
 
+config BCM_THERMAL
+	tristate "Temperature sensor on Broadcom BCM281xx family of SoCs"
+	depends on ARCH_BCM_MOBILE

Is the sensor IP used only on this Arch? No plans for re-usability?

Quoted 67 lines
drivers/thermal/Kconfig +7 -0
+	default y
+	help
+	  If you say yes here you get support for TMU (Thermal Management
+	  Unit) on Broadcom BCM281xx family of SoCs. This provides thermal
+	  monitoring of CPU clusters, graphics, and SoC glue, but does not
+	  include monitoring of charger temperature.
+
 config DOVE_THERMAL
 	tristate "Temperature sensor on Marvell Dove SoCs"
 	depends on ARCH_DOVE
drivers/thermal/Makefile +1 -0
index 584b363..3ea8c1c 100644
@@ -21,6 +21,7 @@ obj-$(CONFIG_SPEAR_THERMAL)	+= spear_thermal.o
 obj-$(CONFIG_RCAR_THERMAL)	+= rcar_thermal.o
 obj-$(CONFIG_KIRKWOOD_THERMAL)  += kirkwood_thermal.o
 obj-y				+= samsung/
+obj-$(CONFIG_BCM_THERMAL)       += bcm_thermal.o
 obj-$(CONFIG_DOVE_THERMAL)  	+= dove_thermal.o
 obj-$(CONFIG_DB8500_THERMAL)	+= db8500_thermal.o
 obj-$(CONFIG_ARMADA_THERMAL)	+= armada_thermal.o
drivers/thermal/bcm_thermal.c new file +39 -0
new file mode 100644
index 0000000..131d3c4
@@ -0,0 +1,170 @@
+/*
+ * Copyright 2013 Broadcom Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License, version 2,
+ * as published by the Free Software Foundation (the "GPL").
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * A copy of the GPL is available at http://www.broadcom.com/licenses/GPLv2.php,
+ * or by writing to the Free Software Foundation, Inc.,
+ * 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ */
+
+/**
+*  Broadcom Thermal Management Unit - bcm_tmu
+*/
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/io.h>
+#include <linux/thermal.h>
+#include <linux/of.h>
+
+/* From TMON Register Database */
+#define TMON_TEMP_VAL_OFFSET			0x0000001c
+#define TMON_TEMP_VAL_TEMP_VAL_SHIFT		0
+#define TMON_TEMP_VAL_TEMP_VAL_MASK		0x000003ff
+
+/* Broadcom Thermal Zone Device Structure */
+struct bcm_thermal_zone_priv {
+	char name[THERMAL_NAME_LENGTH];
+	void __iomem *base;
+};
+

drivers/thermal/bcm_thermal.c line 49

Quoted 10 lines
drivers/thermal/bcm_thermal.c new file +10 -0
+/* Temperature conversion function for TMON block */
+static long raw_to_mcelsius(u32 raw)
+{
+	/*
+	 * According to Broadcom internal Analog Module Specification
+	 * the formula for converting TMON block output to temperature in
+	 * degree Celsius is:
+	 *	T = 428 - (0.561 * raw)
+	 * Note: the valid operating range for the TMON block is -40C to 125C
+	 */

Does 125C mean silicon is not reliable? Shall we define a critical trip at this level?

Quoted 19 lines
drivers/thermal/bcm_thermal.c new file +19 -0
+	return 428000 - (561 * (long)raw);
+}
+
+/* Get temperature callback function for thermal zone */
+static int bcm_get_temp(struct thermal_zone_device *thermal,
+			unsigned long *temp)
+{
+	u32 raw;
+	long mcelsius;
+	struct bcm_thermal_zone_priv *priv = thermal->devdata;
+
+	if (!priv) {
+		pr_err("%s: thermal zone number %d devdata not initialized.\n",
+			__func__, thermal->id);
+		return -EINVAL;
+	}
+
+	raw = (readl(priv->base + TMON_TEMP_VAL_OFFSET)
+		& TMON_TEMP_VAL_TEMP_VAL_MASK) >> TMON_TEMP_VAL_TEMP_VAL_SHIFT;

drivers/thermal/bcm_thermal.c line 78

Quoted 10 lines
drivers/thermal/bcm_thermal.c new file +10 -0
+
+	pr_debug("%s: thermal zone number %d raw temp 0x%x\n", __func__,
+		thermal->id, raw);
+
+	mcelsius = raw_to_mcelsius(raw);
+
+	/*
+	 * Since 'mcelsius' might be negative, we need to limit it to smallest
+	 * unsigned value before returning it to thermal framework.
+	 */

Do you have practical usage of negative values?

Quoted 28 lines
drivers/thermal/bcm_thermal.c new file +28 -0
+	if (mcelsius < 0)
+		*temp = 0;
+	else
+		*temp = mcelsius;
+
+	pr_debug("%s: thermal zone number %d final temp %d\n", __func__,
+		thermal->id, (int) *temp);
+
+	return 0;
+}
+
+/* Operation callback functions for thermal zone */
+static struct thermal_zone_device_ops bcm_dev_ops = {
+	.get_temp = bcm_get_temp,
+};
+
+static const struct of_device_id bcm_tmu_match_table[] = {
+	{ .compatible = "brcm,kona-thermal" },
+	{},
+};
+MODULE_DEVICE_TABLE(of, bcm_tmu_match_table);
+
+static int bcm_tmu_probe(struct platform_device *pdev)
+{
+	struct thermal_zone_device *thermal = NULL;
+	struct bcm_thermal_zone_priv *priv;
+	struct resource *res;
+	const char *str;

drivers/thermal/bcm_thermal.c line 116

Quoted 10 lines
drivers/thermal/bcm_thermal.c new file +10 -0
+
+	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv) {
+		dev_err(&pdev->dev, "Failed to malloc priv.\n");
+		return -ENOMEM;
+	}
+
+	/* Obtain the tmu name from device tree file */
+	if (of_property_read_string(pdev->dev.of_node, "thermal-name",
+			&str) == 0) {

it is common practice to use a variable to hold the error values.

drivers/thermal/bcm_thermal.c line 129

Quoted 13 lines
drivers/thermal/bcm_thermal.c new file +13 -0
+		strlcpy(priv->name, str, sizeof(priv->name));
+	} else {
+		dev_err(&pdev->dev, "Failed to get thermal-name from DT.\n");
+		return -EINVAL;
+	}
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	priv->base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(priv->base))
+		return PTR_ERR(priv->base);
+
+	thermal = thermal_zone_device_register(priv->name, 0, 0, priv,
+						&bcm_dev_ops, NULL, 0, 0);

No trips, no cooling.. constraint and logic is somewhere in userland?

drivers/thermal/bcm_thermal.c line 138

Quoted 9 lines
drivers/thermal/bcm_thermal.c new file +9 -0
+	if (IS_ERR(thermal)) {
+		dev_err(&pdev->dev,
+			"Failed to register Broadcom thermal zone device.\n");
+		return PTR_ERR(thermal);
+	}
+
+	platform_set_drvdata(pdev, thermal);
+
+	dev_info(&pdev->dev, "Broadcom Thermal Monitor Initialized.\n");

Are you sure you want to be this wordy?

drivers/thermal/bcm_thermal.c line 150

Quoted 12 lines
drivers/thermal/bcm_thermal.c new file +12 -0
+
+	return 0;
+}
+
+static int bcm_tmu_remove(struct platform_device *pdev)
+{
+	struct thermal_zone_device *broadcom_thermal =
+		platform_get_drvdata(pdev);
+
+	thermal_zone_device_unregister(broadcom_thermal);
+
+	dev_info(&pdev->dev, "Broadcom Thermal Monitor Uninitialized.\n");

ditto

Quoted 21 lines
drivers/thermal/bcm_thermal.c new file +20 -0
+
+	return 0;
+}
+
+static struct platform_driver bcm_tmu_driver = {
+	.driver = {
+		.name = "bcm-thermal",
+		.owner = THIS_MODULE,
+		.of_match_table = bcm_tmu_match_table,
+	},
+	.probe = bcm_tmu_probe,
+	.remove = bcm_tmu_remove,
+};
+
+module_platform_driver(bcm_tmu_driver);
+
+MODULE_DESCRIPTION("Broadcom Thermal Driver");
+MODULE_AUTHOR("Broadcom");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:bcm-thermal");
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin
author
#3 lore raw
Quoted 16 lines · Eduardo Valentin
Quoted 15 lines · Wendy Ng

This adds the support for reading out temperature from Broadcom bcm281xx SoCs.

---
  .../bindings/thermal/bcm-kona-thermal.txt          |   18 +++
  drivers/thermal/Kconfig                            |   10 ++
  drivers/thermal/Makefile                           |    1 +
  drivers/thermal/bcm_thermal.c                      |  170 ++++++++++++++++++++
  4 files changed, 199 insertions(+)

create mode 100644 Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt create mode 100644 drivers/thermal/bcm_thermal.c

Quoted 13 lines

Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt line 3

Quoted 9 lines
Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt new file +3 -0
new file mode 100644
index 0000000..acca99e
@@ -0,0 +1,18 @@
+* Broadcom Kona Thermal Management Unit
+
+This version is for the BCM281xx family of SoCs.

Might be worth describing the hardware a bit and also appending a link to its documentation for further details.

I will improve this part in the next version of this patch series.

Quoted 12 lines

Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt line 10

Quoted 7 lines
Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt new file +7 -0
+
+Required properties:
+- compatible : "brcm,bcm11351-thermal", "brcm,kona-thermal"
+- reg : Address range of the thermal register
+- thermal-name: this entry must be specified and it will be passed into
+thermal_zone_device_register().  This name will also be reported under Hwmon
+sysfs 'name' attribute.

I guess by now you already remember my suggestion on this dt property. If you can drop it then we could proceed with this driver. But with it we are adding something specific to it that may be soon deprecated.

Yes, 'thermal-name' will be dropped in the next version of this patch series.

Quoted 94 lines
Quoted 13 lines
Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt new file +8 -0
+
+Example:
+	thermal@34008000 {
+		compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
+		reg = <0x34008000 0x0024>;
+		thermal-name = "bcm_kona_therm";
+		status = "disabled";
+	};
drivers/thermal/Kconfig +0 -0
index dbfc390..6a5341c 100644

drivers/thermal/Kconfig config KIRKWOOD_THERMAL · line 139

Quoted 6 lines
drivers/thermal/Kconfig +3 -0
@@ -134,6 +134,16 @@ config KIRKWOOD_THERMAL
  	  Support for the Kirkwood thermal sensor driver into the Linux thermal
  	  framework. Only kirkwood 88F6282 and 88F6283 have this sensor.
 
+config BCM_THERMAL
+	tristate "Temperature sensor on Broadcom BCM281xx family of SoCs"
+	depends on ARCH_BCM_MOBILE

Is the sensor IP used only on this Arch? No plans for re-usability?

Quoted 72 lines
drivers/thermal/Kconfig +7 -0
+	default y
+	help
+	  If you say yes here you get support for TMU (Thermal Management
+	  Unit) on Broadcom BCM281xx family of SoCs. This provides thermal
+	  monitoring of CPU clusters, graphics, and SoC glue, but does not
+	  include monitoring of charger temperature.
+
  config DOVE_THERMAL
  	tristate "Temperature sensor on Marvell Dove SoCs"
  	depends on ARCH_DOVE
drivers/thermal/Makefile +1 -0
index 584b363..3ea8c1c 100644
@@ -21,6 +21,7 @@ obj-$(CONFIG_SPEAR_THERMAL)	+= spear_thermal.o
  obj-$(CONFIG_RCAR_THERMAL)	+= rcar_thermal.o
  obj-$(CONFIG_KIRKWOOD_THERMAL)  += kirkwood_thermal.o
  obj-y				+= samsung/
+obj-$(CONFIG_BCM_THERMAL)       += bcm_thermal.o
  obj-$(CONFIG_DOVE_THERMAL)  	+= dove_thermal.o
  obj-$(CONFIG_DB8500_THERMAL)	+= db8500_thermal.o
  obj-$(CONFIG_ARMADA_THERMAL)	+= armada_thermal.o
drivers/thermal/bcm_thermal.c new file +44 -0
new file mode 100644
index 0000000..131d3c4
@@ -0,0 +1,170 @@
+/*
+ * Copyright 2013 Broadcom Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License, version 2,
+ * as published by the Free Software Foundation (the "GPL").
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * A copy of the GPL is available at http://www.broadcom.com/licenses/GPLv2.php,
+ * or by writing to the Free Software Foundation, Inc.,
+ * 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ */
+
+/**
+*  Broadcom Thermal Management Unit - bcm_tmu
+*/
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/io.h>
+#include <linux/thermal.h>
+#include <linux/of.h>
+
+/* From TMON Register Database */
+#define TMON_TEMP_VAL_OFFSET			0x0000001c
+#define TMON_TEMP_VAL_TEMP_VAL_SHIFT		0
+#define TMON_TEMP_VAL_TEMP_VAL_MASK		0x000003ff
+
+/* Broadcom Thermal Zone Device Structure */
+struct bcm_thermal_zone_priv {
+	char name[THERMAL_NAME_LENGTH];
+	void __iomem *base;
+};
+
+/* Temperature conversion function for TMON block */
+static long raw_to_mcelsius(u32 raw)
+{
+	/*
+	 * According to Broadcom internal Analog Module Specification
Quoted 9 lines

drivers/thermal/bcm_thermal.c line 49

Quoted 5 lines
drivers/thermal/bcm_thermal.c new file +5 -0
+	 * the formula for converting TMON block output to temperature in
+	 * degree Celsius is:
+	 *	T = 428 - (0.561 * raw)
+	 * Note: the valid operating range for the TMON block is -40C to 125C
+	 */

Does 125C mean silicon is not reliable? Shall we define a critical trip at this level?

The critical trip temperature will be specified through the DTS file with your new thermal binding approach.

Btw, I would like to mention here about the use case of taking the trip-point temperature that is specified in the DTS files to configure hardware specific registers such that an interrupt can be fired according to the trip-point temperature.

Eduardo, you confirmed with me that this is a limitation with your thermal DT binding approach in another email thread. Could you please let me know if you have a plan to address this use-case in your patch series:
https://lkml.org/lkml/2013/9/26/787

Quoted 23 lines
Quoted 23 lines
drivers/thermal/bcm_thermal.c new file +23 -0
+	return 428000 - (561 * (long)raw);
+}
+
+/* Get temperature callback function for thermal zone */
+static int bcm_get_temp(struct thermal_zone_device *thermal,
+			unsigned long *temp)
+{
+	u32 raw;
+	long mcelsius;
+	struct bcm_thermal_zone_priv *priv = thermal->devdata;
+
+	if (!priv) {
+		pr_err("%s: thermal zone number %d devdata not initialized.\n",
+			__func__, thermal->id);
+		return -EINVAL;
+	}
+
+	raw = (readl(priv->base + TMON_TEMP_VAL_OFFSET)
+		& TMON_TEMP_VAL_TEMP_VAL_MASK) >> TMON_TEMP_VAL_TEMP_VAL_SHIFT;
+
+	pr_debug("%s: thermal zone number %d raw temp 0x%x\n", __func__,
+		thermal->id, raw);
+
Quoted 8 lines

drivers/thermal/bcm_thermal.c line 78

Quoted 6 lines
drivers/thermal/bcm_thermal.c new file +6 -0
+	mcelsius = raw_to_mcelsius(raw);
+
+	/*
+	 * Since 'mcelsius' might be negative, we need to limit it to smallest
+	 * unsigned value before returning it to thermal framework.
+	 */

Do you have practical usage of negative values?

No practical usage other than taking care of the possible range that the thermal sensor supports. This code is to prevent a negative value from reporting back to the thermal framework which is treating temperature as an unsigned value.

Quoted 33 lines
Quoted 33 lines
drivers/thermal/bcm_thermal.c new file +32 -0
+	if (mcelsius < 0)
+		*temp = 0;
+	else
+		*temp = mcelsius;
+
+	pr_debug("%s: thermal zone number %d final temp %d\n", __func__,
+		thermal->id, (int) *temp);
+
+	return 0;
+}
+
+/* Operation callback functions for thermal zone */
+static struct thermal_zone_device_ops bcm_dev_ops = {
+	.get_temp = bcm_get_temp,
+};
+
+static const struct of_device_id bcm_tmu_match_table[] = {
+	{ .compatible = "brcm,kona-thermal" },
+	{},
+};
+MODULE_DEVICE_TABLE(of, bcm_tmu_match_table);
+
+static int bcm_tmu_probe(struct platform_device *pdev)
+{
+	struct thermal_zone_device *thermal = NULL;
+	struct bcm_thermal_zone_priv *priv;
+	struct resource *res;
+	const char *str;
+
+	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv) {
+		dev_err(&pdev->dev, "Failed to malloc priv.\n");
Quoted 9 lines

drivers/thermal/bcm_thermal.c line 116

Quoted 6 lines
drivers/thermal/bcm_thermal.c new file +6 -0
+		return -ENOMEM;
+	}
+
+	/* Obtain the tmu name from device tree file */
+	if (of_property_read_string(pdev->dev.of_node, "thermal-name",
+			&str) == 0) {

it is common practice to use a variable to hold the error values.

Thanks for pointing this out. This line of code will be gone in the next version of this patch series. We won't need to get the 'thermal-name' from the DT binding.

Quoted 8 lines
Quoted 8 lines
drivers/thermal/bcm_thermal.c new file +8 -0
+		strlcpy(priv->name, str, sizeof(priv->name));
+	} else {
+		dev_err(&pdev->dev, "Failed to get thermal-name from DT.\n");
+		return -EINVAL;
+	}
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	priv->base = devm_ioremap_resource(&pdev->dev, res);
Quoted 9 lines

drivers/thermal/bcm_thermal.c line 129

Quoted 5 lines
drivers/thermal/bcm_thermal.c new file +5 -0
+	if (IS_ERR(priv->base))
+		return PTR_ERR(priv->base);
+
+	thermal = thermal_zone_device_register(priv->name, 0, 0, priv,
+						&bcm_dev_ops, NULL, 0, 0);

No trips, no cooling.. constraint and logic is somewhere in userland?

The critical trip temperature will be specified in the next version of this patch series. The other passive trip points that need to bind with cooling devices will be added in another patch series in the near future.

Quoted 11 lines

drivers/thermal/bcm_thermal.c line 138

Quoted 9 lines
drivers/thermal/bcm_thermal.c new file +9 -0
+	if (IS_ERR(thermal)) {
+		dev_err(&pdev->dev,
+			"Failed to register Broadcom thermal zone device.\n");
+		return PTR_ERR(thermal);
+	}
+
+	platform_set_drvdata(pdev, thermal);
+
+	dev_info(&pdev->dev, "Broadcom Thermal Monitor Initialized.\n");

Are you sure you want to be this wordy?

Do you see any drawback or issue with this? I would like to understand your concern before changing it so I will get it right the next time. Thanks.

Quoted 28 lines

drivers/thermal/bcm_thermal.c line 150

Quoted 12 lines
drivers/thermal/bcm_thermal.c new file +12 -0
+
+	return 0;
+}
+
+static int bcm_tmu_remove(struct platform_device *pdev)
+{
+	struct thermal_zone_device *broadcom_thermal =
+		platform_get_drvdata(pdev);
+
+	thermal_zone_device_unregister(broadcom_thermal);
+
+	dev_info(&pdev->dev, "Broadcom Thermal Monitor Uninitialized.\n");

ditto

Quoted 13 lines
drivers/thermal/bcm_thermal.c new file +13 -0
+
+	return 0;
+}
+
+static struct platform_driver bcm_tmu_driver = {
+	.driver = {
+		.name = "bcm-thermal",
+		.owner = THIS_MODULE,
+		.of_match_table = bcm_tmu_match_table,
+	},
+	.probe = bcm_tmu_probe,
+	.remove = bcm_tmu_remove,
+};
Quoted 10 lines

drivers/thermal/bcm_thermal.c line 170

Quoted 8 lines
drivers/thermal/bcm_thermal.c new file +7 -0
+
+module_platform_driver(bcm_tmu_driver);
+
+MODULE_DESCRIPTION("Broadcom Thermal Driver");
+MODULE_AUTHOR("Broadcom");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:bcm-thermal");

Hello Eduardo,

Thanks for providing your feedback. I would like to let you know that I have rebased my code with your latest patch series as shown in:

https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux.git/log/?h=thermal_work/thermal_core/dt_parser_rfc_v4

My latest code changes are under *internal* review right now. Once the review is done, then I will send it out to the LKML and you can have another look. I understand your patch series is still under review, so I will try to keep up with it. But once your patch series has been accepted, do you think you can also pick-up my patch series such that they get into the mainline together? I think my patch series is another example to illustrate how to use your new DT binding for the thermal framework.

Signature · 2 lines
Best regards,
-Wendy
author
#4 lore raw

PATCH v2 2/3 ARM: bcm281xx: Turn on Thermal and HWMON drivers.

In reply to Wendy Ng

This enables the thermal and HWMON drivers for Broadcom bcm281xx SoCs.

---
 arch/arm/configs/bcm_defconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/configs/bcm_defconfig +2 -1
index 6e49310..1474661 100644
@@ -83,7 +83,8 @@ CONFIG_SERIAL_8250_DW=y
 CONFIG_HW_RANDOM=y
 CONFIG_I2C=y
 CONFIG_I2C_CHARDEV=y
-# CONFIG_HWMON is not set
+CONFIG_THERMAL=y
+CONFIG_HWMON=y
 CONFIG_VIDEO_OUTPUT_CONTROL=y
 CONFIG_FB=y
 CONFIG_BACKLIGHT_LCD_SUPPORT=y
Signature · 1 line
1.7.9.5
#5 lore raw

Re: [PATCH v2 2/3] ARM: bcm281xx: Turn on Thermal and HWMON drivers.

Wendy,

Quoted 14 lines · Wendy Ng

This enables the thermal and HWMON drivers for Broadcom bcm281xx SoCs.

---
 arch/arm/configs/bcm_defconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/configs/bcm_defconfig +0 -0
index 6e49310..1474661 100644

arch/arm/configs/bcm_defconfig CONFIG_SERIAL_8250_DW=y · line 86

Quoted 5 lines
arch/arm/configs/bcm_defconfig +1 -1
@@ -83,7 +83,8 @@ CONFIG_SERIAL_8250_DW=y
 CONFIG_HW_RANDOM=y
 CONFIG_I2C=y
 CONFIG_I2C_CHARDEV=y
-# CONFIG_HWMON is not set
+CONFIG_THERMAL=y

Maybe you also wanted to
CONFIG_BCM_THERMAL=y
?

Quoted 5 lines
arch/arm/configs/bcm_defconfig +1 -0
+CONFIG_HWMON=y
 CONFIG_VIDEO_OUTPUT_CONTROL=y
 CONFIG_FB=y
 CONFIG_BACKLIGHT_LCD_SUPPORT=y
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin
author
#6 lore raw

Re: [PATCH v2 2/3] ARM: bcm281xx: Turn on Thermal and HWMON drivers.

Quoted 12 lines · Eduardo Valentin

Wendy,

Quoted 9 lines · Wendy Ng

This enables the thermal and HWMON drivers for Broadcom bcm281xx SoCs.

---
  arch/arm/configs/bcm_defconfig |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 15 lines

arch/arm/configs/bcm_defconfig CONFIG_SERIAL_8250_DW=y · line 86

Quoted 10 lines
arch/arm/configs/bcm_defconfig +1 -1
index 6e49310..1474661 100644
@@ -83,7 +83,8 @@ CONFIG_SERIAL_8250_DW=y
  CONFIG_HW_RANDOM=y
  CONFIG_I2C=y
  CONFIG_I2C_CHARDEV=y
-# CONFIG_HWMON is not set
+CONFIG_THERMAL=y

Maybe you also wanted to
CONFIG_BCM_THERMAL=y
?

This is not required as I have default BCM_THERMAL to 'y' in Kconfig file.

Quoted 7 lines
Quoted 5 lines
arch/arm/configs/bcm_defconfig +1 -0
+CONFIG_HWMON=y
  CONFIG_VIDEO_OUTPUT_CONTROL=y
  CONFIG_FB=y
  CONFIG_BACKLIGHT_LCD_SUPPORT=y
Signature · 2 lines
Best regards,
-Wendy
author
#7 lore raw

PATCH v2 3/3 ARM: bcm281xx: Add thermal driver to device tree.

In reply to Wendy Ng

This patch adds the device tree node for Broadcom bcm281xx SoCs thermal driver.

---
 arch/arm/boot/dts/bcm11351-brt.dts |    4 +++-
 arch/arm/boot/dts/bcm11351.dtsi    |    6 ++++++
 arch/arm/boot/dts/bcm28155-ap.dts  |    4 ++++
 3 files changed, 13 insertions(+), 1 deletion(-)
arch/arm/boot/dts/bcm11351-brt.dts +3 -1
index 9d36eb4..0771b6b 100644
@@ -43,5 +43,7 @@
 		status = "okay";
 	};
 
-
+	thermal@34008000 {
+		status = "okay";
+	};
 };
arch/arm/boot/dts/bcm11351.dtsi +6 -0
index 05a5aab..aa13353 100644
@@ -96,4 +96,10 @@
 		status = "disabled";
 	};
 
+	thermal@34008000 {
+		compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
+		reg = <0x34008000 0x0024>;
+		thermal-name = "bcm_kona_therm";
+		status = "disabled";
+	};
 };
arch/arm/boot/dts/bcm28155-ap.dts +4 -0
index 96ae67a..a39aa47 100644
@@ -42,4 +42,8 @@
 		max-frequency = <48000000>;
 		status = "okay";
 	};
+
+	thermal@34008000 {
+		status = "okay";
+	};
 };
Signature · 7 lines
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#8 lore raw

Re: [PATCH v2 3/3] ARM: bcm281xx: Add thermal driver to device tree.

Quoted 30 lines · Wendy Ng

This patch adds the device tree node for Broadcom bcm281xx SoCs thermal driver.

---
 arch/arm/boot/dts/bcm11351-brt.dts |    4 +++-
 arch/arm/boot/dts/bcm11351.dtsi    |    6 ++++++
 arch/arm/boot/dts/bcm28155-ap.dts  |    4 ++++
 3 files changed, 13 insertions(+), 1 deletion(-)
arch/arm/boot/dts/bcm11351-brt.dts +3 -1
index 9d36eb4..0771b6b 100644
@@ -43,5 +43,7 @@
 		status = "okay";
 	};
 
-
+	thermal@34008000 {
+		status = "okay";
+	};
 };
arch/arm/boot/dts/bcm11351.dtsi +0 -0
index 05a5aab..aa13353 100644

arch/arm/boot/dts/bcm11351.dtsi line 102

Quoted 7 lines
arch/arm/boot/dts/bcm11351.dtsi +4 -0
@@ -96,4 +96,10 @@
 		status = "disabled";
 	};
 
+	thermal@34008000 {
+		compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
+		reg = <0x34008000 0x0024>;
+		thermal-name = "bcm_kona_therm";

As I mentioned previously, my only concern is this thermal binding, which is specific to your driver (BTW, you would need to do bcm,thermal-name)

Quoted 17 lines
arch/arm/boot/dts/bcm11351.dtsi +2 -0
+		status = "disabled";
+	};
 };
arch/arm/boot/dts/bcm28155-ap.dts +4 -0
index 96ae67a..a39aa47 100644
@@ -42,4 +42,8 @@
 		max-frequency = <48000000>;
 		status = "okay";
 	};
+
+	thermal@34008000 {
+		status = "okay";
+	};
 };
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin
author
#9 lore raw

Re: [PATCH v2 3/3] ARM: bcm281xx: Add thermal driver to device tree.

Quoted 34 lines · Eduardo Valentin
Quoted 33 lines · Wendy Ng

This patch adds the device tree node for Broadcom bcm281xx SoCs thermal driver.

---
  arch/arm/boot/dts/bcm11351-brt.dts |    4 +++-
  arch/arm/boot/dts/bcm11351.dtsi    |    6 ++++++
  arch/arm/boot/dts/bcm28155-ap.dts  |    4 ++++
  3 files changed, 13 insertions(+), 1 deletion(-)
arch/arm/boot/dts/bcm11351-brt.dts +3 -1
index 9d36eb4..0771b6b 100644
@@ -43,5 +43,7 @@
  		status = "okay";
  	};
 
-
+	thermal@34008000 {
+		status = "okay";
+	};
  };
arch/arm/boot/dts/bcm11351.dtsi +0 -0
index 05a5aab..aa13353 100644
@@ -96,4 +96,10 @@
  		status = "disabled";
  	};
 
Quoted 9 lines

arch/arm/boot/dts/bcm11351.dtsi line 102

Quoted 4 lines
arch/arm/boot/dts/bcm11351.dtsi +4 -0
+	thermal@34008000 {
+		compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
+		reg = <0x34008000 0x0024>;
+		thermal-name = "bcm_kona_therm";

As I mentioned previously, my only concern is this thermal binding, which is specific to your driver (BTW, you would need to do bcm,thermal-name)

Hi Eduardo,

I have a local working copy of the thermal driver that does not use the 'thermal-name' from this DTS file. It has been re-based to your working version of the new thermal DT binding.

Quoted 19 lines
Quoted 17 lines
arch/arm/boot/dts/bcm11351.dtsi +2 -0
+		status = "disabled";
+	};
  };
arch/arm/boot/dts/bcm28155-ap.dts +4 -0
index 96ae67a..a39aa47 100644
@@ -42,4 +42,8 @@
  		max-frequency = <48000000>;
  		status = "okay";
  	};
+
+	thermal@34008000 {
+		status = "okay";
+	};
  };
Signature · 7 lines
Best regards,
-Wendy

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html