powerpc: fix section mismatch warning in free_lppacas
PATCH 1/1 powerpc: fix section mismatch warning in free_lppacas
While cross-building for PPC64 I've got bunch of
WARNING: arch/powerpc/kernel/built-in.o(.text.unlikely+0x2d2): Section mismatch in reference from the function .free_lppacas() to the variable .init.data:lppaca_size The function .free_lppacas() references the variable __initdata lppaca_size. This is often because .free_lppacas lacks a __initdata annotation or the annotation of lppaca_size is wrong.
Fix it by using proper annotation for free_lppacas. Additionally, annotate {allocate,new}_llpcas properly.
--- arch/powerpc/kernel/paca.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/kernel/paca.c +3 -3
@@ -46,7 +46,7 @@ struct lppaca lppaca[] = {static struct lppaca *extra_lppacas;static long __initdata lppaca_size; -static void allocate_lppacas (int nr_cpus,unsigned long limit) +static void __init allocate_lppacas (int nr_cpus,unsigned long limit) {if (nr_cpus <=NR_LPPACAS )return ;
@@ -57,7 +57,7 @@ static void allocate_lppacas(int nr_cpus, unsigned long limit) PAGE_SIZE, limit)); } -static struct lppaca *new_lppaca (int cpu) +static struct lppaca *__init new_lppaca (int cpu) {struct lppaca *lp;
@@ -70,7 +70,7 @@ static struct lppaca *new_lppaca(int cpu)return lp; } -static void free_lppacas (void ) +static void __init free_lppacas (void ) {long new_size =0 , nr;
Signature · 1 line
1.8.1.5
Quoted 10 lines · Vladimir Murzin
While cross-building for PPC64 I've got bunch of
WARNING: arch/powerpc/kernel/built-in.o(.text.unlikely+0x2d2): Section mismatch in reference from the function .free_lppacas() to the variable .init.data:lppaca_size The function .free_lppacas() references the variable
__initdatalppaca_size. This is often because .free_lppacas lacks a__initdataannotation or the annotation oflppaca_sizeis wrong.Fix it by using proper annotation for
free_lppacas. Additionally, annotate {allocate,new}_llpcas properly.
Yep looks good.
cheers