Skip to contentSkip to conversation

dm9601: fix IFF_ALLMULTI handling

PATCH Applied Peter Korsgaard 3 participants 3 messages Sep 30, 2013 – Oct 1, 2013

Subsystems (4)
lore
Share & tools
lore

Peter Korsgaard

author maintainer
#0 lore raw

PATCH 1/1 dm9601: fix IFF_ALLMULTI handling

Pass-all-multicast is controlled by bit 3 in RX control, not bit 2 (pass undersized frames).

---
 drivers/net/usb/dm9601.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/usb/dm9601.c +1 -1
index 2dbb946..c6867f9 100644
@@ -303,7 +303,7 @@ static void dm9601_set_multicast(struct net_device *net)
 		rx_ctl |= 0x02;
 	} else if (net->flags & IFF_ALLMULTI ||
 		   netdev_mc_count(net) > DM_MAX_MCAST) {
-		rx_ctl |= 0x04;
+		rx_ctl |= 0x08;
 	} else if (!netdev_mc_empty(net)) {
 		struct netdev_hw_addr *ha;
 
Signature · 1 line
1.7.10.4
#2 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"David" == David Miller <[email protected]> writes:

Hi,

David> Applied, thanks.

Thanks!

David> It would be so much better if these register values were all David> properly documented, one by one, with macros.

Yes, I know. I'll take a look at getting rid of all the magic values.

Signature · 1 line
Bye, Peter Korsgaard