dm9601: fix IFF_ALLMULTI handling
Peter Korsgaard
maintainerPATCH 1/1 dm9601: fix IFF_ALLMULTI handling
Pass-all-multicast is controlled by bit 3 in RX control, not bit 2 (pass undersized frames).
Reported-by Joseph Chang <[email protected]>
Signed-off-by Peter Korsgaard <[email protected]>
--- drivers/net/usb/dm9601.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/usb/dm9601.c +1 -1
@@ -303,7 +303,7 @@ static void dm9601_set_multicast(struct net_device *net) rx_ctl |=0x02 ; }else if (net->flags &IFF_ALLMULTI ||netdev_mc_count (net) >DM_MAX_MCAST ) { - rx_ctl |=0x04 ; + rx_ctl |=0x08 ; }else if (!netdev_mc_empty (net)) {struct netdev_hw_addr *ha;
Signature · 1 line
1.7.10.4
From: Peter Korsgaard <[email protected]>
Date: Mon, 30 Sep 2013 23:28:20 +0200
Quoted 5 lines
Pass-all-multicast is controlled by bit 3 in RX control, not bit 2 (pass undersized frames).
Reported-by Joseph Chang <[email protected]>Signed-off-by Peter Korsgaard <[email protected]>
Applied, thanks.
It would be so much better if these register values were all properly documented, one by one, with macros.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"David" == David Miller <[email protected]> writes:
Hi,
David> Applied, thanks.
Thanks!
David> It would be so much better if these register values were all David> properly documented, one by one, with macros.
Yes, I know. I'll take a look at getting rid of all the magic values.
Signature · 1 line
Bye, Peter Korsgaard