Skip to contentSkip to conversation

arm: socfpga: Fix incorrect sdmmc clock name

PATCH New dinguyen at altera.com 3 participants 4 messages Sep 17, 2013 – Oct 7, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

From: Dinh Nguyen <[email protected]>

The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this, the SD driver was getting the incorrect clock value. This prevented the SD driver from initializing correctly.

Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
---
 drivers/clk/socfpga/clk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/socfpga/clk.c +1 -1
index 5bb848c..81dd31a 100644
@@ -49,7 +49,7 @@
 #define SOCFPGA_L4_SP_CLK		"l4_sp_clk"
 #define SOCFPGA_NAND_CLK		"nand_clk"
 #define SOCFPGA_NAND_X_CLK		"nand_x_clk"
-#define SOCFPGA_MMC_CLK			"mmc_clk"
+#define SOCFPGA_MMC_CLK			"sdmmc_clk"
 #define SOCFPGA_DB_CLK			"gpio_db_clk"
 
 #define div_mask(width)	((1 << (width)) - 1)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoted 10 lines · dinguyen at altera.com

From: Dinh Nguyen <[email protected]>

The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this, the SD driver was getting the incorrect clock value. This prevented the SD driver from initializing correctly.

Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>

Thanks!
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

In reply to dinguyen at altera.com

Hi,

Just wondering if I can solicit any comments for this patch? It's small, so I'm not sure if I need at least a good Ack-by and put it in my tree for a pull request, or ask to be applied to the arm-soc or Mike's clock tree?

Thanks,
Dinh

Quoted 29 lines · Dinh Nguyen

From: Dinh Nguyen <[email protected]>

The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this, the SD driver was getting the incorrect clock value. This prevented the SD driver from initializing correctly.

Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
---
 drivers/clk/socfpga/clk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/socfpga/clk.c +1 -1
index 5bb848c..81dd31a 100644
@@ -49,7 +49,7 @@
 #define SOCFPGA_L4_SP_CLK		"l4_sp_clk"
 #define SOCFPGA_NAND_CLK		"nand_clk"
 #define SOCFPGA_NAND_X_CLK		"nand_x_clk"
-#define SOCFPGA_MMC_CLK			"mmc_clk"
+#define SOCFPGA_MMC_CLK			"sdmmc_clk"
 #define SOCFPGA_DB_CLK			"gpio_db_clk"
 
 #define div_mask(width)	((1 << (width)) - 1)
#3 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoting Dinh Nguyen (2013-10-01 12:28:56)

Quoted 6 lines

Hi,

Just wondering if I can solicit any comments for this patch? It's small, so I'm not sure if I need at least a good Ack-by and put it in my tree for a pull request, or ask to be applied to the arm-soc or Mike's clock tree?

I've taken this into clk-fixes for 3.12.

Regards,
Mike

Quoted 34 lines

Thanks,
Dinh

Quoted 29 lines · Dinh Nguyen

From: Dinh Nguyen <[email protected]>

The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this, the SD driver was getting the incorrect clock value. This prevented the SD driver from initializing correctly.

Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
---
 drivers/clk/socfpga/clk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/socfpga/clk.c +1 -1
index 5bb848c..81dd31a 100644
@@ -49,7 +49,7 @@
 #define SOCFPGA_L4_SP_CLK            "l4_sp_clk"
 #define SOCFPGA_NAND_CLK             "nand_clk"
 #define SOCFPGA_NAND_X_CLK           "nand_x_clk"
-#define SOCFPGA_MMC_CLK                      "mmc_clk"
+#define SOCFPGA_MMC_CLK                      "sdmmc_clk"
 #define SOCFPGA_DB_CLK                       "gpio_db_clk"
 
 #define div_mask(width)      ((1 << (width)) - 1)