Bluetooth: Restrict disabling of HS when controller is powered off
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/1 Bluetooth: Restrict disabling of HS when controller is powered off
Disabling the high speed setting when the controller is powered on has too many side effects that are not taken care of. And in general it is not an useful operation anyway. So just make such a command fail with a rejection error message.
Signed-off-by Marcel Holtmann <[email protected]>
--- net/bluetooth/mgmt.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
net/bluetooth/mgmt.c +9 -2
@@ -1352,10 +1352,17 @@ static int set_hs(struct sock *sk, struct hci_dev *hdev, void *data, u16 len)hci_dev_lock (hdev); -if (cp->val) +if (cp->val) { changed = !test_and_set_bit (HCI_HS_ENABLED , &hdev->dev_flags); -else + }else { +if (hdev_is_powered (hdev)) { + err =cmd_status (sk, hdev->id,MGMT_OP_SET_HS , +MGMT_STATUS_REJECTED ); + goto unlock; + } + changed =test_and_clear_bit (HCI_HS_ENABLED , &hdev->dev_flags); + } err =send_settings_rsp (sk,MGMT_OP_SET_HS , hdev);if (err <0 )
Signature · 1 line
1.8.3.1
Johan Hedberg
AppliedHi Marcel,
Quoted 9 lines · Marcel Holtmann
Disabling the high speed setting when the controller is powered on has too many side effects that are not taken care of. And in general it is not an useful operation anyway. So just make such a command fail with a rejection error message.
Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/mgmt.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
Applied to bluetooth-next. Thanks.
Johan