boot-directdisk: avoid loop in MBR disk signature generation

PATCH New Jonathan Liu 1 participant 1 message Oct 2, 2013

Share & tools

Jonathan Liu

author

2013-10-02 10:49 UTC #0 lore raw

PATCH 1/1 boot-directdisk: avoid loop in MBR disk signature generation

Instead of looping until the generated signature is non-zero, just return 'ffffffff' if it's zero. This avoids an infinite loop if the generated signature is always zero.

Signed-off-by Jonathan Liu <[email protected]>

---
 meta/classes/boot-directdisk.bbclass | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

meta/classes/boot-directdisk.bbclass +5 -4

index 0f64b44..5535728 100644
@@ -148,11 +148,12 @@ python do_bootdirectdisk() {
 def generate_disk_signature():
     import uuid
 
-    while True:
-        signature = str(uuid.uuid4())[:8]
+    signature = str(uuid.uuid4())[:8]
 
-        if signature != '00000000':
-            return signature
+    if signature != '00000000':
+        return signature
+    else:
+        return 'ffffffff'
 
 def validate_disk_signature(d):
     import re

Signature · 1 line

1.8.4