Skip to contentSkip to conversation

pinctrl: palmas: remove pin config BIAS_PULL_PIN_DEFAULT support

PATCH In review Laxman Dewangan 3 participants 3 messages Oct 2, 2013 – Oct 8, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: palmas: remove pin config BIAS_PULL_PIN_DEFAULT support

Palmas devices do not support the default bias configuration and hence removing this option from valid pin config parameters.

---
Based on discussion on the patch
pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT
creating this patch to remove this option.

 .../devicetree/bindings/pinctrl/pinctrl-palmas.txt |    2 +-
 drivers/pinctrl/pinctrl-palmas.c                   |    3 ---
 2 files changed, 1 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt +1 -1
index 734d9b0..caf297b 100644
@@ -41,7 +41,7 @@ pinctrl-bindings.txt:
 
 Required: pins
 Options: function, bias-disable, bias-pull-up, bias-pull-down,
-	 bias-pin-default, drive-open-drain.
+	 drive-open-drain.
 
 Note that many of these properties are only valid for certain specific pins.
 See the Palmas device datasheet for complete details regarding which pins
drivers/pinctrl/pinctrl-palmas.c +0 -3
index 6164381..f13d0e7 100644
@@ -891,9 +891,6 @@ static int palmas_pinconf_set(struct pinctrl_dev *pctldev,
 		param = pinconf_to_config_param(configs[i]);
 		param_val = pinconf_to_config_argument(configs[i]);
 
-		if (param == PIN_CONFIG_BIAS_PULL_PIN_DEFAULT)
-			continue;
-
 		switch (param) {
 		case PIN_CONFIG_BIAS_DISABLE:
 		case PIN_CONFIG_BIAS_PULL_UP:
Signature · 1 line
1.7.1.1