x86: sysfb: mark simplefb resources as BUSY
PATCH 1/1 x86: sysfb: mark simplefb resources as BUSY
IORESOURCE_BUSY is used to mark temporary driver mem-resources instead of global regions. This suppresses warnings if regions overlap with a region marked as BUSY.
This was always the case for VESA/VGA/EFI framebuffer regions so do the same for simplefb regions. The reason we do this is to allow device handover to real GPU drivers like i915/radeon/nouveau which get the same regions via PCI BARs. Maybe at some point we will be able to unregister platform devices properly during the handover. In this case the simplefb region would get removed before the new region is created. However, this is currently not the case and would require rather huge changes in remove_conflicting_framebuffers(). Add the BUSY marker now and try to eventually rewrite the handover for a next release.
Also see kernel/resource.c for more information:
/*
* if a resource is "BUSY", it's not a hardware resource
* but a driver mapping of such a resource; we don't want
* to warn for those; some drivers legitimately map only
* partial hardware resources. (example: vesafb) */
This suppresses warnings like:
------------[ cut here ]------------
WARNING: CPU: 2 PID: 199 at arch/x86/mm/ioremap.c:171 __ioremap_caller+0x2e3/0x390()
Info: mapping multiple BARs. Your kernel is fine.
Call Trace:
dump_stack+0x54/0x8d
warn_slowpath_common+0x7d/0xa0
warn_slowpath_fmt+0x4c/0x50
iomem_map_sanity_check+0xac/0xe0
__ioremap_caller+0x2e3/0x390
ioremap_wc+0x32/0x40
i915_driver_load+0x670/0xf50 [i915]
...---
Hi
Sorry for the delay, but I was in the US for the last 2 weeks and this is really no major issue, just suppresses a warning that says "Your kernel is fine". Anyhow, thanks to Tom and Pavel for reporting and testing this! This is targeted at 3.12-rc4 as bugfix. I think it's still early/mid rc-stage and is a one-line patch so it should be fine, right?
Thanks
David
arch/x86/kernel/sysfb_simplefb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/sysfb_simplefb.c +1 -1
@@ -79,7 +79,7 @@ __init int create_simplefb(const struct screen_info *si,/* setup IORESOURCE_MEM as framebuffer memory */ memset (&res,0 ,sizeof (res)); - res.flags =IORESOURCE_MEM ; + res.flags =IORESOURCE_MEM |IORESOURCE_BUSY ; res.name = simplefb_resname; res.start = si->lfb_base; res.end = si->lfb_base + len -1 ;
Signature · 1 line
1.8.4
Quoted 1 line · On Wed, 2 Oct 2013 16:41:04 +0200 David Herrmann <[email protected]> wrote:
Tested-by Pavel Roskin <[email protected]>
Tested indeed, on ThinkPad W530 with 32-bit and 64-bit kernels with Intel and NVidia graphics enabled.
Quoted 3 lines
Sorry for the delay, but I was in the US for the last 2 weeks and this is really no major issue, just suppresses a warning that says "Your kernel is fine".
It shows a stack trace, so it might confuse (and has confused) users into thinking that it's a more important issue than it is.
Quoted 4 lines
Anyhow, thanks to Tom and Pavel for reporting
and testing this! This is targeted at 3.12-rc4 as bugfix. I think it's still early/mid rc-stage and is a one-line patch so it should be fine, right?
I second this.
Signature · 2 lines
Regards, Pavel Roskin
tip-bot for David Herrmann
merge bot[tip:x86/urgent] x86/simplefb: Mark framebuffer mem-resources as IORESOURCE_BUSY to avoid bootup warning
In reply to David Herrmannx86/simplefb: Mark framebuffer mem-resources as IORESOURCE_BUSY to avoid bootup warning
Commit-ID: 29d274b8d3e2404cd1832b3a999b12f9d1e1d895 Gitweb: http://git.kernel.org/tip/29d274b8d3e2404cd1832b3a999b12f9d1e1d895 Author: David Herrmann <[email protected]> AuthorDate: Wed, 2 Oct 2013 16:41:04 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 3 Oct 2013 07:51:11 +0200
x86/simplefb: Mark framebuffer mem-resources as IORESOURCE_BUSY to avoid bootup warning
IORESOURCE_BUSY is used to mark temporary driver mem-resources instead of global regions. This suppresses warnings if regions overlap with a region marked as BUSY.
This was always the case for VESA/VGA/EFI framebuffer regions so do the same for simplefb regions. The reason we do this is to allow device handover to real GPU drivers like i915/radeon/nouveau which get the same regions via PCI BARs.
Maybe at some point we will be able to unregister platform devices properly during the handover. In this case the simplefb region would get removed before the new region is created. However, this is currently not the case and would require rather huge changes in remove_conflicting_framebuffers(). Add the BUSY marker now and try to eventually rewrite the handover for a next release.
Also see kernel/resource.c for more information:
/*
* if a resource is "BUSY", it's not a hardware resource
* but a driver mapping of such a resource; we don't want
* to warn for those; some drivers legitimately map only
* partial hardware resources. (example: vesafb) */
This suppresses warnings like:
------------[ cut here ]------------
WARNING: CPU: 2 PID: 199 at arch/x86/mm/ioremap.c:171 __ioremap_caller+0x2e3/0x390()
Info: mapping multiple BARs. Your kernel is fine.
Call Trace:
dump_stack+0x54/0x8d
warn_slowpath_common+0x7d/0xa0
warn_slowpath_fmt+0x4c/0x50
iomem_map_sanity_check+0xac/0xe0
__ioremap_caller+0x2e3/0x390
ioremap_wc+0x32/0x40
i915_driver_load+0x670/0xf50 [i915]
...--- arch/x86/kernel/sysfb_simplefb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/sysfb_simplefb.c +1 -1
@@ -79,7 +79,7 @@ __init int create_simplefb(const struct screen_info *si,/* setup IORESOURCE_MEM as framebuffer memory */ memset (&res,0 ,sizeof (res)); - res.flags =IORESOURCE_MEM ; + res.flags =IORESOURCE_MEM |IORESOURCE_BUSY ; res.name = simplefb_resname; res.start = si->lfb_base; res.end = si->lfb_base + len -1 ;