Skip to contentSkip to conversation

Add AMS AS3722 mfd, pincontrol, regulator and RTC driver.

PATCH Superseded Laxman Dewangan 4 participants 9 messages Oct 2, 2013 – Oct 10, 2013

Subsystems (5)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover Add AMS AS3722 mfd, pincontrol, regulator and RTC driver.

This series add the driver support for AMS AS3722 PMIC. The driver includes MFD, pincontrol and GPIO, regulator and RTC.

Changes from V1:
- Remove compatible string from DT for subnode.
- Add macro in regmap.h for definign range.
- Nit cleanups in driver and use module_i2c_driver/module_platform_driver.
- Use linear_range and added regulator_map_* on regulators.
- Move OC configuration to regulator_current limit setting.
- Get rid of clk32k out configuration from RTC. Will add clock driver.

Changes from V2:
- Drop the already applied patches on V2 series
regmap: add helper macro to set min/max range of register
regulator: as3722: add regulator driver for AMS AS3722
- Move the GPIo driver to pincontrol driver to expose the pin configuration through pincontrol.
- rewrite the DT binding of the mfd.

Changes from V3:
- Change AMS to ams
- combine DT of regulator, pincontrol to the mfd.
- Taken care of Lee's nits feedback.

Laxman Dewangan (3):
mfd: add support for ams AS3722 PMIC
pincntrl: add support for ams AS3722 pin control driver drivers/rtc/rtc-as3722: add RTC driver

 Documentation/devicetree/bindings/mfd/as3722.txt |  174 ++++++
 drivers/mfd/Kconfig                              |   12 +
 drivers/mfd/Makefile                             |    1 +
 drivers/mfd/as3722.c                             |  449 +++++++++++++++
 drivers/pinctrl/Kconfig                          |   11 +
 drivers/pinctrl/Makefile                         |    1 +
 drivers/pinctrl/pinctrl-as3722.c                 |  630 ++++++++++++++++++++++
 drivers/rtc/Kconfig                              |   10 +
 drivers/rtc/Makefile                             |    1 +
 drivers/rtc/rtc-as3722.c                         |  296 ++++++++++
 include/linux/mfd/as3722.h                       |  423 +++++++++++++++
 11 files changed, 2008 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/as3722.txt
 create mode 100644 drivers/mfd/as3722.c
 create mode 100644 drivers/pinctrl/pinctrl-as3722.c
 create mode 100644 drivers/rtc/rtc-as3722.c
 create mode 100644 include/linux/mfd/as3722.h
#1 lore raw

PATCH v5 2/3 pincntrl: add support for ams AS3722 pin control driver

The AS3722 is a compact system PMU suitable for mobile phones, tablets etc.

Add a driver to support accessing the GPIO, pinmux and pin configuration of 8 GPIO pins found on the ams AS3722 through pin control driver and gpiolib.

The driver will register itself as the pincontrol driver and gpio driver.

---
Changes from V1:
- Nit cleanups in driver and use module_platform_driver.

Changes from V2:
- Move the gpio driver from gpio folder to pinctnrl driver and register driver as pincontrol driver.
- Provide pin configuration through pincntrl framework.

Changes from V3:
- Added gpio ranges and pinctrl_gpio calls.
- Used pinctrl_gpio_* calls on gpio chips callback.
- Remove dummy function which just return not supported.
- Nit cleanups.

Changes from V4:
- Drop separate DT binding document as it is moved to mfd/as3722.txt.

 drivers/pinctrl/Kconfig          |   11 +
 drivers/pinctrl/Makefile         |    1 +
 drivers/pinctrl/pinctrl-as3722.c |  630 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 642 insertions(+), 0 deletions(-)
 create mode 100644 drivers/pinctrl/pinctrl-as3722.c
drivers/pinctrl/Kconfig +11 -0
index 21db201..85f5462 100644
@@ -59,6 +59,17 @@ config PINCTRL_ADI2
 	  future processors. This option is selected automatically when specific
 	  machine and arch are selected to build.
 
+config PINCTRL_AS3722
+	bool "Pinctrl and GPIO driver for ams AS3722 PMIC"
+	depends on MFD_AS3722 && GPIOLIB
+	select PINMUX
+	select GENERIC_PINCONF
+	help
+	  AS3722 device supports the configuration of GPIO pins for different
+	  functionality. This driver supports the pinmux, push-pull and
+	  open drain configuration for the GPIO pins of AS3722 devices. It also
+	  supports the GPIO functionality through gpiolib.
+
 config PINCTRL_BF54x
 	def_bool y if BF54x
 	select PINCTRL_ADI2
drivers/pinctrl/Makefile +1 -0
index bbeb980..3d14cb8 100644
@@ -15,6 +15,7 @@ obj-$(CONFIG_PINCTRL_AB8540)	+= pinctrl-ab8540.o
 obj-$(CONFIG_PINCTRL_AB9540)	+= pinctrl-ab9540.o
 obj-$(CONFIG_PINCTRL_AB8505)	+= pinctrl-ab8505.o
 obj-$(CONFIG_PINCTRL_ADI2)	+= pinctrl-adi2.o
+obj-$(CONFIG_PINCTRL_AS3722)	+= pinctrl-as3722.o
 obj-$(CONFIG_PINCTRL_BF54x)	+= pinctrl-adi2-bf54x.o
 obj-$(CONFIG_PINCTRL_BF60x)	+= pinctrl-adi2-bf60x.o
 obj-$(CONFIG_PINCTRL_AT91)	+= pinctrl-at91.o
drivers/pinctrl/pinctrl-as3722.c new file +630 -0

630 lines not on this page · raw message

Signature · 1 line
1.7.1.1
Acked-by on v5 2/3
#2 lore raw

Re: [rtc-linux] [PATCH V5 2/3] pincntrl: add support for ams AS3722 pin control driver

Quoted 18 lines · Laxman Dewangan

The AS3722 is a compact system PMU suitable for mobile phones, tablets etc.

Add a driver to support accessing the GPIO, pinmux and pin configuration of 8 GPIO pins found on the ams AS3722 through pin control driver and gpiolib.

The driver will register itself as the pincontrol driver and gpio driver.

---
Changes from V1:
- Nit cleanups in driver and use module_platform_driver.

Changes from V2:
- Move the gpio driver from gpio folder to pinctnrl driver and register driver as pincontrol driver.
- Provide pin configuration through pincntrl framework.

Quoted 8 lines

Changes from V3:
- Added gpio ranges and pinctrl_gpio calls.
- Used pinctrl_gpio_* calls on gpio chips callback.
- Remove dummy function which just return not supported.
- Nit cleanups.

Changes from V4:
- Drop separate DT binding document as it is moved to mfd/as3722.txt.

As mentioned I am happy with this driver,

When you agreed with the DT folks and want me to merge it, tell me.

Yours,
Linus Walleij

#3 lore raw

Re: [rtc-linux] [PATCH V5 2/3] pincntrl: add support for ams AS3722 pin control driver

Quoted 26 lines · Linus Walleij
Quoted 24 lines · Laxman Dewangan

The AS3722 is a compact system PMU suitable for mobile phones, tablets etc.

Add a driver to support accessing the GPIO, pinmux and pin configuration of 8 GPIO pins found on the ams AS3722 through pin control driver and gpiolib.

The driver will register itself as the pincontrol driver and gpio driver.

---
Changes from V1:
- Nit cleanups in driver and use module_platform_driver.

Changes from V2:
- Move the gpio driver from gpio folder to pinctnrl driver and register driver as pincontrol driver.
- Provide pin configuration through pincntrl framework.

Changes from V3:
- Added gpio ranges and pinctrl_gpio calls.
- Used pinctrl_gpio_* calls on gpio chips callback.
- Remove dummy function which just return not supported.
- Nit cleanups.

Quoted 8 lines
Quoted 2 lines

Changes from V4:
- Drop separate DT binding document as it is moved to mfd/as3722.txt.

As mentioned I am happy with this driver,

When you agreed with the DT folks and want me to merge it, tell me.

Stephen has given the ACK from DT side, so I think you can merge this patch.

Thanks,
Laxman

#4 lore raw

Re: [rtc-linux] [PATCH V5 2/3] pincntrl: add support for ams AS3722 pin control driver

Quoted 7 lines · Laxman Dewangan
Quoted 6 lines · Linus Walleij
Quoted 2 lines · Laxman Dewangan

Changes from V4:
- Drop separate DT binding document as it is moved to mfd/as3722.txt.

Quoted 7 lines
Quoted 5 lines

As mentioned I am happy with this driver,

When you agreed with the DT folks and want me to merge it, tell me.

Stephen has given the ACK from DT side, so I think you can merge this patch.

OK patch applied.

Yours,
Linus Walleij

#5 lore raw

PATCH v4 1/3 mfd: add support for ams AS3722 PMIC

In reply to Laxman Dewangan

The ams AS3722 is a compact system PMU suitable for mobile phones, tablets etc. It has 4 DC/DC step-down regulators, 3 DC/DC step-down controller, 11 LDOs, RTC, automatic battery, temperature and over-current monitoring, 8 GPIOs, ADC and a watchdog.

Add MFD core driver for the AS3722 to support core functionality.

---
Changes from V1:
- Remove compatible string from DT for subnode.
- Nit cleanups in driver and use module_i2c_driver

Changes from V2:
- Change DT file to reflect the changes in gpio/pincntrl driver. Now there is no extra subnode.

Changes from V3:
- Combine DT of pincontrol and regulator to mfd.
- Nits cleanups.
- AMS to ams.

 Documentation/devicetree/bindings/mfd/as3722.txt |  174 +++++++++
 drivers/mfd/Kconfig                              |   12 +
 drivers/mfd/Makefile                             |    1 +
 drivers/mfd/as3722.c                             |  449 ++++++++++++++++++++++
 include/linux/mfd/as3722.h                       |  423 ++++++++++++++++++++
 5 files changed, 1059 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/as3722.txt
 create mode 100644 drivers/mfd/as3722.c
 create mode 100644 include/linux/mfd/as3722.h
Documentation/devicetree/bindings/mfd/as3722.txt new file +174 -0
new file mode 100644
index 0000000..885ca4c
@@ -0,0 +1,174 @@
+* ams AS3722 Power management IC.
+
+Required properties:
+-------------------
+- compatible: Must be "ams,as3722".
+- reg: I2C device address.
+- interrupt-controller: AS3722 has internal interrupt controller which takes the
+  interrupt request from  internal sub-blocks like RTC, regulators, GPIOs as well
+  as external input.
+- #interrupt-cells: Should be set to 2 for IRQ number and flags.
+  The first cell is the IRQ number.
+  The second cell is the flags, encoded as the trigger masks from binding document
+	interrupts.txt, using dt-bindings/irq.
+
+Optional submodule and their properties:
+---------------------------------------
+
+Pinmux and GPIO:
+---------------
+Device has 8 GPIO pins which can be configured as GPIO as well as the special IO
+functions.
+
+Please refer to pinctrl-bindings.txt in this directory for details of the
+common pinctrl bindings used by client devices, including the meaning of the
+phrase "pin configuration node".
+
+Following are properties which is needed if GPIO and pinmux functionality
+is required:
+- gpio-controller: Marks the device node as a GPIO controller.
+- #gpio-cells: Number of GPIO cells. Refer to binding document gpio/gpio.txt
+- pinctrl-names: A pinctrl state named "default" must be defined, using the
+		bindings in pinctrl/pinctrl-binding.txt.
+- pinctrl[0...n]: Nodes for pin control to represents state 0 to state n.
+	Each of these nodes contains different subnodes to represents
+	some desired configuration for a list of pins. This configuration can
+	include the mux function to select on those pin(s), and various pin
+	configuration parameters, such as pull-up, open drain.
+
+Each subnode have following properties:
+Required properties:
+	pins: List of pins. Valid options for pins properties are
+		gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7
+
+Optional properties:
+	Optional properties are
+		function, bias-disable, bias-pull-up, bias-pull-down,
+		bias-high-impedance, drive-open-drain.
+
+		Valid options for funtion properties are:
+		gpio, interrupt-out, gpio-in-interrupt,
+		vsup-vbat-low-undebounce-out, vsup-vbat-low-debounce-out,
+		voltage-in-standby, oc-pg-sd0, oc-pg-sd6, powergood-out,
+		pwm-in, pwm-out, clk32k-out, watchdog-in, soft-reset-in
+
+Regulators:
+-----------
+Device has multiple DCDC and LDOs. The node "regulators" is require if regulator
+functionality is needed.
+
+Following are properties of regulator subnode.
+
+Optional properties:
+-------------------
+The input supply of regulators are the optional properties on the
+regulator node. The input supply of these regulators are provided
+through following properties:
+vsup-sd2-supply: Input supply for SD2.
+vsup-sd3-supply: Input supply for SD3.
+vsup-sd4-supply: Input supply for SD4.
+vsup-sd5-supply: Input supply for SD5.
+vin-ldo0-supply: Input supply for LDO0.
+vin-ldo1-6-supply: Input supply for LDO1 and LDO6.
+vin-ldo2-5-7-supply: Input supply for LDO2, LDO5 and LDO7.
+vin-ldo3-4-supply: Input supply for LDO3 and LDO4.
+vin-ldo9-10-supply: Input supply for LDO9 and LDO10.
+vin-ldo11-supply: Input supply for LDO11.
+
+Optional sub nodes:
+-----------------
+	The subnodes name is the name of regulator and it must be one of:
+	sd[0-6], ldo[0-7], ldo[9-11]
+
+	Each sub-node should contain the constraints and initialization
+	information for that regulator. See regulator.txt for a description
+	of standard properties for these sub-nodes.
+	Additional custom properties  are listed below.
+		ams,ext-control: External control of the rail. The option of
+			this properties will tell which external input is
+			controlling this rail. Valid values are 0, 1, 2 ad 3.
+			0: There is no external control of this rail.
+			1: Rail is controlled by ENABLE1 input pin.
+			2: Rail is controlled by ENABLE2 input pin.
+			3: Rail is controlled by ENABLE3 input pin.
+		ams,enable-tracking: Enable tracking with SD1, only supported
+			by LDO3.
+
+Example:
+--------
+ams3722 {
+	compatible = "ams,as3722";
+	reg = <0x48>;
+
+	interrupt-parent = <&intc>;
+	interrupt-controller;
+	#interrupt-cells = <2>;
+
+	gpio-controller;
+	#gpio-cells = <2>;
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&as3722_default>;
+
+	as3722_default: pinmux {
+			gpio0 {
+				pins = "gpio0";
+				function = "gpio";
+				bias-pull-down;
+			};
+
+			gpio1_2_4_7 {
+				pins = "gpio1", "gpio2", "gpio4", "gpio7";
+				function = "gpio";
+				bias-pull-up;
+			};
+
+			gpio5 {
+				pins = "gpio5";
+				function = "clk32k_out";
+			};
+	}
+
+	regulators {
+			vsup-sd2-supply = <...>;
+			...
+
+			sd0 {
+				regulator-name = "vdd_cpu";
+				regulator-min-microvolt = <700000>;
+				regulator-max-microvolt = <1400000>;
+				regulator-always-on;
+				ams,ext-control = <2>;
+			};
+
+			sd1 {
+				regulator-name = "vdd_core";
+				regulator-min-microvolt = <700000>;
+				regulator-max-microvolt = <1400000>;
+				regulator-always-on;
+				ams,ext-control = <1>;
+			};
+
+			sd2 {
+				regulator-name = "vddio_ddr";
+				regulator-min-microvolt = <1350000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-always-on;
+			};
+
+			sd4 {
+				regulator-name = "avdd-hdmi-pex";
+				regulator-min-microvolt = <1050000>;
+				regulator-max-microvolt = <1050000>;
+				regulator-always-on;
+			};
+
+			sd5 {
+				regulator-name = "vdd-1v8";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+			};
+			....
+	};
+};
drivers/mfd/Kconfig +12 -0
index d078fe4..b7c74a7 100644
@@ -27,6 +27,18 @@ config MFD_AS3711
 	help
 	  Support for the AS3711 PMIC from AMS
 
+config MFD_AS3722
+	bool "ams AS3722 Power Management IC"
+	select MFD_CORE
+	select REGMAP_I2C
+	select REGMAP_IRQ
+	depends on I2C && OF
+	help
+	  The ams AS3722 is a compact system PMU suitable for mobile phones,
+	  tablets etc. It has 4 DC/DC step-down regulators, 3 DC/DC step-down
+	  controllers, 11 LDOs, RTC, automatic battery, temperature and
+	  over current monitoring, GPIOs, ADC and a watchdog.
+
 config PMIC_ADP5520
 	bool "Analog Devices ADP5520/01 MFD PMIC Core Support"
 	depends on I2C=y
drivers/mfd/Makefile +1 -0
index 656cec9..8a28dc9 100644
@@ -162,4 +162,5 @@ obj-$(CONFIG_MFD_LM3533)	+= lm3533-core.o lm3533-ctrlbank.o
 obj-$(CONFIG_VEXPRESS_CONFIG)	+= vexpress-config.o vexpress-sysreg.o
 obj-$(CONFIG_MFD_RETU)		+= retu-mfd.o
 obj-$(CONFIG_MFD_AS3711)	+= as3711.o
+obj-$(CONFIG_MFD_AS3722)	+= as3722.o
 obj-$(CONFIG_MFD_STW481X)	+= stw481x.o
drivers/mfd/as3722.c new file +449 -0

449 lines not on this page · raw message

include/linux/mfd/as3722.h new file +423 -0

423 lines not on this page · raw message

Signature · 1 line
1.7.1.1
Acked-by on v4 1/3
#6 lore raw

Re: [PATCH V4 1/3] mfd: add support for ams AS3722 PMIC

Quoted 32 lines · Laxman Dewangan

The ams AS3722 is a compact system PMU suitable for mobile phones, tablets etc. It has 4 DC/DC step-down regulators, 3 DC/DC step-down controller, 11 LDOs, RTC, automatic battery, temperature and over-current monitoring, 8 GPIOs, ADC and a watchdog.

Add MFD core driver for the AS3722 to support core functionality.

---
Changes from V1:
- Remove compatible string from DT for subnode.
- Nit cleanups in driver and use module_i2c_driver

Changes from V2:
- Change DT file to reflect the changes in gpio/pincntrl driver. Now there is no extra subnode.

Changes from V3:
- Combine DT of pincontrol and regulator to mfd.
- Nits cleanups.
- AMS to ams.

 Documentation/devicetree/bindings/mfd/as3722.txt |  174 +++++++++
 drivers/mfd/Kconfig                              |   12 +
 drivers/mfd/Makefile                             |    1 +
 drivers/mfd/as3722.c                             |  449 ++++++++++++++++++++++
 include/linux/mfd/as3722.h                       |  423 ++++++++++++++++++++
 5 files changed, 1059 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/as3722.txt
 create mode 100644 drivers/mfd/as3722.c
 create mode 100644 include/linux/mfd/as3722.h

<snip>

Documentation/devicetree/bindings/mfd/as3722.txt

Quoted 6 lines
Documentation/devicetree/bindings/mfd/as3722.txt new file +6 -0
+Required properties:
+-------------------
+- compatible: Must be "ams,as3722".
+- reg: I2C device address.
+- interrupt-controller: AS3722 has internal interrupt controller which takes the
+  interrupt request from  internal sub-blocks like RTC, regulators,

Silly nit: Attention to detail 'from..internal'.

Quoted 10 lines

GPIOs as well

80 chars

Documentation/devicetree/bindings/mfd/as3722.txt new file +4 -0
+  as external input.
+- #interrupt-cells: Should be set to 2 for IRQ number and flags.
+  The first cell is the IRQ number.
+  The second cell is the flags, encoded as the trigger masks from binding document

80 chars

<snip>

Quoted 5 lines
Documentation/devicetree/bindings/mfd/as3722.txt new file +5 -0
+Optional properties:
+-------------------
+The input supply of regulators are the optional properties on the
+regulator node. The input supply of these regulators are provided
+through following properties:

Documentation/devicetree/bindings/mfd/as3722.txt line 76

Quoted 10 lines
Documentation/devicetree/bindings/mfd/as3722.txt new file +10 -0
+vsup-sd2-supply: Input supply for SD2.
+vsup-sd3-supply: Input supply for SD3.
+vsup-sd4-supply: Input supply for SD4.
+vsup-sd5-supply: Input supply for SD5.
+vin-ldo0-supply: Input supply for LDO0.
+vin-ldo1-6-supply: Input supply for LDO1 and LDO6.
+vin-ldo2-5-7-supply: Input supply for LDO2, LDO5 and LDO7.
+vin-ldo3-4-supply: Input supply for LDO3 and LDO4.
+vin-ldo9-10-supply: Input supply for LDO9 and LDO10.
+vin-ldo11-supply: Input supply for LDO11.

Perhaps some indentation would be good here.

Documentation/devicetree/bindings/mfd/as3722.txt line 86

Quoted 9 lines
Documentation/devicetree/bindings/mfd/as3722.txt new file +9 -0
+Optional sub nodes:
+-----------------
+	The subnodes name is the name of regulator and it must be one of:
+	sd[0-6], ldo[0-7], ldo[9-11]
+
+	Each sub-node should contain the constraints and initialization
+	information for that regulator. See regulator.txt for a description
+	of standard properties for these sub-nodes.
+	Additional custom properties  are listed below.

Silly nit: Attention to detail 'properties..are'.

<snip>

Besides all that stuff that's actually not all that important, the code looks pretty good to me.

For the !DT MFD stuff:

Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#7 lore raw

Re: [PATCH V4 1/3] mfd: add support for ams AS3722 PMIC

In reply to Laxman Dewangan

Documentation/devicetree/bindings/mfd/as3722.txt

Quoted 8 lines · Laxman Dewangan

The ams AS3722 is a compact system PMU suitable for mobile phones, tablets etc. It has 4 DC/DC step-down regulators, 3 DC/DC step-down controller, 11 LDOs, RTC, automatic battery, temperature and over-current monitoring, 8 GPIOs, ADC and a watchdog.

Documentation/devicetree/bindings/mfd/as3722.txt +1 -0
 
+  The first cell is the IRQ number.

Which IRQ number exist? Perhaps the IRQ IDs match some specific HW register?

Documentation/devicetree/bindings/mfd/as3722.txt line 32

Quoted 4 lines
Documentation/devicetree/bindings/mfd/as3722.txt +3 -0
+Pinmux and GPIO:
 
+- pinctrl-names: A pinctrl state named "default" must be defined, using the
+		bindings in pinctrl/pinctrl-binding.txt.

Why is the DT required to define a default state? If the board doesn't need to set up any pinctrl settings, surely it shouldn't have to define the default state.

Quoted 1 line

+- pinctrl[0...n]: Nodes for pin control to represents state 0 to state n.

These aren't nodes. Those are properties that contain phandles that refer to nodes.

Documentation/devicetree/bindings/mfd/as3722.txt line 37

Quoted 4 lines
Documentation/devicetree/bindings/mfd/as3722.txt +4 -0
+	Each of these nodes contains different subnodes to represents
+	some desired configuration for a list of pins. This configuration can
+	include the mux function to select on those pin(s), and various pin
+	configuration parameters, such as pull-up, open drain.

What contains "these nodes"?

Documentation/devicetree/bindings/mfd/as3722.txt line 45

Quoted 8 lines
Documentation/devicetree/bindings/mfd/as3722.txt +8 -0
+
+Each subnode have following properties:
+Required properties:
+	pins: List of pins. Valid options for pins properties are
+		gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7
+
+Optional properties:
+	Optional properties are

Why repeat that?

Documentation/devicetree/bindings/mfd/as3722.txt line 49

Quoted 4 lines
Documentation/devicetree/bindings/mfd/as3722.txt +4 -0
+		function, bias-disable, bias-pull-up, bias-pull-down,
+		bias-high-impedance, drive-open-drain.
+
+		Valid options for funtion properties are:

s/funtion/function/

I would say "values" not "options", as I think I pointed out before, but I supopse I don't care.

Quoted 1 line

+Optional sub nodes:

The following might make it clear where these optional nodes sit:

Optional sub nodes of "regulators":
-----------------------------------

Documentation/devicetree/bindings/mfd/as3722.txt line 86

Quoted 1 line
Documentation/devicetree/bindings/mfd/as3722.txt +1 -0
+	Additional custom properties  are listed below.

Required or optional?

#8 lore raw

PATCH v4 3/3 drivers/rtc/rtc-as3722: add RTC driver

In reply to Laxman Dewangan

The ams AS3722 is a compact system PMU suitable for mobile phones, tablets etc.

Add a driver to support accessing the RTC found on the ams AS3722 PMIC using RTC framework.

---
Changes from V1:
- Get rid of clk32k out configuration from RTC. Will add clock driver.

Changes from V2:
- None.

Changes form V3:
- Change AMS to ams.

 drivers/rtc/Kconfig      |   10 ++
 drivers/rtc/Makefile     |    1 +
 drivers/rtc/rtc-as3722.c |  296 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 307 insertions(+), 0 deletions(-)
 create mode 100644 drivers/rtc/rtc-as3722.c
drivers/rtc/Kconfig +10 -0
index 9654aa3..d8785d7 100644
@@ -153,6 +153,16 @@ config RTC_DRV_88PM80X
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-88pm80x.
 
+config RTC_DRV_AS3722
+	tristate "ams AS3722 RTC driver"
+	depends on MFD_AS3722
+	help
+	  If you say yes here you get support for the RTC of ams AS3722 PMIC
+	  chips.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called rtc-as3722.
+
 config RTC_DRV_DS1307
 	tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025"
 	help
drivers/rtc/Makefile +1 -0
index 2dff3d2..fdb5764 100644
@@ -20,6 +20,7 @@ obj-$(CONFIG_RTC_DRV_88PM860X)  += rtc-88pm860x.o
 obj-$(CONFIG_RTC_DRV_88PM80X)	+= rtc-88pm80x.o
 obj-$(CONFIG_RTC_DRV_AB3100)	+= rtc-ab3100.o
 obj-$(CONFIG_RTC_DRV_AB8500)	+= rtc-ab8500.o
+obj-$(CONFIG_RTC_DRV_AS3722)	+= rtc-as3722.o
 obj-$(CONFIG_RTC_DRV_AT32AP700X)+= rtc-at32ap700x.o
 obj-$(CONFIG_RTC_DRV_AT91RM9200)+= rtc-at91rm9200.o
 obj-$(CONFIG_RTC_DRV_AT91SAM9)	+= rtc-at91sam9.o
drivers/rtc/rtc-as3722.c new file +296 -0

296 lines not on this page · raw message

Signature · 1 line
1.7.1.1