Bluetooth: Allow changing device class when BR/EDR is disabled
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/1 Bluetooth: Allow changing device class when BR/EDR is disabled
Changing the device class when BR/EDR is disabled has no visible effect for remote devices. However to simplify the logic allow it as long as the controller supports BR/EDR operations.
If it is not allowed, then the overall logic becomes rather complicated since the class of device values would need clearing or restoring when BR/EDR setting changes.
--- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/mgmt.c +1 -1
@@ -1757,7 +1757,7 @@ static int set_dev_class(struct sock *sk, struct hci_dev *hdev, void *data,BT_DBG ("request for %s" , hdev->name); -if (!test_bit (HCI_BREDR_ENABLED , &hdev->dev_flags)) +if (!lmp_bredr_capable (hdev))return cmd_status (sk, hdev->id,MGMT_OP_SET_DEV_CLASS ,MGMT_STATUS_NOT_SUPPORTED );
Signature · 1 line
1.8.3.1
Johan Hedberg
AppliedHi Marcel,
Quoted 4 lines · Marcel Holtmann
Changing the device class when BR/EDR is disabled has no visible effect for remote devices. However to simplify the logic allow it as long as the controller supports BR/EDR operations.
Quoted 8 lines
If it is not allowed, then the overall logic becomes rather complicated since the class of device values would need clearing or restoring when BR/EDR setting changes.
Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to bluetooth-next. Thanks.
Johan