Skip to contentSkip to conversation

OMAPDSS: HDMI: Correctly compare timings

PATCH In review Richard Röjfors 2 participants 2 messages Oct 3, 2013 – Oct 9, 2013 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAPDSS: HDMI: Correctly compare timings

There is currently a copy and paste error where the hdmi vsync timings are not compared correctly, this patch fixes this.

---

drivers/video/omap2/dss/hdmi.c +1 -1
index 82a9640..e3ea2d5 100644
@@ -391,7 +391,7 @@ static bool hdmi_timings_compare(struct omap_video_timings *timing1,
 		timing2_hsync = timing2->hfp + timing2->hsw + timing2->hbp;
 		timing1_hsync = timing1->hfp + timing1->hsw + timing1->hbp;
 		timing2_vsync = timing2->vfp + timing2->vsw + timing2->vbp;
-		timing1_vsync = timing2->vfp + timing2->vsw + timing2->vbp;
+		timing1_vsync = timing1->vfp + timing1->vsw + timing1->vbp;
 
 		DSSDBG("timing1_hsync = %d timing1_vsync = %d"\
 			"timing2_hsync = %d timing2_vsync = %d\n",

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw
Quoted 11 lines · Richard Röjfors

There is currently a copy and paste error where the hdmi vsync timings are not compared correctly, this patch fixes this.

---

drivers/video/omap2/dss/hdmi.c +0 -0
index 82a9640..e3ea2d5 100644

drivers/video/omap2/dss/hdmi.c static bool hdmi_timings_compare(struct omap_video_timings *timing1, · line 397

Quoted 8 lines
drivers/video/omap2/dss/hdmi.c +1 -1
@@ -391,7 +391,7 @@ static bool hdmi_timings_compare(struct omap_video_timings *timing1,
 		timing2_hsync = timing2->hfp + timing2->hsw + timing2->hbp;
 		timing1_hsync = timing1->hfp + timing1->hsw + timing1->hbp;
 		timing2_vsync = timing2->vfp + timing2->vsw + timing2->vbp;
-		timing1_vsync = timing2->vfp + timing2->vsw + timing2->vbp;
+		timing1_vsync = timing1->vfp + timing1->vsw + timing1->vbp;
 
 		DSSDBG("timing1_hsync = %d timing1_vsync = %d"\
 			"timing2_hsync = %d timing2_vsync = %d\n",

Thanks, queuing for 3.13.

Tomi