x86, wmi fix modalias_show return values
PATCH 1/1 x86, wmi fix modalias_show return values
I just fixed this same bug in arch/powerpc/kernel/vio.c and took a quick look for other similar errors in the kernel.
modalias_show() should return an empty string on error, not errno.
Signed-off-by Prarit Bhargava <[email protected]>
Cc Matthew Garrett <[email protected]>
--- drivers/platform/x86/wmi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/platform/x86/wmi.c +4 -2
@@ -686,8 +686,10 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,struct wmi_block *wblock; wblock =dev_get_drvdata (dev); -if (!wblock) -return -ENOMEM ; +if (!wblock) { +strcat (buf,"\n" ); +return strlen (buf); + }wmi_gtoa (wblock->gblock.guid, guid_string);
Signature · 1 line
1.7.9.3
Matthew Garrett
AppliedApplied, thanks.
Signature · 1 line
Matthew Garrett <[email protected]>