Skip to contentSkip to conversation

xmlrpc: Show a better error message for connection failures

PATCH New Richard Purdie 1 participant 1 message Oct 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xmlrpc: Show a better error message for connection failures

Showing a traceback when unable to connect to a bitbake server is rather ugly. This change allows us to show a sensible error message.

---

bitbake/lib/bb/server/xmlrpc.py +6 -3
index 389327a..82c0e8d 100644
@@ -354,9 +354,12 @@ class BitBakeXMLRPCClient(BitBakeBaseServer):
             s.close()
         except:
             return None
-        self.serverImpl = XMLRPCProxyServer(host, port)
-        self.connection = BitBakeXMLRPCServerConnection(self.serverImpl, (ip, 0), self.observer_only, featureset)
-        return self.connection.connect()
+        try:
+            self.serverImpl = XMLRPCProxyServer(host, port)
+            self.connection = BitBakeXMLRPCServerConnection(self.serverImpl, (ip, 0), self.observer_only, featureset)
+            return self.connection.connect()
+        except Exception as e:
+            bb.fatal("Could not connect to server at %s:%s (%s)" % (host, port, str(e)))
 
     def endSession(self):
         self.connection.removeClient()