Skip to contentSkip to conversation

ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode

PATCH Applied Fabio Estevam 2 participants 4 messages Oct 4, 2013 – Oct 6, 2013

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/3 ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode

From: Fabio Estevam <[email protected]>

SDHC3 is 8 bit-wide, so pass the bus-width property to reflect that.

---
 arch/arm/boot/dts/imx53-qsb.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx53-qsb.dts +1 -0
index 94597c3..b646ef1 100644
@@ -136,6 +136,7 @@
 	pinctrl-0 = <&pinctrl_esdhc3_1>;
 	cd-gpios = <&gpio3 11 0>;
 	wp-gpios = <&gpio3 12 0>;
+	bus-width = <8>;
 	status = "okay";
 };
 
Signature · 1 line
1.8.1.2
author reviewer
#1 lore raw

PATCH 2/3 ARM: dts: imx53-qsb: SDHC1 does not have cd-gpios

From: Fabio Estevam <[email protected]>

SDHC1 does not have any GPIO for reading the card detection status, so remove 'cd-gpios'.

After this change card detection works via the internal SD controller mechanism.

---
 arch/arm/boot/dts/imx53-qsb.dts | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/imx53-qsb.dts +0 -2
index b646ef1..029ae42 100644
@@ -122,7 +122,6 @@
 &esdhc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_esdhc1_1>;
-	cd-gpios = <&gpio3 13 0>;
 	status = "okay";
 };
 
@@ -153,7 +152,6 @@
 				MX53_PAD_PATA_DATA15__GPIO2_15    0x80000000
 				MX53_PAD_EIM_DA11__GPIO3_11       0x80000000
 				MX53_PAD_EIM_DA12__GPIO3_12       0x80000000
-				MX53_PAD_EIM_DA13__GPIO3_13       0x80000000
 				MX53_PAD_PATA_DA_0__GPIO7_6       0x80000000
 				MX53_PAD_PATA_DA_2__GPIO7_8	  0x80000000
 				MX53_PAD_GPIO_16__GPIO7_11        0x80000000
Signature · 1 line
1.8.1.2
author reviewer
#2 lore raw

PATCH 3/3 ARM: dts: imx53-qsb: Do not use GPIO1_8 as wakeup source

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

On the mx53qsb board with mc34708 PMIC, GPIO1_8 resets the system, so better not to use it as a wakeup source.

Use GPIO 2_14 and 2_15 for wakeup sources instead.

---
 arch/arm/boot/dts/imx53-qsb.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx53-qsb.dts +2 -1
index 029ae42..91a5935 100644
@@ -55,19 +55,20 @@
 			label = "Power Button";
 			gpios = <&gpio1 8 0>;
 			linux,code = <116>; /* KEY_POWER */
-			gpio-key,wakeup;
 		};
 
 		volume-up {
 			label = "Volume Up";
 			gpios = <&gpio2 14 0>;
 			linux,code = <115>; /* KEY_VOLUMEUP */
+			gpio-key,wakeup;
 		};
 
 		volume-down {
 			label = "Volume Down";
 			gpios = <&gpio2 15 0>;
 			linux,code = <114>; /* KEY_VOLUMEDOWN */
+			gpio-key,wakeup;
 		};
 	};
 
Signature · 1 line
1.8.1.2