usb: g_ffs: fix compilation warning
PATCH 1/1 usb: g_ffs: fix compilation warning
Due to lack of "u_ether.h" header file, g_ffs.c compiles with following warning:
drivers/usb/gadget/g_ffs.c:81:1: warning: data definition has no type or storage class [enabled by default] drivers/usb/gadget/g_ffs.c:81:1: warning: type defaults to ‘int’ in declaration of ‘USB_ETHERNET_MODULE_PARAMETERS’ [-Wimplicit-int] drivers/usb/gadget/g_ffs.c:81:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
This patch adds the missing header.
--- drivers/usb/gadget/g_ffs.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/usb/gadget/g_ffs.c +3 -0
@@ -13,6 +13,9 @@#define pr_fmt (fmt) "g_ffs: " fmt#include <linux/module.h> + +#include "u_ether.h" +/* * kbuild is not very cooperative with respect to linking separately * compiled library objects into one module. So for now we won't use
Signature · 1 line
1.8.4.rc3
Greg KH
maintainerQuoted 2 lines · David Cohen
Due to lack of "
u_ether.h" header file,g_ffs.ccompiles with following warning:
It does? In what tree/branch/release is this happening?
thanks,
greg k-h
Quoted 5 lines · Greg KH
Quoted 2 lines · David Cohen
Due to lack of "
u_ether.h" header file,g_ffs.ccompiles with following warning:It does? In what tree/branch/release is this happening?
This is intended for Linus' 3.12-rc3. Haven't checked any other kernel.
In my compilation I disabled USB Host support and enabled DWC3 (gadget only) with ePCI + NOP_USB_XCEIV.
Br, David
Quoted 5 lines
thanks,
greg k-h
Quoted 11 lines · David Cohen
Quoted 5 lines · Greg KH
Quoted 2 lines · David Cohen
Due to lack of "
u_ether.h" header file,g_ffs.ccompiles with following warning:It does? In what tree/branch/release is this happening?
This is intended for Linus' 3.12-rc3. Haven't checked any other kernel.
In my compilation I disabled USB Host support and enabled DWC3 (gadget only) with ePCI +
NOP_USB_XCEIV.
After checking again this patch is not fixing properly. u_ether.h is conditionally included.
I'll solve it in another way. Please do not consider this patch anymore.
BR, David
Quoted 9 lines
Br, David
Quoted 5 lines
thanks,
greg k-h