mmc:sdhci-esdhc-imx: Use NULL instead of zero
Subsystems (4)
Fabio Estevam
reviewerPATCH 1/3 mmc:sdhci-esdhc-imx: Use NULL instead of zero
From: Fabio Estevam <[email protected]>
Fix the following sparse warning:
drivers/mmc/host/sdhci-esdhc-imx.c:617:35: warning: Using plain integer as NULL pointer
--- drivers/mmc/host/sdhci-esdhc-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-esdhc-imx.c +1 -1
@@ -614,7 +614,7 @@ static void esdhc_request_done(struct mmc_request *mrq)static int esdhc_send_tuning_cmd (struct sdhci_host *host,u32 opcode) {struct mmc_command cmd = {0 }; -struct mmc_request mrq = {0 }; +struct mmc_request mrq = {NULL };struct mmc_data data = {0 };struct scatterlist sg;char tuning_pattern[ESDHC_TUNING_BLOCK_PATTERN_LEN ];
Signature · 1 line
1.8.1.2
Fabio Estevam
reviewerPATCH 2/3 mmc: host: sdhci: Make sdhci_disable_irq_wakeups static
From: Fabio Estevam <[email protected]>
sdhci_disable_irq_wakeups() is not used anywhere else, so make it static.
Fix the following sparse warning:
drivers/mmc/host/sdhci.c:2543:6: warning: symbol 'sdhci_disable_irq_wakeups' was not declared. Should it be static?
--- drivers/mmc/host/sdhci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/host/sdhci.c +1 -2
@@ -2540,7 +2540,7 @@ void sdhci_enable_irq_wakeups(struct sdhci_host *host) }EXPORT_SYMBOL_GPL (sdhci_enable_irq_wakeups); -void sdhci_disable_irq_wakeups (struct sdhci_host *host) +static void sdhci_disable_irq_wakeups (struct sdhci_host *host) {u8 val;u8 mask =SDHCI_WAKE_ON_INSERT |SDHCI_WAKE_ON_REMOVE
@@ -2550,7 +2550,6 @@ void sdhci_disable_irq_wakeups(struct sdhci_host *host) val &= ~mask;sdhci_writeb (host, val,SDHCI_WAKE_UP_CONTROL ); } -EXPORT_SYMBOL_GPL (sdhci_disable_irq_wakeups);int sdhci_suspend_host (struct sdhci_host *host) {
Signature · 1 line
1.8.1.2
Fabio Estevam
reviewerPATCH 3/3 mmc: card.h: Use NULL instead of zero
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Fix the following sparse warnings:
drivers/mmc/card/block.c:2371:9: warning: Using plain integer as NULL pointer drivers/mmc/core/quirks.c:61:9: warning: Using plain integer as NULL pointer
--- include/linux/mmc/card.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mmc/card.h +1 -1
@@ -350,7 +350,7 @@ struct mmc_fixup {#define CID_OEMID_ANY ((unsigned short) -1)#define CID_NAME_ANY (NULL) -#define END_FIXUP { 0 } +#define END_FIXUP { NULL } #define _FIXUP_EXT(_name, _manfid, _oemid, _rev_start, _rev_end, \ _cis_vendor, _cis_device, \
Signature · 1 line
1.8.1.2
Fabio Estevam
reviewerChris,
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Fix the following sparse warning:
drivers/mmc/host/sdhci-esdhc-imx.c:617:35: warning: Using plain integer as NULL pointerCc Shawn Guo <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Any comments on this one?
Regards,
Fabio Estevam
Hi Fabio,
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Fix the following sparse warning:
drivers/mmc/host/sdhci-esdhc-imx.c:617:35: warning: Using plain integer as NULL pointerCc Shawn Guo <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Thanks, pushed to mmc-next for 3.14.
- Chris.
Signature · 1 line
Chris Ball <[email protected]> <http://printf.net/>