Skip to contentSkip to conversation

AM33XX crypto DTS patches

PATCH In review Joel Fernandes 2 participants 5 messages Oct 5, 2013 – Oct 8, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover AM33XX crypto DTS patches

These patches are some minor fixups and changes to commit messages to the AM33XX crypto (aes, sham) patches with reference to the comments at:
http://comments.gmane.org/gmane.linux.drivers.devicetree/45961

Joel Fernandes (1):
ARM: dts: AM33XX: Fix AES interrupt number

Mark A. Greer (2):
ARM: dts: AM33XX: Add SHAM data and documentation
ARM: dts: AM33XX: Add AES data and documentation

 .../devicetree/bindings/crypto/omap-aes.txt        | 31 ++++++++++++++++++++++
 .../devicetree/bindings/crypto/omap-sham.txt       | 28 +++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  8 ++++++
 arch/arm/boot/dts/am335x-evm.dts                   |  8 ++++++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  8 ++++++
 arch/arm/boot/dts/am33xx.dtsi                      | 19 +++++++++++++
 6 files changed, 102 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH v3 1/3 ARM: dts: AM33XX: Add SHAM data and documentation

From: "Mark A. Greer" <[email protected]>

Add the generic AM33XX SHAM module's device tree data and enable it for the am335x-evm, am335x-evmsk, and am335x-bone platforms. Also add Documentation file describing the data for the SHAM module.

[joelf at ti.com: Dropped interrupt-parrent property, documentation fixups]
CC Paul Walmsley <[email protected]>
---
 .../devicetree/bindings/crypto/omap-sham.txt       | 28 ++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  4 ++++
 arch/arm/boot/dts/am335x-evm.dts                   |  4 ++++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  4 ++++
 arch/arm/boot/dts/am33xx.dtsi                      |  9 +++++++
 5 files changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt
Documentation/devicetree/bindings/crypto/omap-sham.txt new file +28 -0
new file mode 100644
index 0000000..f839acd
@@ -0,0 +1,28 @@
+OMAP SoC SHA crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  SHAM versions:
+  - "ti,omap2-sham" for OMAP2 & OMAP3.
+  - "ti,omap4-sham" for OMAP4 and AM33XX.
+  Note that these two versions are incompatible.
+- ti,hwmods: Name of the hwmod associated with the SHAM module
+- reg : Offset and length of the register set for the module
+- interrupts : the interrupt-specifier for the SHAM module.
+
+Optional properties:
+- dmas: DMA specifiers for the rx dma. See the DMA client binding,
+	Documentation/devicetree/bindings/dma/dma.txt
+- dma-names: DMA request name. Should be "rx" if a dma is present.
+
+Example:
+	/* AM335x */
+	sham: sham at 53100000 {
+		compatible = "ti,omap4-sham";
+		ti,hwmods = "sham";
+		reg = <0x53100000 0x200>;
+		interrupts = <109>;
+		dmas = <&edma 36>;
+		dma-names = "rx";
+	};
arch/arm/boot/dts/am335x-bone.dts +4 -0
index 0d63348..8a9802e 100644
@@ -19,3 +19,7 @@
 &mmc1 {
 	vmmc-supply = <&ldo3_reg>;
 };
+
+&sham {
+	status = "okay";
+};
arch/arm/boot/dts/am335x-evm.dts +4 -0
index 23b0a3e..d59e51c 100644
@@ -522,3 +522,7 @@
 	status = "okay";
 	vmmc-supply = <&vmmc_reg>;
 };
+
+&sham {
+	status = "okay";
+};
arch/arm/boot/dts/am335x-evmsk.dts +4 -0
index bc93895..d45a330 100644
@@ -424,3 +424,7 @@
 	status = "okay";
 	vmmc-supply = <&vmmc_reg>;
 };
+
+&sham {
+	status = "okay";
+};
arch/arm/boot/dts/am33xx.dtsi +9 -0
index 553adc6..299710b 100644
@@ -710,5 +710,14 @@
 			#size-cells = <1>;
 			status = "disabled";
 		};
+
+		sham: sham at 53100000 {
+			compatible = "ti,omap4-sham";
+			ti,hwmods = "sham";
+			reg = <0x53100000 0x200>;
+			interrupts = <109>;
+			dmas = <&edma 36>;
+			dma-names = "rx";
+		};
 	};
 };
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH v3 2/3 ARM: dts: AM33XX: Add AES data and documentation

In reply to Joel Fernandes

From: "Mark A. Greer" <[email protected]>

Add the generic AM33XX AES module's device tree data and enable it for the am335x-evm, am335x-evmsk, and am335x-bone platforms. Also add Documentation file describing the data for the AES module.

[joelf at ti.com: Dropped interrupt-parent propert, documentation fixups]

---
 .../devicetree/bindings/crypto/omap-aes.txt        | 31 ++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  4 +++
 arch/arm/boot/dts/am335x-evm.dts                   |  4 +++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  4 +++
 arch/arm/boot/dts/am33xx.dtsi                      | 10 +++++++
 5 files changed, 53 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt
Documentation/devicetree/bindings/crypto/omap-aes.txt new file +31 -0
new file mode 100644
index 0000000..fd97176
@@ -0,0 +1,31 @@
+OMAP SoC AES crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  AES versions:
+  - "ti,omap2-aes" for OMAP2.
+  - "ti,omap3-aes" for OMAP3.
+  - "ti,omap4-aes" for OMAP4 and AM33XX.
+  Note that the OMAP2 and 3 versions are compatible (OMAP3 supports
+  more algorithms) but they are incompatible with OMAP4.
+- ti,hwmods: Name of the hwmod associated with the AES module
+- reg : Offset and length of the register set for the module
+- interrupts : the interrupt-specifier for the AES module.
+
+Optional properties:
+- dmas: DMA specifiers for tx and rx dma. See the DMA client binding,
+	Documentation/devicetree/bindings/dma/dma.txt
+- dma-names: DMA request names should include "tx" and "rx" if present.
+
+Example:
+	/* AM335x */
+	aes: aes at 53500000 {
+		compatible = "ti,omap4-aes";
+		ti,hwmods = "aes";
+		reg = <0x53500000 0xa0>;
+		interrupts = <102>;
+		dmas = <&edma 6>,
+		       <&edma 5>;
+		dma-names = "tx", "rx";
+	};
arch/arm/boot/dts/am335x-bone.dts +4 -0
index 8a9802e..94ee427 100644
@@ -23,3 +23,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
arch/arm/boot/dts/am335x-evm.dts +4 -0
index d59e51c..86463fa 100644
@@ -526,3 +526,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
arch/arm/boot/dts/am335x-evmsk.dts +4 -0
index d45a330..f577e65 100644
@@ -428,3 +428,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
arch/arm/boot/dts/am33xx.dtsi +10 -0
index 299710b..2664da9 100644
@@ -719,5 +719,15 @@
 			dmas = <&edma 36>;
 			dma-names = "rx";
 		};
+
+		aes: aes at 53500000 {
+			compatible = "ti,omap4-aes";
+			ti,hwmods = "aes";
+			reg = <0x53500000 0xa0>;
+			interrupts = <102>;
+			dmas = <&edma 6>,
+			       <&edma 5>;
+			dma-names = "tx", "rx";
+		};
 	};
 };
Signature · 1 line
1.8.1.2
#3 lore raw

PATCH v3 3/3 ARM: dts: AM33XX: Fix AES interrupt number

In reply to Joel Fernandes

AES interrupts were previously not used, but after recent changes to omap-aes driver, its being used. We correct the interrupt number to have working PIO mode.

---
 arch/arm/boot/dts/am33xx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am33xx.dtsi +1 -1
index 2664da9..5c2d6c1 100644
@@ -724,7 +724,7 @@
 			compatible = "ti,omap4-aes";
 			ti,hwmods = "aes";
 			reg = <0x53500000 0xa0>;
-			interrupts = <102>;
+			interrupts = <103>;
 			dmas = <&edma 6>,
 			       <&edma 5>;
 			dma-names = "tx", "rx";
Signature · 1 line
1.8.1.2
#4 lore raw
In reply to Joel Fernandes

Hi Joel,

Quoted 18 lines · Joel Fernandes

These patches are some minor fixups and changes to commit messages to the AM33XX crypto (aes, sham) patches with reference to the comments at:
http://comments.gmane.org/gmane.linux.drivers.devicetree/45961

Joel Fernandes (1):
ARM: dts: AM33XX: Fix AES interrupt number

Mark A. Greer (2):
ARM: dts: AM33XX: Add SHAM data and documentation
ARM: dts: AM33XX: Add AES data and documentation

  .../devicetree/bindings/crypto/omap-aes.txt        | 31 ++++++++++++++++++++++
  .../devicetree/bindings/crypto/omap-sham.txt       | 28 +++++++++++++++++++
  arch/arm/boot/dts/am335x-bone.dts                  |  8 ++++++
  arch/arm/boot/dts/am335x-evm.dts                   |  8 ++++++
  arch/arm/boot/dts/am335x-evmsk.dts                 |  8 ++++++
  arch/arm/boot/dts/am33xx.dtsi                      | 19 +++++++++++++
  6 files changed, 102 insertions(+)
Quoted 3 lines

create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt

I've just applied this series and the remaining ones from the previous version.

Thanks,
Benoit