Skip to contentSkip to conversation

cpufreq: sa11x0: Fix build

PATCH New Mark Brown 3 participants 4 messages Oct 6, 2013 – Oct 13, 2013

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 cpufreq: sa11x0: Fix build

From: Mark Brown <[email protected]>

Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure that the struct was declared, causing build failures on machines using that header. Fix this.

---

The relevant commit is in the cpufreq tree in -next.

 arch/arm/mach-sa1100/generic.h | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-sa1100/generic.h +1 -0
index f5214ce..eff1469 100644
@@ -4,6 +4,7 @@
  * Author: Nicolas Pitre
  */
 #include <linux/reboot.h>
+#include <linux/cpufreq.h>
 
 extern void sa1100_timer_init(void);
 extern void __init sa1100_map_io(void);
Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH 1/1 cpufreq: sa11x0: Fix build

Quoted 7 lines · Mark Brown

From: Mark Brown <[email protected]>

Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure that the struct was declared, causing build failures on machines using that header. Fix this.

Quoted 5 lines

---

The relevant commit is in the cpufreq tree in -next.

I have already sent relevant fix to Rafael for this, which looks similar to this.. And I am waiting for Rafael to merge it with offending commit...

#2 lore raw

PATCH 1/1 cpufreq: sa11x0: Fix build

Quoted 12 lines · Viresh Kumar
Quoted 11 lines · Mark Brown

From: Mark Brown <[email protected]>

Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure that the struct was declared, causing build failures on machines using that header. Fix this.

---

Quoted 5 lines
Quoted 1 line

The relevant commit is in the cpufreq tree in -next.

I have already sent relevant fix to Rafael for this, which looks similar to this.. And I am waiting for Rafael to merge it with offending commit...

Things are still broken (or broken again). Can we please see this patch show up in next soon?

-Olof

#3 lore raw

PATCH 1/1 cpufreq: sa11x0: Fix build

Quoted 2 lines · Olof Johansson

Things are still broken (or broken again). Can we please see this patch show up in next soon?

Its just applied today by rafael..
b37e4d1 cpufreq: sa11x0: Fix build breakage after "Expose frequency table"