Bluetooth: Power off AMP controllers after setup phase
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/3 Bluetooth: Power off AMP controllers after setup phase
Even AMP controllers should be powered off after the setup phase. It is not a good idea to keep AMP controllers powered on all the time if they are not in use.
Power on of the AMP controller can either be done manually via command line commands or directly via A2MP. Especially since there is an indication in A2MP for powered down controllers that can be activated.
--- net/bluetooth/hci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/hci_core.c +1 -1
@@ -2356,9 +2356,9 @@ int hci_register_dev(struct hci_dev *hdev)set_bit (HCI_RFKILLED , &hdev->dev_flags);set_bit (HCI_SETUP , &hdev->dev_flags); +set_bit (HCI_AUTO_OFF , &hdev->dev_flags);if (hdev->dev_type ==HCI_BREDR ) { -set_bit (HCI_AUTO_OFF , &hdev->dev_flags);/* Assume BR/EDR support until proven otherwise (such as * through reading supported features during init. */
Signature · 1 line
1.8.3.1
Hi Marcel,
Quoted 9 lines · Marcel Holtmann
Even AMP controllers should be powered off after the setup phase. It is not a good idea to keep AMP controllers powered on all the time if they are not in use.
Power on of the AMP controller can either be done manually via command line commands or directly via A2MP. Especially since there is an indication in A2MP for powered down controllers that can be activated.
Quoted 4 lines
Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/hci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
All patches in this set have been applied to bluetooth-next. Thanks.
Johan