Skip to contentSkip to conversation

netfilter: ipvs: ip_vs_sync: Remove unused variable

PATCH In review Fabio Estevam 2 participants 3 messages Oct 7, 2013 – Nov 6, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter: ipvs: ip_vs_sync: Remove unused variable

From: Fabio Estevam <[email protected]>

Variable 'ret' is not used anywhere and it causes the following build warning:

net/netfilter/ipvs/ip_vs_sync.c: In function 'sync_thread_master':
net/netfilter/ipvs/ip_vs_sync.c:1640:8: warning: unused variable 'ret' [-Wunused-variable]

---
 net/netfilter/ipvs/ip_vs_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/ipvs/ip_vs_sync.c +1 -1
index f63c238..d258125 100644
@@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
 			continue;
 		}
 		while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
-			int ret = __wait_event_interruptible(*sk_sleep(sk),
+			__wait_event_interruptible(*sk_sleep(sk),
 						   sock_writeable(sk) ||
 						   kthread_should_stop());
 			if (unlikely(kthread_should_stop()))
Signature · 1 line
1.8.1.2
maintainer
#1 lore raw
Quoted 17 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Variable 'ret' is not used anywhere and it causes the following build warning:

net/netfilter/ipvs/ip_vs_sync.c: In function 'sync_thread_master':
net/netfilter/ipvs/ip_vs_sync.c:1640:8: warning: unused variable 'ret' [-Wunused-variable]

---
 net/netfilter/ipvs/ip_vs_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/ipvs/ip_vs_sync.c +0 -0
index f63c238..d258125 100644

net/netfilter/ipvs/ip_vs_sync.c static int sync_thread_master(void *data) · line 1643

Quoted 8 lines
net/netfilter/ipvs/ip_vs_sync.c +1 -1
@@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
 			continue;
 		}
 		while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
-			int ret = __wait_event_interruptible(*sk_sleep(sk),
+			__wait_event_interruptible(*sk_sleep(sk),
 						   sock_writeable(sk) ||
 						   kthread_should_stop());
 			if (unlikely(kthread_should_stop()))

Hi Fabio,

this patch does not seem to apply against ipvs-next.
Could you please rework it and repost if you believe it is still needed.

#2 lore raw

Hi Simon,

Quoted 4 lines · Simon Horman

Hi Fabio,

this patch does not seem to apply against ipvs-next.
Could you please rework it and repost if you believe it is still needed.

Yes, ipvs-next does not have this issue, but linux-next still shows this problem though.

Won't ipvs-next get synced with linux-next?

Regards,

Fabio Estevam