usb:smsx95xx LED activity for USB net driver
PATCH 1/1 usb:smsx95xx LED activity for USB net driver
Add LED activity for SMSX95XX USB Ether driver.
--- drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
drivers/usb/eth/smsc95xx.c +14 -0
@@ -14,6 +14,12 @@/* SMSC LAN95xx based USB 2.0 Ethernet Devices */ +/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000) +/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000#define TX_CMD_A_LAST_SEG_ 0x00001000
@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)return ret;debug ("ID_REV = 0x%08x\n" , read_buf); +/* Configure GPIO pins as LED outputs */ + write_buf =LED_GPIO_CFG_SPD_LED |LED_GPIO_CFG_LNK_LED | +LED_GPIO_CFG_FDX_LED ; + ret =smsc95xx_write_reg (dev,LED_GPIO_CFG , write_buf); +if (ret <0 ) +return ret; +debug ("LED_GPIO_CFG set\n" ); +/* Init Tx */ write_buf =0 ; ret =smsc95xx_write_reg (dev,FLOW , write_buf);
Signature · 1 line
1.7.1
PATCH 1/1 usb:smsx95xx LED activity for USB net driver
+Joe (net maintainer)
+Marek (USB)
Hi Suriyan,
Quoted 28 lines · Suriyan Ramasami
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by ?Suriyan Ramasami" <[email protected]>--- drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)drivers/usb/eth/smsc95xx.c +6
-0@@ -14,6 +14,12 @@/* SMSC LAN95xx based USB 2.0 Ethernet Devices */ +/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000) +/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000#define TX_CMD_A_LAST_SEG_ 0x00001000@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)return ret;debug ("ID_REV = 0x%08x\n" , read_buf);
drivers/usb/eth/smsc95xx.c static int smsc95xx_init(struct eth_device *eth, bd_t · line 609
Quoted 10 lines
drivers/usb/eth/smsc95xx.c +8
-0+/* Configure GPIO pins as LED outputs */ + write_buf =LED_GPIO_CFG_SPD_LED |LED_GPIO_CFG_LNK_LED | +LED_GPIO_CFG_FDX_LED ; + ret =smsc95xx_write_reg (dev,LED_GPIO_CFG , write_buf); +if (ret <0 ) +return ret; +debug ("LED_GPIO_CFG set\n" ); +
Seems good.
Quoted 7 lines
drivers/usb/eth/smsc95xx.c +0
-0/* Init Tx */ write_buf = 0; ret = smsc95xx_write_reg(dev, FLOW, write_buf);--
1.7.1
Marek Vasut
AppliedPATCH 1/1 usb:smsx95xx LED activity for USB net driver
Dear Simon Glass,
Quoted 51 lines
(quoted diff) +2
-0+Joe (net maintainer) +Marek (USB)Hi Suriyan,
Quoted 32 lines · Suriyan Ramasami
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by ?Suriyan Ramasami" <[email protected]>---
drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)drivers/usb/eth/smsc95xx.c +6
-0@@ -14,6 +14,12 @@/* SMSC LAN95xx based USB 2.0 Ethernet Devices */ +/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000) +/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000#define
TX_CMD_A_LAST_SEG_0x00001000drivers/usb/eth/smsc95xx.c +0
-0@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)return ret;drivers/usb/eth/smsc95xx.c static int smsc95xx_init(struct eth_device *eth, · line 610
Quoted 10 lines
drivers/usb/eth/smsc95xx.c +8
-0debug ("ID_REV = 0x%08x\n" , read_buf); +/* Configure GPIO pins as LED outputs */ + write_buf =LED_GPIO_CFG_SPD_LED |LED_GPIO_CFG_LNK_LED | +LED_GPIO_CFG_FDX_LED ; + ret =smsc95xx_write_reg (dev,LED_GPIO_CFG , write_buf); +if (ret <0 ) +return ret; +debug ("LED_GPIO_CFG set\n" ); +Seems good.
Quoted 1 line
Acked-by Simon Glass <[email protected]>
Applied to usb/next
I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Best regards,
Marek Vasut
PATCH 1/1 usb:smsx95xx LED activity for USB net driver
Quoted 53 lines · Marek Vasut
Dear Simon Glass,
Quoted 51 lines
(quoted diff) +2
-0+Joe (net maintainer) +Marek (USB)Hi Suriyan,
Quoted 32 lines · Suriyan Ramasami
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by ?Suriyan Ramasami" <[email protected]>---
drivers/usb/eth/smsc95xx.c| 14 ++++++++++++++1 files changed, 14 insertions(+), 0 deletions(-)drivers/usb/eth/smsc95xx.c +6
-0@@ -14,6 +14,12 @@/* SMSC LAN95xx based USB 2.0 Ethernet Devices */ +/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000) +/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000#define
TX_CMD_A_LAST_SEG_0x00001000drivers/usb/eth/smsc95xx.c +0
-0@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)return ret;drivers/usb/eth/smsc95xx.c static int smsc95xx_init(struct eth_device *eth, · line 610
Quoted 10 lines
drivers/usb/eth/smsc95xx.c +8
-0debug ("ID_REV = 0x%08x\n" , read_buf); +/* Configure GPIO pins as LED outputs */ + write_buf =LED_GPIO_CFG_SPD_LED |LED_GPIO_CFG_LNK_LED | +LED_GPIO_CFG_FDX_LED ; + ret =smsc95xx_write_reg (dev,LED_GPIO_CFG , write_buf); +if (ret <0 ) +return ret; +debug ("LED_GPIO_CFG set\n" ); +Seems good.
Quoted 5 lines
Quoted 1 line
Acked-by Simon Glass <[email protected]>Applied to usb/next
I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Sure... When I need to be.
Quoted 3 lines
Best regards,
Marek Vasut
PATCH 1/1 usb:smsx95xx LED activity for USB net driver
Dear Joe Hershberger,
Quoted 9 lines · Marek Vasut
Quoted 8 lines
Dear Simon Glass,
Quoted 6 lines
(quoted diff) +2
-0+Joe (net maintainer) +Marek (USB)Hi Suriyan,
On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami
Quoted 45 lines · <[email protected]>wrote:
Quoted 45 lines
Quoted 45 lines
Quoted 32 lines
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by ?Suriyan Ramasami" <[email protected]>---
drivers/usb/eth/smsc95xx.c| 14 ++++++++++++++1 files changed, 14 insertions(+), 0 deletions(-)drivers/usb/eth/smsc95xx.c +6
-0@@ -14,6 +14,12 @@/* SMSC LAN95xx based USB 2.0 Ethernet Devices */ +/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000) +/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000#define
TX_CMD_A_LAST_SEG_0x00001000drivers/usb/eth/smsc95xx.c +0
-0@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)return ret;drivers/usb/eth/smsc95xx.c static int smsc95xx_init(struct eth_device *eth, · line 610
Quoted 10 lines
drivers/usb/eth/smsc95xx.c +8
-0debug ("ID_REV = 0x%08x\n" , read_buf); +/* Configure GPIO pins as LED outputs */ + write_buf =LED_GPIO_CFG_SPD_LED |LED_GPIO_CFG_LNK_LED | +LED_GPIO_CFG_FDX_LED ; + ret =smsc95xx_write_reg (dev,LED_GPIO_CFG , write_buf); +if (ret <0 ) +return ret; +debug ("LED_GPIO_CFG set\n" ); +Seems good.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Acked-by Simon Glass <[email protected]>Applied to usb/next
I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Sure... When I need to be.
Heh :) Haven't seen you on IRC for a while (and you surely missed a lot, applied for sjg too). I picked this patch, so no problem here.
Best regards,
Marek Vasut