fib_trie: only calc for the un-first node
Subsystems (3)
PATCH 1/1 fib_trie: only calc for the un-first node
From: "baker.zhang" <[email protected]>
This is a enhancement.
for the first node in fib_trie, newpos is 0, bit is 1. Only for the leaf or node with unmatched key need calc pos.
Signed-off-by baker.zhang <[email protected]>
--- net/ipv4/fib_trie.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
net/ipv4/fib_trie.c +1 -5
@@ -1117,12 +1117,8 @@ static struct list_head *fib_insert_node(struct trie *t, u32 key, int plen)* first tnode need some special handling */ -if (tp) - pos = tp->pos+tp->bits; -else - pos =0 ; -if (n) { + pos = tp ? tp->pos+tp->bits :0 ; newpos =tkey_mismatch (key, pos, n->key); tn =tnode_new (n->key, newpos,1 ); }else {
Signature · 1 line
1.7.9.5
David Miller
maintainerFrom: [email protected]
Date: Tue, 8 Oct 2013 11:36:51 +0800
Quoted 8 lines
From: "baker.zhang" <[email protected]>
This is a enhancement.
for the first node in
fib_trie, newpos is 0, bit is 1. Only for the leaf or node with unmatched key need calc pos.Signed-off-by baker.zhang <[email protected]>
The compiler is probably doing this transformation all by itself, but applied anyways, thanks.