Skip to contentSkip to conversation

Add new package espeak, a speech synthesizer software

PATCH Superseded arnaud.aujon at gmail.com 2 participants 3 messages Oct 8, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Add new package espeak, a speech synthesizer software

From: Arnaud Aujon <[email protected]>

---
 package/Config.in                                  |  1 +
 package/espeak/Config.in                           | 53 ++++++++++++++++++++++
 .../espeak-1-do-not-compil-when-install.patch      | 15 ++++++
 package/espeak/espeak.mk                           | 41 +++++++++++++++++
 4 files changed, 110 insertions(+)
 create mode 100644 package/espeak/Config.in
 create mode 100644 package/espeak/espeak-1-do-not-compil-when-install.patch
 create mode 100644 package/espeak/espeak.mk
package/Config.in +1 -0
index 424e40d..b5f411f 100644
@@ -6,6 +6,7 @@ menu "Audio and video applications"
 source "package/alsa-utils/Config.in"
 source "package/aumix/Config.in"
 source "package/bellagio/Config.in"
+source "package/espeak/Config.in"
 source "package/faad2/Config.in"
 source "package/ffmpeg/Config.in"
 source "package/flac/Config.in"
package/espeak/Config.in new file +53 -0

53 lines not on this page · raw message

package/espeak/espeak-1-do-not-compil-when-install.patch new file +15 -0
new file mode 100644
index 0000000..744af62
@@ -0,0 +1,15 @@
+Index: espeak-1.47.11-source/src/Makefile
+Makefile: do not executethe rule "all" when executing "install"
+signed-off-by Arnaud Aujon <[email protected]>
+===================================================================
+--- espeak-1.47.11-source.orig/src/Makefile
++++ espeak-1.47.11-source/src/Makefile
+@@ -131,7 +131,7 @@
+ 	rm -f $(BIN2_NAME)
+ 	rm -f $(LIB_NAME)*
+ 
+-install: all
++install:
+ 	# Create directories
+ 	rm -rf $(DESTDIR)$(DATADIR)
+ 	$(MKDIR) $(DESTDIR)$(BINDIR)
package/espeak/espeak.mk new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
1.8.3.1
#1 lore raw

PATCH v2 1/1 Add new package espeak, a speech synthesizer software

Dear arnaud.aujon at gmail.com,

Quoted 3 lines · arnaud.aujon at gmail.com

From: Arnaud Aujon <[email protected]>

Thanks, it looks better since the patch is no longer wrapped, but other than that, you haven't taken into account any of the comments I made in the review of the first version.

Have you seen the comments I made at
http://lists.busybox.net/pipermail/buildroot/2013-October/079804.html ? Look at the entire e-mail, my answer was spread in the different parts of the e-mail, depending on what the comment was referring to.

Also, your previous commit title was better, it should be just:

espeak: new package

Thanks

Thomas

Signature · 3 lines
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 Add new package espeak, a speech synthesizer software

Sorry I send the wrong patch, I obviouly fixed everything, I will send it again soon.
Sorry about that.

2013/10/8 Thomas Petazzoni <[email protected]>

Quoted 20 lines

Dear arnaud.aujon at gmail.com,

Quoted 3 lines · arnaud.aujon at gmail.com

From: Arnaud Aujon <[email protected]>

Thanks, it looks better since the patch is no longer wrapped, but other than that, you haven't taken into account any of the comments I made in the review of the first version.

Have you seen the comments I made at
http://lists.busybox.net/pipermail/buildroot/2013-October/079804.html ? Look at the entire e-mail, my answer was spread in the different parts of the e-mail, depending on what the comment was referring to.

Also, your previous commit title was better, it should be just:

espeak: new package

Quoted 8 lines

Thanks

Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131008/93cea62f/attachment.html>