Skip to contentSkip to conversation

regmap: Don't generate gather writes for single register raw writes

PATCH New Mark Brown 1 participant 1 message Oct 8, 2013

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/1 regmap: Don't generate gather writes for single register raw writes

From: Mark Brown <[email protected]>

Since it is quite common for single register raw or async writes to be generated by rbtree cache syncs or firmware downloads and essentially all hardware will be faster with only a single transfer optimise this case by copying single values into the internal scratch buffer before sending.

---
 drivers/base/regmap/regmap.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/base/regmap/regmap.c +10 -0
index 5754513..4866ae5 100644
@@ -1118,6 +1118,16 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg,
 
 	u8[0] |= map->write_flag_mask;
 
+	/*
+	 * Essentially all I/O mechanisms will be faster with a single
+	 * buffer to write.  Since register syncs often generate raw
+	 * writes of single registers optimise that case.
+	 */
+	if (val != work_val && val_len == map->format.val_bytes) {
+		memcpy(work_val, val, map->format.val_bytes);
+		val = work_val;
+	}
+
 	if (async && map->bus->async_write) {
 		struct regmap_async *async;
 
Signature · 1 line
1.8.4.rc3