iio: adc: Move mxs-lradc out of staging
Subsystems (5)
Fabio Estevam
reviewerPATCH 1/1 iio: adc: Move mxs-lradc out of staging
From: Fabio Estevam <[email protected]>
There have been some discussions [1] about removing this driver out of staging, so let's do it now.
[1] http://www.spinics.net/lists/linux-iio/msg10091.html
---
.../devicetree/bindings/{staging => }/iio/adc/mxs-lradc.txt | 0
drivers/iio/adc/Kconfig | 12 ++++++++++++
drivers/iio/adc/Makefile | 1 +
drivers/{staging => }/iio/adc/mxs-lradc.c | 0
drivers/staging/iio/adc/Kconfig | 12 ------------
drivers/staging/iio/adc/Makefile | 1 -
6 files changed, 13 insertions(+), 13 deletions(-)
rename Documentation/devicetree/bindings/{staging => }/iio/adc/mxs-lradc.txt (100%)
rename drivers/{staging => }/iio/adc/mxs-lradc.c (100%)Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt renamed from Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt +0 -0
drivers/iio/adc/Kconfig +12 -0
@@ -155,6 +155,18 @@ config MCP3422 This driver can also be built as a module. If so, the module will be called mcp3422. +config MXS_LRADC + tristate "Freescale i.MX23/i.MX28 LRADC" + depends on ARCH_MXS + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER + help + Say yes here to build support for i.MX23/i.MX28 LRADC convertor + built into these chips. + + To compile this driver as a module, choose M here: the + module will be called mxs-lradc. + config NAU7802 tristate "Nuvoton NAU7802 ADC driver" depends on I2C
drivers/iio/adc/Makefile +1 -0
@@ -17,6 +17,7 @@ obj-$(CONFIG_LP8788_ADC) += lp8788_adc.o obj-$(CONFIG_MAX1363) += max1363.o obj-$(CONFIG_MCP320X) += mcp320x.o obj-$(CONFIG_MCP3422) += mcp3422.o +obj-$(CONFIG_MXS_LRADC) += mxs-lradc.o obj-$(CONFIG_NAU7802) += nau7802.o obj-$(CONFIG_TI_ADC081C) += ti-adc081c.o obj-$(CONFIG_TI_AM335X_ADC) += ti_am335x_adc.o
drivers/iio/adc/mxs-lradc.c renamed from drivers/staging/iio/adc/mxs-lradc.c +0 -0
drivers/staging/iio/adc/Kconfig +0 -12
@@ -111,18 +111,6 @@ config LPC32XX_ADC activate only one via device tree selection. Provides direct access via sysfs. -config MXS_LRADC - tristate "Freescale i.MX23/i.MX28 LRADC" - depends on ARCH_MXS - select IIO_BUFFER - select IIO_TRIGGERED_BUFFER - help - Say yes here to build support for i.MX23/i.MX28 LRADC convertor - built into these chips. - - To compile this driver as a module, choose M here: the - module will be called mxs-lradc. - config SPEAR_ADC tristate "ST SPEAr ADC" depends on PLAT_SPEAR
drivers/staging/iio/adc/Makefile +0 -1
@@ -18,5 +18,4 @@ obj-$(CONFIG_AD7816) += ad7816.o obj-$(CONFIG_AD7192) += ad7192.o obj-$(CONFIG_AD7280) += ad7280a.o obj-$(CONFIG_LPC32XX_ADC) += lpc32xx_adc.o -obj-$(CONFIG_MXS_LRADC) += mxs-lradc.o obj-$(CONFIG_SPEAR_ADC) += spear_adc.o
Signature · 1 line
1.8.1.2
Dear Fabio Estevam,
Quoted 8 lines
From: Fabio Estevam <[email protected]>
There have been some discussions [1] about removing this driver out of staging, so let's do it now.
[1] http://www.spinics.net/lists/linux-iio/msg10091.html
Signed-off-by Fabio Estevam <[email protected]>
Thanks!
Best regards,
Marek Vasut
Quoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There have been some discussions [1] about removing this driver out of staging, so let's do it now.
What about the TODO[1] entry that was recently added?
- Lars
[1] http://www.spinics.net/lists/linux-iio/msg10645.html
Quoted 89 lines
Signed-off-by Fabio Estevam <[email protected]>--- .../devicetree/bindings/{staging => }/iio/adc/mxs-lradc.txt | 0 drivers/iio/adc/Kconfig | 12 ++++++++++++ drivers/iio/adc/Makefile | 1 + drivers/{staging => }/iio/adc/mxs-lradc.c | 0 drivers/staging/iio/adc/Kconfig | 12 ------------ drivers/staging/iio/adc/Makefile | 1 - 6 files changed, 13 insertions(+), 13 deletions(-) rename Documentation/devicetree/bindings/{staging => }/iio/adc/mxs-lradc.txt (100%) rename drivers/{staging => }/iio/adc/mxs-lradc.c (100%)Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt renamed from Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt +0
-0drivers/iio/adc/Kconfig +12
-0@@ -155,6 +155,18 @@ config MCP3422 This driver can also be built as a module. If so, the module will be called mcp3422. +config MXS_LRADC + tristate "Freescale i.MX23/i.MX28 LRADC" + depends on ARCH_MXS + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER + help + Say yes here to build support for i.MX23/i.MX28 LRADC convertor + built into these chips. + + To compile this driver as a module, choose M here: the + module will be called mxs-lradc. + config NAU7802 tristate "Nuvoton NAU7802 ADC driver" depends on I2Cdrivers/iio/adc/Makefile +1
-0@@ -17,6 +17,7 @@ obj-$(CONFIG_LP8788_ADC) += lp8788_adc.o obj-$(CONFIG_MAX1363) += max1363.o obj-$(CONFIG_MCP320X) += mcp320x.o obj-$(CONFIG_MCP3422) += mcp3422.o +obj-$(CONFIG_MXS_LRADC) += mxs-lradc.o obj-$(CONFIG_NAU7802) += nau7802.o obj-$(CONFIG_TI_ADC081C) += ti-adc081c.o obj-$(CONFIG_TI_AM335X_ADC) += ti_am335x_adc.odrivers/iio/adc/mxs-lradc.c renamed from drivers/staging/iio/adc/mxs-lradc.c +0
-0drivers/staging/iio/adc/Kconfig +0
-12@@ -111,18 +111,6 @@ config LPC32XX_ADC activate only one via device tree selection. Provides direct access via sysfs. -config MXS_LRADC - tristate "Freescale i.MX23/i.MX28 LRADC" - depends on ARCH_MXS - select IIO_BUFFER - select IIO_TRIGGERED_BUFFER - help - Say yes here to build support for i.MX23/i.MX28 LRADC convertor - built into these chips. - - To compile this driver as a module, choose M here: the - module will be called mxs-lradc. - config SPEAR_ADC tristate "ST SPEAr ADC" depends on PLAT_SPEARdrivers/staging/iio/adc/Makefile +0
-1@@ -18,5 +18,4 @@ obj-$(CONFIG_AD7816) += ad7816.o obj-$(CONFIG_AD7192) += ad7192.o obj-$(CONFIG_AD7280) += ad7280a.o obj-$(CONFIG_LPC32XX_ADC) += lpc32xx_adc.o -obj-$(CONFIG_MXS_LRADC) += mxs-lradc.o obj-$(CONFIG_SPEAR_ADC) += spear_adc.o
Fabio Estevam
reviewerQuoted 10 lines · Lars-Peter Clausen
Quoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There have been some discussions [1] about removing this driver out of staging, so let's do it now.
What about the TODO[1] entry that was recently added?
Good catch.
Would it be acceptable if I move the mxs TODO text into mxs-lradc.c?
Regards,
Fabio Estevam
Hi Fabio,
Quoted 7 lines · On Wednesday 09 October 2013 14:31:26 Fabio Estevam wrote:
Quoted 6 lines · Lars-Peter Clausen
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There have been some discussions [1] about removing this driver out of staging, so let's do it now.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
What about the TODO[1] entry that was recently added?
Good catch.
Would it be acceptable if I move the mxs TODO text into
mxs-lradc.c?
Sounds like you want to make it forgotten. ;)
Regards,
Juergen
Signature · 2 lines
Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
Fabio Estevam
reviewerHi Jürgen,
Quoted 3 lines · Jürgen Beisert
Quoted 1 line
Would it be acceptable if I move the mxs TODO text into
mxs-lradc.c?Sounds like you want to make it forgotten. ;)
What would you suggest?
Regards,
Fabio Estevam
Hi Fabio,
Quoted 6 lines · On Wednesday 09 October 2013 15:17:33 Fabio Estevam wrote:
Quoted 3 lines · Jürgen Beisert
Quoted 1 line
Would it be acceptable if I move the mxs TODO text into
mxs-lradc.c?Sounds like you want to make it forgotten. ;)
What would you suggest?
Keep the driver in staging until somebody can spend some effort to split this driver into an MFD and at least into its IIO (generic ADC) and touchscreen components. IMHO the touchscreen component should go into the input subsystem part of the kernel tree, its not related to IIO.
Regards,
Juergen
Signature · 2 lines
Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
Jonathan Cameron
maintainerQuoted 6 lines · Jürgen Beisert
Hi Fabio,
Quoted 3 lines · On Wednesday 09 October 2013 15:17:33 Fabio Estevam wrote:
Quoted 2 lines · Jürgen Beisert
Quoted 1 line
Would it be acceptable if I move the mxs TODO text into
mxs-lradc.c?
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Sounds like you want to make it forgotten. ;)
What would you suggest?
Keep the driver in staging until somebody can spend some effort to split this driver into an MFD and at least into its IIO (generic ADC) and touchscreen components. IMHO the touchscreen component should go into the input subsystem part of the kernel tree, its not related to IIO.
That would definitely be my preference as well.
Jonathan
Quoted 4 lines
Regards,
Juergen