Skip to contentSkip to conversation

fix way of setting ioengine specific parameter

PATCH New Akinobu Mita 1 participant 1 message Oct 8, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix way of setting ioengine specific parameter

When I tried to specify userspace_reap parameter which is libaio ioengine specific, it caused segfault because thread_data.o.description was unexpectedly set to 1.

The problem is in a way of setting ioengine specific parameter which doesn't correctly set the value at corresponding offset in thread_data.eo, but it unexpectedly sets the value in the same offset in thread_data.o instead.

This fixes it by providing a correct pointer when setting the ioengine specific parameters.

---
 options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
options.c +1 -1
index 4b91f52..f26ff77 100644
@@ -3603,7 +3603,7 @@ int fio_cmd_option_parse(struct thread_data *td, const char *opt, char *val)
 int fio_cmd_ioengine_option_parse(struct thread_data *td, const char *opt,
 				char *val)
 {
-	return parse_cmd_option(opt, val, td->io_ops->options, td);
+	return parse_cmd_option(opt, val, td->io_ops->options, td->eo);
 }
 
 void fio_fill_default_options(struct thread_data *td)
Signature · 1 line
1.8.3.1