Skip to contentSkip to conversation

drm/nouveau: Do not show an error if the TMDS table pointer is invalid

PATCH In review Albert Pool 2 participants 2 messages Oct 9, 2013 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau: Do not show an error if the TMDS table pointer is invalid

Optimus cards with no outputs trigger this message (NVD7, for example) This commit changes the warning into an informational message. The return value of the function is not used, so I left it at -EINVAL.

---
 drivers/gpu/drm/nouveau/nouveau_bios.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_bios.c +2 -1
index 3e72876..7681b01 100644
@@ -936,7 +936,8 @@ static int parse_bit_tmds_tbl_entry(struct drm_device *dev, struct nvbios *bios,
 
 	tmdstableptr = ROM16(bios->data[bitentry->offset]);
 	if (!tmdstableptr) {
-		NV_ERROR(drm, "Pointer to TMDS table invalid\n");
+		/* Happens on NVD7 and other Optimus cards with no outputs */
+		NV_INFO(drm, "TMDS table not found\n");
 		return -EINVAL;
 	}
 
Signature · 1 line
1.7.10.4

A message that is not in the archive (sent off-list or not yet received): 1381347626-3472-1-git-send-email-albertpool-2BgBnwcziRhmR6Xm/[email protected]

#2 lore raw
Quoted 15 lines · Albert Pool

Optimus cards with no outputs trigger this message (NVD7, for example) This commit changes the warning into an informational message. The return value of the function is not used, so I left it at -EINVAL.

---
 drivers/gpu/drm/nouveau/nouveau_bios.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_bios.c +0 -0
index 3e72876..7681b01 100644

drivers/gpu/drm/nouveau/nouveau_bios.c static int parse_bit_tmds_tbl_entry(struct drm_device *dev, struct nvbios *bios, · line 940

Quoted 6 lines
drivers/gpu/drm/nouveau/nouveau_bios.c +2 -1
@@ -936,7 +936,8 @@ static int parse_bit_tmds_tbl_entry(struct drm_device *dev, struct nvbios *bios,
 
        tmdstableptr = ROM16(bios->data[bitentry->offset]);
        if (!tmdstableptr) {
-               NV_ERROR(drm, "Pointer to TMDS table invalid\n");
+               /* Happens on NVD7 and other Optimus cards with no outputs */
+               NV_INFO(drm, "TMDS table not found\n");

Hmm, ideally this code wouldn't exist anymore, but we're not there yet. So, I'll take the patch. But, I suspect NV_DEBUG() will be better here, anyone looking will likely thing "not found" means an error anyway.

Thanks,
Ben.

Quoted 10 lines
drivers/gpu/drm/nouveau/nouveau_bios.c +0 -1
                return -EINVAL;
        }
 
--

1.7.10.4

_______________________________________________
Nouveau mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau