Skip to contentSkip to conversation

Makefile.am: add mkdir testsuite

PATCH In review Saul Wold 2 participants 2 messages Oct 10, 2013 Kbuild

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 Makefile.am: add mkdir testsuite

If we are note building in the existing source tree and have disabled dependency-tracking then the testsuite directory is not created during the configure phase and will not exist when the cp of ROOTFS_PRISTINE occurs, thus causing an error and fail.

---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile.am +1 -1
index 91a766a..4ff42ae 100644
@@ -130,7 +130,7 @@ endif
 
 ROOTFS = testsuite/rootfs
 ROOTFS_PRISTINE = $(top_srcdir)/testsuite/rootfs-pristine
-CREATE_ROOTFS = $(AM_V_GEN) ( $(RM) -rf $(ROOTFS) && \
+CREATE_ROOTFS = $(AM_V_GEN) ( $(RM) -rf $(ROOTFS) && mkdir -p $(dir $(ROOTFS)) && \
 				cp -r $(ROOTFS_PRISTINE) $(ROOTFS) && \
 				touch testsuite/stamp-rootfs && \
 				find $(ROOTFS) -type d -exec chmod +w {} \; )
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 15 lines · Saul Wold

If we are note building in the existing source tree and have disabled dependency-tracking then the testsuite directory is not created during the configure phase and will not exist when the cp of ROOTFS_PRISTINE occurs, thus causing an error and fail.

---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile.am +0 -0
index 91a766a..4ff42ae 100644

Makefile.am endif · line 136

Quoted 8 lines
Makefile.am +1 -1
@@ -130,7 +130,7 @@ endif
 
 ROOTFS = testsuite/rootfs
 ROOTFS_PRISTINE = $(top_srcdir)/testsuite/rootfs-pristine
-CREATE_ROOTFS = $(AM_V_GEN) ( $(RM) -rf $(ROOTFS) && \
+CREATE_ROOTFS = $(AM_V_GEN) ( $(RM) -rf $(ROOTFS) && mkdir -p $(dir $(ROOTFS)) && \
                                cp -r $(ROOTFS_PRISTINE) $(ROOTFS) && \
                                touch testsuite/stamp-rootfs && \
                                find $(ROOTFS) -type d -exec chmod +w {} \; )

Patch has been applied

Thanks
Lucas De Marchi