Btrfs: don't leak ioctl args in btrfs_ioctl_dev_replace
PATCH 1/1 Btrfs: don't leak ioctl args in btrfs_ioctl_dev_replace
struct btrfs_ioctl_dev_replace_args memory is leaked if replace is requested on a read-only filesystem. Fix it.
Signed-off-by Ilya Dryomov <[email protected]>
--- fs/btrfs/ioctl.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
fs/btrfs/ioctl.c +5 -4
@@ -3679,9 +3679,10 @@ static long btrfs_ioctl_dev_replace(struct btrfs_root *root, void __user *arg)switch (p->cmd) {case BTRFS_IOCTL_DEV_REPLACE_CMD_START : -if (root->fs_info->sb->s_flags &MS_RDONLY ) -return -EROFS ; - +if (root->fs_info->sb->s_flags &MS_RDONLY ) { + ret = -EROFS ; + goto out; + }if (atomic_xchg ( &root->fs_info->mutually_exclusive_operation_running,1 )) {
@@ -3707,7 +3708,7 @@ static long btrfs_ioctl_dev_replace(struct btrfs_root *root, void __user *arg)if (copy_to_user (arg, p,sizeof (*p))) ret = -EFAULT ; - +out:kfree (p);return ret; }
Signature · 1 line
1.7.10.4