Bluetooth: Remote return value from hci_send_frame() function
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/1 Bluetooth: Remote return value from hci_send_frame() function
The return value of hci_send_frame() is never checked. So just make this function void and print an error when the hdev->send driver callback returns a negative value.
Having the error printed is actually an improvement over the current situation where any driver error just gets ignored.
Signed-off-by Marcel Holtmann <[email protected]>
--- net/bluetooth/hci_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
net/bluetooth/hci_core.c +3 -2
@@ -2697,7 +2697,7 @@ int hci_unregister_cb(struct hci_cb *cb) }EXPORT_SYMBOL (hci_unregister_cb); -static int hci_send_frame (struct hci_dev *hdev,struct sk_buff *skb) +static void hci_send_frame (struct hci_dev *hdev,struct sk_buff *skb) {BT_DBG ("%s type %d len %d" , hdev->name,bt_cb (skb)->pkt_type, skb->len);
@@ -2717,7 +2717,8 @@ static int hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb) skb->dev = (void *) hdev; -return hdev->send (skb); +if (hdev->send (skb) <0 ) +BT_ERR ("%s sending frame failed" , hdev->name); }void hci_req_init (struct hci_request *req,struct hci_dev *hdev)
Signature · 1 line
1.8.3.1
Johan Hedberg
AppliedHi Marcel,
Quoted 11 lines · Marcel Holtmann
The return value of
hci_send_frame()is never checked. So just make this function void and print an error when thehdev->senddriver callback returns a negative value.Having the error printed is actually an improvement over the current situation where any driver error just gets ignored.
Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/hci_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Applied to bluetooth-next. Thanks.
Johan