Skip to contentSkip to conversation

Bluetooth: Remove pointless parameter check in bluecard_hci_send_frame()

PATCH In review Marcel Holtmann 1 participant 1 message Oct 11, 2013 Bluetooth drivers

lore
Share & tools
lore

Marcel Holtmann

author maintainer
#0 lore raw

PATCH 2/8 Bluetooth: Remove pointless parameter check in bluecard_hci_send_frame()

The hdev parameter of bluecard_hci_send_frame() is always valid. If it were not valid, then it would have crashed earlier in the call chain.

---
 drivers/bluetooth/bluecard_cs.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/bluetooth/bluecard_cs.c +1 -8
index 9194a1b..57427de 100644
@@ -660,14 +660,7 @@ static int bluecard_hci_close(struct hci_dev *hdev)
 
 static int bluecard_hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
 {
-	bluecard_info_t *info;
-
-	if (!hdev) {
-		BT_ERR("Frame for unknown HCI device (hdev=NULL)");
-		return -ENODEV;
-	}
-
-	info = hci_get_drvdata(hdev);
+	bluecard_info_t *info = hci_get_drvdata(hdev);
 
 	switch (bt_cb(skb)->pkt_type) {
 	case HCI_COMMAND_PKT:
Signature · 1 line
1.8.3.1