Skip to contentSkip to conversation

Bluetooth: Remove pointless parameter check in vhci_send_frame()

PATCH In review Marcel Holtmann 1 participant 1 message Oct 11, 2013 Bluetooth drivers

lore
Share & tools
lore

Marcel Holtmann

author maintainer
#0 lore raw

PATCH 8/8 Bluetooth: Remove pointless parameter check in vhci_send_frame()

The hdev parameter of vhci_send_frame() is always valid. If it were not valid, then it would have crashed earlier in the call chain.

---
 drivers/bluetooth/hci_vhci.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/bluetooth/hci_vhci.c +1 -8
index e6f5919..7b16738 100644
@@ -83,18 +83,11 @@ static int vhci_flush(struct hci_dev *hdev)
 
 static int vhci_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
 {
-	struct vhci_data *data;
-
-	if (!hdev) {
-		BT_ERR("Frame for unknown HCI device (hdev=NULL)");
-		return -ENODEV;
-	}
+	struct vhci_data *data = hci_get_drvdata(hdev);
 
 	if (!test_bit(HCI_RUNNING, &hdev->flags))
 		return -EBUSY;
 
-	data = hci_get_drvdata(hdev);
-
 	memcpy(skb_push(skb, 1), &bt_cb(skb)->pkt_type, 1);
 	skb_queue_tail(&data->readq, skb);
 
Signature · 1 line
1.8.3.1