mount.cifs: fix bad free() of string returned by dirname()
Subsystems (2)
PATCH 1/1 mount.cifs: fix bad free() of string returned by dirname()
Coverity says:
Error: CPPCHECK_WARNING: [#def10]
cifs-utils-6.2/mount.cifs.c:1518: error[memleakOnRealloc]: Common realloc mistake: 'mtabdir' nulled but not freed upon failure
del_mtab has a number of bugs in handling of allocated memory:
a) the return value of strdup() is not checked
b) It calls realloc() on a pointer that wasn't returned by an allocation function (e.g. malloc, calloc, etc.)
c) If realloc() fails, it doesn't call free() on the original memory returned by strdup()
Fix all of these bugs and add newlines to the end of the error messages in del_mtab.
--- mount.cifs.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-)
mount.cifs.c +16 -10
@@ -1508,23 +1508,29 @@ add_mtab_exit:static int del_mtab (char *mountpoint) { -int tmprc, rc =0 ; +int len, tmprc, rc =0 ;FILE *mnttmp, *mntmtab;struct mntent *mountent;char *mtabfile, *mtabdir, *mtabtmpfile; mtabfile =strdup (MOUNTED ); - mtabdir =dirname (mtabfile); - mtabdir =realloc (mtabdir,strlen (mtabdir) +strlen (MNT_TMP_FILE ) +2 ); -if (!mtabdir) { -fprintf (stderr,"del_mtab: cannot determine current mtab path" ); +if (!mtabfile) { +fprintf (stderr,"del_mtab: cannot strdup MOUNTED\n" ); rc =EX_FILEIO ; goto del_mtab_exit; } - mtabtmpfile =strcat (mtabdir,MNT_TMP_FILE ); + mtabdir =dirname (mtabfile); + len =strlen (mtabdir) +strlen (MNT_TMP_FILE ); + mtabtmpfile =malloc (len +1 );if (!mtabtmpfile) { -fprintf (stderr,"del_mtab: cannot allocate memory to tmp file" ); +fprintf (stderr,"del_mtab: cannot allocate memory to tmp file\n" ); + rc =EX_FILEIO ; + goto del_mtab_exit; + } + +if (sprintf (mtabtmpfile,"%s%s" , mtabdir,MNT_TMP_FILE ) != len) { +fprintf (stderr,"del_mtab: error writing new string\n" ); rc =EX_FILEIO ; goto del_mtab_exit; }
@@ -1532,14 +1538,14 @@ del_mtab(char *mountpoint)atexit (unlock_mtab); rc =lock_mtab ();if (rc) { -fprintf (stderr,"del_mtab: cannot lock mtab" ); +fprintf (stderr,"del_mtab: cannot lock mtab\n" ); rc =EX_FILEIO ; goto del_mtab_exit; } mtabtmpfile =mktemp (mtabtmpfile);if (!mtabtmpfile) { -fprintf (stderr,"del_mtab: cannot setup tmp file destination" ); +fprintf (stderr,"del_mtab: cannot setup tmp file destination\n" ); rc =EX_FILEIO ; goto del_mtab_exit; }
@@ -1587,7 +1593,7 @@ del_mtab(char *mountpoint) del_mtab_exit:unlock_mtab (); -free (mtabdir); +free (mtabfile);return rc; del_mtab_error:
Signature · 1 line
1.8.3.1
A message that is not in the archive (sent off-list or not yet received): 1381501673-7286-1-git-send-email-jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org
PATCH v2 1/1 mount.cifs: fix bad free() of string returned by dirname()
v2:
- explicitly free mtabtmpfile memory
Coverity says:
Error: CPPCHECK_WARNING: [#def10]
cifs-utils-6.2/mount.cifs.c:1518: error[memleakOnRealloc]: Common realloc mistake: 'mtabdir' nulled but not freed upon failure
del_mtab has a number of bugs in handling of allocated memory:
a) the return value of strdup() is not checked
b) It calls realloc() on a pointer that wasn't returned by an allocation function (e.g. malloc, calloc, etc.)
c) If realloc() fails, it doesn't call free() on the original memory returned by strdup()
Fix all of these bugs and add newlines to the end of the error messages in del_mtab.
--- mount.cifs.c | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-)
mount.cifs.c +18 -11
@@ -1508,23 +1508,29 @@ add_mtab_exit:static int del_mtab (char *mountpoint) { -int tmprc, rc =0 ; +int len, tmprc, rc =0 ;FILE *mnttmp, *mntmtab;struct mntent *mountent; -char *mtabfile, *mtabdir, *mtabtmpfile; +char *mtabfile, *mtabdir, *mtabtmpfile =NULL ; mtabfile =strdup (MOUNTED ); - mtabdir =dirname (mtabfile); - mtabdir =realloc (mtabdir,strlen (mtabdir) +strlen (MNT_TMP_FILE ) +2 ); -if (!mtabdir) { -fprintf (stderr,"del_mtab: cannot determine current mtab path" ); +if (!mtabfile) { +fprintf (stderr,"del_mtab: cannot strdup MOUNTED\n" ); rc =EX_FILEIO ; goto del_mtab_exit; } - mtabtmpfile =strcat (mtabdir,MNT_TMP_FILE ); + mtabdir =dirname (mtabfile); + len =strlen (mtabdir) +strlen (MNT_TMP_FILE ); + mtabtmpfile =malloc (len +1 );if (!mtabtmpfile) { -fprintf (stderr,"del_mtab: cannot allocate memory to tmp file" ); +fprintf (stderr,"del_mtab: cannot allocate memory to tmp file\n" ); + rc =EX_FILEIO ; + goto del_mtab_exit; + } + +if (sprintf (mtabtmpfile,"%s%s" , mtabdir,MNT_TMP_FILE ) != len) { +fprintf (stderr,"del_mtab: error writing new string\n" ); rc =EX_FILEIO ; goto del_mtab_exit; }
@@ -1532,14 +1538,14 @@ del_mtab(char *mountpoint)atexit (unlock_mtab); rc =lock_mtab ();if (rc) { -fprintf (stderr,"del_mtab: cannot lock mtab" ); +fprintf (stderr,"del_mtab: cannot lock mtab\n" ); rc =EX_FILEIO ; goto del_mtab_exit; } mtabtmpfile =mktemp (mtabtmpfile);if (!mtabtmpfile) { -fprintf (stderr,"del_mtab: cannot setup tmp file destination" ); +fprintf (stderr,"del_mtab: cannot setup tmp file destination\n" ); rc =EX_FILEIO ; goto del_mtab_exit; }
@@ -1587,7 +1593,8 @@ del_mtab(char *mountpoint) del_mtab_exit:unlock_mtab (); -free (mtabdir); +free (mtabtmpfile); +free (mtabfile);return rc; del_mtab_error:
Signature · 1 line
1.8.3.1