Skip to contentSkip to conversation

drivers/base/core.c: always output device renaming messages.

PATCH New Greg KH 4 participants 9 messages Oct 11, 2013 – Oct 13, 2013 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author
#1 lore raw
Quoted 5 lines · ethan.zhao

From: "ethan.zhao" <[email protected]>

While loading ixgbevf driver,every vf detected will be output as the same name 'eth4':

Quoted 9 lines

ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver - version 2.8.7
Copyright (c) 2009-2012 Intel Corporation.
ixgbevf 0000:20:10.0: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 0
ixgbevf 0000:20:10.0: irq 199 for MSI/MSI-X
ixgbevf 0000:20:10.0: irq 200 for MSI/MSI-X
ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1

What is that message? That's not good, "eth%d"?

Quoted 18 lines

ixgbevf: eth4: ixgbevf_probe: Intel(R) X540 Virtual Function aa:bb:cc:dd:ee:f1
ixgbevf: eth4: ixgbevf_probe: LRO is disabled
ixgbevf: eth4: ixgbevf_probe: GRO is enabled
ixgbevf: eth4: ixgbevf_probe: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver
ixgbevf 0000:20:10.2: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 1
ixgbevf 0000:20:10.2: irq 201 for MSI/MSI-X
ixgbevf 0000:20:10.2: irq 202 for MSI/MSI-X
ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1
ixgbevf: eth4: ixgbevf_probe: Intel(R) X540 Virtual Function aa:bb:cc:dd:ee:f2
ixgbevf: eth4: ixgbevf_probe: LRO is disabled
ixgbevf: eth4: ixgbevf_probe: GRO is enabled
ixgbevf: eth4: ixgbevf_probe: Intel(R) 10 Gigabit PCI Express Virtual

Quoted 5 lines

But if we view the NICs with ifconfig, found no NIC named 'eth4', the cause is udev has renamed the 'eth4' to 'eth10', 'eth10' one by one. because no renaming messages output, that is confusing.
So we need always output renaming messages in device_name() instead of pr_debug(). After applied this patch, it is much clearer:

How is journald tracking this today, without this extra message sent to the kernel log? It knows what devices are renamed to what somehow.

I really don't want to clutter up the syslog for things that aren't needed, and as userspace was the one that told the kernel to rename the device, why does the kernel have to spit it back out again to userspace? That seems redundant, don't you think?

Quoted 9 lines

ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver - version 2.8.7
Copyright (c) 2009-2012 Intel Corporation.
ixgbevf 0000:20:10.0: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 0
ixgbevf 0000:20:10.0: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1
ixgbevf: eth4: ixgbevf_probe: Intel(R) X540 Virtual Function
net eth4: 'eth4' renaming to 'eth8'

A bit redundant, "eth4" shows up twice.

Quoted 27 lines

aa:bb:cc:dd:ee:11
ixgbevf: eth8: ixgbevf_probe: LRO is disabled
ixgbevf: eth8: ixgbevf_probe: GRO is enabled
ixgbevf: eth8: ixgbevf_probe: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver
ixgbevf 0000:20:10.2: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 1
ixgbevf 0000:20:10.2: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1
ixgbevf: eth4: ixgbevf_probe: Intel(R) X540 Virtual Function
net eth4: 'eth4' renaming to 'eth9'
aa:bb:cc:dd:ee:12
ixgbevf: eth9: ixgbevf_probe: LRO is disabled
ixgbevf: eth9: ixgbevf_probe: GRO is enabled
ixgbevf: eth9: ixgbevf_probe: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver

---
 drivers/base/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/base/core.c +0 -0
index 2d1c6ba..9a98794 100644

drivers/base/core.c int device_rename(struct device *dev, const char *new_name) · line 1907

Quoted 6 lines
drivers/base/core.c +1 -2
@@ -1904,8 +1904,7 @@ int device_rename(struct device *dev, const char *new_name)
 	if (!dev)
 		return -EINVAL;
 
-	pr_debug("device: '%s': %s: renaming to '%s'\n", dev_name(dev),
-		 __func__, new_name);
+	dev_info(dev, "'%s' renaming to '%s'\n", dev_name(dev), new_name);

How about:

	dev_dbg(dev, "renaming to '%s'\n", new_name);

should be all that is needed, right? Good call on pointing out that we don't need to use pr_debug() here, don't know why I never noticed that...

That way, if you really want to know this information, you can dynamically turn on that line to be printed out, no need to clutter up everyone else's logs.

Care to redo this?

thanks,

greg k-h

#2 lore raw

[+cc Don, e1000-devel]

Quoted 16 lines · Greg KH
Quoted 5 lines · ethan.zhao

From: "ethan.zhao" <[email protected]>

While loading ixgbevf driver,every vf detected will be output as the same name 'eth4':

Quoted 9 lines

ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver - version 2.8.7
Copyright (c) 2009-2012 Intel Corporation.
ixgbevf 0000:20:10.0: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 0
ixgbevf 0000:20:10.0: irq 199 for MSI/MSI-X
ixgbevf 0000:20:10.0: irq 200 for MSI/MSI-X
ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1

Quoted 1 line

What is that message? That's not good, "eth%d"?

Just a reminder that ixgbevf 2.8.7 is not the driver version that's in the kernel tree, so it's easy to spend time on mainline issue that have been fixed in the out-of-tree versions, or vice versa.

Per Don, the latest ixgbevf driver is here:
https://sourceforge.net/projects/e1000/files/ixgbevf%20stable/

Bjorn

author
#3 lore raw
Quoted 19 lines · Bjorn Helgaas

[+cc Don, e1000-devel]

Quoted 16 lines · Greg KH
Quoted 14 lines · ethan.zhao

From: "ethan.zhao" <[email protected]>

While loading ixgbevf driver,every vf detected will be output as the same name 'eth4':

ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver - version 2.8.7
Copyright (c) 2009-2012 Intel Corporation.
ixgbevf 0000:20:10.0: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 0
ixgbevf 0000:20:10.0: irq 199 for MSI/MSI-X
ixgbevf 0000:20:10.0: irq 200 for MSI/MSI-X
ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1

Quoted 8 lines
Quoted 1 line

What is that message? That's not good, "eth%d"?

Just a reminder that ixgbevf 2.8.7 is not the driver version that's in the kernel tree, so it's easy to spend time on mainline issue that have been fixed in the out-of-tree versions, or vice versa.

Per Don, the latest ixgbevf driver is here:
https://sourceforge.net/projects/e1000/files/ixgbevf%20stable/

I hate to ask why isn't this merged upstream, but given that this is an Intel network driver, I know the answer :(

Thanks for pointing this out, saved me a trip through the kernel tree...

greg k-h

Quoted 2 lines

Bjorn

A message that is not in the archive (sent off-list or not yet received): F6FB0E698C9B3143BDF729DF222866466FD67CA7@ORSMSX110.amr.corp.intel.com

#5 lore raw
Quoted 38 lines · Donald C
Quoted 38 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Friday, October 11, 2013 9:12 AM
To: Bjorn Helgaas
Cc: ethan.zhao; [email protected]; Skidmore, Donald C; e1000- [email protected]
Subject: Re: [PATCH] drivers/base/core.c: always output device renaming messages.

Quoted 3 lines · Bjorn Helgaas

[+cc Don, e1000-devel]

On Fri, Oct 11, 2013 at 9:35 AM, Greg KH <[email protected]>

Quoted 23 lines · wrote:
Quoted 15 lines · ethan.zhao
Quoted 5 lines

From: "ethan.zhao" <[email protected]>

While loading ixgbevf driver,every vf detected will be output as the same name 'eth4':

Quoted 8 lines

ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Network
Driver - version 2.8.7 Copyright (c) 2009-2012 Intel Corporation.
ixgbevf 0000:20:10.0: enabling device (0000 -> 0002) ixgbe
0000:20:00.0 eth0: VF Reset msg received from vf 0 ixgbevf 0000:20:10.0: irq 199 for MSI/MSI-X ixgbevf 0000:20:10.0: irq 200 for MSI/MSI-X
ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: Multiqueue
Disabled: Rx Queue count = 1, Tx Queue count = 1

Quoted 1 line

What is that message? That's not good, "eth%d"?

Just a reminder that ixgbevf 2.8.7 is not the driver version that's in the kernel tree, so it's easy to spend time on mainline issue that have been fixed in the out-of-tree versions, or vice versa.

Per Don, the latest ixgbevf driver is here:
https://sourceforge.net/projects/e1000/files/ixgbevf%20stable/

Quoted 7 lines
Quoted 5 lines

I hate to ask why isn't this merged upstream, but given that this is an Intel network driver, I know the answer :(

Thanks for pointing this out, saved me a trip through the kernel tree...

That message sure does look strange "eth%d"? From reading your email I'm implying that it came from a 2.8.7 out or tree driver, is that correct? The reason I'm asking is I want to make sure this is not an issue in the kernel tree or the latest out of tree driver.

Yes, it came from ixgbevf 2.8.7

Quoted 7 lines

Also for what it is worth I do have all the patches queued in Jeff K. tree that gets the kernel tree and latest out of tree driver functionally in sync. Once they pass our internal validation he should be pushing them upstream.

Thanks for pointing out the error,
-Don Skidmore <[email protected]>

#6 lore raw

PATCH 1/1 ixgbevf: Fix the debugging output when device is not registered

A message can be output with an unidentified eth%d port when the ixgbevf device is not registered.

ie: ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: etc...

Fix this by using the generic netdev_name() helper to emit "(unregistered net_device)" instead of "eth%d".

Neaten the format string that emits this too.

---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +5 -5
index 59a62bb..1b48a55 100644
@@ -2010,10 +2010,10 @@ static int ixgbevf_init_interrupt_scheme(struct ixgbevf_adapter *adapter)
 		goto err_alloc_queues;
 	}
 
-	hw_dbg(&adapter->hw, "Multiqueue %s: Rx Queue count = %u, "
-	       "Tx Queue count = %u\n",
-	       (adapter->num_rx_queues > 1) ? "Enabled" :
-	       "Disabled", adapter->num_rx_queues, adapter->num_tx_queues);
+	hw_dbg(&adapter->hw,
+	       "Multiqueue %s: Rx Queue count = %u, Tx Queue count = %u\n",
+	       (adapter->num_rx_queues > 1) ? "Enabled" : "Disabled",
+	       adapter->num_rx_queues, adapter->num_tx_queues);
 
 	set_bit(__IXGBEVF_DOWN, &adapter->state);
 
@@ -3645,7 +3645,7 @@ static void __exit ixgbevf_exit_module(void)
 char *ixgbevf_get_hw_dev_name(struct ixgbe_hw *hw)
 {
 	struct ixgbevf_adapter *adapter = hw->back;
-	return adapter->netdev->name;
+	return netdev_name(adapter->netdev);
 }
 
 #endif
#7 lore raw
In reply to Bjorn Helgaas
Quoted 19 lines · Bjorn Helgaas

[+cc Don, e1000-devel]

Quoted 16 lines · Greg KH
Quoted 14 lines · ethan.zhao

From: "ethan.zhao" <[email protected]>

While loading ixgbevf driver,every vf detected will be output as the same name 'eth4':

ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver - version 2.8.7
Copyright (c) 2009-2012 Intel Corporation.
ixgbevf 0000:20:10.0: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 0
ixgbevf 0000:20:10.0: irq 199 for MSI/MSI-X
ixgbevf 0000:20:10.0: irq 200 for MSI/MSI-X
ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1

Quoted 6 lines
Quoted 1 line

What is that message? That's not good, "eth%d"?

Just a reminder that ixgbevf 2.8.7 is not the driver version that's in the kernel tree, so it's easy to spend time on mainline issue that have been fixed in the out-of-tree versions, or vice versa.

Thanks, Yes, the driver version of ixgbevf in mainline is far later from the ones
in sourceforge.
the "eth%d" issue maybe was fixed in recent 2.11.3 .

Quoted 4 lines

Per Don, the latest ixgbevf driver is here:
https://sourceforge.net/projects/e1000/files/ixgbevf%20stable/

Bjorn

#8 lore raw
In reply to Greg KH
Quoted 16 lines · Greg KH
Quoted 5 lines · ethan.zhao

From: "ethan.zhao" <[email protected]>

While loading ixgbevf driver,every vf detected will be output as the same name 'eth4':

Quoted 9 lines

ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver - version 2.8.7
Copyright (c) 2009-2012 Intel Corporation.
ixgbevf 0000:20:10.0: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 0
ixgbevf 0000:20:10.0: irq 199 for MSI/MSI-X
ixgbevf 0000:20:10.0: irq 200 for MSI/MSI-X
ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1

Quoted 2 lines

What is that message? That's not good, "eth%d"?

This message came from ixgbevf version 2.8.7, not from kernel 3.11.4, output netdev name before registration.

Quoted 24 lines
Quoted 18 lines

ixgbevf: eth4: ixgbevf_probe: Intel(R) X540 Virtual Function aa:bb:cc:dd:ee:f1
ixgbevf: eth4: ixgbevf_probe: LRO is disabled
ixgbevf: eth4: ixgbevf_probe: GRO is enabled
ixgbevf: eth4: ixgbevf_probe: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver
ixgbevf 0000:20:10.2: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 1
ixgbevf 0000:20:10.2: irq 201 for MSI/MSI-X
ixgbevf 0000:20:10.2: irq 202 for MSI/MSI-X
ixgbevf: eth%d: ixgbevf_init_interrupt_scheme: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1
ixgbevf: eth4: ixgbevf_probe: Intel(R) X540 Virtual Function aa:bb:cc:dd:ee:f2
ixgbevf: eth4: ixgbevf_probe: LRO is disabled
ixgbevf: eth4: ixgbevf_probe: GRO is enabled
ixgbevf: eth4: ixgbevf_probe: Intel(R) 10 Gigabit PCI Express Virtual

Quoted 5 lines

But if we view the NICs with ifconfig, found no NIC named 'eth4', the cause is udev has renamed the 'eth4' to 'eth10', 'eth10' one by one. because no renaming messages output, that is confusing.
So we need always output renaming messages in device_name() instead of pr_debug(). After applied this patch, it is much clearer:

Quoted 7 lines

How is journald tracking this today, without this extra message sent to the kernel log? It knows what devices are renamed to what somehow.

I really don't want to clutter up the syslog for things that aren't needed, and as userspace was the one that told the kernel to rename the device, why does the kernel have to spit it back out again to userspace? That seems redundant, don't you think?

Yes, agree somehow , perfect system should run without any noise and rubbish in log.
But if something wrong happened, no message shown will make us helpless. As an user space daemon, udev, also has the reason to refuse any message output(
you have udev tracking tools).

'redundant', yes, sometime waste and not perfect, but sometime the backup help us more.

Quoted 11 lines
Quoted 10 lines

ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver - version 2.8.7
Copyright (c) 2009-2012 Intel Corporation.
ixgbevf 0000:20:10.0: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 0
ixgbevf 0000:20:10.0: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1
ixgbevf: eth4: ixgbevf_probe: Intel(R) X540 Virtual Function
net eth4: 'eth4' renaming to 'eth8'

Quoted 1 line

A bit redundant, "eth4" shows up twice.

You hate 'redundant' , got it.

Quoted 31 lines
Quoted 31 lines

aa:bb:cc:dd:ee:11
ixgbevf: eth8: ixgbevf_probe: LRO is disabled
ixgbevf: eth8: ixgbevf_probe: GRO is enabled
ixgbevf: eth8: ixgbevf_probe: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver
ixgbevf 0000:20:10.2: enabling device (0000 -> 0002)
ixgbe 0000:20:00.0 eth0: VF Reset msg received from vf 1
ixgbevf 0000:20:10.2: Multiqueue Disabled: Rx Queue count = 1, Tx Queue count = 1
ixgbevf: eth4: ixgbevf_probe: Intel(R) X540 Virtual Function
net eth4: 'eth4' renaming to 'eth9'
aa:bb:cc:dd:ee:12
ixgbevf: eth9: ixgbevf_probe: LRO is disabled
ixgbevf: eth9: ixgbevf_probe: GRO is enabled
ixgbevf: eth9: ixgbevf_probe: Intel(R) 10 Gigabit PCI Express Virtual Function Network Driver

---
 drivers/base/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/base/core.c +0 -0
index 2d1c6ba..9a98794 100644
@@ -1904,8 +1904,7 @@ int device_rename(struct device *dev, const char *new_name)
      if (!dev)
              return -EINVAL;
 
Quoted 6 lines

drivers/base/core.c int device_rename(struct device *dev, const char *new_name) · line 1907

Quoted 3 lines
drivers/base/core.c +1 -2
-     pr_debug("device: '%s': %s: renaming to '%s'\n", dev_name(dev),
-              __func__, new_name);
+     dev_info(dev, "'%s' renaming to '%s'\n", dev_name(dev), new_name);

How about:

        dev_dbg(dev, "renaming to '%s'\n", new_name);

If something confusing or wrong, need to take a look.
For pr_debug(), We have to build and load a debug kernel… For dev_dbg(), We have to rebuild a kernel with CONFIG_DYNAMIC_DEBUG set to 'y', that is default 'n'.
So, do you mean

dev_printk(KERN_DEBUG, dev, "renaming to '%s'\n", new_name); ?

Quoted 14 lines

should be all that is needed, right? Good call on pointing out that we don't need to use pr_debug() here, don't know why I never noticed that...

That way, if you really want to know this information, you can dynamically turn on that line to be printed out, no need to clutter up everyone else's logs.

Care to redo this?

thanks,

greg k-h

author
#9 lore raw
Quoted 13 lines · Ethan Zhao
Quoted 6 lines
Quoted 6 lines
drivers/base/core.c +0 -0
@@ -1904,8 +1904,7 @@ int device_rename(struct device *dev, const char *new_name)
      if (!dev)
              return -EINVAL;
 
Quoted 6 lines

drivers/base/core.c int device_rename(struct device *dev, const char *new_name) · line 1907

Quoted 3 lines
drivers/base/core.c +1 -2
-     pr_debug("device: '%s': %s: renaming to '%s'\n", dev_name(dev),
-              __func__, new_name);
+     dev_info(dev, "'%s' renaming to '%s'\n", dev_name(dev), new_name);

How about:

        dev_dbg(dev, "renaming to '%s'\n", new_name);
Quoted 4 lines

If something confusing or wrong, need to take a look.
For pr_debug(), We have to build and load a debug kernel… For dev_dbg(), We have to rebuild a kernel with CONFIG_DYNAMIC_DEBUG set to 'y', that is default 'n'.

Why would you not enable that option these days? All distros enable it, and if you should too :)

Quoted 3 lines

So, do you mean

dev_printk(KERN_DEBUG, dev, "renaming to '%s'\n", new_name); ?

No, dev_dbg();.

thanks,

greg k-h

#10 lore raw
Quoted 14 lines · Greg KH
Quoted 13 lines · Ethan Zhao
Quoted 12 lines

drivers/base/core.c int device_rename(struct device *dev, const char *new_name) · line 1907

Quoted 9 lines
drivers/base/core.c +1 -2
@@ -1904,8 +1904,7 @@ int device_rename(struct device *dev, const char *new_name)
      if (!dev)
              return -EINVAL;
 
-     pr_debug("device: '%s': %s: renaming to '%s'\n", dev_name(dev),
-              __func__, new_name);
+     dev_info(dev, "'%s' renaming to '%s'\n", dev_name(dev), new_name);

How about:

        dev_dbg(dev, "renaming to '%s'\n", new_name);
Quoted 8 lines
Quoted 4 lines

If something confusing or wrong, need to take a look.
For pr_debug(), We have to build and load a debug kernel… For dev_dbg(), We have to rebuild a kernel with CONFIG_DYNAMIC_DEBUG set to 'y', that is default 'n'.

Why would you not enable that option these days? All distros enable it, and if you should too :)

Okey, let them enable it in the Linux distribution.

Thanks,
Ethan

Quoted 9 lines
Quoted 3 lines

So, do you mean

dev_printk(KERN_DEBUG, dev, "renaming to '%s'\n", new_name); ?

No, dev_dbg();.

thanks,

greg k-h