uboot: support -r option for mkenvimage
PATCH v2 1/1 uboot: support -r option for mkenvimage
From: Simon Dawson <[email protected]>
Some boards are configured in u-boot to store multiple redundant copies of the environment image in flash. For these boards, it is required to pass the -r flag, when generating a boot environment image using mkenvimage.
---
v2: Change configuration menu text and help text, in response to feedback
from Arnout Vandecappelle and Thomas Petazzoni
boot/uboot/Config.in | 8 ++++++++ boot/uboot/uboot.mk | 1 + 2 files changed, 9 insertions(+)
boot/uboot/Config.in +8 -0
@@ -242,6 +242,14 @@ config BR2_TARGET_UBOOT_ENVIMAGE_SIZE Size of envronment, can be prefixed with 0x for hexadecimal values. +config BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT + bool "Environment has two copies" + help + There are two copies of the environment in flash. + + Check your u-boot configuration for the CONFIG_ENV_ADDR_REDUND and + CONFIG_ENV_SIZE_REDUND settings. + endif # BR2_TARGET_UBOOT_ENVIMAGE endif # BR2_TARGET_UBOOT
boot/uboot/uboot.mk +1 -0
@@ -117,6 +117,7 @@ define UBOOT_INSTALL_IMAGES_CMDS cp -dpf $(@D)/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/) $(if $(BR2_TARGET_UBOOT_ENVIMAGE), $(HOST_DIR)/usr/bin/mkenvimage -s $(BR2_TARGET_UBOOT_ENVIMAGE_SIZE) \ + $(if $(BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT),-r) \ -o $(BINARIES_DIR)/uboot-env.bin $(BR2_TARGET_UBOOT_ENVIMAGE_SOURCE)) endef
Signature · 1 line
1.8.1.2
PATCH v2 1/1 uboot: support -r option for mkenvimage
Simon,
Quoted 20 lines · spdawson at gmail.com
From: Simon Dawson <[email protected]>
Some boards are configured in u-boot to store multiple redundant copies of the environment image in flash. For these boards, it is required to pass the -r flag, when generating a boot environment image using mkenvimage.
Signed-off-by Simon Dawson <[email protected]>---
v2: Change configuration menu text and help text, in response to feedback
from Arnout Vandecappelle and Thomas Petazzoniboot/uboot/Config.in | 8 ++++++++ boot/uboot/uboot.mk | 1 + 2 files changed, 9 insertions(+)boot/uboot/Config.in +0
-0
boot/uboot/Config.in config BR2_TARGET_UBOOT_ENVIMAGE_SIZE · line 251
Quoted 10 lines
boot/uboot/Config.in +7
-0@@ -242,6 +242,14 @@ config BR2_TARGET_UBOOT_ENVIMAGE_SIZE Size of envronment, can be prefixed with 0x for hexadecimal values. +config BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT + bool "Environment has two copies" + help + There are two copies of the environment in flash. + + Check your u-boot configuration for the CONFIG_ENV_ADDR_REDUND and + CONFIG_ENV_SIZE_REDUND settings.
I'm sorry but I'm still unhappy with the help text, especially since your commit log is in fact better :-)
Some platforms define in their U-Boot configuration that the U-Boot environment should be duplicated in two locations (for extra safety). Check your U-Boot configuration for the CONFIG_ENV_ADDR_REDUND and CONFIG_ENV_SIZE_REDUND settings to see if it is the case for your platform.
If it is the case, then you should enable this option to ensure that the U-Boot environment image generated by Buildroot is compatible with this "redundant environment" mechanism of U-Boot.
Or something along those lines (don't hesitate to fix the broken english if needed).
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 uboot: support -r option for mkenvimage
Quoted 9 lines · Thomas Petazzoni
I'm sorry but I'm still unhappy with the help text, especially since your commit log is in fact better :-)
Some platforms define in their U-Boot configuration that the U-Boot environment should be duplicated in two locations (for extra safety). Check your U-Boot configuration for the
CONFIG_ENV_ADDR_REDUNDandCONFIG_ENV_SIZE_REDUNDsettings to see if it is the case for your platform.
Quoted 7 lines
If it is the case, then you should enable this option to ensure that the U-Boot environment image generated by Buildroot is compatible with this "redundant environment" mechanism of U-Boot.
Or something along those lines (don't hesitate to fix the broken english if needed).
Okay, I'll try to improve the help text. Thanks for the feedback Thomas.
Simon.