Optimize jump label implementation on ARM64
Subsystems (2)
v2 cover Optimize jump label implementation on ARM64
From: Jiang Liu <[email protected]>
This patchset tries to optimize arch specfic jump label implementation for ARM64 by dynamic kernel text patching.
To enable this feature, your toolchain must support "asm goto" extension and "%c" constraint extesion. Current GCC for AARCH64 doesn't support "%c", so you need a GCC patch similiar to this:
http://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/arm/arm.c?view=patch&r1=175293&r2=175565&pathrev=175565
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48637
It has been tested on ARM Fast mode, but not on real hardware yet.
Any comments are welcomed!
V1->V2: address review comments of V1
1) refine comments
2) add a new interface to always synchronize with stop_machine() when patching code
3) handle endian issue when patching code
Jiang Liu (7):
arm64: introduce basic aarch64 instruction decoding helpers
arm64: introduce interfaces to hotpatch kernel and module code
arm64: move encode_insn_immediate() from module.c to insn.c
arm64: introduce aarch64_insn_gen_{nop|branch_imm}() helper functions arm64, jump label: detect %c support for ARM64
arm64, jump label: optimize jump label implementation
jump_label: use defined macros instead of hard-coding for better
readability
arch/arm64/Kconfig | 1 + arch/arm64/include/asm/insn.h | 79 ++++++++++ arch/arm64/include/asm/jump_label.h | 52 +++++++ arch/arm64/kernel/Makefile | 3 +- arch/arm64/kernel/insn.c | 290 ++++++++++++++++++++++++++++++++++++ arch/arm64/kernel/jump_label.c | 60 ++++++++ arch/arm64/kernel/module.c | 151 ++++--------------- include/linux/jump_label.h | 15 +- scripts/gcc-goto.sh | 2 +- 9 files changed, 527 insertions(+), 126 deletions(-) create mode 100644 arch/arm64/include/asm/insn.h create mode 100644 arch/arm64/include/asm/jump_label.h create mode 100644 arch/arm64/kernel/insn.c create mode 100644 arch/arm64/kernel/jump_label.c
Signature · 1 line
1.8.1.2
PATCH v2 1/7 arm64: introduce basic aarch64 instruction decoding helpers
From: Jiang Liu <[email protected]>
Introduce basic aarch64 instruction decoding helper aarch64_get_insn_class() and aarch64_insn_hotpatch_safe().
--- arch/arm64/include/asm/insn.h | 53 +++++++++++++++++++++++++++ arch/arm64/kernel/Makefile | 2 +- arch/arm64/kernel/insn.c | 85 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 139 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/include/asm/insn.h create mode 100644 arch/arm64/kernel/insn.c
arch/arm64/include/asm/insn.h new file +53 -0
@@ -0,0 +1,53 @@ +/* +* Copyright (C) 2013 Huawei Ltd. +* Author: Jiang Liu <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program. If not, see <http://www.gnu.org/licenses/>. +*/ +#ifndef _ASM_ARM64_INSN_H +#define _ASM_ARM64_INSN_H +#include <linux/types.h> + +enum aarch64_insn_class { +AARCH64_INSN_CLS_UNKNOWN ,/* UNALLOCATED */ +AARCH64_INSN_CLS_DP_IMM ,/* Data processing - immediate */ +AARCH64_INSN_CLS_DP_REG ,/* Data processing - register */ +AARCH64_INSN_CLS_DP_FPSIMD ,/* Data processing - SIMD and FP */ +AARCH64_INSN_CLS_LDST ,/* Loads and stores */ +AARCH64_INSN_CLS_BR_SYS ,/* Branch, exception generation and +* system instructions */ +}; + +#define __AARCH64_INSN_FUNCS (abbr, mask, val) \ +static __always_inline bool aarch64_insn_is_##abbr(u32 code) \ +{ return (code & (mask)) == (val); } \ +static __always_inline u32 aarch64_insn_get_##abbr##_mask(void) \ +{ return (mask); } \ +static __always_inline u32 aarch64_insn_get_##abbr##_value(void) \ +{ return (val); } + +__AARCH64_INSN_FUNCS(b, 0xFC000000, 0x14000000) +__AARCH64_INSN_FUNCS(bl, 0xFC000000, 0x94000000) +__AARCH64_INSN_FUNCS(svc, 0xFFE0001F, 0xD4000001) +__AARCH64_INSN_FUNCS(hvc, 0xFFE0001F, 0xD4000002) +__AARCH64_INSN_FUNCS(smc, 0xFFE0001F, 0xD4000003) +__AARCH64_INSN_FUNCS(brk, 0xFFE0001F, 0xD4200000) +__AARCH64_INSN_FUNCS(nop, 0xFFFFFFFF, 0xD503201F) + +#undef __AARCH64_INSN_FUNCS + +enum aarch64_insn_class aarch64_get_insn_class (u32 insn); + +bool aarch64_insn_hotpatch_safe (u32 old_insn,u32 new_insn); + +#endif /* _ASM_ARM64_INSN_H */
arch/arm64/kernel/Makefile +1 -1
@@ -9,7 +9,7 @@ AFLAGS_head.o := -DTEXT_OFFSET=$(TEXT_OFFSET) arm64-obj-y := cputable.o debug-monitors.o entry.o irq.o fpsimd.o \ entry-fpsimd.o process.o ptrace.o setup.o signal.o \ sys.o stacktrace.o time.o traps.o io.o vdso.o \ - hyp-stub.o psci.o + hyp-stub.o psci.o insn.o arm64-obj-$(CONFIG_COMPAT) += sys32.o kuser32.o signal32.o \ sys_compat.o
arch/arm64/kernel/insn.c new file +85 -0
85 lines not on this page · raw message
Signature · 1 line
1.8.1.2
PATCH v2 2/7 arm64: introduce interfaces to hotpatch kernel and module code
In reply to Jiang LiuFrom: Jiang Liu <[email protected]>
Introduce three interfaces to patch kernel and module code:aarch64_insn_patch_text_nosync():
patch code without synchronization, it's caller's responsibility to synchronize all CPUs if needed.aarch64_insn_patch_text_sync():
patch code and always synchronize with stop_machine()aarch64_insn_patch_text():
patch code and synchronize with stop_machine() if needed
--- arch/arm64/include/asm/insn.h | 7 ++- arch/arm64/kernel/insn.c | 101 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 107 insertions(+), 1 deletion(-)
arch/arm64/include/asm/insn.h +6 -1
@@ -47,7 +47,12 @@ __AARCH64_INSN_FUNCS(nop, 0xFFFFFFFF, 0xD503201F)#undef __AARCH64_INSN_FUNCSenum aarch64_insn_class aarch64_get_insn_class (u32 insn); - +u32 aarch64_insn_read (void *addr); +void aarch64_insn_write (void *addr,u32 insn);bool aarch64_insn_hotpatch_safe (u32 old_insn,u32 new_insn); +int aarch64_insn_patch_text_nosync (void *addrs[],u32 insns[],int cnt); +int aarch64_insn_patch_text_sync (void *addrs[],u32 insns[],int cnt); +int aarch64_insn_patch_text (void *addrs[],u32 insns[],int cnt); +#endif /* _ASM_ARM64_INSN_H */
arch/arm64/kernel/insn.c +101 -0
110 lines not on this page · raw message
Signature · 1 line
1.8.1.2
PATCH v2 3/7 arm64: move encode_insn_immediate() from module.c to insn.c
In reply to Jiang LiuFrom: Jiang Liu <[email protected]>
Function encode_insn_immediate() will be used by other instruction manipulate related functions, so move it into insn.c and rename it as aarch64_insn_encode_immediate().
--- arch/arm64/include/asm/insn.h | 14 ++++ arch/arm64/kernel/insn.c | 77 +++++++++++++++++++++ arch/arm64/kernel/module.c | 151 +++++++++--------------------------------- 3 files changed, 123 insertions(+), 119 deletions(-)
arch/arm64/include/asm/insn.h +14 -0
@@ -28,6 +28,18 @@ enum aarch64_insn_class {* system instructions */ }; +enum aarch64_insn_imm_type { +AARCH64_INSN_IMM_MOVNZ , +AARCH64_INSN_IMM_MOVK , +AARCH64_INSN_IMM_ADR , +AARCH64_INSN_IMM_26 , +AARCH64_INSN_IMM_19 , +AARCH64_INSN_IMM_16 , +AARCH64_INSN_IMM_14 , +AARCH64_INSN_IMM_12 , +AARCH64_INSN_IMM_9 , +}; +#define __AARCH64_INSN_FUNCS (abbr, mask, val) \ static __always_inline bool aarch64_insn_is_##abbr(u32 code) \ { return (code & (mask)) == (val); } \
@@ -47,6 +59,8 @@ __AARCH64_INSN_FUNCS(nop, 0xFFFFFFFF, 0xD503201F)#undef __AARCH64_INSN_FUNCSenum aarch64_insn_class aarch64_get_insn_class (u32 insn); +u32 aarch64_insn_encode_immediate (enum aarch64_insn_imm_type type, +u32 insn,u64 imm);u32 aarch64_insn_read (void *addr);void aarch64_insn_write (void *addr,u32 insn);bool aarch64_insn_hotpatch_safe (u32 old_insn,u32 new_insn);
arch/arm64/kernel/insn.c +77 -0
80 lines not on this page · raw message
arch/arm64/kernel/module.c +32 -119
289 lines not on this page · raw message
Signature · 1 line
1.8.1.2
PATCH v2 4/7 arm64: introduce aarch64_insn_gen_{nop|branch_imm}() helper functions
In reply to Jiang LiuFrom: Jiang Liu <[email protected]>
Introduce aarch64_insn_gen_{nop|branch_imm}() helper functions, which will be used to implement jump label on ARM64.
--- arch/arm64/include/asm/insn.h | 7 +++++++ arch/arm64/kernel/insn.c | 27 +++++++++++++++++++++++++++ 2 files changed, 34 insertions(+)
arch/arm64/include/asm/insn.h +7 -0
@@ -61,6 +61,13 @@ __AARCH64_INSN_FUNCS(nop, 0xFFFFFFFF, 0xD503201F)enum aarch64_insn_class aarch64_get_insn_class (u32 insn);u32 aarch64_insn_encode_immediate (enum aarch64_insn_imm_type type,u32 insn,u64 imm); +u32 aarch64_insn_gen_branch_imm (unsigned long pc,unsigned long addr, +bool link); +static __always_inline u32 aarch64_insn_gen_nop(void) +{ +return aarch64_insn_get_nop_value (); +} +u32 aarch64_insn_read (void *addr);void aarch64_insn_write (void *addr,u32 insn);bool aarch64_insn_hotpatch_safe (u32 old_insn,u32 new_insn);
arch/arm64/kernel/insn.c +27 -0
@@ -14,6 +14,7 @@* You should have received a copy of the GNU General Public License * along with this program. If not, see <http://www.gnu.org/licenses/>. */ +#include <linux/bitops.h> #include <linux/kernel.h> #include <linux/stop_machine.h> #include <asm/cacheflush.h>
@@ -261,3 +262,29 @@ u32 aarch64_insn_encode_immediate(enum aarch64_insn_imm_type type,return insn; } + +u32 aarch64_insn_gen_branch_imm (unsigned long pc,unsigned long addr,bool link) +{ +u32 insn; +long offset; + +/* +* PC: A 64-bit Program Counter holding the address of the current +* instruction. A64 instructions may be word-aligned. +*/ +BUG_ON ((pc &0x3 ) || (addr &0x3 )); + +/* B/BR support [-128M, 128M) offset */ + offset = ((long )addr - (long )pc) >>2 ; +if (offset >=BIT (25 ) ||abs (offset) >BIT (25 )) { +WARN_ON_ONCE (1 ); +return 0 ; + } + +if (link) + insn =aarch64_insn_get_bl_value (); +else + insn =aarch64_insn_get_b_value (); + +return aarch64_insn_encode_immediate (AARCH64_INSN_IMM_26 , insn, offset); +}
Signature · 1 line
1.8.1.2
PATCH 1/1 arm64: introduce aarch64_insn_gen_{nop|branch_imm}() helper functions
From: Jiang Liu <[email protected]>
Introduce aarch64_insn_gen_{nop|branch_imm}() helper functions, which will be used to implement jump label on ARM64.
---
Fix a bug in comparing signed and unsigned value, it should be
if (abs(offset) > BIT(25) || offset == BIT(25)) {
instead of
if (offset >= BIT(25) || abs(offset) > BIT(25)) {--- arch/arm64/include/asm/insn.h | 7 +++++++ arch/arm64/kernel/insn.c | 27 +++++++++++++++++++++++++++ 2 files changed, 34 insertions(+)
arch/arm64/include/asm/insn.h +7 -0
@@ -61,6 +61,13 @@ __AARCH64_INSN_FUNCS(nop, 0xFFFFFFFF, 0xD503201F)enum aarch64_insn_class aarch64_get_insn_class (u32 insn);u32 aarch64_insn_encode_immediate (enum aarch64_insn_imm_type type,u32 insn,u64 imm); +u32 aarch64_insn_gen_branch_imm (unsigned long pc,unsigned long addr, +bool link); +static __always_inline u32 aarch64_insn_gen_nop(void) +{ +return aarch64_insn_get_nop_value (); +} +u32 aarch64_insn_read (void *addr);void aarch64_insn_write (void *addr,u32 insn);bool aarch64_insn_hotpatch_safe (u32 old_insn,u32 new_insn);
arch/arm64/kernel/insn.c +27 -0
@@ -14,6 +14,7 @@* You should have received a copy of the GNU General Public License * along with this program. If not, see <http://www.gnu.org/licenses/>. */ +#include <linux/bitops.h> #include <linux/kernel.h> #include <linux/stop_machine.h> #include <asm/cacheflush.h>
@@ -261,3 +262,29 @@ u32 aarch64_insn_encode_immediate(enum aarch64_insn_imm_type type,return insn; } + +u32 aarch64_insn_gen_branch_imm (unsigned long pc,unsigned long addr,bool link) +{ +u32 insn; +long offset; + +/* +* PC: A 64-bit Program Counter holding the address of the current +* instruction. A64 instructions may be word-aligned. +*/ +BUG_ON ((pc &0x3 ) || (addr &0x3 )); + +/* B/BR support [-128M, 128M) offset */ + offset = ((long )addr - (long )pc) >>2 ; +if (abs (offset) >BIT (25 ) || offset ==BIT (25 )) { +WARN_ON_ONCE (1 ); +return 0 ; + } + +if (link) + insn =aarch64_insn_get_bl_value (); +else + insn =aarch64_insn_get_b_value (); + +return aarch64_insn_encode_immediate (AARCH64_INSN_IMM_26 , insn, offset); +}
Signature · 1 line
1.8.1.2
PATCH v2 5/7 arm64, jump label: detect %c support for ARM64
In reply to Jiang LiuFrom: Jiang Liu <[email protected]>
As commit a9468f30b5eac6 "ARM: 7333/2: jump label: detect %c support for ARM", this patch detects the same thing for ARM64 because some ARM64 GCC versions have the same issue.
Some versions of ARM64 GCC which do support asm goto, do not support the %c specifier. Since we need the %c to support jump labels on ARM64, detect that too in the asm goto detection script to avoid build errors with these versions.
--- scripts/gcc-goto.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/gcc-goto.sh +1 -1
@@ -5,7 +5,7 @@ cat << "END" | $@ -x c - -c -o /dev/null >/dev/null 2>&1 && echo "y" int main(void) { -#ifdef __arm__ +#if defined(__arm__) || defined(__aarch64__) /* * Not related to asm goto, but used by jump label * and broken on some ARM GCC versions (see GCC Bug 48637).
Signature · 1 line
1.8.1.2
PATCH v2 6/7 arm64, jump label: optimize jump label implementation
In reply to Jiang LiuFrom: Jiang Liu <[email protected]>
Optimize jump label implementation for ARM64 by dynamically patching kernel text.
--- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/jump_label.h | 52 ++++++++++++++++++++++++++++++++ arch/arm64/kernel/Makefile | 1 + arch/arm64/kernel/jump_label.c | 60 +++++++++++++++++++++++++++++++++++++ 4 files changed, 114 insertions(+) create mode 100644 arch/arm64/include/asm/jump_label.h create mode 100644 arch/arm64/kernel/jump_label.c
arch/arm64/Kconfig +1 -0
@@ -17,6 +17,7 @@ config ARM64 select GENERIC_SMP_IDLE_THREAD select GENERIC_TIME_VSYSCALL select HARDIRQS_SW_RESEND + select HAVE_ARCH_JUMP_LABEL select HAVE_ARCH_TRACEHOOK select HAVE_DEBUG_BUGVERBOSE select HAVE_DEBUG_KMEMLEAK
arch/arm64/include/asm/jump_label.h new file +52 -0
52 lines not on this page · raw message
arch/arm64/kernel/Makefile +1 -0
@@ -18,6 +18,7 @@ arm64-obj-$(CONFIG_SMP) += smp.o smp_spin_table.o smp_psci.o arm64-obj-$(CONFIG_HW_PERF_EVENTS) += perf_event.o arm64-obj-$(CONFIG_HAVE_HW_BREAKPOINT)+= hw_breakpoint.o arm64-obj-$(CONFIG_EARLY_PRINTK) += early_printk.o +arm64-obj-$(CONFIG_JUMP_LABEL) += jump_label.o obj-y += $(arm64-obj-y) vdso/ obj-m += $(arm64-obj-m)
arch/arm64/kernel/jump_label.c new file +60 -0
60 lines not on this page · raw message
Signature · 1 line
1.8.1.2
PATCH v2 7/7 jump_label: use defined macros instead of hard-coding for better readability
In reply to Jiang LiuFrom: Jiang Liu <[email protected]>
Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better readability.
--- include/linux/jump_label.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
include/linux/jump_label.h +10 -5
@@ -74,18 +74,21 @@ struct module;#include <linux/atomic.h> #ifdef HAVE_JUMP_LABEL -#define JUMP_LABEL_TRUE_BRANCH 1UL +#define JUMP_LABEL_TYPE_FALSE_BRANCH 0UL +#define JUMP_LABEL_TYPE_TRUE_BRANCH 1UL +#define JUMP_LABEL_TYPE_MASK 1ULstatic inline struct jump_entry *jump_label_get_entries (struct static_key *key) {return (struct jump_entry *)((unsigned long )key->entries - & ~JUMP_LABEL_TRUE_BRANCH ); + & ~JUMP_LABEL_TYPE_MASK ); }static inline bool jump_label_get_branch_default (struct static_key *key) { -if ((unsigned long )key->entries &JUMP_LABEL_TRUE_BRANCH ) +if (((unsigned long )key->entries &JUMP_LABEL_TYPE_MASK ) == +JUMP_LABEL_TYPE_TRUE_BRANCH )return true;return false; }
@@ -116,9 +119,11 @@ extern void static_key_slow_dec(struct static_key *key);extern void jump_label_apply_nops (struct module *mod);#define STATIC_KEY_INIT_TRUE ((struct static_key) \ - { .enabled = ATOMIC_INIT(1), .entries = (void *)1 }) + { .enabled = ATOMIC_INIT(1), \ + .entries = (void *)JUMP_LABEL_TYPE_TRUE_BRANCH })#define STATIC_KEY_INIT_FALSE ((struct static_key) \ - { .enabled = ATOMIC_INIT(0), .entries = (void *)0 }) + { .enabled = ATOMIC_INIT(0), \ + .entries = (void *)JUMP_LABEL_TYPE_FALSE_BRANCH })#else /* !HAVE_JUMP_LABEL */
Signature · 1 line
1.8.1.2
Quoted 10 lines · Jiang Liu
From: Jiang Liu <[email protected]>
This patchset tries to optimize arch specfic jump label implementation for ARM64 by dynamic kernel text patching.
To enable this feature, your toolchain must support "asm goto" extension and "%c" constraint extesion. Current GCC for AARCH64 doesn't support "%c", so you need a GCC patch similiar to this:
http://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/arm/arm.c?view=patch&r1=175293&r2=175565&pathrev=175565
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48637
Right, but this is just for the ARM (AArch32) backend afaict. Are there any plans for upstream GCC to support this constraint for AArch64?
Will
Quoted 12 lines · Will Deacon
Quoted 10 lines · Jiang Liu
From: Jiang Liu <[email protected]>
This patchset tries to optimize arch specfic jump label implementation for ARM64 by dynamic kernel text patching.
To enable this feature, your toolchain must support "asm goto" extension and "%c" constraint extesion. Current GCC for AARCH64 doesn't support "%c", so you need a GCC patch similiar to this:
http://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/arm/arm.c?view=patch&r1=175293&r2=175565&pathrev=175565
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48637
Quoted 5 lines
Right, but this is just for the ARM (AArch32) backend afaict. Are there any plans for upstream GCC to support this constraint for AArch64?
Will
Hi Will,
We have an internal GCC version with this issue fixed. But I'm not
familiar with GCC community and don't know the way to get the fix merged into GCC mainstream. Any suggestion?
Thanks!
Quoted 3 lines · Jiang Liu
To enable this feature, your toolchain must support "asm goto" extension and "%c" constraint extesion. Current GCC for AARCH64 doesn't support "%c", so you need a GCC patch similiar to this:
Oh god, not that again. I've no idea why ARM stuff has such a problem with supporting this very useful "%c" GCC constraint. Aarch32 didn't for ages consequently we now have horrid hacks around it in the kernel source because our compilers suck. Seems Aarch64 is doomed to repeat the same stupid mistakes. :(
Quoted 11 lines · Russell King - ARM Linux
Quoted 3 lines · Jiang Liu
To enable this feature, your toolchain must support "asm goto" extension and "%c" constraint extesion. Current GCC for AARCH64 doesn't support "%c", so you need a GCC patch similiar to this:
Oh god, not that again. I've no idea why ARM stuff has such a problem with supporting this very useful "%c" GCC constraint. Aarch32 didn't for ages consequently we now have horrid hacks around it in the kernel source because our compilers suck. Seems Aarch64 is doomed to repeat the same stupid mistakes. :(
We need to do the same trick for ARM64 too:)
Quoted 6 lines · Jiang Liu
Quoted 5 lines · Russell King - ARM Linux
Quoted 3 lines · Jiang Liu
To enable this feature, your toolchain must support "asm goto" extension and "%c" constraint extesion. Current GCC for AARCH64 doesn't support "%c", so you need a GCC patch similiar to this:
Quoted 7 lines
Quoted 6 lines
Oh god, not that again. I've no idea why ARM stuff has such a problem with supporting this very useful "%c" GCC constraint. Aarch32 didn't for ages consequently we now have horrid hacks around it in the kernel source because our compilers suck. Seems Aarch64 is doomed to repeat the same stupid mistakes. :(
We need to do the same trick for ARM64 too:)
Just been locating it - it's part of the gcc internals documentation:
| In the simplest case, a `%' followed by a digit N says to output | operand N at that point in the string. | | `%' followed by a letter and a digit says to output an operand in an | alternate fashion. Four letters have standard, built-in meanings | described below. The machine description macro `PRINT_OPERAND' can | define additional letters with nonstandard meanings. | | `%cDIGIT' can be used to substitute an operand that is a constant | value without the syntax that normally indicates an immediate operand. | ... | `%lDIGIT' is used to substitute a `label_ref' into a jump instruction.
%lDIGIT is used (but not commented upon) in the gcc extended asm documentation where it talks about asm gotos, so there's probably a doc bug here too about whether these options should be described in the main doc as well.
Nevertheness, this section is documenting the _internals_ of gcc, and it seems perverse for a gcc backend to ignore something that is documented as being a standard part of gcc.
Quoted 14 lines · Russell King - ARM Linux
Quoted 1 line · Russell King - ARM Linux
| In the simplest case, a `%' followed by a digit N says to output | operand N at that point in the string. | | `%' followed by a letter and a digit says to output an operand in an | alternate fashion. Four letters have standard, built-in meanings | described below. The machine description macro `PRINT_OPERAND' can | define additional letters with nonstandard meanings. | | `%cDIGIT' can be used to substitute an operand that is a constant | value without the syntax that normally indicates an immediate operand. | ... | `%lDIGIT' is used to substitute a `label_ref' into a jump instruction.
Quoted 8 lines
%lDIGIT is used (but not commented upon) in the gcc extended asm documentation where it talks about asm gotos, so there's probably a doc bug here too about whether these options should be described in the main doc as well.
Nevertheness, this section is documenting the _internals_ of gcc, and it seems perverse for a gcc backend to ignore something that is documented as being a standard part of gcc.
I'll make sure this gets fixed.
Will