Skip to contentSkip to conversation

x86, microcode: Correct kconfig dependencies

PATCH New Borislav Petkov 2 participants 2 messages Oct 13, 2013 – Oct 14, 2013 x86

lore
Share & tools
lore

Borislav Petkov

author maintainer
#0 lore raw

PATCH 1/1 x86, microcode: Correct kconfig dependencies

From: Borislav Petkov <[email protected]>

I have a randconfig here which has enabled only

CONFIG_MICROCODE=y
CONFIG_MICROCODE_OLD_INTERFACE=y

with both

# CONFIG_MICROCODE_INTEL is not set
# CONFIG_MICROCODE_AMD is not set

off. Which makes building the microcode functionality a little pointless. Don't do that in such cases then.

---
 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/Kconfig +1 -0
index 8076f1d9e4e7..945492c9b285 100644
@@ -1071,6 +1071,7 @@ config X86_REBOOTFIXUPS
 
 config MICROCODE
 	tristate "CPU microcode loading support"
+	depends on CPU_SUP_AMD || CPU_SUP_INTEL
 	select FW_LOADER
 	---help---
 
Signature · 1 line
1.8.4
#1 lore raw

[tip:x86/urgent] x86/microcode: Correct Kconfig dependencies

x86/microcode: Correct Kconfig dependencies
Commit-ID:  80030e3d8ec6414790a5ec67ae4c5eeee82aba98
Gitweb:     http://git.kernel.org/tip/80030e3d8ec6414790a5ec67ae4c5eeee82aba98
Author:     Borislav Petkov <[email protected]>
AuthorDate: Sun, 13 Oct 2013 18:36:29 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 14 Oct 2013 09:24:27 +0200

x86/microcode: Correct Kconfig dependencies

I have a randconfig here which has enabled only

CONFIG_MICROCODE=y
CONFIG_MICROCODE_OLD_INTERFACE=y

with both

# CONFIG_MICROCODE_INTEL is not set
# CONFIG_MICROCODE_AMD is not set

off. Which makes building the microcode functionality a little pointless. Don't do that in such cases then.

---
 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/Kconfig +1 -0
index 145d703..f67e839 100644
@@ -1033,6 +1033,7 @@ config X86_REBOOTFIXUPS
 
 config MICROCODE
 	tristate "CPU microcode loading support"
+	depends on CPU_SUP_AMD || CPU_SUP_INTEL
 	select FW_LOADER
 	---help---