btrfs: simplify kmalloc+copy_from_user to memdup_user
PATCH 1/1 btrfs: simplify kmalloc+copy_from_user to memdup_user
Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives
The semantic patch that makes this report is available in scripts/coccinelle/api/memdup_user.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by Geyslan G. Bem <[email protected]>
--- fs/btrfs/ioctl.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
fs/btrfs/ioctl.c +3 -8
@@ -2727,15 +2727,10 @@ static long btrfs_ioctl_file_extent_same(struct file *file, size =sizeof (tmp) + tmp.dest_count *sizeof (struct btrfs_ioctl_same_extent_info ); - same =kmalloc (size,GFP_NOFS ); -if (!same) { - ret = -EFAULT ; - goto out; - } + same =memdup_user ((struct btrfs_ioctl_same_args __user *)argp, size); -if (copy_from_user (same, - (struct btrfs_ioctl_same_args __user *)argp, size)) { - ret = -EFAULT ; +if (IS_ERR (same)) { + ret =PTR_ERR (same); goto out; }
Signature · 1 line
1.8.4