Bluetooth: Check that scan window is smaller or equal than scan interval
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/1 Bluetooth: Check that scan window is smaller or equal than scan interval
The scan window parameter for connection establishment and passive scanning needs to be smaller or equal than the scan interval.
Instead of waiting for a controller to reject these values later on, just reject them right away.
Signed-off-by Marcel Holtmann <[email protected]>
--- net/bluetooth/mgmt.c | 4 ++++ 1 file changed, 4 insertions(+)
net/bluetooth/mgmt.c +4 -0
@@ -3423,6 +3423,10 @@ static int set_scan_params(struct sock *sk, struct hci_dev *hdev,return cmd_status (sk, hdev->id,MGMT_OP_SET_SCAN_PARAMS ,MGMT_STATUS_INVALID_PARAMS ); +if (window > interval) +return cmd_status (sk, hdev->id,MGMT_OP_SET_SCAN_PARAMS , +MGMT_STATUS_INVALID_PARAMS ); +hci_dev_lock (hdev); hdev->le_scan_interval = interval;
Signature · 1 line
1.8.3.1
Johan Hedberg
AppliedHi Marcel,
Quoted 10 lines · Marcel Holtmann
The scan window parameter for connection establishment and passive scanning needs to be smaller or equal than the scan interval.
Instead of waiting for a controller to reject these values later on, just reject them right away.
Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/mgmt.c | 4 ++++ 1 file changed, 4 insertions(+)
Applied to bluetooth-next. Thanks.
Johan