perf list: Show error if tracepoints not available
PATCH 1/1 perf list: Show error if tracepoints not available
Tracepoints are not visible in "perf list" on Fedora 19 because regular users have no permission to /sys/kernel/debug by default. Show an error message so that the user knows about it instead of assuming that tracepoints are not supported on the system.
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Ingo Molnar <[email protected]>
Signed-off-by Pekka Enberg <[email protected]>
--- tools/perf/util/parse-events.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/util/parse-events.c +3 -1
@@ -998,8 +998,10 @@ void print_tracepoint_events(const char *subsys_glob, const char *event_glob,char evt_path[MAXPATHLEN ];char dir_path[MAXPATHLEN ]; -if (debugfs_valid_mountpoint (tracing_events_path)) +if (debugfs_valid_mountpoint (tracing_events_path)) { +printf (" [ Tracepoints not available: %s ]\n" ,strerror (errno));return ; + } sys_dir =opendir (tracing_events_path);if (!sys_dir)
Signature · 1 line
1.8.3.1
tip-bot for Pekka Enberg
merge botperf list: Show error if tracepoints not available
Commit-ID: f11cfc6f294dbd83b0d58037404df2bd16066238 Gitweb: http://git.kernel.org/tip/f11cfc6f294dbd83b0d58037404df2bd16066238 Author: Pekka Enberg <[email protected]> AuthorDate: Tue, 15 Oct 2013 23:07:27 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 21 Oct 2013 17:33:22 -0300
perf list: Show error if tracepoints not available
Tracepoints are not visible in "perf list" on Fedora 19 because regular users have no permission to /sys/kernel/debug by default. Show an error message so that the user knows about it instead of assuming that tracepoints are not supported on the system.
Signed-off-by Pekka Enberg <[email protected]>
Acked-by Ingo Molnar <[email protected]>
Cc Ingo Molnar <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/parse-events.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/util/parse-events.c +3 -1
@@ -998,8 +998,10 @@ void print_tracepoint_events(const char *subsys_glob, const char *event_glob,char evt_path[MAXPATHLEN ];char dir_path[MAXPATHLEN ]; -if (debugfs_valid_mountpoint (tracing_events_path)) +if (debugfs_valid_mountpoint (tracing_events_path)) { +printf (" [ Tracepoints not available: %s ]\n" ,strerror (errno));return ; + } sys_dir =opendir (tracing_events_path);if (!sys_dir)