of: refactor IRQ parsing and add interrupts-extended implementation
Subsystems (15)
cover of: refactor IRQ parsing and add interrupts-extended implementation
Hi everyone.
This series is mostly a set of cleanup to the interrupt parsing code. Some of it merely clarification, like the renames of of_irq_map_*, some to tighten up the API by using of_phandle_args, and some to prepare for the last patch in the series.
Of all these patches, the last one is probably the only one likely to be controversial. It adds a new way of specifying interrupts. If a device gets wired up to multiple interrupt controllers, the interrupts-extended property allows the device to specify multiple connections without redirecting through an interrupt-map node which can be rather difficult to understand. In a lot of cases, an interrupts-extended property is a whole lot easier to use.
Please take a look and comment. We'll probably discuss the interrupts-extended binding in Edinburgh at the DT workshop in a few weeks.
RFC 1/9 of/irq: Rename of_irq_map_* functions to of_irq_parse_*
The OF irq handling code has been overloading the term 'map' to refer to both parsing the data in the device tree and mapping it to the internal linux irq system. This is probably because the device tree does have the concept of an 'interrupt-map' function for translating interrupt references from one node to another, but 'map' is still confusing when the primary purpose of some of the functions are to parse the DT data.
This patch renames all the of_irq_map_* functions to of_irq_parse_* which makes it clear that there is a difference between the parsing phase and the mapping phase. Kernel code can make use of just the parsing or just the mapping support as needed by the subsystem.
The patch was generated mechanically with a handful of sed commands.
--- arch/arm/mach-integrator/pci_v3.c | 4 ++-- arch/microblaze/pci/pci-common.c | 2 +- arch/mips/pci/fixup-lantiq.c | 2 +- arch/mips/pci/pci-rt3883.c | 2 +- arch/powerpc/kernel/pci-common.c | 2 +- arch/powerpc/platforms/cell/celleb_scc_pciex.c | 2 +- arch/powerpc/platforms/cell/celleb_scc_sio.c | 2 +- arch/powerpc/platforms/cell/spider-pic.c | 2 +- arch/powerpc/platforms/cell/spu_manage.c | 2 +- arch/powerpc/platforms/fsl_uli1575.c | 2 +- arch/powerpc/platforms/powermac/pic.c | 2 +- arch/powerpc/platforms/pseries/event_sources.c | 2 +- arch/powerpc/sysdev/mpic_msi.c | 2 +- arch/x86/kernel/devicetree.c | 2 +- drivers/of/address.c | 4 ++-- drivers/of/irq.c | 28 +++++++++++++------------- drivers/of/of_pci_irq.c | 10 ++++----- drivers/pci/host/pci-mvebu.c | 2 +- include/linux/of_irq.h | 8 ++++---- include/linux/of_pci.h | 2 +- 20 files changed, 42 insertions(+), 42 deletions(-)
arch/arm/mach-integrator/pci_v3.c +2 -2
@@ -840,9 +840,9 @@ static int __init pci_v3_map_irq_dt(const struct pci_dev *dev, u8 slot, u8 pin)struct of_irq oirq;int ret; - ret =of_irq_map_pci (dev, &oirq); + ret =of_irq_parse_pci (dev, &oirq);if (ret) { -dev_err (&dev->dev,"of_irq_map_pci() %d\n" , ret); +dev_err (&dev->dev,"of_irq_parse_pci() %d\n" , ret);/* Proper return code 0 == NO_IRQ */ return 0 ; }
arch/microblaze/pci/pci-common.c +1 -1
@@ -217,7 +217,7 @@ int pci_read_irq_line(struct pci_dev *pci_dev)memset (&oirq,0xff ,sizeof (oirq));#endif /* Try to get a mapping from the device-tree */ -if (of_irq_map_pci (pci_dev, &oirq)) { +if (of_irq_parse_pci (pci_dev, &oirq)) {u8 line, pin;/* If that fails, lets fallback to what is in the config
arch/mips/pci/fixup-lantiq.c +1 -1
@@ -28,7 +28,7 @@ int __init pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)struct of_irq dev_irq;int irq; -if (of_irq_map_pci (dev, &dev_irq)) { +if (of_irq_parse_pci (dev, &dev_irq)) {dev_err (&dev->dev,"trying to map irq for unknown slot:%d pin:%d\n" , slot, pin);return 0 ;
arch/mips/pci/pci-rt3883.c +1 -1
@@ -587,7 +587,7 @@ int __init pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)int err;int irq; - err =of_irq_map_pci (dev, &dev_irq); + err =of_irq_parse_pci (dev, &dev_irq);if (err) {pr_err ("pci %s: unable to get irq map, err=%d\n" ,pci_name ((struct pci_dev *) dev), err);
arch/powerpc/kernel/pci-common.c +1 -1
@@ -237,7 +237,7 @@ static int pci_read_irq_line(struct pci_dev *pci_dev)memset (&oirq,0xff ,sizeof (oirq));#endif /* Try to get a mapping from the device-tree */ -if (of_irq_map_pci (pci_dev, &oirq)) { +if (of_irq_parse_pci (pci_dev, &oirq)) {u8 line, pin;/* If that fails, lets fallback to what is in the config
arch/powerpc/platforms/cell/celleb_scc_pciex.c +1 -1
@@ -507,7 +507,7 @@ static __init int celleb_setup_pciex(struct device_node *node, phb->ops = &scc_pciex_pci_ops;/* internal interrupt handler */ -if (of_irq_map_one (node,1 , &oirq)) { +if (of_irq_parse_one (node,1 , &oirq)) {pr_err ("PCIEXC:Failed to map irq\n" ); goto error; }
arch/powerpc/platforms/cell/celleb_scc_sio.c +1 -1
@@ -53,7 +53,7 @@ static int __init txx9_serial_init(void)if (!(txx9_serial_bitmap & (1 <<i)))continue ; -if (of_irq_map_one (node, i, &irq)) +if (of_irq_parse_one (node, i, &irq))continue ;if (of_address_to_resource (node, txx9_scc_tab[i].index, &res))
arch/powerpc/platforms/cell/spider-pic.c +1 -1
@@ -236,7 +236,7 @@ static unsigned int __init spider_find_cascade_and_node(struct spider_pic *pic)* tree in case the device-tree is ever fixed */ struct of_irq oirq; -if (of_irq_map_one (pic->host->of_node,0 , &oirq) ==0 ) { +if (of_irq_parse_one (pic->host->of_node,0 , &oirq) ==0 ) { virq =irq_create_of_mapping (oirq.controller, oirq.specifier, oirq.size);return virq;
arch/powerpc/platforms/cell/spu_manage.c +1 -1
@@ -182,7 +182,7 @@ static int __init spu_map_interrupts(struct spu *spu, struct device_node *np)int i;for (i=0 ; i <3 ; i++) { - ret =of_irq_map_one (np, i, &oirq); + ret =of_irq_parse_one (np, i, &oirq);if (ret) {pr_debug ("spu_new: failed to get irq %d\n" , i); goto err;
arch/powerpc/platforms/fsl_uli1575.c +1 -1
@@ -333,7 +333,7 @@ static void hpcd_final_uli5288(struct pci_dev *dev) laddr[0 ] = (hose->first_busno <<16 ) | (PCI_DEVFN (31 ,0 ) <<8 ); laddr[1 ] = laddr[2 ] =0 ; -of_irq_map_raw (hosenode, &pin,1 , laddr, &oirq); +of_irq_parse_raw (hosenode, &pin,1 , laddr, &oirq); virq =irq_create_of_mapping (oirq.controller, oirq.specifier, oirq.size); dev->irq = virq;
arch/powerpc/platforms/powermac/pic.c +1 -1
@@ -393,7 +393,7 @@ static void __init pmac_pic_probe_oldstyle(void)#endif } -int of_irq_map_oldworld (struct device_node *device,int index, +int of_irq_parse_oldworld (struct device_node *device,int index,struct of_irq *out_irq) {const u32 *ints =NULL ;
arch/powerpc/platforms/pseries/event_sources.c +1 -1
@@ -55,7 +55,7 @@ void request_event_sources_irqs(struct device_node *np,/* Else use normal interrupt tree parsing */ else {/* First try to do a proper OF tree parsing */ -for (index =0 ;of_irq_map_one (np, index, &oirq) ==0 ; +for (index =0 ;of_irq_parse_one (np, index, &oirq) ==0 ; index++) {if (count >15 )break ;
arch/powerpc/sysdev/mpic_msi.c +1 -1
@@ -63,7 +63,7 @@ static int mpic_msi_reserve_u3_hwirqs(struct mpic *mpic)pr_debug ("mpic: mapping hwirqs for %s\n" , np->full_name); index =0 ; -while (of_irq_map_one (np, index++, &oirq) ==0 ) { +while (of_irq_parse_one (np, index++, &oirq) ==0 ) { ops->xlate (mpic->irqhost,NULL , oirq.specifier, oirq.size, &hwirq, &flags);msi_bitmap_reserve_hwirq (&mpic->msi_bitmap, hwirq);
arch/x86/kernel/devicetree.c +1 -1
@@ -116,7 +116,7 @@ static int x86_of_pci_irq_enable(struct pci_dev *dev)if (!pin)return 0 ; - ret =of_irq_map_pci (dev, &oirq); + ret =of_irq_parse_pci (dev, &oirq);if (ret)return ret;
drivers/of/address.c +2 -2
@@ -532,12 +532,12 @@ static u64 __of_translate_address(struct device_node *dev, pbus->count_cells (dev, &pna, &pns);if (!OF_CHECK_COUNTS (pna, pns)) {printk (KERN_ERR "prom_parse: Bad cell count for %s\n" , - dev->full_name); +of_node_full_name (dev));break ; }pr_debug ("OF: parent bus is %s (na=%d, ns=%d) on %s\n" , - pbus->name, pna, pns, parent->full_name); + pbus->name, pna, pns,of_node_full_name (parent));/* Apply bus translation */ if (of_translate_one (dev, bus, pbus, addr, na, ns, pna, rprop))
drivers/of/irq.c +14 -14
@@ -31,14 +31,14 @@* @dev: Device node of the device whose interrupt is to be mapped * @index: Index of the interrupt to map * -* This function is a wrapper that chains of_irq_map_one() and +* This function is a wrapper that chains of_irq_parse_one() and * irq_create_of_mapping() to make things easier to callers */ unsigned int irq_of_parse_and_map (struct device_node *dev,int index) {struct of_irq oirq; -if (of_irq_map_one (dev, index, &oirq)) +if (of_irq_parse_one (dev, index, &oirq))return 0 ; return irq_create_of_mapping(oirq.controller, oirq.specifier,
@@ -79,7 +79,7 @@ struct device_node *of_irq_find_parent(struct device_node *child) }/** -* of_irq_map_raw - Low level interrupt tree parsing +* of_irq_parse_raw - Low level interrupt tree parsing * @parent: the device interrupt parent * @intspec: interrupt specifier ("interrupts" property of the device) * @ointsize: size of the passed in interrupt specifier
@@ -93,7 +93,7 @@ struct device_node *of_irq_find_parent(struct device_node *child)* properties, for example when resolving PCI interrupts when no device * node exist for the parent. */ -int of_irq_map_raw (struct device_node *parent,const __be32 *intspec, +int of_irq_parse_raw (struct device_node *parent,const __be32 *intspec,u32 ointsize,const __be32 *addr,struct of_irq *out_irq) {struct device_node *ipar, *tnode, *old =NULL , *newpar =NULL ;
@@ -101,7 +101,7 @@ int of_irq_map_raw(struct device_node *parent, const __be32 *intspec,u32 intsize =1 , addrsize, newintsize =0 , newaddrsize =0 ;int imaplen, match, i; -pr_debug ("of_irq_map_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n" , +pr_debug ("of_irq_parse_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n" ,of_node_full_name (parent),be32_to_cpup (intspec),be32_to_cpup (intspec +1 ), ointsize);
@@ -126,7 +126,7 @@ int of_irq_map_raw(struct device_node *parent, const __be32 *intspec, goto fail; } -pr_debug ("of_irq_map_raw: ipar=%s, size=%d\n" ,of_node_full_name (ipar), intsize); +pr_debug ("of_irq_parse_raw: ipar=%s, size=%d\n" ,of_node_full_name (ipar), intsize);if (ointsize != intsize)return -EINVAL ;
@@ -269,29 +269,29 @@ int of_irq_map_raw(struct device_node *parent, const __be32 *intspec,return -EINVAL ; } -EXPORT_SYMBOL_GPL (of_irq_map_raw); +EXPORT_SYMBOL_GPL (of_irq_parse_raw);/** -* of_irq_map_one - Resolve an interrupt for a device +* of_irq_parse_one - Resolve an interrupt for a device * @device: the device whose interrupt is to be resolved * @index: index of the interrupt to resolve * @out_irq: structure of_irq filled by this function * * This function resolves an interrupt, walking the tree, for a given -* device-tree node. It's the high level pendant to of_irq_map_raw(). +* device-tree node. It's the high level pendant to of_irq_parse_raw(). */ -int of_irq_map_one (struct device_node *device,int index,struct of_irq *out_irq) +int of_irq_parse_one (struct device_node *device,int index,struct of_irq *out_irq) {struct device_node *p;const __be32 *intspec, *tmp, *addr;u32 intsize, intlen;int res = -EINVAL ; -pr_debug ("of_irq_map_one: dev=%s, index=%d\n" ,of_node_full_name (device), index); +pr_debug ("of_irq_parse_one: dev=%s, index=%d\n" ,of_node_full_name (device), index);/* OldWorld mac stuff is "special", handle out of line */ if (of_irq_workarounds &OF_IMAP_OLDWORLD_MAC ) -return of_irq_map_oldworld (device, index, out_irq); +return of_irq_parse_oldworld (device, index, out_irq);/* Get the interrupts property */ intspec =of_get_property (device,"interrupts" , &intlen);
@@ -322,13 +322,13 @@ int of_irq_map_one(struct device_node *device, int index, struct of_irq *out_irq goto out;/* Get new specifier and map it */ - res =of_irq_map_raw (p, intspec + index * intsize, intsize, + res =of_irq_parse_raw (p, intspec + index * intsize, intsize, addr, out_irq); out:of_node_put (p);return res; } -EXPORT_SYMBOL_GPL (of_irq_map_one); +EXPORT_SYMBOL_GPL (of_irq_parse_one);/** * of_irq_to_resource - Decode a node's IRQ and return it as a resource
drivers/of/of_pci_irq.c +5 -5
@@ -5,7 +5,7 @@#include <asm/prom.h> /** -* of_irq_map_pci - Resolve the interrupt for a PCI device +* of_irq_parse_pci - Resolve the interrupt for a PCI device * @pdev: the device whose interrupt is to be resolved * @out_irq: structure of_irq filled by this function *
@@ -15,7 +15,7 @@* PCI tree until an device-node is found, at which point it will finish * resolving using the OF tree walking. */ -int of_irq_map_pci (const struct pci_dev *pdev,struct of_irq *out_irq) +int of_irq_parse_pci (const struct pci_dev *pdev,struct of_irq *out_irq) {struct device_node *dn, *ppnode;struct pci_dev *ppdev;
@@ -30,7 +30,7 @@ int of_irq_map_pci(const struct pci_dev *pdev, struct of_irq *out_irq)*/ dn =pci_device_to_OF_node (pdev);if (dn) { - rc =of_irq_map_one (dn,0 , out_irq); + rc =of_irq_parse_one (dn,0 , out_irq);if (!rc)return rc; }
@@ -88,6 +88,6 @@ int of_irq_map_pci(const struct pci_dev *pdev, struct of_irq *out_irq) lspec_be =cpu_to_be32 (lspec); laddr[0 ] =cpu_to_be32 ((pdev->bus->number <<16 ) | (pdev->devfn <<8 )); laddr[1 ] = laddr[2 ] =cpu_to_be32 (0 ); -return of_irq_map_raw (ppnode, &lspec_be,1 , laddr, out_irq); +return of_irq_parse_raw (ppnode, &lspec_be,1 , laddr, out_irq); } -EXPORT_SYMBOL_GPL (of_irq_map_pci); +EXPORT_SYMBOL_GPL (of_irq_parse_pci);
drivers/pci/host/pci-mvebu.c +1 -1
@@ -650,7 +650,7 @@ static int __init mvebu_pcie_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)struct of_irq oirq;int ret; - ret =of_irq_map_pci (dev, &oirq); + ret =of_irq_parse_pci (dev, &oirq);if (ret)return ret;
include/linux/of_irq.h +4 -4
@@ -35,12 +35,12 @@ typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *);#if defined(CONFIG_PPC32 ) && defined(CONFIG_PPC_PMAC )extern unsigned int of_irq_workarounds;extern struct device_node *of_irq_dflt_pic; -extern int of_irq_map_oldworld (struct device_node *device,int index, +extern int of_irq_parse_oldworld (struct device_node *device,int index,struct of_irq *out_irq);#else /* CONFIG_PPC32 && CONFIG_PPC_PMAC */ #define of_irq_workarounds (0)#define of_irq_dflt_pic (NULL) -static inline int of_irq_map_oldworld (struct device_node *device,int index, +static inline int of_irq_parse_oldworld (struct device_node *device,int index,struct of_irq *out_irq) {return -EINVAL ;
@@ -48,10 +48,10 @@ static inline int of_irq_map_oldworld(struct device_node *device, int index,#endif /* CONFIG_PPC32 && CONFIG_PPC_PMAC */ -extern int of_irq_map_raw (struct device_node *parent,const __be32 *intspec, +extern int of_irq_parse_raw (struct device_node *parent,const __be32 *intspec,u32 ointsize,const __be32 *addr,struct of_irq *out_irq); -extern int of_irq_map_one (struct device_node *device,int index, +extern int of_irq_parse_one (struct device_node *device,int index,struct of_irq *out_irq); extern unsigned int irq_create_of_mapping(struct device_node *controller, const u32 *intspec,
include/linux/of_pci.h +1 -1
@@ -6,7 +6,7 @@struct pci_dev ;struct of_irq ; -int of_irq_map_pci (const struct pci_dev *pdev,struct of_irq *out_irq); +int of_irq_parse_pci (const struct pci_dev *pdev,struct of_irq *out_irq);struct device_node ; struct device_node *of_pci_find_child_device(struct device_node *parent,
Signature · 1 line
1.8.1.2
Re: [RFC 1/9] of/irq: Rename of_irq_map_* functions to of_irq_parse_*
Quoted 32 lines · Grant Likely
The OF irq handling code has been overloading the term 'map' to refer to both parsing the data in the device tree and mapping it to the internal linux irq system. This is probably because the device tree does have the concept of an 'interrupt-map' function for translating interrupt references from one node to another, but 'map' is still confusing when the primary purpose of some of the functions are to parse the DT data.
This patch renames all the of_irq_map_* functions to of_irq_parse_* which makes it clear that there is a difference between the parsing phase and the mapping phase. Kernel code can make use of just the parsing or just the mapping support as needed by the subsystem.
The patch was generated mechanically with a handful of sed commands.
Signed-off-by Grant Likely <[email protected]>Cc Michal Simek <[email protected]>Cc Ralf Baechle <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>--- arch/arm/mach-integrator/pci_v3.c | 4 ++-- arch/microblaze/pci/pci-common.c | 2 +- arch/mips/pci/fixup-lantiq.c | 2 +- arch/mips/pci/pci-rt3883.c | 2 +- arch/powerpc/kernel/pci-common.c | 2 +- arch/powerpc/platforms/cell/celleb_scc_pciex.c | 2 +- arch/powerpc/platforms/cell/celleb_scc_sio.c | 2 +- arch/powerpc/platforms/cell/spider-pic.c | 2 +- arch/powerpc/platforms/cell/spu_manage.c | 2 +- arch/powerpc/platforms/fsl_uli1575.c | 2 +- arch/powerpc/platforms/powermac/pic.c | 2 +- arch/powerpc/platforms/pseries/event_sources.c | 2 +- arch/powerpc/sysdev/mpic_msi.c | 2 +-
Quoted 8 lines
arch/x86/kernel/devicetree.c | 2 +- drivers/of/address.c | 4 ++-- drivers/of/irq.c | 28 +++++++++++++------------- drivers/of/of_pci_irq.c | 10 ++++----- drivers/pci/host/pci-mvebu.c | 2 +- include/linux/of_irq.h | 8 ++++---- include/linux/of_pci.h | 2 +- 20 files changed, 42 insertions(+), 42 deletions(-)
I have go through microblaze changes in this series and all are fine.
For Microblaze changes. I expect you have already compiled that without any warning.
Thanks,
Michal
Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
RFC 2/9 of/irq: Replace of_irq with of_phandle_args
In reply to Grant Likelystruct of_irq and struct of_phandle_args are exactly the same structure. This patch makes the kernel use of_phandle_args everywhere. This in itself isn't a big deal, but it makes some follow-on patches simpler.
--- arch/arm/mach-integrator/pci_v3.c | 5 ++--- arch/microblaze/pci/pci-common.c | 9 ++++----- arch/mips/pci/fixup-lantiq.c | 5 ++--- arch/mips/pci/pci-rt3883.c | 6 ++---- arch/powerpc/kernel/pci-common.c | 9 ++++----- arch/powerpc/platforms/cell/celleb_scc_pciex.c | 5 ++--- arch/powerpc/platforms/cell/celleb_scc_sio.c | 5 ++--- arch/powerpc/platforms/cell/spider-pic.c | 6 +++--- arch/powerpc/platforms/cell/spu_manage.c | 12 ++++++------ arch/powerpc/platforms/fsl_uli1575.c | 8 +++----- arch/powerpc/platforms/powermac/pic.c | 8 ++++---- arch/powerpc/platforms/pseries/event_sources.c | 7 +++---- arch/powerpc/sysdev/mpic_msi.c | 6 +++--- arch/x86/kernel/devicetree.c | 5 ++--- drivers/of/irq.c | 15 +++++++-------- drivers/of/of_pci_irq.c | 2 +- drivers/pci/host/pci-mvebu.c | 5 ++--- include/linux/of_irq.h | 24 ++++-------------------- include/linux/of_pci.h | 4 ++-- 19 files changed, 58 insertions(+), 88 deletions(-)
arch/arm/mach-integrator/pci_v3.c +2 -3
@@ -837,7 +837,7 @@ static struct hw_pci pci_v3 __initdata = {static int __init pci_v3_map_irq_dt (const struct pci_dev *dev,u8 slot,u8 pin) { -struct of_irq oirq; +struct of_phandle_args oirq;int ret; ret =of_irq_parse_pci (dev, &oirq);
@@ -847,8 +847,7 @@ static int __init pci_v3_map_irq_dt(const struct pci_dev *dev, u8 slot, u8 pin)return 0 ; } -return irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); +return irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); } static int __init pci_v3_dtprobe(struct platform_device *pdev,
arch/microblaze/pci/pci-common.c +4 -5
@@ -199,7 +199,7 @@ void pcibios_set_master(struct pci_dev *dev)*/ int pci_read_irq_line (struct pci_dev *pci_dev) { -struct of_irq oirq; +struct of_phandle_args oirq;unsigned int virq;/* The current device-tree that iSeries generates from the HV
@@ -243,11 +243,10 @@ int pci_read_irq_line(struct pci_dev *pci_dev)irq_set_irq_type (virq,IRQ_TYPE_LEVEL_LOW ); }else {pr_debug (" Got one, spec %d cells (0x%08x 0x%08x...) on %s\n" , - oirq.size, oirq.specifier[0 ], oirq.specifier[1 ], -of_node_full_name (oirq.controller)); + oirq.args_count, oirq.args[0 ], oirq.args[1 ], +of_node_full_name (oirq.np)); - virq =irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); + virq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); }if (!virq) {pr_debug (" Failed to map !\n" );
arch/mips/pci/fixup-lantiq.c +2 -3
@@ -25,7 +25,7 @@ int pcibios_plat_dev_init(struct pci_dev *dev)int __init pcibios_map_irq (const struct pci_dev *dev,u8 slot,u8 pin) { -struct of_irq dev_irq; +struct of_phandle_args dev_irq;int irq;if (of_irq_parse_pci (dev, &dev_irq)) {
@@ -33,8 +33,7 @@ int __init pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) slot, pin);return 0 ; } - irq =irq_create_of_mapping (dev_irq.controller, dev_irq.specifier, - dev_irq.size); + irq =irq_create_of_mapping (dev_irq.np, dev_irq.args, dev_irq.args_count);dev_info (&dev->dev,"SLOT:%d PIN:%d IRQ:%d\n" , slot, pin, irq);return irq; }
arch/mips/pci/pci-rt3883.c +2 -4
@@ -583,7 +583,7 @@ err_put_intc_node:int __init pcibios_map_irq (const struct pci_dev *dev,u8 slot,u8 pin) { -struct of_irq dev_irq; +struct of_phandle_args dev_irq;int err;int irq;
@@ -594,9 +594,7 @@ int __init pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)return 0 ; } - irq =irq_create_of_mapping (dev_irq.controller, - dev_irq.specifier, - dev_irq.size); + irq =irq_create_of_mapping (dev_irq.np, dev_irq.args, dev_irq.args_count);if (irq ==0 ) pr_crit("pci %s: no irq found for pin %u\n",
arch/powerpc/kernel/pci-common.c +4 -5
@@ -228,7 +228,7 @@ int pcibios_add_platform_entries(struct pci_dev *pdev)*/ static int pci_read_irq_line (struct pci_dev *pci_dev) { -struct of_irq oirq; +struct of_phandle_args oirq;unsigned int virq;pr_debug ("PCI: Try to map irq for %s...\n" ,pci_name (pci_dev));
@@ -263,11 +263,10 @@ static int pci_read_irq_line(struct pci_dev *pci_dev)irq_set_irq_type (virq,IRQ_TYPE_LEVEL_LOW ); }else {pr_debug (" Got one, spec %d cells (0x%08x 0x%08x...) on %s\n" , - oirq.size, oirq.specifier[0 ], oirq.specifier[1 ], -of_node_full_name (oirq.controller)); + oirq.args_count, oirq.args[0 ], oirq.args[1 ], +of_node_full_name (oirq.np)); - virq =irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); + virq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); }if (virq ==NO_IRQ ) {pr_debug (" Failed to map !\n" );
arch/powerpc/platforms/cell/celleb_scc_pciex.c +2 -3
@@ -486,7 +486,7 @@ static __init int celleb_setup_pciex(struct device_node *node, struct pci_controller *phb) {struct resource r; -struct of_irq oirq; +struct of_phandle_args oirq;int virq;/* SMMIO registers; used inside this file */
@@ -511,8 +511,7 @@ static __init int celleb_setup_pciex(struct device_node *node,pr_err ("PCIEXC:Failed to map irq\n" ); goto error; } - virq =irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); + virq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count);if (request_irq (virq, pciex_handle_internal_irq,0 ,"pciex" , (void *)phb)) {pr_err ("PCIEXC:Failed to request irq\n" );
arch/powerpc/platforms/cell/celleb_scc_sio.c +2 -3
@@ -45,7 +45,7 @@ static int __init txx9_serial_init(void)struct device_node *node;int i;struct uart_port req; -struct of_irq irq; +struct of_phandle_args irq;struct resource res;for_each_compatible_node (node,"serial" ,"toshiba,sio-scc" ) {
@@ -66,8 +66,7 @@ static int __init txx9_serial_init(void)#ifdef CONFIG_SERIAL_TXX9_CONSOLE req.membase =ioremap (req.mapbase,0x24 );#endif - req.irq =irq_create_of_mapping (irq.controller, - irq.specifier, irq.size); + req.irq =irq_create_of_mapping (irq.np, irq.args, irq.args_count); req.flags |=UPF_IOREMAP |UPF_BUGGY_UART /*HAVE_CTS_LINE*/ ; req.uartclk =83300000 ;
arch/powerpc/platforms/cell/spider-pic.c +3 -3
@@ -235,10 +235,10 @@ static unsigned int __init spider_find_cascade_and_node(struct spider_pic *pic)/* First, we check whether we have a real "interrupts" in the device * tree in case the device-tree is ever fixed */ -struct of_irq oirq; +struct of_phandle_args oirq;if (of_irq_parse_one (pic->host->of_node,0 , &oirq) ==0 ) { - virq =irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); + virq =irq_create_of_mapping (oirq.np, oirq.args, + oirq.args_count);return virq; }
arch/powerpc/platforms/cell/spu_manage.c +6 -6
@@ -177,7 +177,7 @@ out:static int __init spu_map_interrupts (struct spu *spu,struct device_node *np) { -struct of_irq oirq; +struct of_phandle_args oirq;int ret;int i;
@@ -188,10 +188,10 @@ static int __init spu_map_interrupts(struct spu *spu, struct device_node *np) goto err; } ret = -EINVAL ; -pr_debug (" irq %d no 0x%x on %s\n" , i, oirq.specifier[0 ], - oirq.controller->full_name); - spu->irqs[i] =irq_create_of_mapping (oirq.controller, - oirq.specifier, oirq.size); +pr_debug (" irq %d no 0x%x on %s\n" , i, oirq.args[0 ], + oirq.np->full_name); + spu->irqs[i] =irq_create_of_mapping (oirq.np, + oirq.args, oirq.args_count);if (spu->irqs[i] ==NO_IRQ ) {pr_debug ("spu_new: failed to map it !\n" ); goto err;
@@ -200,7 +200,7 @@ static int __init spu_map_interrupts(struct spu *spu, struct device_node *np)return 0 ; err: -pr_debug ("failed to map irq %x for spu %s\n" , *oirq.specifier, +pr_debug ("failed to map irq %x for spu %s\n" , *oirq.args, spu->name);for (; i >=0 ; i--) {if (spu->irqs[i] !=NO_IRQ )
arch/powerpc/platforms/fsl_uli1575.c +3 -5
@@ -321,8 +321,8 @@ static void hpcd_final_uli5288(struct pci_dev *dev) {struct pci_controller *hose =pci_bus_to_host (dev->bus);struct device_node *hosenode = hose ? hose->dn :NULL ; -struct of_irq oirq; -int virq, pin =2 ; +struct of_phandle_args oirq; +int pin =2 ;u32 laddr[3 ];if (!machine_is (mpc86xx_hpcd))
@@ -334,9 +334,7 @@ static void hpcd_final_uli5288(struct pci_dev *dev) laddr[0 ] = (hose->first_busno <<16 ) | (PCI_DEVFN (31 ,0 ) <<8 ); laddr[1 ] = laddr[2 ] =0 ;of_irq_parse_raw (hosenode, &pin,1 , laddr, &oirq); - virq =irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); - dev->irq = virq; + dev->irq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); }DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_AL ,0x1575 , hpcd_quirk_uli1575);
arch/powerpc/platforms/powermac/pic.c +4 -4
@@ -394,7 +394,7 @@ static void __init pmac_pic_probe_oldstyle(void) }int of_irq_parse_oldworld (struct device_node *device,int index, -struct of_irq *out_irq) +struct of_phandle_args *out_irq) {const u32 *ints =NULL ;int intlen;
@@ -422,9 +422,9 @@ int of_irq_parse_oldworld(struct device_node *device, int index,if (index >= intlen)return -EINVAL ; - out_irq->controller =NULL ; - out_irq->specifier[0 ] = ints[index]; - out_irq->size =1 ; + out_irq->np =NULL ; + out_irq->args[0 ] = ints[index]; + out_irq->args_count =1 ;return 0 ; }
arch/powerpc/platforms/pseries/event_sources.c +3 -4
@@ -25,7 +25,7 @@ void request_event_sources_irqs(struct device_node *np, const char *name) {int i, index, count =0 ; -struct of_irq oirq; +struct of_phandle_args oirq;const u32 *opicprop;unsigned int opicplen;unsigned int virqs[16 ];
@@ -59,9 +59,8 @@ void request_event_sources_irqs(struct device_node *np, index++) {if (count >15 )break ; - virqs[count] =irq_create_of_mapping (oirq.controller, - oirq.specifier, - oirq.size); + virqs[count] =irq_create_of_mapping (oirq.np, oirq.args, + oirq.args_count);if (virqs[count] ==NO_IRQ ) { pr_err("event-sources: Unable to allocate " "interrupt number for %s\n",
arch/powerpc/sysdev/mpic_msi.c +3 -3
@@ -35,7 +35,7 @@ static int mpic_msi_reserve_u3_hwirqs(struct mpic *mpic)const struct irq_domain_ops *ops = mpic->irqhost->ops;struct device_node *np;int flags, index, i; -struct of_irq oirq; +struct of_phandle_args oirq;pr_debug ("mpic: found U3, guessing msi allocator setup\n" );
@@ -64,8 +64,8 @@ static int mpic_msi_reserve_u3_hwirqs(struct mpic *mpic) index =0 ;while (of_irq_parse_one (np, index++, &oirq) ==0 ) { - ops->xlate (mpic->irqhost,NULL , oirq.specifier, - oirq.size, &hwirq, &flags); + ops->xlate (mpic->irqhost,NULL , oirq.args, + oirq.args_count, &hwirq, &flags);msi_bitmap_reserve_hwirq (&mpic->msi_bitmap, hwirq); } }
arch/x86/kernel/devicetree.c +2 -3
@@ -105,7 +105,7 @@ struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)static int x86_of_pci_irq_enable (struct pci_dev *dev) { -struct of_irq oirq; +struct of_phandle_args oirq;u32 virq;int ret;u8 pin;
@@ -120,8 +120,7 @@ static int x86_of_pci_irq_enable(struct pci_dev *dev)if (ret)return ret; - virq =irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); + virq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count);if (virq ==0 )return -EINVAL ; dev->irq = virq;
drivers/of/irq.c +7 -8
@@ -36,13 +36,12 @@*/ unsigned int irq_of_parse_and_map (struct device_node *dev,int index) { -struct of_irq oirq; +struct of_phandle_args oirq;if (of_irq_parse_one (dev, index, &oirq))return 0 ; -return irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); +return irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); }EXPORT_SYMBOL_GPL (irq_of_parse_and_map);
@@ -94,7 +93,7 @@ struct device_node *of_irq_find_parent(struct device_node *child)* node exist for the parent. */ int of_irq_parse_raw (struct device_node *parent,const __be32 *intspec, -u32 ointsize,const __be32 *addr,struct of_irq *out_irq) +u32 ointsize,const __be32 *addr,struct of_phandle_args *out_irq) {struct device_node *ipar, *tnode, *old =NULL , *newpar =NULL ;const __be32 *tmp, *imap, *imask;
@@ -156,10 +155,10 @@ int of_irq_parse_raw(struct device_node *parent, const __be32 *intspec, NULL) {pr_debug (" -> got it !\n" );for (i =0 ; i < intsize; i++) - out_irq->specifier[i] = + out_irq->args[i] =of_read_number (intspec +i,1 ); - out_irq->size = intsize; - out_irq->controller = ipar; + out_irq->args_count = intsize; + out_irq->np = ipar;of_node_put (old);return 0 ; }
@@ -280,7 +279,7 @@ EXPORT_SYMBOL_GPL(of_irq_parse_raw);* This function resolves an interrupt, walking the tree, for a given * device-tree node. It's the high level pendant to of_irq_parse_raw(). */ -int of_irq_parse_one (struct device_node *device,int index,struct of_irq *out_irq) +int of_irq_parse_one (struct device_node *device,int index,struct of_phandle_args *out_irq) {struct device_node *p;const __be32 *intspec, *tmp, *addr;
drivers/of/of_pci_irq.c +1 -1
@@ -15,7 +15,7 @@* PCI tree until an device-node is found, at which point it will finish * resolving using the OF tree walking. */ -int of_irq_parse_pci (const struct pci_dev *pdev,struct of_irq *out_irq) +int of_irq_parse_pci (const struct pci_dev *pdev,struct of_phandle_args *out_irq) {struct device_node *dn, *ppnode;struct pci_dev *ppdev;
drivers/pci/host/pci-mvebu.c +2 -3
@@ -647,15 +647,14 @@ static int __init mvebu_pcie_setup(int nr, struct pci_sys_data *sys)static int __init mvebu_pcie_map_irq (const struct pci_dev *dev,u8 slot,u8 pin) { -struct of_irq oirq; +struct of_phandle_args oirq;int ret; ret =of_irq_parse_pci (dev, &oirq);if (ret)return ret; -return irq_create_of_mapping (oirq.controller, oirq.specifier, - oirq.size); +return irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); }static struct pci_bus *mvebu_pcie_scan_bus (int nr,struct pci_sys_data *sys)
include/linux/of_irq.h +4 -20
@@ -8,22 +8,6 @@#include <linux/ioport.h> #include <linux/of.h> -/** -* of_irq - container for device_node/irq_specifier pair for an irq controller -* @controller: pointer to interrupt controller device tree node -* @size: size of interrupt specifier -* @specifier: array of cells @size long specifing the specific interrupt -* -* This structure is returned when an interrupt is mapped. The controller -* field needs to be put() after use -*/ -#define OF_MAX_IRQ_SPEC 4/* We handle specifiers of at most 4 cells */ -struct of_irq { -struct device_node *controller;/* Interrupt controller node */ -u32 size;/* Specifier size */ -u32 specifier[OF_MAX_IRQ_SPEC ];/* Specifier copy */ -}; -typedef int (*of_irq_init_cb_t )(struct device_node *,struct device_node *);/*
@@ -36,12 +20,12 @@ typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *);extern unsigned int of_irq_workarounds;extern struct device_node *of_irq_dflt_pic;extern int of_irq_parse_oldworld (struct device_node *device,int index, -struct of_irq *out_irq); +struct of_phandle_args *out_irq);#else /* CONFIG_PPC32 && CONFIG_PPC_PMAC */ #define of_irq_workarounds (0)#define of_irq_dflt_pic (NULL)static inline int of_irq_parse_oldworld (struct device_node *device,int index, -struct of_irq *out_irq) +struct of_phandle_args *out_irq) {return -EINVAL ; }
@@ -50,9 +34,9 @@ static inline int of_irq_parse_oldworld(struct device_node *device, int index,extern int of_irq_parse_raw (struct device_node *parent,const __be32 *intspec,u32 ointsize,const __be32 *addr, -struct of_irq *out_irq); +struct of_phandle_args *out_irq);extern int of_irq_parse_one (struct device_node *device,int index, -struct of_irq *out_irq); +struct of_phandle_args *out_irq);extern unsigned int irq_create_of_mapping (struct device_node *controller,const u32 *intspec,unsigned int intsize);
include/linux/of_pci.h +2 -2
@@ -5,8 +5,8 @@#include <linux/msi.h> struct pci_dev ; -struct of_irq ; -int of_irq_parse_pci (const struct pci_dev *pdev,struct of_irq *out_irq); +struct of_phandle_args ; +int of_irq_parse_pci (const struct pci_dev *pdev,struct of_phandle_args *out_irq);struct device_node ; struct device_node *of_pci_find_child_device(struct device_node *parent,
Signature · 1 line
1.8.1.2
RFC 3/9 of/irq: simplify args to irq_create_of_mapping
In reply to Grant LikelyAll the callers of irq_create_of_mapping() pass the contents of a struct of_phandle_args structure to the function. Since all the callers already have an of_phandle_args pointer, why not pass it directly to irq_create_of_mapping()?
--- arch/arm/mach-integrator/pci_v3.c | 2 +- arch/microblaze/pci/pci-common.c | 2 +- arch/mips/pci/fixup-lantiq.c | 2 +- arch/mips/pci/pci-rt3883.c | 2 +- arch/powerpc/kernel/pci-common.c | 2 +- arch/powerpc/platforms/cell/celleb_scc_pciex.c | 2 +- arch/powerpc/platforms/cell/celleb_scc_sio.c | 2 +- arch/powerpc/platforms/cell/spider-pic.c | 7 ++----- arch/powerpc/platforms/cell/spu_manage.c | 3 +-- arch/powerpc/platforms/fsl_uli1575.c | 2 +- arch/powerpc/platforms/pseries/event_sources.c | 3 +-- arch/x86/kernel/devicetree.c | 2 +- drivers/of/irq.c | 2 +- drivers/pci/host/pci-mvebu.c | 2 +- include/linux/of_irq.h | 4 +--- kernel/irq/irqdomain.c | 13 ++++++------- 16 files changed, 22 insertions(+), 30 deletions(-)
arch/arm/mach-integrator/pci_v3.c +1 -1
@@ -847,7 +847,7 @@ static int __init pci_v3_map_irq_dt(const struct pci_dev *dev, u8 slot, u8 pin)return 0 ; } -return irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); +return irq_create_of_mapping (&oirq); } static int __init pci_v3_dtprobe(struct platform_device *pdev,
arch/microblaze/pci/pci-common.c +1 -1
@@ -246,7 +246,7 @@ int pci_read_irq_line(struct pci_dev *pci_dev) oirq.args_count, oirq.args[0 ], oirq.args[1 ], of_node_full_name(oirq.np)); - virq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); + virq =irq_create_of_mapping (&oirq); }if (!virq) {pr_debug (" Failed to map !\n" );
arch/mips/pci/fixup-lantiq.c +1 -1
@@ -33,7 +33,7 @@ int __init pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) slot, pin);return 0 ; } - irq =irq_create_of_mapping (dev_irq.np, dev_irq.args, dev_irq.args_count); + irq =irq_create_of_mapping (&dev_irq);dev_info (&dev->dev,"SLOT:%d PIN:%d IRQ:%d\n" , slot, pin, irq);return irq; }
arch/mips/pci/pci-rt3883.c +1 -1
@@ -594,7 +594,7 @@ int __init pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)return 0 ; } - irq =irq_create_of_mapping (dev_irq.np, dev_irq.args, dev_irq.args_count); + irq =irq_create_of_mapping (&dev_irq);if (irq ==0 ) pr_crit("pci %s: no irq found for pin %u\n",
arch/powerpc/kernel/pci-common.c +1 -1
@@ -266,7 +266,7 @@ static int pci_read_irq_line(struct pci_dev *pci_dev) oirq.args_count, oirq.args[0 ], oirq.args[1 ], of_node_full_name(oirq.np)); - virq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); + virq =irq_create_of_mapping (&oirq); }if (virq ==NO_IRQ ) {pr_debug (" Failed to map !\n" );
arch/powerpc/platforms/cell/celleb_scc_pciex.c +1 -1
@@ -511,7 +511,7 @@ static __init int celleb_setup_pciex(struct device_node *node,pr_err ("PCIEXC:Failed to map irq\n" ); goto error; } - virq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); + virq =irq_create_of_mapping (&oirq);if (request_irq (virq, pciex_handle_internal_irq,0 ,"pciex" , (void *)phb)) {pr_err ("PCIEXC:Failed to request irq\n" );
arch/powerpc/platforms/cell/celleb_scc_sio.c +1 -1
@@ -66,7 +66,7 @@ static int __init txx9_serial_init(void)#ifdef CONFIG_SERIAL_TXX9_CONSOLE req.membase =ioremap (req.mapbase,0x24 );#endif - req.irq =irq_create_of_mapping (irq.np, irq.args, irq.args_count); + req.irq =irq_create_of_mapping (&irq); req.flags |=UPF_IOREMAP |UPF_BUGGY_UART /*HAVE_CTS_LINE*/ ; req.uartclk =83300000 ;
arch/powerpc/platforms/cell/spider-pic.c +2 -5
@@ -236,11 +236,8 @@ static unsigned int __init spider_find_cascade_and_node(struct spider_pic *pic)* tree in case the device-tree is ever fixed */ struct of_phandle_args oirq; -if (of_irq_parse_one (pic->host->of_node,0 , &oirq) ==0 ) { - virq =irq_create_of_mapping (oirq.np, oirq.args, - oirq.args_count); -return virq; - } +if (of_irq_parse_one (pic->host->of_node,0 , &oirq) ==0 ) +return irq_create_of_mapping (&oirq);/* Now do the horrible hacks */ tmp =of_get_property (pic->host->of_node,"#interrupt-cells" ,NULL );
arch/powerpc/platforms/cell/spu_manage.c +1 -2
@@ -190,8 +190,7 @@ static int __init spu_map_interrupts(struct spu *spu, struct device_node *np) ret = -EINVAL ;pr_debug (" irq %d no 0x%x on %s\n" , i, oirq.args[0 ], oirq.np->full_name); - spu->irqs[i] =irq_create_of_mapping (oirq.np, - oirq.args, oirq.args_count); + spu->irqs[i] =irq_create_of_mapping (&oirq);if (spu->irqs[i] ==NO_IRQ ) {pr_debug ("spu_new: failed to map it !\n" ); goto err;
arch/powerpc/platforms/fsl_uli1575.c +1 -1
@@ -334,7 +334,7 @@ static void hpcd_final_uli5288(struct pci_dev *dev) laddr[0 ] = (hose->first_busno <<16 ) | (PCI_DEVFN (31 ,0 ) <<8 ); laddr[1 ] = laddr[2 ] =0 ;of_irq_parse_raw (hosenode, &pin,1 , laddr, &oirq); - dev->irq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); + dev->irq =irq_create_of_mapping (&oirq); }DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_AL ,0x1575 , hpcd_quirk_uli1575);
arch/powerpc/platforms/pseries/event_sources.c +1 -2
@@ -59,8 +59,7 @@ void request_event_sources_irqs(struct device_node *np, index++) {if (count >15 )break ; - virqs[count] =irq_create_of_mapping (oirq.np, oirq.args, - oirq.args_count); + virqs[count] =irq_create_of_mapping (&oirq);if (virqs[count] ==NO_IRQ ) { pr_err("event-sources: Unable to allocate " "interrupt number for %s\n",
arch/x86/kernel/devicetree.c +1 -1
@@ -120,7 +120,7 @@ static int x86_of_pci_irq_enable(struct pci_dev *dev)if (ret)return ret; - virq =irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); + virq =irq_create_of_mapping (&oirq);if (virq ==0 )return -EINVAL ; dev->irq = virq;
drivers/of/irq.c +1 -1
@@ -41,7 +41,7 @@ unsigned int irq_of_parse_and_map(struct device_node *dev, int index)if (of_irq_parse_one (dev, index, &oirq))return 0 ; -return irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); +return irq_create_of_mapping (&oirq); }EXPORT_SYMBOL_GPL (irq_of_parse_and_map);
drivers/pci/host/pci-mvebu.c +1 -1
@@ -654,7 +654,7 @@ static int __init mvebu_pcie_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)if (ret)return ret; -return irq_create_of_mapping (oirq.np, oirq.args, oirq.args_count); +return irq_create_of_mapping (&oirq); }static struct pci_bus *mvebu_pcie_scan_bus (int nr,struct pci_sys_data *sys)
include/linux/of_irq.h +1 -3
@@ -37,9 +37,7 @@ extern int of_irq_parse_raw(struct device_node *parent, const __be32 *intspec, struct of_phandle_args *out_irq);extern int of_irq_parse_one (struct device_node *device,int index,struct of_phandle_args *out_irq); -extern unsigned int irq_create_of_mapping (struct device_node *controller, -const u32 *intspec, -unsigned int intsize); +extern unsigned int irq_create_of_mapping (struct of_phandle_args *irq_data);extern int of_irq_to_resource (struct device_node *dev,int index,struct resource *r);extern int of_irq_count (struct device_node *dev);
kernel/irq/irqdomain.c +6 -7
@@ -465,27 +465,26 @@ int irq_create_strict_mappings(struct irq_domain *domain, unsigned int irq_base, }EXPORT_SYMBOL_GPL (irq_create_strict_mappings); -unsigned int irq_create_of_mapping (struct device_node *controller, -const u32 *intspec,unsigned int intsize) +unsigned int irq_create_of_mapping (struct of_phandle_args *irq_data) {struct irq_domain *domain;irq_hw_number_t hwirq;unsigned int type =IRQ_TYPE_NONE ;unsigned int virq; - domain = controller ?irq_find_host (controller) : irq_default_domain; + domain = irq_data->np ?irq_find_host (irq_data->np) : irq_default_domain;if (!domain) {pr_warn ("no irq domain found for %s !\n" , -of_node_full_name (controller)); +of_node_full_name (irq_data->np));return 0 ; }/* If domain has no translation, then we assume interrupt line */ if (domain->ops->xlate ==NULL ) - hwirq = intspec[0 ]; + hwirq = irq_data->args[0 ];else { -if (domain->ops->xlate (domain, controller, intspec, intsize, - &hwirq, &type)) +if (domain->ops->xlate (domain, irq_data->np, irq_data->args, + irq_data->args_count, &hwirq, &type))return 0 ; }
Signature · 6 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
RFC 4/9 of/irq: Refactor interrupt-map parsing
In reply to Grant LikelyAll the users of of_irq_parse_raw pass in a raw interrupt specifier from the device tree and expect it to be returned (possibly modified) in an of_phandle_args structure. However, the primary function of of_irq_parse_raw() is to check for translations due to the presence of one or more interrupt-map properties. The actual placing of the data into an of_phandle_args structure is trivial. If it is refactored to accept an of_phandle_args structure directly, then it becomes possible to consume of_phandle_args from other sources. This is important for an upcoming patch that allows a device to be connected to more than one interrupt parent. It also simplifies the code a bit.
The biggest complication with this patch is that the old version works on the interrupt specifiers in __be32 form, but the of_phandle_args structure is intended to carry it in the cpu-native version. A bit of churn was required to make this work. In the end it results in tighter code, so the churn is worth it.
--- arch/powerpc/platforms/fsl_uli1575.c | 6 +- drivers/of/irq.c | 108 ++++++++++++++++++----------------- drivers/of/of_pci_irq.c | 7 ++- include/linux/of_irq.h | 5 +- 4 files changed, 67 insertions(+), 59 deletions(-)
arch/powerpc/platforms/fsl_uli1575.c +4 -2
@@ -322,7 +322,6 @@ static void hpcd_final_uli5288(struct pci_dev *dev)struct pci_controller *hose =pci_bus_to_host (dev->bus);struct device_node *hosenode = hose ? hose->dn :NULL ;struct of_phandle_args oirq; -int pin =2 ;u32 laddr[3 ];if (!machine_is (mpc86xx_hpcd))
@@ -331,9 +330,12 @@ static void hpcd_final_uli5288(struct pci_dev *dev)if (!hosenode)return ; + oirq.np = hosenode; + oirq.args[0 ] =2 ; + oirq.args_count =1 ; laddr[0 ] = (hose->first_busno <<16 ) | (PCI_DEVFN (31 ,0 ) <<8 ); laddr[1 ] = laddr[2 ] =0 ; -of_irq_parse_raw (hosenode, &pin,1 , laddr, &oirq); +of_irq_parse_raw (laddr, &oirq); dev->irq =irq_create_of_mapping (&oirq); }
drivers/of/irq.c +57 -51
189 lines not on this page · raw message
drivers/of/of_pci_irq.c +5 -2
@@ -85,9 +85,12 @@ int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq pdev = ppdev; } + out_irq->np = ppnode; + out_irq->args_count =1 ; + out_irq->args[0 ] = lspec; lspec_be =cpu_to_be32 (lspec); laddr[0 ] =cpu_to_be32 ((pdev->bus->number <<16 ) | (pdev->devfn <<8 )); - laddr[1 ] = laddr[2 ] =cpu_to_be32 (0 ); -return of_irq_parse_raw (ppnode, &lspec_be,1 , laddr, out_irq); + laddr[1 ] = laddr[2 ] =cpu_to_be32 (0 ); +return of_irq_parse_raw (laddr, out_irq); }EXPORT_SYMBOL_GPL (of_irq_parse_pci);
include/linux/of_irq.h +1 -4
@@ -31,10 +31,7 @@ static inline int of_irq_parse_oldworld(struct device_node *device, int index, }#endif /* CONFIG_PPC32 && CONFIG_PPC_PMAC */ - -extern int of_irq_parse_raw (struct device_node *parent,const __be32 *intspec, -u32 ointsize,const __be32 *addr, -struct of_phandle_args *out_irq); +extern int of_irq_parse_raw (const __be32 *addr,struct of_phandle_args *out_irq);extern int of_irq_parse_one (struct device_node *device,int index,struct of_phandle_args *out_irq);extern unsigned int irq_create_of_mapping (struct of_phandle_args *irq_data);
Signature · 1 line
1.8.1.2
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing
Hi,
Quoted 11 lines · Grant Likely
All the users of
of_irq_parse_rawpass in a raw interrupt specifier from the device tree and expect it to be returned (possibly modified) in anof_phandle_argsstructure. However, the primary function ofof_irq_parse_raw()is to check for translations due to the presence of one or more interrupt-map properties. The actual placing of the data into anof_phandle_argsstructure is trivial. If it is refactored to accept anof_phandle_argsstructure directly, then it becomes possible to consumeof_phandle_argsfrom other sources. This is important for an upcoming patch that allows a device to be connected to more than one interrupt parent. It also simplifies the code a bit.
Quoted 8 lines
The biggest complication with this patch is that the old version works on the interrupt specifiers in
__be32form, but theof_phandle_argsstructure is intended to carry it in the cpu-native version. A bit of churn was required to make this work. In the end it results in tighter code, so the churn is worth it.Signed-off-by Grant Likely <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>
This patch stopped exynos/arndale from booting when it hit next (i.e. last night). I bisected down to this commit.
It seems that the platform is getting stuck calibrating delay loop, i.e. it is not getting interrupts. Let me know if you want me to collect more data of some sort.
-Olof
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing
Quoted 20 lines · Olof Johansson
Hi,
Quoted 17 lines · Grant Likely
All the users of
of_irq_parse_rawpass in a raw interrupt specifier from the device tree and expect it to be returned (possibly modified) in anof_phandle_argsstructure. However, the primary function ofof_irq_parse_raw()is to check for translations due to the presence of one or more interrupt-map properties. The actual placing of the data into anof_phandle_argsstructure is trivial. If it is refactored to accept anof_phandle_argsstructure directly, then it becomes possible to consumeof_phandle_argsfrom other sources. This is important for an upcoming patch that allows a device to be connected to more than one interrupt parent. It also simplifies the code a bit.The biggest complication with this patch is that the old version works on the interrupt specifiers in
__be32form, but theof_phandle_argsstructure is intended to carry it in the cpu-native version. A bit of churn was required to make this work. In the end it results in tighter code, so the churn is worth it.
Quoted 5 lines
Quoted 2 lines
Signed-off-by Grant Likely <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>This patch stopped exynos/arndale from booting when it hit next (i.e. last night). I bisected down to this commit.
+1, :-)
Quoted 4 lines
It seems that the platform is getting stuck calibrating delay loop, i.e. it is not getting interrupts. Let me know if you want me to collect more data of some sort.
Thanks,
Signature · 1 line
Ming Lei
A message that is not in the archive (sent off-list or not yet received): CACxGe6uE+KvycQq3XBavRcvprff6PhBaxX54W_Cb1cfuVpMXvQ@mail.gmail.com
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing
Quoted 4 lines · Grant Likely
(Sorry for HTML mail)
Can you put #define DEBUG at the top of
drivers/of/irq.cand send me the log output from before and after the commit?
Here you go, quite verbose log below.
Looks like we're tripping the "no reg passed in" checks, not sure if related.
After:
[arndale 01:05] [ 0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1 [arndale 01:05] [ 0.000000] Preemptible hierarchical RCU implementation. [arndale 01:05] [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [arndale 01:05] [ 0.000000] of_irq_init: init arm,cortex-a9-gic @ c1569754, parent (null) [arndale 01:05] [ 0.000000] of_irq_init: init samsung,exynos4210-combiner @ c1569608, parent c1569754 [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=0 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000000...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=1 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000001...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=2 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000002...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=3 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000003...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=4 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000004...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=5 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000005...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=6 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000006...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=7 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000007...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=8 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000008...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=9 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000009...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=10 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000a...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=11 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000b...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=12 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000c...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=13 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000d...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=14 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000e...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=15 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000f...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=16 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000010...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=17 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000011...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=18 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000012...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=19 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000013...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=20 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000014...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=21 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000015...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=22 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000016...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=23 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000017...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=24 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000018...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=25 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000019...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=26 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001a...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=27 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001b...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=28 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001c...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=29 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001d...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=30 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001e...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=31 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001f...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] Exynos5250: clock setup completed, armclk=1000000000 [arndale 01:05] [ 0.000000] Exynos: Audss: clock setup completed [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/timer, index=0 [arndale 01:05] [ 0.000000] intspec=1 intlen=12 [arndale 01:05] [ 0.000000] intsize=3 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000d...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> no reg passed in when needed ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/timer, index=1 [arndale 01:05] [ 0.000000] intspec=1 intlen=12 [arndale 01:05] [ 0.000000] intsize=3 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000e...],ointsize=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> no reg passed in when needed ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/timer, index=2 [arndale 01:05] [ 0.000000] intspec=1 intlen=12 [arndale 01:05] [ 0.000000] intsize=3 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000b...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> no reg passed in when needed ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/timer, index=3 [arndale 01:05] [ 0.000000] intspec=1 intlen=12 [arndale 01:05] [ 0.000000] intsize=3 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000a...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> no reg passed in when needed ! [arndale 01:05] [ 0.000000] arch_timer: No interrupt available, giving up [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=0 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000000 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=0 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000000 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=1 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000001 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=2 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000002 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=3 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000003 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=4 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000004 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=5 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000005 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=6 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=4 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000004 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=5 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000005 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] genirq: Flags mismatch irq 347. 00015200 (mct_comp_irq) vs. 00014a00 (mct_tick0) [arndale 01:05] [ 0.000000] sched_clock: 32 bits at 200 Hz, resolution 5000000ns, wraps every 4294967291ms [arndale 01:05] [ 0.000000] Console: colour dummy device 80x30 [arndale 01:05] [ 0.000000] Calibrating delay loop... [arndale 01:05] got exception: timeout
Before:
Huh, before this change we end up using pre-calculated elay loop:
[arndale 00:58] [ 0.000000] Preemptible hierarchical RCU implementation. [arndale 00:58] [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [arndale 00:58] [ 0.000000] of_irq_init: init arm,cortex-a9-gic @ c1569754, parent (null) [arndale 00:58] [ 0.000000] of_irq_init: init samsung,exynos4210-combiner @ c1569608, parent c1569754 [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=0 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000000...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=1 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000001...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=2 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000002...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=3 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000003...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=4 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000004...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=5 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000005...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=6 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000006...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=7 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000007...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=8 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000008...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=9 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000009...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=10 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000a...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=11 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000b...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=12 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000c...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=13 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000d...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=14 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000e...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=15 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000f...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=16 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000010...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=17 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000011...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=18 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000012...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=19 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000013...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=20 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000014...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=21 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000015...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=22 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000016...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=23 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000017...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=24 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000018...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=25 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000019...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=26 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001a...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=27 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001b...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=28 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001c...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=29 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001d...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=30 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001e...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=31 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001f...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] Exynos5250: clock setup completed, armclk=1000000000 [arndale 00:58] [ 0.000000] Exynos: Audss: clock setup completed [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/timer, index=0 [arndale 00:58] [ 0.000000] intspec=1 intlen=12 [arndale 00:58] [ 0.000000] intsize=3 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000d...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/timer, index=1 [arndale 00:58] [ 0.000000] intspec=1 intlen=12 [arndale 00:58] [ 0.000000] intsize=3 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000e...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/timer, index=2 [arndale 00:58] [ 0.000000] intspec=1 intlen=12 [arndale 00:58] [ 0.000000] intsize=3 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000b...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/timer, index=3 [arndale 00:58] [ 0.000000] intspec=1 intlen=12 [arndale 00:58] [ 0.000000] intsize=3 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000a...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] Architected cp15 timer(s) running at 24.00MHz (phys). [arndale 00:58] [ 0.000000] Switching to timer-based delay loop [arndale 00:58] [ 0.000000] sched_clock: ARM arch timer >56 bits at 24000kHz, resolution 41ns [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=0 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000000 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=0 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000000 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=1 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000001 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=2 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000002 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=3 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000003 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=4 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000004 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=10) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=6 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10481000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=5 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000005 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=10) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=6 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=4) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=0 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10481000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=6 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=4 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000004 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=10) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=6 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10481000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=5 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000005 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=10) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=6 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=4) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=0 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10481000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] sched_clock: 32 bits at 200 Hz, resolution 5000000ns, wraps every 4294967291ms [arndale 00:58] [ 0.000000] Console: colour dummy device 80x30 [arndale 00:58] [ 0.012702] Calibrating delay loop (skipped), value calculated using timer frequency.. 48.00 BogoMIPS (lpj=120000) [arndale 00:58] [ 0.022934] pid_max: default: 32768 minimum: 301
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing
Quoted 9 lines · Olof Johansson
Quoted 4 lines · Grant Likely
(Sorry for HTML mail)
Can you put #define DEBUG at the top of
drivers/of/irq.cand send me the log output from before and after the commit?Here you go, quite verbose log below.
Looks like we're tripping the "no reg passed in" checks, not sure if related.
Thanks.
Hmmm. that's very odd. The using a precalcuated delay before the change bothers me because there shouldn't be a functional change here to the users. I'll dig into it today and see if I can figure out what the behaviour change is.
g.
Quoted 825 lines
After:
[arndale 01:05] [ 0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1 [arndale 01:05] [ 0.000000] Preemptible hierarchical RCU implementation. [arndale 01:05] [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [arndale 01:05] [ 0.000000] of_irq_init: init arm,cortex-a9-gic @ c1569754, parent (null) [arndale 01:05] [ 0.000000] of_irq_init: init samsung,exynos4210-combiner @ c1569608, parent c1569754 [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=0 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000000...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=1 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000001...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=2 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000002...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=3 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000003...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=4 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000004...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=5 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000005...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=6 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000006...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=7 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000007...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=8 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000008...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=9 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000009...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=10 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000a...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=11 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000b...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=12 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000c...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=13 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000d...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=14 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000e...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=15 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000f...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=16 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000010...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=17 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000011...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=18 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000012...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=19 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000013...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=20 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000014...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=21 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000015...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=22 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000016...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=23 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000017...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=24 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000018...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=25 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000019...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=26 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001a...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=27 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001b...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=28 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001c...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=29 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001d...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=30 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001e...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=31 [arndale 01:05] [ 0.000000] intspec=0 intlen=96 [arndale 01:05] [ 0.000000] intsize=3 intlen=96 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001f...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] Exynos5250: clock setup completed, armclk=1000000000 [arndale 01:05] [ 0.000000] Exynos: Audss: clock setup completed [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/timer, index=0 [arndale 01:05] [ 0.000000] intspec=1 intlen=12 [arndale 01:05] [ 0.000000] intsize=3 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000d...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> no reg passed in when needed ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/timer, index=1 [arndale 01:05] [ 0.000000] intspec=1 intlen=12 [arndale 01:05] [ 0.000000] intsize=3 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000e...],ointsize=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> no reg passed in when needed ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/timer, index=2 [arndale 01:05] [ 0.000000] intspec=1 intlen=12 [arndale 01:05] [ 0.000000] intsize=3 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000b...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> no reg passed in when needed ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/timer, index=3 [arndale 01:05] [ 0.000000] intspec=1 intlen=12 [arndale 01:05] [ 0.000000] intsize=3 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000a...],ointsize=3 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 01:05] [ 0.000000] -> addrsize=1 [arndale 01:05] [ 0.000000] -> no reg passed in when needed ! [arndale 01:05] [ 0.000000] arch_timer: No interrupt available, giving up [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=0 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000000 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=0 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000000 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=1 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000001 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=2 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000002 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=3 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000003 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=4 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000004 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=5 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000005 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=6 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=4 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000004 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=5 [arndale 01:05] [ 0.000000] intspec=0 intlen=12 [arndale 01:05] [ 0.000000] intsize=2 intlen=12 [arndale 01:05] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000005 0x00000000...],ointsize=2 [arndale 01:05] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 01:05] [ 0.000000] -> addrsize=0 [arndale 01:05] [ 0.000000] -> match=1 (imaplen=30) [arndale 01:05] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 01:05] [ 0.000000] -> imaplen=27 [arndale 01:05] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 01:05] [ 0.000000] -> got it ! [arndale 01:05] [ 0.000000] genirq: Flags mismatch irq 347. 00015200 (mct_comp_irq) vs. 00014a00 (mct_tick0) [arndale 01:05] [ 0.000000] sched_clock: 32 bits at 200 Hz, resolution 5000000ns, wraps every 4294967291ms [arndale 01:05] [ 0.000000] Console: colour dummy device 80x30 [arndale 01:05] [ 0.000000] Calibrating delay loop... [arndale 01:05] got exception: timeoutBefore:
Huh, before this change we end up using pre-calculated elay loop:
[arndale 00:58] [ 0.000000] Preemptible hierarchical RCU implementation. [arndale 00:58] [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [arndale 00:58] [ 0.000000] of_irq_init: init arm,cortex-a9-gic @ c1569754, parent (null) [arndale 00:58] [ 0.000000] of_irq_init: init samsung,exynos4210-combiner @ c1569608, parent c1569754 [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=0 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000000...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=1 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000001...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=2 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000002...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=3 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000003...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=4 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000004...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=5 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000005...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=6 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000006...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=7 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000007...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=8 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000008...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=9 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000009...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=10 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000a...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=11 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000b...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=12 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000c...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=13 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000d...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=14 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000e...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=15 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000000f...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=16 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000010...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=17 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000011...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=18 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000012...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=19 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000013...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=20 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000014...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=21 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000015...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=22 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000016...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=23 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000017...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=24 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000018...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=25 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x00000019...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=26 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001a...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=27 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001b...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=28 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001c...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=29 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001d...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=30 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001e...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/interrupt-controller@10440000, index=31 [arndale 00:58] [ 0.000000] intspec=0 intlen=96 [arndale 00:58] [ 0.000000] intsize=3 intlen=96 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000000 0x0000001f...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] Exynos5250: clock setup completed, armclk=1000000000 [arndale 00:58] [ 0.000000] Exynos: Audss: clock setup completed [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/timer, index=0 [arndale 00:58] [ 0.000000] intspec=1 intlen=12 [arndale 00:58] [ 0.000000] intsize=3 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000d...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/timer, index=1 [arndale 00:58] [ 0.000000] intspec=1 intlen=12 [arndale 00:58] [ 0.000000] intsize=3 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000e...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/timer, index=2 [arndale 00:58] [ 0.000000] intspec=1 intlen=12 [arndale 00:58] [ 0.000000] intsize=3 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000b...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/timer, index=3 [arndale 00:58] [ 0.000000] intspec=1 intlen=12 [arndale 00:58] [ 0.000000] intsize=3 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/interrupt-controller@10481000,intspec=[0x00000001 0x0000000a...],ointsize=3 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/interrupt-controller@10481000, size=3 [arndale 00:58] [ 0.000000] -> addrsize=1 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] Architected cp15 timer(s) running at 24.00MHz (phys). [arndale 00:58] [ 0.000000] Switching to timer-based delay loop [arndale 00:58] [ 0.000000] sched_clock: ARM arch timer >56 bits at 24000kHz, resolution 41ns [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=0 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000000 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=0 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000000 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=1 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000001 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=2 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000002 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=3 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000003 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10440000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=4 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000004 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=10) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=6 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10481000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=5 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000005 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=10) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=6 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=4) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=0 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10481000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=6 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=4 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000004 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=10) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=6 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10481000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] of_irq_parse_one: dev=/mct@101C0000, index=5 [arndale 00:58] [ 0.000000] intspec=0 intlen=12 [arndale 00:58] [ 0.000000] intsize=2 intlen=12 [arndale 00:58] [ 0.000000] of_irq_parse_raw: par=/mct@101C0000/mct-map,intspec=[0x00000005 0x00000000...],ointsize=2 [arndale 00:58] [ 0.000000] of_irq_parse_raw: ipar=/mct@101C0000/mct-map, size=2 [arndale 00:58] [ 0.000000] -> addrsize=0 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=30) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=27 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=25) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=22 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=20) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=17 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=15) [arndale 00:58] [ 0.000000] -> newintsize=2, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=12 [arndale 00:58] [ 0.000000] -> match=0 (imaplen=10) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=6 [arndale 00:58] [ 0.000000] -> match=1 (imaplen=4) [arndale 00:58] [ 0.000000] -> newintsize=3, newaddrsize=0 [arndale 00:58] [ 0.000000] -> imaplen=0 [arndale 00:58] [ 0.000000] -> new parent: /interrupt-controller@10481000 [arndale 00:58] [ 0.000000] -> got it ! [arndale 00:58] [ 0.000000] sched_clock: 32 bits at 200 Hz, resolution 5000000ns, wraps every 4294967291ms [arndale 00:58] [ 0.000000] Console: colour dummy device 80x30 [arndale 00:58] [ 0.012702] Calibrating delay loop (skipped), value calculated using timer frequency.. 48.00 BogoMIPS (lpj=120000) [arndale 00:58] [ 0.022934] pid_max: default: 32768 minimum: 301--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing
In reply to Olof JohanssonQuoted 9 lines · Olof Johansson
Quoted 4 lines · Grant Likely
(Sorry for HTML mail)
Can you put #define DEBUG at the top of
drivers/of/irq.cand send me the log output from before and after the commit?Here you go, quite verbose log below.
Looks like we're tripping the "no reg passed in" checks, not sure if related.
I think I've found the bug. See if this helps...
Quoted 1 line
From
54a6d89d63361f8117ff69e4b65efabb12b897c7Mon Sep 17 00:00:00 2001
From: Grant Likely <[email protected]>
Date: Fri, 1 Nov 2013 10:50:50 -0700
Subject: [PATCH] of: Fixup interrupt parsing failure.
--- drivers/of/irq.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-)
drivers/of/irq.c +17 -15
@@ -17,7 +17,7 @@* device tree to actual irq numbers on an interrupt controller * driver. */ - +#define DEBUG #include <linux/errno.h> #include <linux/list.h> #include <linux/module.h>
@@ -97,7 +97,7 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)struct device_node *ipar, *tnode, *old =NULL , *newpar =NULL ;__be32 initial_match_array[8 ];const __be32 *match_array = initial_match_array; -const __be32 *tmp, *imap, *imask, dummy_imask[] = { ~0 , ~0 , ~0 , ~0 , ~0 }; +const __be32 *tmp, *imap, *imask, dummy_imask[] = { ~0 , ~0 , ~0 , ~0 , ~0 , ~0 , ~0 , ~0 };u32 intsize =1 , addrsize, newintsize =0 , newaddrsize =0 ;int imaplen, match, i;
@@ -147,21 +147,14 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)pr_debug (" -> addrsize=%d\n" , addrsize); -/* If we were passed no "reg" property and we attempt to parse -* an interrupt-map, then #address-cells must be 0. -* Fail if it's not. -*/ -if (addr ==NULL && addrsize !=0 ) { -pr_debug (" -> no reg passed in when needed !\n" ); -return -EINVAL ; +if (addrsize && addr) { +/* Precalculate the initial match array to simplify match loop */ +for (i =0 ; i < addrsize; i++) + initial_match_array[i] = addr[i]; +for (i =0 ; i < intsize; i++) + initial_match_array[addrsize + i] =cpu_to_be32 (out_irq->args[i]); } -/* Precalculate the match array - this simplifies match loop */ -for (i =0 ; i < addrsize; i++) - initial_match_array[i] = addr[i]; -for (i =0 ; i < intsize; i++) - initial_match_array[addrsize + i] =cpu_to_be32 (out_irq->args[i]); -/* Now start the actual "proper" walk of the interrupt tree */ while (ipar !=NULL ) {/* Now check if cursor is an interrupt-controller and if it is
@@ -174,6 +167,15 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)return 0 ; } +/* If we were passed no "reg" property and we attempt to parse +* an interrupt-map, then #address-cells must be 0. +* Fail if it's not. +*/ +if (addrsize && !addr) { +pr_debug (" -> no reg passed in when needed !\n" ); +return -EINVAL ; + } +/* Now look for an interrupt-map */ imap =of_get_property (ipar,"interrupt-map" , &imaplen);/* No interrupt map, check for an interrupt parent */
Signature · 1 line
1.8.1.2
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing
Quoted 4 lines · Grant Likely
Quoted 3 lines · Olof Johansson
Quoted 2 lines · Grant Likely
(Sorry for HTML mail)
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Can you put #define DEBUG at the top of
drivers/of/irq.cand send me the log output from before and after the commit?Here you go, quite verbose log below.
Looks like we're tripping the "no reg passed in" checks, not sure if related.
I think I've found the bug. See if this helps...
That one was broken. Try this instead.
Quoted 1 line
From
bcbffc3d16f49451ef505dc021480aa061465a15Mon Sep 17 00:00:00 2001
From: Grant Likely <[email protected]>
Date: Fri, 1 Nov 2013 10:50:50 -0700
Subject: [PATCH] of: Fixup interrupt parsing failure.
--- drivers/of/irq.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/of/irq.c +12 -12
@@ -97,7 +97,7 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)struct device_node *ipar, *tnode, *old =NULL , *newpar =NULL ;__be32 initial_match_array[8 ];const __be32 *match_array = initial_match_array; -const __be32 *tmp, *imap, *imask, dummy_imask[] = { ~0 , ~0 , ~0 , ~0 , ~0 }; +const __be32 *tmp, *imap, *imask, dummy_imask[] = { ~0 , ~0 , ~0 , ~0 , ~0 , ~0 , ~0 , ~0 };u32 intsize =1 , addrsize, newintsize =0 , newaddrsize =0 ;int imaplen, match, i;
@@ -147,18 +147,9 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)pr_debug (" -> addrsize=%d\n" , addrsize); -/* If we were passed no "reg" property and we attempt to parse -* an interrupt-map, then #address-cells must be 0. -* Fail if it's not. -*/ -if (addr ==NULL && addrsize !=0 ) { -pr_debug (" -> no reg passed in when needed !\n" ); -return -EINVAL ; - } - -/* Precalculate the match array - this simplifies match loop */ +/* Precalculate the initial match array to simplify match loop */ for (i =0 ; i < addrsize; i++) - initial_match_array[i] = addr[i]; + initial_match_array[i] = addr ? addr[i] :0 ;for (i =0 ; i < intsize; i++) initial_match_array[addrsize + i] =cpu_to_be32 (out_irq->args[i]);
@@ -174,6 +165,15 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)return 0 ; } +/* If we were passed no "reg" property and we attempt to parse +* an interrupt-map, then #address-cells must be 0. +* Fail if it's not. +*/ +if (addrsize && !addr) { +pr_debug (" -> no reg passed in when needed !\n" ); +return -EINVAL ; + } +/* Now look for an interrupt-map */ imap =of_get_property (ipar,"interrupt-map" , &imaplen);/* No interrupt map, check for an interrupt parent */
Signature · 6 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Ming Lei
Tested-byRe: [RFC 4/9] of/irq: Refactor interrupt-map parsing
Quoted 8 lines · Grant Likely
That one was broken. Try this instead.
From
bcbffc3d16f49451ef505dc021480aa061465a15Mon Sep 17 00:00:00 2001
From: Grant Likely <[email protected]>
Date: Fri, 1 Nov 2013 10:50:50 -0700
Subject: [PATCH] of: Fixup interrupt parsing failure.
Quoted 4 lines
Signed-off-by Grant Likely <[email protected]>--- drivers/of/irq.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
This one does fix boot hanging on Arndale board.
Thanks,
Signature · 1 line
Ming Lei
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing
In reply to Grant LikelyQuoted 14 lines · Grant Likely
Quoted 4 lines · Grant Likely
Quoted 3 lines · Olof Johansson
Quoted 2 lines · Grant Likely
(Sorry for HTML mail)
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Can you put #define DEBUG at the top of
drivers/of/irq.cand send me the log output from before and after the commit?Here you go, quite verbose log below.
Looks like we're tripping the "no reg passed in" checks, not sure if related.
I think I've found the bug. See if this helps...
Quoted 8 lines
That one was broken. Try this instead.
From
bcbffc3d16f49451ef505dc021480aa061465a15Mon Sep 17 00:00:00 2001
From: Grant Likely <[email protected]>
Date: Fri, 1 Nov 2013 10:50:50 -0700
Subject: [PATCH] of: Fixup interrupt parsing failure.Signed-off-by Grant Likely <[email protected]>
Well, it boots. That's an improvement. :) It is again going for the precalculated delay loop. I'm not sure why the code path diverged before, especially given the below irq request fail for MCT.
I do see a bunch of new printk errors that I didn't use to though:
[ 0.000000] genirq: Flags mismatch irq 160. 00015200 (mct_comp_irq) vs. 00014a00 (mct_tick0) [ 0.040401] genirq: Flags mismatch irq 160. 00014a00 (mct_tick1) vs. 00014a00 (mct_tick0) [ 0.040405] exynos-mct: cannot register IRQ 160
So I don't think we're home safe yet. I need to spend some time this week actually debugging this... Good thing the merge window is delayed.
-Olof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing
Following two patches seem to fully fix interrupt parsing issues, at least on Exynos 4210 Trats board. They must be applied without Grant's fixup patch, as it doesn't seem to fully solve the problem.
Tomasz Figa (2):
of: irq: Fix interrupt-map entry matching
of: irq: Check for reg property presence only when parsing
interrupt-map
drivers/of/irq.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-)
Signature · 1 line
1.8.4.2
PATCH 1/2 of: irq: Fix interrupt-map entry matching
This patch fixes interrupt-map entry matching code to properly match all specifier cells with interrupt map entries.
--- drivers/of/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/irq.c +1 -1
@@ -195,7 +195,7 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)/* Compare specifiers */ match =1 ;for (i =0 ; i < (addrsize + intsize); i++, imaplen--) - match = !((match_array[i] ^ *imap++) & imask[i]); + match &= !((match_array[i] ^ *imap++) & imask[i]);pr_debug (" -> match=%d (imaplen=%d)\n" , match, imaplen);
Signature · 7 lines
1.8.4.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] of: irq: Fix interrupt-map entry matching
Hi Grant,
Could you pick this patch up? It fixes boot-up at least on several Exynos based platforms, which use interrupt-map nodes with #interrupt-cells higher than 1.
Also please disregard patch 2/2, as your fix that has been merged seems to be fine.
Best regards,
Tomasz
Quoted 14 lines · On Tuesday 05 of November 2013 16:21:18 Tomasz Figa wrote:
This patch fixes interrupt-map entry matching code to properly match all specifier cells with interrupt map entries.
Signed-off-by Tomasz Figa <[email protected]>--- drivers/of/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/of/irq.c +0
-0
drivers/of/irq.c int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq) · line 201
Quoted 8 lines
drivers/of/irq.c +1
-1@@ -195,7 +195,7 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)/* Compare specifiers */ match =1 ;for (i =0 ; i < (addrsize + intsize); i++, imaplen--) - match = !((match_array[i] ^ *imap++) & imask[i]); + match &= !((match_array[i] ^ *imap++) & imask[i]);pr_debug (" -> match=%d (imaplen=%d)\n" , match, imaplen);
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] of: irq: Fix interrupt-map entry matching
Quoted 8 lines · Tomasz Figa
Hi Grant,
Could you pick this patch up? It fixes boot-up at least on several Exynos based platforms, which use interrupt-map nodes with #interrupt-cells higher than 1.
Also please disregard patch 2/2, as your fix that has been merged seems to be fine.
I've applied the 1st patch.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] of: irq: Fix interrupt-map entry matching
Quoted 7 lines · On Thursday 07 of November 2013 10:40:16 Rob Herring wrote:
Quoted 6 lines · Tomasz Figa
Hi Grant,
Could you pick this patch up? It fixes boot-up at least on several Exynos based platforms, which use interrupt-map nodes with #interrupt-cells higher than 1.
Quoted 5 lines
Quoted 3 lines
Also please disregard patch 2/2, as your fix that has been merged seems
to be fine.I've applied the 1st patch.
Thanks Rob.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] of: irq: Fix interrupt-map entry matching
Quoted 8 lines · Tomasz Figa
Quoted 7 lines · On Thursday 07 of November 2013 10:40:16 Rob Herring wrote:
Quoted 6 lines · Tomasz Figa
Hi Grant,
Could you pick this patch up? It fixes boot-up at least on several Exynos based platforms, which use interrupt-map nodes with #interrupt-cells higher than 1.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Also please disregard patch 2/2, as your fix that has been merged seems
to be fine.I've applied the 1st patch.
Thanks Rob.
Thanks Rob and Tomasz. That was definitely a brown-paper-bag mistake on my part.
g.
Re: [PATCH 1/2] of: irq: Fix interrupt-map entry matching
In reply to Tomasz FigaQuoted 4 lines · Tomasz Figa
This patch fixes interrupt-map entry matching code to properly match all specifier cells with interrupt map entries.
Signed-off-by Tomasz Figa <[email protected]>
Tested on Origen and Arndale boards. Works fine.
Signature · 6 lines
With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/2 of: irq: Check for reg property presence only when parsing interrupt-map
In reply to Tomasz FigaThis patch fixes the of_irq_parse_raw() function to check for reg property only when really parsing interrupt map property, as it is not required otherwise and breaks existing device trees.
--- drivers/of/irq.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)
drivers/of/irq.c +11 -10
@@ -147,17 +147,8 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)pr_debug (" -> addrsize=%d\n" , addrsize); -/* If we were passed no "reg" property and we attempt to parse -* an interrupt-map, then #address-cells must be 0. -* Fail if it's not. -*/ -if (addr ==NULL && addrsize !=0 ) { -pr_debug (" -> no reg passed in when needed !\n" ); -return -EINVAL ; - } -/* Precalculate the match array - this simplifies match loop */ -for (i =0 ; i < addrsize; i++) +for (i =0 ; i < addrsize && addr; i++) initial_match_array[i] = addr[i];for (i =0 ; i < intsize; i++) initial_match_array[addrsize + i] =cpu_to_be32 (out_irq->args[i]);
@@ -184,6 +175,16 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq) } imaplen /=sizeof (u32); +/* +* If we were passed no "reg" property and we attempt to parse +* an interrupt-map, then #address-cells must be 0. +* Fail if it's not. +*/ +if (addr ==NULL && addrsize !=0 ) { +pr_debug (" -> no reg passed in when needed !\n" ); +return -EINVAL ; + } +/* Look for a mask */ imask =of_get_property (ipar,"interrupt-map-mask" ,NULL );if (!imask)
Signature · 1 line
1.8.4.2
Re: [PATCH 2/2] of: irq: Check for reg property presence only when parsing interrupt-map
Hi,
Quoted 8 lines · On Tuesday 05 of November 2013 16:21:36 Tomasz Figa wrote:
This patch fixes the
of_irq_parse_raw()function to check for reg property only when really parsing interrupt map property, as it is not required otherwise and breaks existing device trees.Signed-off-by Tomasz Figa <[email protected]>--- drivers/of/irq.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)
Please disregard this patch. It seems like Grant's fix that has been already merged also fixes the same problem.
Best regards,
Tomasz
Stephen Warren
Tested-byRe: [RFC 4/9] of/irq: Refactor interrupt-map parsing
In reply to Grant LikelyQuoted 9 lines · Grant Likely
Quoted 8 lines · Olof Johansson
Quoted 4 lines · Grant Likely
(Sorry for HTML mail)
Can you put #define DEBUG at the top of
drivers/of/irq.cand send me the log output from before and after the commit?Here you go, quite verbose log below.
Quoted 8 lines
Quoted 1 line
Looks like we're tripping the "no reg passed in" checks, not sure if related.
I think I've found the bug. See if this helps...
From
54a6d89d63361f8117ff69e4b65efabb12b897c7Mon Sep 17 00:00:00 2001
From: Grant Likely <[email protected]>
Date: Fri, 1 Nov 2013 10:50:50 -0700
Subject: [PATCH] of: Fixup interrupt parsing failure.
Thanks, this fixes the clocksource errors that I was seeing when performing CPU hotplug, as mentioned in:
https://lkml.org/lkml/2013/10/31/430
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing [CPU hotplug clockevents issue]
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing [CPU hotplug clockevents issue]
In reply to Grant LikelyQuoted 11 lines · Grant Likely
All the users of
of_irq_parse_rawpass in a raw interrupt specifier from the device tree and expect it to be returned (possibly modified) in anof_phandle_argsstructure. However, the primary function ofof_irq_parse_raw()is to check for translations due to the presence of one or more interrupt-map properties. The actual placing of the data into anof_phandle_argsstructure is trivial. If it is refactored to accept anof_phandle_argsstructure directly, then it becomes possible to consumeof_phandle_argsfrom other sources. This is important for an upcoming patch that allows a device to be connected to more than one interrupt parent. It also simplifies the code a bit.
Quoted 5 lines
The biggest complication with this patch is that the old version works on the interrupt specifiers in
__be32form, but theof_phandle_argsstructure is intended to carry it in the cpu-native version. A bit of churn was required to make this work. In the end it results in tighter code, so the churn is worth it.
This commit appears to cause kernel error spew while performing CPU hotplug operations on Tegra114. For example, see the log at the end of this message.
I guess this boot-time message is the clue:
[ 0.000000] arch_timer: No interrupt available, giving up
which corresponds to this diff in /proc/interrupts:
Quoted 1 line
- 27: 2929 2216 2027 1922 GIC 27
arch_timer
The relevant DT node is probably:
Quoted 4 lines
timer {
compatible = "arm,armv7-timer";
interrupts =
<GIC_PPI 13Quoted 8 lines
(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 14
(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 11
(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 10
(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
};I guess this is a similar problem to that which Olof reported; there's no reg property in that node, yet #size-cells=<0> since the timer node is a direct child of the root node.
Hotplug error spew:
Quoted 25 lines
root@localhost:~# ./cpuonline.py echo 0 > /sys/devices/system/cpu/cpu2/online [ 46.753347] CPU2: shutdown echo 0 > /sys/devices/system/cpu/cpu1/online [ 48.848007] CPU1: shutdown echo 0 > /sys/devices/system/cpu/cpu3/online [ 50.897720] CPU3: shutdown echo 1 > /sys/devices/system/cpu/cpu1/online [ 52.949980] CPU1: Booted secondary processor [ 52.961188] Clockevents: could not switch to one-shot mode: dummy_timer is not functional. [ 52.969566] Could not switch to high resolution mode on CPU 1 echo 1 > /sys/devices/system/cpu/cpu2/online [ 54.999852] CPU2: Booted secondary processor [ 55.011164] Clockevents: could not switch to one-shot mode: dummy_timer is not functional. [ 55.019543] Could not switch to high resolution mode on CPU 2 echo 0 > /sys/devices/system/cpu/cpu1/online [ 57.048730] CPU1: shutdown echo 1 > /sys/devices/system/cpu/cpu3/online [ 59.088927] CPU3: Booted secondary processor [ 59.101149] Clockevents: could not switch to one-shot mode: dummy_timer is not functional. [ 59.109517] Could not switch to high resolution mode on CPU 3 echo 1 > /sys/devices/system/cpu/cpu1/online [ 61.129737] CPU1: Booted secondary processor [ 61.141161] Clockevents: could not switch to one-shot mode: dummy_timer is not functional. [ 61.149540] Could not switch to high resolution mode on CPU 1
RFC 5/9 of: Add helper for printing an of_phandle_args structure
In reply to Grant LikelyIt is sometimes useful for debug to get the contents of an of_phandle_args structure out into the kernel log.
--- drivers/of/base.c | 9 +++++++++ drivers/of/irq.c | 6 +++--- include/linux/of.h | 1 + 3 files changed, 13 insertions(+), 3 deletions(-)
drivers/of/base.c +9 -0
@@ -1185,6 +1185,15 @@ int of_property_count_strings(struct device_node *np, const char *propname) }EXPORT_SYMBOL_GPL (of_property_count_strings); +void of_print_phandle_args (const char *msg,const struct of_phandle_args *args) +{ +int i; +printk ("%s %s" , msg,of_node_full_name (args->np)); +for (i =0 ; i < args->args_count; i++) +printk (i ?",%08x" :":%08x" , args->args[i]); +printk ("\n" ); +} + static int __of_parse_phandle_with_args(const struct device_node *np, const char *list_name, const char *cells_name,
drivers/of/irq.c +3 -3
@@ -101,9 +101,9 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)u32 intsize =1 , addrsize, newintsize =0 , newaddrsize =0 ;int imaplen, match, i; -pr_debug ("of_irq_parse_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n" , -of_node_full_name (out_irq->np), out_irq->args[0 ], out_irq->args[1 ], - out_irq->args_count); +#ifdef DEBUG +of_print_phandle_args ("of_irq_parse_raw: " , out_irq); +#endif ipar =of_node_get (out_irq->np);
include/linux/of.h +1 -0
@@ -275,6 +275,7 @@ extern int of_n_size_cells(struct device_node *np);extern const struct of_device_id *of_match_node (const struct of_device_id *matches,const struct device_node *node);extern int of_modalias_node (struct device_node *node,char *modalias,int len); +extern void of_print_phandle_args (const char *msg,const struct of_phandle_args *args);extern struct device_node *of_parse_phandle (const struct device_node *np,const char *phandle_name,int index);
Signature · 1 line
1.8.1.2
RFC 6/9 of: Add testcases for interrupt parsing
In reply to Grant LikelyThis patch extends the DT selftest code with some test cases for the interrupt parsing functions.
--- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 41 ++++++++++ arch/arm/boot/dts/testcases/tests.dtsi | 1 + drivers/of/selftest.c | 91 +++++++++++++++++++++-- 3 files changed, 127 insertions(+), 6 deletions(-) create mode 100644 arch/arm/boot/dts/testcases/tests-interrupts.dtsi
arch/arm/boot/dts/testcases/tests-interrupts.dtsi new file +41 -0
@@ -0,0 +1,41 @@ + +/ { + testcase-data { + interrupts { + #address-cells = <0>; + test_intc0: intc0 { + interrupt-controller; + #interrupt-cells = <1>; + }; + + test_intc1: intc1 { + interrupt-controller; + #interrupt-cells = <3>; + }; + + test_intc2: intc2 { + interrupt-controller; + #interrupt-cells = <2>; + }; + + test_intmap0: intmap0 { + #interrupt-cells = <1>; + #address-cells = <0>; + interrupt-map = <1 &test_intc0 9>, + <2 &test_intc1 10 11 12>, + <3 &test_intc2 13 14>, + <4 &test_intc2 15 16>; + }; + + interrupts0 { + interrupt-parent = <&test_intc0>; + interrupts = <1>, <2>, <3>, <4>; + }; + + interrupts1 { + interrupt-parent = <&test_intmap0>; + interrupts = <1>, <2>, <3>, <4>; + }; + }; + }; +};
arch/arm/boot/dts/testcases/tests.dtsi +1 -0
@@ -1 +1,2 @@ /include/ "tests-phandle.dtsi" +/include/ "tests-interrupts.dtsi"
drivers/of/selftest.c +85 -6
123 lines not on this page · raw message
Signature · 6 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
RFC 7/9 of/irq: Create of_irq_parse_and_map_pci() to consolidate arch code.
In reply to Grant LikelySeveral architectures open code effectively the same code block for finding and mapping PCI irqs. This patch consolidates it down to a single function.
--- arch/arm/mach-integrator/pci_v3.c | 17 +---------------- arch/mips/pci/fixup-lantiq.c | 12 +----------- arch/mips/pci/pci-rt3883.c | 22 +--------------------- arch/x86/kernel/devicetree.c | 7 +------ drivers/of/of_pci_irq.c | 25 +++++++++++++++++++++++++ drivers/pci/host/pci-mvebu.c | 14 +------------- include/linux/of_pci.h | 1 + 7 files changed, 31 insertions(+), 67 deletions(-)
arch/arm/mach-integrator/pci_v3.c +1 -16
@@ -835,21 +835,6 @@ static struct hw_pci pci_v3 __initdata = {#ifdef CONFIG_OF -static int __init pci_v3_map_irq_dt (const struct pci_dev *dev,u8 slot,u8 pin) -{ -struct of_phandle_args oirq; -int ret; - - ret =of_irq_parse_pci (dev, &oirq); -if (ret) { -dev_err (&dev->dev,"of_irq_parse_pci() %d\n" , ret); -/* Proper return code 0 == NO_IRQ */ -return 0 ; - } - -return irq_create_of_mapping (&oirq); -} -static int __init pci_v3_dtprobe (struct platform_device *pdev,struct device_node *np) {
@@ -918,7 +903,7 @@ static int __init pci_v3_dtprobe(struct platform_device *pdev,return -EINVAL ; } - pci_v3.map_irq = pci_v3_map_irq_dt; + pci_v3.map_irq = of_irq_parse_and_map_pci;pci_common_init_dev (&pdev->dev, &pci_v3);return 0 ;
arch/mips/pci/fixup-lantiq.c +1 -11
@@ -25,15 +25,5 @@ int pcibios_plat_dev_init(struct pci_dev *dev)int __init pcibios_map_irq (const struct pci_dev *dev,u8 slot,u8 pin) { -struct of_phandle_args dev_irq; -int irq; - -if (of_irq_parse_pci (dev, &dev_irq)) { -dev_err (&dev->dev,"trying to map irq for unknown slot:%d pin:%d\n" , - slot, pin); -return 0 ; - } - irq =irq_create_of_mapping (&dev_irq); -dev_info (&dev->dev,"SLOT:%d PIN:%d IRQ:%d\n" , slot, pin, irq); -return irq; +return of_irq_parse_and_map_pci (dev, slot, pin); }
arch/mips/pci/pci-rt3883.c +1 -21
@@ -583,27 +583,7 @@ err_put_intc_node:int __init pcibios_map_irq (const struct pci_dev *dev,u8 slot,u8 pin) { -struct of_phandle_args dev_irq; -int err; -int irq; - - err =of_irq_parse_pci (dev, &dev_irq); -if (err) { -pr_err ("pci %s: unable to get irq map, err=%d\n" , -pci_name ((struct pci_dev *) dev), err); -return 0 ; - } - - irq =irq_create_of_mapping (&dev_irq); - -if (irq ==0 ) -pr_crit ("pci %s: no irq found for pin %u\n" , -pci_name ((struct pci_dev *) dev), pin); -else -pr_info ("pci %s: using irq %d for pin %u\n" , -pci_name ((struct pci_dev *) dev), irq, pin); - -return irq; +return of_irq_parse_and_map_pci (dev, slot, pin); }int pcibios_plat_dev_init (struct pci_dev *dev)
arch/x86/kernel/devicetree.c +1 -6
@@ -105,7 +105,6 @@ struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)static int x86_of_pci_irq_enable (struct pci_dev *dev) { -struct of_phandle_args oirq;u32 virq;int ret;u8 pin;
@@ -116,11 +115,7 @@ static int x86_of_pci_irq_enable(struct pci_dev *dev)if (!pin)return 0 ; - ret =of_irq_parse_pci (dev, &oirq); -if (ret) -return ret; - - virq =irq_create_of_mapping (&oirq); + virq =of_irq_parse_and_map_pci (dev,0 ,0 );if (virq ==0 )return -EINVAL ; dev->irq = virq;
drivers/of/of_pci_irq.c +25 -0
@@ -94,3 +94,28 @@ int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irqreturn of_irq_parse_raw (laddr, out_irq); }EXPORT_SYMBOL_GPL (of_irq_parse_pci); + +/** +* of_irq_parse_and_map_pci() - Decode a PCI irq from the device tree and map to a virq +* @dev: The pci device needing an irq +* @slot: PCI slot number; passed when used as map_irq callback. Unused +* @pin: PCI irq pin number; passed when used as map_irq callback. Unused +* +* @slot and @pin are unused, but included in the function so that this +* function can be used directly as the map_irq callback to pci_fixup_irqs(). +*/ +int of_irq_parse_and_map_pci (const struct pci_dev *dev,u8 slot,u8 pin) +{ +struct of_phandle_args oirq; +int ret; + + ret =of_irq_parse_pci (dev, &oirq); +if (ret) { +dev_err (&dev->dev,"of_irq_parse_pci() failed with rc=%d\n" , ret); +return 0 ;/* Proper return code 0 == NO_IRQ */ + } + +return irq_create_of_mapping (&oirq); +} +EXPORT_SYMBOL_GPL (of_irq_parse_and_map_pci); +
drivers/pci/host/pci-mvebu.c +1 -13
@@ -645,18 +645,6 @@ static int __init mvebu_pcie_setup(int nr, struct pci_sys_data *sys)return 1 ; } -static int __init mvebu_pcie_map_irq (const struct pci_dev *dev,u8 slot,u8 pin) -{ -struct of_phandle_args oirq; -int ret; - - ret =of_irq_parse_pci (dev, &oirq); -if (ret) -return ret; - -return irq_create_of_mapping (&oirq); -} -static struct pci_bus *mvebu_pcie_scan_bus (int nr,struct pci_sys_data *sys) {struct mvebu_pcie *pcie =sys_to_pcie (sys);
@@ -705,7 +693,7 @@ static void __init mvebu_pcie_enable(struct mvebu_pcie *pcie) hw.private_data = (void **)&pcie; hw.setup = mvebu_pcie_setup; hw.scan = mvebu_pcie_scan_bus; - hw.map_irq = mvebu_pcie_map_irq; + hw.map_irq = of_irq_parse_and_map_pci; hw.ops = &mvebu_pcie_ops; hw.align_resource = mvebu_pcie_align_resource;
include/linux/of_pci.h +1 -0
@@ -7,6 +7,7 @@struct pci_dev ;struct of_phandle_args ;int of_irq_parse_pci (const struct pci_dev *pdev,struct of_phandle_args *out_irq); +int of_irq_parse_and_map_pci (const struct pci_dev *dev,u8 slot,u8 pin);struct device_node ; struct device_node *of_pci_find_child_device(struct device_node *parent,
Signature · 1 line
1.8.1.2
RFC 8/9 microblaze/pci: Drop PowerPC-ism from irq parsing
In reply to Grant LikelyThe Microblaze PCI code copied the PowerPC irq handling, but powerpc needs to handle broken device trees that are not present on Microblaze. This patch removes the powerpc special case and replaces it with a direct of_irq_parse_and_map_pci() call.
--- arch/microblaze/include/asm/pci.h | 2 -- arch/microblaze/pci/pci-common.c | 71 +-------------------------------------- 2 files changed, 1 insertion(+), 72 deletions(-)
arch/microblaze/include/asm/pci.h +0 -2
@@ -127,8 +127,6 @@ extern void of_scan_pci_bridge(struct device_node *node,extern void of_scan_bus (struct device_node *node,struct pci_bus *bus);extern void of_rescan_bus (struct device_node *node,struct pci_bus *bus); -extern int pci_read_irq_line (struct pci_dev *dev); -extern int pci_bus_find_capability (struct pci_bus *bus,unsigned int devfn,int cap);
arch/microblaze/pci/pci-common.c +1 -70
83 lines not on this page · raw message
Signature · 1 line
1.8.1.2
RFC 9/9 of/irq: create interrupts-extended property
In reply to Grant LikelyThe standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +23 -6
@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in the +"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; + +A device node may contain either "interrupts" or "interrupts-extended", but not +both. If both properties are present, then the operating system should log an +error and use only the data in "interrupts". 2) Interrupt controller nodes -----------------------------
arch/arm/boot/dts/testcases/tests-interrupts.dtsi +16 -0
@@ -27,6 +27,12 @@ <4 &test_intc2 15 16>; }; + test_intmap1: intmap1 { + #interrupt-cells = <2>; + #address-cells = <0>; + interrupt-map = <1 2 &test_intc0 15>; + }; + interrupts0 { interrupt-parent = <&test_intc0>; interrupts = <1>, <2>, <3>, <4>;
@@ -36,6 +42,16 @@ interrupt-parent = <&test_intmap0>; interrupts = <1>, <2>, <3>, <4>; }; + + interrupts-extended0 { + interrupts-extended = <&test_intc0 1>, + <&test_intc1 2 3 4>, + <&test_intc2 5 6>, + <&test_intmap0 1>, + <&test_intmap0 2>, + <&test_intmap0 3>, + <&test_intmap1 1 2>; + }; }; }; };
arch/arm/boot/dts/versatile-ab.dts +1 -1
@@ -185,7 +185,7 @@ mmc@5000 { compatible = "arm,primecell"; reg = < 0x5000 0x1000>; - interrupts = <22 34>; + interrupts-extended = <&vic 22 &sic 2>; }; kmi@6000 { compatible = "arm,pl050", "arm,primecell";
arch/arm/boot/dts/versatile-pb.dts +1 -1
@@ -41,7 +41,7 @@ mmc@b000 { compatible = "arm,primecell"; reg = <0xb000 0x1000>; - interrupts = <23 34>; + interrupts-extended = <&vic 23 &sic 2>; }; }; };
drivers/of/irq.c +11 -5
@@ -292,17 +292,23 @@ int of_irq_parse_one(struct device_node *device, int index, struct of_phandle_arif (of_irq_workarounds &OF_IMAP_OLDWORLD_MAC )return of_irq_parse_oldworld (device, index, out_irq); +/* Get the reg property (if any) */ + addr =of_get_property (device,"reg" ,NULL ); +/* Get the interrupts property */ intspec =of_get_property (device,"interrupts" , &intlen); -if (intspec ==NULL ) -return -EINVAL ; +if (intspec ==NULL ) { +/* Try the new-style interrupts-extended */ + res =of_parse_phandle_with_args (device,"interrupts-extended" , +"#interrupt-cells" , index, out_irq); +if (res) +return -EINVAL ; +return of_irq_parse_raw (addr, out_irq); + } intlen /=sizeof (*intspec);pr_debug (" intspec=%d intlen=%d\n" ,be32_to_cpup (intspec), intlen); -/* Get the reg property (if any) */ - addr =of_get_property (device,"reg" ,NULL ); -/* Look for the interrupt parent. */ p =of_irq_find_parent (device);if (p ==NULL )
drivers/of/selftest.c +70 -0
82 lines not on this page · raw message
Signature · 6 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 8 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
Quoted 6 lines
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <[email protected]>
Works for me and solves the issue for devices with interrupts from multiple interrupt controllers:
Re: [RFC 9/9] of/irq: create interrupts-extended property
In reply to Grant LikelyQuoted 8 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
Quoted 6 lines
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <[email protected]>
Alright, I want to merge this one. I've got an Ack from Tony, general agreement from an in person converstaion from Ben (aside from wishing he could think of a better property name), and various rumblings of approval from anyone I talked to about it at ksummit. I'd like to have something more that that to put into the commit text. Please take a look and let me know if you agree/disagree with this binding.
g.
Quoted 237 lines
--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +23
-6@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in the +"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; + +A device node may contain either "interrupts" or "interrupts-extended", but not +both. If both properties are present, then the operating system should log an +error and use only the data in "interrupts". 2) Interrupt controller nodes -----------------------------arch/arm/boot/dts/testcases/tests-interrupts.dtsi +16
-0@@ -27,6 +27,12 @@ <4 &test_intc2 15 16>; }; + test_intmap1: intmap1 { + #interrupt-cells = <2>; + #address-cells = <0>; + interrupt-map = <1 2 &test_intc0 15>; + }; + interrupts0 { interrupt-parent = <&test_intc0>; interrupts = <1>, <2>, <3>, <4>;@@ -36,6 +42,16 @@ interrupt-parent = <&test_intmap0>; interrupts = <1>, <2>, <3>, <4>; }; + + interrupts-extended0 { + interrupts-extended = <&test_intc0 1>, + <&test_intc1 2 3 4>, + <&test_intc2 5 6>, + <&test_intmap0 1>, + <&test_intmap0 2>, + <&test_intmap0 3>, + <&test_intmap1 1 2>; + }; }; }; };arch/arm/boot/dts/versatile-ab.dts +1
-1@@ -185,7 +185,7 @@ mmc@5000 { compatible = "arm,primecell"; reg = < 0x5000 0x1000>; - interrupts = <22 34>; + interrupts-extended = <&vic 22 &sic 2>; }; kmi@6000 { compatible = "arm,pl050", "arm,primecell";arch/arm/boot/dts/versatile-pb.dts +1
-1@@ -41,7 +41,7 @@ mmc@b000 { compatible = "arm,primecell"; reg = <0xb000 0x1000>; - interrupts = <23 34>; + interrupts-extended = <&vic 23 &sic 2>; }; }; };drivers/of/irq.c +11
-5@@ -292,17 +292,23 @@ int of_irq_parse_one(struct device_node *device, int index, struct of_phandle_arif (of_irq_workarounds &OF_IMAP_OLDWORLD_MAC )return of_irq_parse_oldworld (device, index, out_irq); +/* Get the reg property (if any) */ + addr =of_get_property (device,"reg" ,NULL ); +/* Get the interrupts property */ intspec =of_get_property (device,"interrupts" , &intlen); -if (intspec ==NULL ) -return -EINVAL ; +if (intspec ==NULL ) { +/* Try the new-style interrupts-extended */ + res =of_parse_phandle_with_args (device,"interrupts-extended" , +"#interrupt-cells" , index, out_irq); +if (res) +return -EINVAL ; +return of_irq_parse_raw (addr, out_irq); + } intlen /=sizeof (*intspec);pr_debug (" intspec=%d intlen=%d\n" ,be32_to_cpup (intspec), intlen); -/* Get the reg property (if any) */ - addr =of_get_property (device,"reg" ,NULL ); -/* Look for the interrupt parent. */ p =of_irq_find_parent (device);if (p ==NULL )drivers/of/selftest.c +70
-0@@ -231,6 +231,75 @@ static void __init of_selftest_parse_interrupts(void)of_node_put (np); } +static void __init of_selftest_parse_interrupts_extended (void ) +{ +struct device_node *np; +struct of_phandle_args args; +int i, rc; + + np =of_find_node_by_path ("/testcase-data/interrupts/interrupts-extended0" ); +if (!np) { +pr_err ("missing testcase data\n" ); +return ; + } + +for (i =0 ; i <7 ; i++) { +bool passed = true; + rc =of_irq_parse_one (np, i, &args); + +/* Test the values from tests-phandle.dtsi */ +switch (i) { +case 0 : + passed &= !rc; + passed &= (args.args_count ==1 ); + passed &= (args.args[0 ] ==1 ); +break ; +case 1 : + passed &= !rc; + passed &= (args.args_count ==3 ); + passed &= (args.args[0 ] ==2 ); + passed &= (args.args[1 ] ==3 ); + passed &= (args.args[2 ] ==4 ); +break ; +case 2 : + passed &= !rc; + passed &= (args.args_count ==2 ); + passed &= (args.args[0 ] ==5 ); + passed &= (args.args[1 ] ==6 ); +break ; +case 3 : + passed &= !rc; + passed &= (args.args_count ==1 ); + passed &= (args.args[0 ] ==9 ); +break ; +case 4 : + passed &= !rc; + passed &= (args.args_count ==3 ); + passed &= (args.args[0 ] ==10 ); + passed &= (args.args[1 ] ==11 ); + passed &= (args.args[2 ] ==12 ); +break ; +case 5 : + passed &= !rc; + passed &= (args.args_count ==2 ); + passed &= (args.args[0 ] ==13 ); + passed &= (args.args[1 ] ==14 ); +break ; +case 6 : + passed &= !rc; + passed &= (args.args_count ==1 ); + passed &= (args.args[0 ] ==15 ); +break ; +default : + passed = false; + } + +selftest (passed,"index %i - data error on node %s rc=%i\n" , + i, args.np->full_name, rc); + } +of_node_put (np); +} +static int __init of_selftest (void ) {struct device_node *np;@@ -246,6 +315,7 @@ static int __init of_selftest(void)of_selftest_parse_phandle_with_args ();of_selftest_property_match_string ();of_selftest_parse_interrupts (); +of_selftest_parse_interrupts_extended ();pr_info ("end of selftest - %i passed, %i failed\n" , selftest_results.passed, selftest_results.failed);return 0 ;Signature · 1 line
1.8.1.2
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 16 lines · Grant Likely
Quoted 8 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
Quoted 6 lines
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <[email protected]>
Quoted 6 lines
Alright, I want to merge this one. I've got an Ack from Tony, general agreement from an in person converstaion from Ben (aside from wishing he could think of a better property name), and various rumblings of approval from anyone I talked to about it at ksummit. I'd like to have something more that that to put into the commit text. Please take a look and let me know if you agree/disagree with this binding.
I think it looks fine, but I'll throw out an alternative proposal. Simply allow for interrupt-parent to be an array in equal size to interrupts property. Then it is a minimal change to the existing binding:
interrupt-parent = <&intc1>, <&intc2>;
interrupts = <5 0>, <6 0>;
Of course interrupts-extended is more inline with standard patterns for bindings.
Rob
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 17 lines · Rob Herring
Quoted 16 lines · Grant Likely
Quoted 14 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <[email protected]>
Quoted 6 lines
Quoted 6 lines
Alright, I want to merge this one. I've got an Ack from Tony, general agreement from an in person converstaion from Ben (aside from wishing he could think of a better property name), and various rumblings of approval from anyone I talked to about it at ksummit. I'd like to have something more that that to put into the commit text. Please take a look and let me know if you agree/disagree with this binding.
The only comment I have is that I'm not keen on the name (it's a bit generic and we might want to extend the interrupts binding in future), but I'm happy to leave that as a matter of personal taste.
The best alternative I could come up with was parented-interrupts, but that could be misinterpreted as describing the relationship backwards (i.e. this device is the parent for those interrupts).
Quoted 8 lines
I think it looks fine, but I'll throw out an alternative proposal. Simply allow for interrupt-parent to be an array in equal size to interrupts property. Then it is a minimal change to the existing binding:
interrupt-parent = <&intc1>, <&intc2>;
interrupts = <5 0>, <6 0>;
I'd prefer the interrupts-extended approach.
This might not matter, but if you have an existing driver with two interrupts, and you attempt to describe the situation this way, e.g.
intc1: interrupt_controller1 {
compatible = "vendor,interrupt-controller";
#interrupt-cells = <1>;
};
intc2: interrupt_controller2 {
compatible = "vendor,another-interrupt-controller";
#interrupt-cells = <2>;
};
dev {
compatible = "vendor,some-device";
interrupt-parent = <&intc1>, <&intc2>;
interrupts = <5>, <65 73>;
};The existing driver may read interrupts as two interrupts for intc1, and believe it's been successful when it has not, and one of those interrupts might never fire. That would be very bad for a timer for example.
Additionally it makes the interrupts list difficult for a human to read, as you need to match it with an entry in another list (this problem exists with other parallel properties like interrupt-names too, but we can't do much better there).
It's also easy to make a typo (e.g. an extra cell in an interrupt) that will parse as valid when you don't expect it to. At least with the phandle in the list it's less likely to happen.
Quoted 3 lines
Of course interrupts-extended is more inline with standard patterns for bindings.
I think for this reason alone it should be preferable. Unless I'm mistaken it would be identical to the clock bindings pattern with a uniformly named phandle+args property and a parallel -names property. I don't think the gpio style ${NAME}-interrupts would easily fit here.
Thanks,
Mark.
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 25 lines · Mark Rutland
Quoted 17 lines · Rob Herring
Quoted 16 lines · Grant Likely
Quoted 14 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>Quoted 6 lines
Quoted 6 lines
Alright, I want to merge this one. I've got an Ack from Tony, general agreement from an in person converstaion from Ben (aside from wishing he could think of a better property name), and various rumblings of approval from anyone I talked to about it at ksummit. I'd like to have something more that that to put into the commit text. Please take a look and let me know if you agree/disagree with this binding.
Quoted 7 lines
The only comment I have is that I'm not keen on the name (it's a bit generic and we might want to extend the interrupts binding in future), but I'm happy to leave that as a matter of personal taste.
The best alternative I could come up with was parented-interrupts, but that could be misinterpreted as describing the relationship backwards (i.e. this device is the parent for those interrupts).
I think we seem to all agree the name sucks, but can't come up with anything better.
Quoted 33 lines
Quoted 7 lines
I think it looks fine, but I'll throw out an alternative proposal. Simply allow for interrupt-parent to be an array in equal size to interrupts property. Then it is a minimal change to the existing binding:
interrupt-parent = <&intc1>, <&intc2>;
interrupts = <5 0>, <6 0>;I'd prefer the interrupts-extended approach.
This might not matter, but if you have an existing driver with two interrupts, and you attempt to describe the situation this way, e.g.
intc1: interrupt_controller1 { compatible = "vendor,interrupt-controller"; #interrupt-cells = <1>;};
intc2: interrupt_controller2 { compatible = "vendor,another-interrupt-controller"; #interrupt-cells = <2>;};
dev { compatible = "vendor,some-device"; interrupt-parent = <&intc1>, <&intc2>; interrupts = <5>, <65 73>;};
The existing driver may read interrupts as two interrupts for intc1, and believe it's been successful when it has not, and one of those interrupts might never fire. That would be very bad for a timer for example.
Quoted 8 lines
Additionally it makes the interrupts list difficult for a human to read, as you need to match it with an entry in another list (this problem exists with other parallel properties like interrupt-names too, but we can't do much better there).
It's also easy to make a typo (e.g. an extra cell in an interrupt) that will parse as valid when you don't expect it to. At least with the phandle in the list it's less likely to happen.
I agreed, I'd assume that in Rob's suggestion the length of interrupt-parent & interrupts would have to match so you'd have:
dev {
compatible = "vendor,some-device";
interrupt-parent = <&intc1>, <&intc2>, <&intc2>;
interrupts = <5>, <65 73>;};
Quoted 5 lines
Quoted 4 lines
Of course interrupts-extended is more inline with standard patterns for bindings.
Quoted 7 lines
I think for this reason alone it should be preferable. Unless I'm mistaken it would be identical to the clock bindings pattern with a uniformly named phandle+args property and a parallel -names property. I don't think the gpio style ${NAME}-interrupts would easily fit here.
Thanks,
Mark.
- k
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Stephen Warren
Acked-byRe: [RFC 9/9] of/irq: create interrupts-extended property
In reply to Grant LikelyQuoted 16 lines · Grant Likely
Quoted 8 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
Quoted 6 lines
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>
Quoted 6 lines
Alright, I want to merge this one. I've got an Ack from Tony, general agreement from an in person converstaion from Ben (aside from wishing he could think of a better property name), and various rumblings of approval from anyone I talked to about it at ksummit. I'd like to have something more that that to put into the commit text. Please take a look and let me know if you agree/disagree with this binding.
The new binding makes sense to me. So, the binding,
A couple of minor perhaps bikesheddy comments below.
Quoted 4 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 8
Quoted 4 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +2
-0+Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties
"interrupts-ex" would be shorter, although I guess slightly harder to guess its purpose, unless you're familiar with "ex" in symbol names.
...
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +3
-0+A device node may contain either "interrupts" or "interrupts-extended", but not +both. If both properties are present, then the operating system should log an +error
That sounds rather like prescribing SW behaviour, which I thought DT bindings shouldn't do?
Quoted 1 line
Quoted 1 line
and use only the data in "interrupts".
... so perhaps that's better phrased as:
A device node may contain either "interrupts" or "interrupts-extended", but not both. If both properties are present, the data in "interrupts" takes precedence.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 29 lines · Stephen Warren
Quoted 16 lines · Grant Likely
Quoted 8 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
Quoted 6 lines
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <[email protected]>Quoted 6 lines
Alright, I want to merge this one. I've got an Ack from Tony, general agreement from an in person converstaion from Ben (aside from wishing he could think of a better property name), and various rumblings of approval from anyone I talked to about it at ksummit. I'd like to have something more that that to put into the commit text. Please take a look and let me know if you agree/disagree with this binding.
The new binding makes sense to me. So, the binding,
Acked-by Stephen Warren <[email protected]>A couple of minor perhaps bikesheddy comments below.
Quoted 7 lines
Quoted 4 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 8
Quoted 4 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +2
-0+Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties"interrupts-ex" would be shorter, although I guess slightly harder to guess its purpose, unless you're familiar with "ex" in symbol names.
I'd prefer a more precise name. IMO "-extended" is preferable to "-ex".
Quoted 8 lines
...
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +3
-0+A device node may contain either "interrupts" or "interrupts-extended", but not +both. If both properties are present, then the operating system should log an +errorThat sounds rather like prescribing SW behaviour, which I thought DT bindings shouldn't do?
I think recommending a behaviour relating to parsing is valid. Parsing notes in bindings make it very easy to write an extensible binding. I think if we'd just stated that having both properties was invalid you would not have a problem?
Quoted 9 lines
Quoted 2 lines
Quoted 2 lines
and use only the data in "interrupts".
... so perhaps that's better phrased as:
A device node may contain either "interrupts" or "interrupts-extended", but not both. If both properties are present, the data in "interrupts" takes precedence.
This sounds reasonable to me, but I'd definitely want the kernel to scream (though I appreciate that's separate from the binding details).
Thanks,
Mark.
Re: [RFC 9/9] of/irq: create interrupts-extended property
In reply to Stephen WarrenQuoted 11 lines · Stephen Warren
"interrupts-ex" would be shorter, although I guess slightly harder to guess its purpose, unless you're familiar with "ex" in symbol names.
...
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +3
-0+A device node may contain either "interrupts" or "interrupts-extended", but not +both. If both properties are present, then the operating system should log an +errorThat sounds rather like prescribing SW behaviour, which I thought DT bindings shouldn't do?
Quoted 7 lines
Quoted 1 line
Quoted 1 line
and use only the data in "interrupts".
... so perhaps that's better phrased as:
A device node may contain either "interrupts" or "interrupts-extended", but not both. If both properties are present, the data in "interrupts" takes precedence.
So let's add a coat of paint to this shed :-)
Either it's an error, or we have a precedence rule. If it's an error then there is no point having a precedence rule, the DT is broken and might be in all sort of other ways, the precedence is pointless, there's no telling what property is correct.
However, if we have a precedence rule, then it should be the other way around, interrupts-extended takes precedence.
A concrete example:
A device has two interrupts "INT0" and "INT1". One goes to PICA, the other one to PICB,
the first one is necessary for basic use, the second one is only necessary for some advanced/new functionality.
It makes sense in this case to have the device-tree do:
interrupts = < INT0 >; interrupt-parent = <&PICA>; interrupts-extended = <&PICA, INT0, &PICB, INT1>;
Because that way:
- An old kernel which doesn't understand interrupts-extended but *also*
only uses the first interrupt (doesn't exploit the advanced/new functionalities) will work by picking up interrupts+interrupt-parent,
- A newer kernel which does understand interrupts-extended can then
make use of it to support the advanced/new functionalities.
Cheers,
Ben.
Re: [RFC 9/9] of/irq: create interrupts-extended property
In reply to Grant LikelyQuoted 14 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>
Quoted 8 lines
---
.../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)
[ I think the patch should be split up so we aren't touching versatile dts as part of it ]
- k
Signature · 7 lines
Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 26 lines · Kumar Gala
Quoted 14 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>Quoted 8 lines
---
.../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)
Quoted 3 lines
Acked-by Kumar Gala <[email protected]>[ I think the patch should be split up so we aren't touching versatile dts as part of it ]
No problem, I'll do that.
g.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
In reply to Grant LikelyHi Grant,
Quoted 51 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-6@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in the
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 30
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-0+"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; +
A slightly different but related problem I am trying to solve with interrupt bindings, is to describe connection of a single device interrupt line to multiple interrupts controller, whereas this binding seems to be describing connection of different interrupt lines to different controllers. Can this syntax accommodate my case is any way?
Bascially I think I'm asking for multiple interrupt specifiers for a single IRQ output if that's possible.
Should I just be using the interrupt map syntax instead?
interrupt-map-mask = < 0 0 63>;
interrupt-map = < 0 0 25 &intc0 ... >, < 0 0 25 &intc1 ... >,
Regards,
Peter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 71 lines · Peter Crosthwaite
Hi Grant,
Quoted 51 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-6@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in theDocumentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 30
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-0+"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; +A slightly different but related problem I am trying to solve with interrupt bindings, is to describe connection of a single device interrupt line to multiple interrupts controller, whereas this binding seems to be describing connection of different interrupt lines to different controllers. Can this syntax accommodate my case is any way?
Quoted 7 lines
Bascially I think I'm asking for multiple interrupt specifiers for a single IRQ output if that's possible.
Should I just be using the interrupt map syntax instead?
interrupt-map-mask = < 0 0 63>;
interrupt-map = < 0 0 25 &intc0 ... >, < 0 0 25 &intc1 ... >,
Interrupt map doesn't actually help you here either since the core code doesn't know what to do with it. It will probably only match and return one of the options.
What I would do is describe both in your interrupts property and make the driver know that the extra interrupt specifier is for the same interrupt output.
g.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Hi Grant,
Quoted 75 lines · Grant Likely
Quoted 74 lines · Peter Crosthwaite
Hi Grant,
Quoted 51 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-6@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in theDocumentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 30
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-0+"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; +A slightly different but related problem I am trying to solve with interrupt bindings, is to describe connection of a single device interrupt line to multiple interrupts controller, whereas this binding seems to be describing connection of different interrupt lines to different controllers. Can this syntax accommodate my case is any way?
Bascially I think I'm asking for multiple interrupt specifiers for a single IRQ output if that's possible.
Quoted 9 lines
Quoted 4 lines
Should I just be using the interrupt map syntax instead?
interrupt-map-mask = < 0 0 63>;
interrupt-map = < 0 0 25 &intc0 ... >, < 0 0 25 &intc1 ... >,Interrupt map doesn't actually help you here either since the core code doesn't know what to do with it. It will probably only match and return one of the options.
Yes I noticed that. Although we are a fair way off Linux patches for this just yet and all I want to solve near-term is the hardware description problem (what core Linux IRQ code is actually supposed to do when given such a wiring setup is probably an open question).
Quoted 4 lines
What I would do is describe both in your interrupts property and make the driver know that the extra interrupt specifier is for the same interrupt output.
So this is a little annoying, as ideally device drivers should not be aware of their external connections. I'm trying to describe board (or SoC) level wiring in hopefully a way that doesn't require individual driver awareness. It also gets very messy when you have multiple interrupt outputs that are each in themselves connected to multiple interrupt controllers (which happens to be my situation). The meaning of multiple tuples becomes ambiguous.
Is the interrupt-map system I proposed acceptable long-term from just a pure binding acceptability standpoint? The driver side solution is also a large change pattern as I'm using this with Xilinx Zynq which has a large number of peripherals, any of which could be multiply-connected to both A9GIC and soft intc's in FPGA fabric.
Thanks and Regards,
Peter
Quoted 6 lines
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 106 lines · Peter Crosthwaite
Hi Grant,
Quoted 75 lines · Grant Likely
Quoted 74 lines · Peter Crosthwaite
Hi Grant,
Quoted 51 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-6@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in theDocumentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 30
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-0+"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; +A slightly different but related problem I am trying to solve with interrupt bindings, is to describe connection of a single device interrupt line to multiple interrupts controller, whereas this binding seems to be describing connection of different interrupt lines to different controllers. Can this syntax accommodate my case is any way?
Bascially I think I'm asking for multiple interrupt specifiers for a single IRQ output if that's possible.
Quoted 9 lines
Quoted 4 lines
Should I just be using the interrupt map syntax instead?
interrupt-map-mask = < 0 0 63>;
interrupt-map = < 0 0 25 &intc0 ... >, < 0 0 25 &intc1 ... >,Interrupt map doesn't actually help you here either since the core code doesn't know what to do with it. It will probably only match and return one of the options.
Yes I noticed that. Although we are a fair way off Linux patches for this just yet and all I want to solve near-term is the hardware description problem (what core Linux IRQ code is actually supposed to do when given such a wiring setup is probably an open question).
Quoted 4 lines
What I would do is describe both in your interrupts property and make the driver know that the extra interrupt specifier is for the same interrupt output.
So this is a little annoying, as ideally device drivers should not be aware of their external connections. I'm trying to describe board (or SoC) level wiring in hopefully a way that doesn't require individual driver awareness. It also gets very messy when you have multiple interrupt outputs that are each in themselves connected to multiple interrupt controllers (which happens to be my situation). The meaning of multiple tuples becomes ambiguous.
Quoted 5 lines
Is the interrupt-map system I proposed acceptable long-term from just a pure binding acceptability standpoint? The driver side solution is also a large change pattern as I'm using this with Xilinx Zynq which has a large number of peripherals, any of which could be multiply-connected to both A9GIC and soft intc's in FPGA fabric.
Well, it isn't actively dangerous, but it really isn't a very good description either. There is no information about what the difference would be between the different connection options. The kernel certainly cannot do anything intelligent with it.
You'd probably be better off with an IRQ mux node and associated driver that chooses the appropriate connection and makes the behaviour transparent to the device driver. That way you'd have a place to embed the knowledge of how to make good decisions.
g.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 118 lines · Grant Likely
Quoted 106 lines · Peter Crosthwaite
Hi Grant,
Quoted 75 lines · Grant Likely
Quoted 74 lines · Peter Crosthwaite
Hi Grant,
Quoted 51 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <rob.herring-bsGFqQB8/[email protected]>--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-6@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in theDocumentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 30
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-0+"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; +A slightly different but related problem I am trying to solve with interrupt bindings, is to describe connection of a single device interrupt line to multiple interrupts controller, whereas this binding seems to be describing connection of different interrupt lines to different controllers. Can this syntax accommodate my case is any way?
Bascially I think I'm asking for multiple interrupt specifiers for a single IRQ output if that's possible.
Quoted 9 lines
Quoted 4 lines
Should I just be using the interrupt map syntax instead?
interrupt-map-mask = < 0 0 63>;
interrupt-map = < 0 0 25 &intc0 ... >, < 0 0 25 &intc1 ... >,Interrupt map doesn't actually help you here either since the core code doesn't know what to do with it. It will probably only match and return one of the options.
Yes I noticed that. Although we are a fair way off Linux patches for this just yet and all I want to solve near-term is the hardware description problem (what core Linux IRQ code is actually supposed to do when given such a wiring setup is probably an open question).
Quoted 4 lines
What I would do is describe both in your interrupts property and make the driver know that the extra interrupt specifier is for the same interrupt output.
So this is a little annoying, as ideally device drivers should not be aware of their external connections. I'm trying to describe board (or SoC) level wiring in hopefully a way that doesn't require individual driver awareness. It also gets very messy when you have multiple interrupt outputs that are each in themselves connected to multiple interrupt controllers (which happens to be my situation). The meaning of multiple tuples becomes ambiguous.
Quoted 5 lines
Is the interrupt-map system I proposed acceptable long-term from just a pure binding acceptability standpoint? The driver side solution is also a large change pattern as I'm using this with Xilinx Zynq which has a large number of peripherals, any of which could be multiply-connected to both A9GIC and soft intc's in FPGA fabric.
Well, it isn't actively dangerous, but it really isn't a very good description either. There is no information about what the difference would be between the different connection options. The kernel certainly cannot do anything intelligent with it.
Quoted 5 lines
You'd probably be better off with an IRQ mux node and associated driver that chooses the appropriate connection and makes the behaviour transparent to the device driver. That way you'd have a place to embed the knowledge of how to make good decisions.
Hi Grant,
That sounds good, and it avoids me having to deal with that interrupt-map crazyness. Here's a first attempt at this form of syntax:
foo_irq_mux {
#interrupt-cells = 0;
comaptible = "irq-mux";
interrupts-extended = < &intc0 0 1 >,< &intc1 2 3 >;
/* descision making info goes here */
};foo : foo@deadbeef {
compatible = "vendor,foo";
interrupts-extended = <&foo_irq_mux>;
}It's going to get a little verbose once you start making multiple connections as you need one mux per wire. Perhaps it could be cleaned up by making the foo_irq_mux node(s) a child of foo?
Regards,
Peter
Quoted 2 lines
g.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 144 lines · Peter Crosthwaite
Quoted 118 lines · Grant Likely
Quoted 106 lines · Peter Crosthwaite
Hi Grant,
Quoted 75 lines · Grant Likely
Quoted 74 lines · Peter Crosthwaite
Hi Grant,
Quoted 51 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <[email protected]>--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-6@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in theDocumentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 30
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-0+"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; +A slightly different but related problem I am trying to solve with interrupt bindings, is to describe connection of a single device interrupt line to multiple interrupts controller, whereas this binding seems to be describing connection of different interrupt lines to different controllers. Can this syntax accommodate my case is any way?
Bascially I think I'm asking for multiple interrupt specifiers for a single IRQ output if that's possible.
Quoted 9 lines
Quoted 4 lines
Should I just be using the interrupt map syntax instead?
interrupt-map-mask = < 0 0 63>;
interrupt-map = < 0 0 25 &intc0 ... >, < 0 0 25 &intc1 ... >,Interrupt map doesn't actually help you here either since the core code doesn't know what to do with it. It will probably only match and return one of the options.
Yes I noticed that. Although we are a fair way off Linux patches for this just yet and all I want to solve near-term is the hardware description problem (what core Linux IRQ code is actually supposed to do when given such a wiring setup is probably an open question).
Quoted 4 lines
What I would do is describe both in your interrupts property and make the driver know that the extra interrupt specifier is for the same interrupt output.
So this is a little annoying, as ideally device drivers should not be aware of their external connections. I'm trying to describe board (or SoC) level wiring in hopefully a way that doesn't require individual driver awareness. It also gets very messy when you have multiple interrupt outputs that are each in themselves connected to multiple interrupt controllers (which happens to be my situation). The meaning of multiple tuples becomes ambiguous.
Quoted 5 lines
Is the interrupt-map system I proposed acceptable long-term from just a pure binding acceptability standpoint? The driver side solution is also a large change pattern as I'm using this with Xilinx Zynq which has a large number of peripherals, any of which could be multiply-connected to both A9GIC and soft intc's in FPGA fabric.
Well, it isn't actively dangerous, but it really isn't a very good description either. There is no information about what the difference would be between the different connection options. The kernel certainly cannot do anything intelligent with it.
Quoted 5 lines
You'd probably be better off with an IRQ mux node and associated driver that chooses the appropriate connection and makes the behaviour transparent to the device driver. That way you'd have a place to embed the knowledge of how to make good decisions.
Hi Grant,
That sounds good, and it avoids me having to deal with that interrupt-map crazyness. Here's a first attempt at this form of syntax:
foo_irq_mux { #interrupt-cells = 0; comaptible = "irq-mux"; interrupts-extended = < &intc0 0 1 >,< &intc1 2 3 >; /* descision making info goes here */ };foo : foo@deadbeef { compatible = "vendor,foo"; interrupts-extended = <&foo_irq_mux>; }
Quoted 3 lines
It's going to get a little verbose once you start making multiple connections as you need one mux per wire. Perhaps it could be cleaned up by making the
foo_irq_muxnode(s) a child of foo?
It could, but then you need some way of attaching a driver to that node, and that would require building knowledge into the driver again.
Can you boil it down to a couple of concrete examples? What is a specific example of how the platform should decide which interrupt line to use?
g.
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 149 lines · Grant Likely
Quoted 144 lines · Peter Crosthwaite
Quoted 118 lines · Grant Likely
Quoted 106 lines · Peter Crosthwaite
Hi Grant,
Quoted 75 lines · Grant Likely
Quoted 74 lines · Peter Crosthwaite
Hi Grant,
Quoted 51 lines · Grant Likely
The standard interrupts property in device tree can only handle interrupts coming from a single interrupt parent. If a device is wired to multiple interrupt controllers, then it needs to be attached to a node with an interrupt-map property to demux the interrupt specifiers which is confusing. It would be a lot easier if there was a form of the interrupts property that allows for a separate interrupt phandle for each interrupt specifier.
This patch does exactly that by creating a new interrupts-extended property which reuses the phandle+arguments pattern used by GPIOs and other core bindings.
Signed-off-by Grant Likely <[email protected]>Cc Rob Herring <[email protected]>--- .../bindings/interrupt-controller/interrupts.txt | 29 +++++++-- arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++ arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- drivers/of/irq.c | 16 +++-- drivers/of/selftest.c | 70 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 13 deletions(-)Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-6@@ -4,16 +4,33 @@ Specifying interrupt information for devices 1) Interrupt client nodes ------------------------- -Nodes that describe devices which generate interrupts must contain an -"interrupts" property. This property must contain a list of interrupt -specifiers, one per output interrupt. The format of the interrupt specifier is -determined by the interrupt controller to which the interrupts are routed; see -section 2 below for details. +Nodes that describe devices which generate interrupts must contain an either an +"interrupts" property or an "interrupts-extended" property. These properties +contain a list of interrupt specifiers, one per output interrupt. The format of +the interrupt specifier is determined by the interrupt controller to which the +interrupts are routed; see section 2 below for details. + + Example: + interrupt-parent = <&intc1>; + interrupts = <5 0>, <6 0>; The "interrupt-parent" property is used to specify the controller to which interrupts are routed and contains a single phandle referring to the interrupt controller node. This property is inherited, so it may be specified in an -interrupt client node or in any of its parent nodes. +interrupt client node or in any of its parent nodes. Interrupts listed in theDocumentation/devicetree/bindings/interrupt-controller/interrupts.txt Specifying interrupt information for devices · line 30
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt +10
-0+"interrupts" property are always in reference to the node's interrupt parent. + +The "interrupts-extended" property is a special form for use when a node needs +to reference multiple interrupt parents. Each entry in this property contains +both the parent phandle and the interrupt specifier. "interrupts-extended" +should only be used when a device has multiple interrupt parents. + + Example: + interrupts-extended = <&intc1 5 1>, <&intc2 1 0>; +A slightly different but related problem I am trying to solve with interrupt bindings, is to describe connection of a single device interrupt line to multiple interrupts controller, whereas this binding seems to be describing connection of different interrupt lines to different controllers. Can this syntax accommodate my case is any way?
Bascially I think I'm asking for multiple interrupt specifiers for a single IRQ output if that's possible.
Quoted 9 lines
Quoted 4 lines
Should I just be using the interrupt map syntax instead?
interrupt-map-mask = < 0 0 63>;
interrupt-map = < 0 0 25 &intc0 ... >, < 0 0 25 &intc1 ... >,Interrupt map doesn't actually help you here either since the core code doesn't know what to do with it. It will probably only match and return one of the options.
Yes I noticed that. Although we are a fair way off Linux patches for this just yet and all I want to solve near-term is the hardware description problem (what core Linux IRQ code is actually supposed to do when given such a wiring setup is probably an open question).
Quoted 4 lines
What I would do is describe both in your interrupts property and make the driver know that the extra interrupt specifier is for the same interrupt output.
So this is a little annoying, as ideally device drivers should not be aware of their external connections. I'm trying to describe board (or SoC) level wiring in hopefully a way that doesn't require individual driver awareness. It also gets very messy when you have multiple interrupt outputs that are each in themselves connected to multiple interrupt controllers (which happens to be my situation). The meaning of multiple tuples becomes ambiguous.
Quoted 5 lines
Is the interrupt-map system I proposed acceptable long-term from just a pure binding acceptability standpoint? The driver side solution is also a large change pattern as I'm using this with Xilinx Zynq which has a large number of peripherals, any of which could be multiply-connected to both A9GIC and soft intc's in FPGA fabric.
Well, it isn't actively dangerous, but it really isn't a very good description either. There is no information about what the difference would be between the different connection options. The kernel certainly cannot do anything intelligent with it.
Quoted 5 lines
You'd probably be better off with an IRQ mux node and associated driver that chooses the appropriate connection and makes the behaviour transparent to the device driver. That way you'd have a place to embed the knowledge of how to make good decisions.
Hi Grant,
That sounds good, and it avoids me having to deal with that interrupt-map crazyness. Here's a first attempt at this form of syntax:
foo_irq_mux { #interrupt-cells = 0; comaptible = "irq-mux"; interrupts-extended = < &intc0 0 1 >,< &intc1 2 3 >; /* descision making info goes here */ };foo : foo@deadbeef { compatible = "vendor,foo"; interrupts-extended = <&foo_irq_mux>; }Quoted 3 lines
It's going to get a little verbose once you start making multiple connections as you need one mux per wire. Perhaps it could be cleaned up by making the
foo_irq_muxnode(s) a child of foo?
Quoted 7 lines
It could, but then you need some way of attaching a driver to that node, and that would require building knowledge into the driver again.
Can you boil it down to a couple of concrete examples? What is a specific example of how the platform should decide which interrupt line to use?
So i've spent some time playing with this. I now have a booting kernel with multiple root interrupt controllers and peripheral devices multiply-connected to both root controllers. But only one on of the controllers is used by Linux (as linux being able to use multiple intcs is a non-trivial problem). So the scheme I am using is to have one of these root intc's marked as disabled via
status = "disabled".
A few small patches to drivers/of/irq.c were needed to get Linux to ignore these marked-disabled intcs.
It all looks rather silly at first glance, so it might be a good time to fill you in on why I am doing this. Two big reasons.
1 - Our cad tools generate complete system DTS's that match the hardware in the system. It is possible to design system with Xilinx CAD which have these multiply connected interrupts. Its awkward for us if there is no dts syntax to support the connectivity (despite Linux being unable to use it) so my thinking here is to generate the complete DTS then post-annotate (e.g. with tricks like status = "disabled") RE choices of what hardware Linux should use.
2 - QEMU. I'm using DTS as a syntax for QEMU machine generation. These QEMU machines should generate the full hardware setup rather than just the Linux usable peripheral subset (I guess I'm kindof asking to be a non-linux consumer of dts here).
Working with Michal to get my patches in a list-ready state. Can you suggest a candidate tree we should base of for contributions to drivers/of/irq.c given your recent work?
Regards,
Peter
Quoted 7 lines
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 14 lines · Peter Crosthwaite
Quoted 5 lines · Grant Likely
Quoted 3 lines · Peter Crosthwaite
It's going to get a little verbose once you start making multiple connections as you need one mux per wire. Perhaps it could be cleaned up by making the
foo_irq_muxnode(s) a child of foo?Quoted 7 lines
It could, but then you need some way of attaching a driver to that node, and that would require building knowledge into the driver again.
Can you boil it down to a couple of concrete examples? What is a specific example of how the platform should decide which interrupt line to use?
Quoted 6 lines
So i've spent some time playing with this. I now have a booting kernel with multiple root interrupt controllers and peripheral devices multiply-connected to both root controllers. But only one on of the controllers is used by Linux (as linux being able to use multiple intcs is a non-trivial problem). So the scheme I am using is to have one of these root intc's marked as disabled via
Multiple intc's should be a solved problem. What issue are you seeing? Or is this a microblaze specific problem?
Quoted 3 lines
Working with Michal to get my patches in a list-ready state. Can you suggest a candidate tree we should base of for contributions to
drivers/of/irq.cgiven your recent work?
Linux-next. It is always linux-next. :-)
g.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 22 lines · Grant Likely
Quoted 14 lines · Peter Crosthwaite
Quoted 5 lines · Grant Likely
Quoted 3 lines · Peter Crosthwaite
It's going to get a little verbose once you start making multiple connections as you need one mux per wire. Perhaps it could be cleaned up by making the
foo_irq_muxnode(s) a child of foo?Quoted 7 lines
It could, but then you need some way of attaching a driver to that node, and that would require building knowledge into the driver again.
Can you boil it down to a couple of concrete examples? What is a specific example of how the platform should decide which interrupt line to use?
Quoted 6 lines
So i've spent some time playing with this. I now have a booting kernel with multiple root interrupt controllers and peripheral devices multiply-connected to both root controllers. But only one on of the controllers is used by Linux (as linux being able to use multiple intcs is a non-trivial problem). So the scheme I am using is to have one of these root intc's marked as disabled via
Quoted 3 lines
Multiple intc's should be a solved problem. What issue are you seeing? Or is this a microblaze specific problem?
It's multiple root (i.e. have no explicit parent) interrupt controllers. And linux
doesnt respect status = "disabled" for interrupt controllers at all it seems.
I'll send the patches tmrw.
Regards,
Peter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 23 lines · Peter Crosthwaite
Quoted 22 lines · Grant Likely
Quoted 20 lines · Peter Crosthwaite
Quoted 5 lines · Grant Likely
Quoted 3 lines · Peter Crosthwaite
It's going to get a little verbose once you start making multiple connections as you need one mux per wire. Perhaps it could be cleaned up by making the
foo_irq_muxnode(s) a child of foo?Quoted 7 lines
It could, but then you need some way of attaching a driver to that node, and that would require building knowledge into the driver again.
Can you boil it down to a couple of concrete examples? What is a specific example of how the platform should decide which interrupt line to use?
So i've spent some time playing with this. I now have a booting kernel with multiple root interrupt controllers and peripheral devices multiply-connected to both root controllers. But only one on of the controllers is used by Linux (as linux being able to use multiple intcs is a non-trivial problem). So the scheme I am using is to have one of these root intc's marked as disabled via
Quoted 7 lines
Quoted 3 lines
Multiple intc's should be a solved problem. What issue are you seeing? Or is this a microblaze specific problem?
It's multiple root (i.e. have no explicit parent) interrupt controllers. And linux
doesnt respect status = "disabled" for interrupt controllers at all it seems.
That can be fixed. :-)
g.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC 9/9] of/irq: create interrupts-extended property
Quoted 28 lines · Grant Likely
Quoted 27 lines · Peter Crosthwaite
Quoted 25 lines · Grant Likely
Quoted 14 lines · Peter Crosthwaite
Quoted 5 lines · Grant Likely
Quoted 3 lines · Peter Crosthwaite
It's going to get a little verbose once you start making multiple connections as you need one mux per wire. Perhaps it could be cleaned up by making the
foo_irq_muxnode(s) a child of foo?Quoted 7 lines
It could, but then you need some way of attaching a driver to that node, and that would require building knowledge into the driver again.
Can you boil it down to a couple of concrete examples? What is a specific example of how the platform should decide which interrupt line to use?
Quoted 6 lines
So i've spent some time playing with this. I now have a booting kernel with multiple root interrupt controllers and peripheral devices multiply-connected to both root controllers. But only one on of the controllers is used by Linux (as linux being able to use multiple intcs is a non-trivial problem). So the scheme I am using is to have one of these root intc's marked as disabled via
Multiple intc's should be a solved problem. What issue are you seeing? Or is this a microblaze specific problem?
Quoted 6 lines
Quoted 3 lines
It's multiple root (i.e. have no explicit parent) interrupt controllers. And linux
doesnt respect status = "disabled" for interrupt controllers at all it seems.That can be fixed. :-)
Patches on list.
Regards,
Peter
Quoted 7 lines
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 7 lines · Grant Likely
Hi everyone.
This series is mostly a set of cleanup to the interrupt parsing code. Some of it merely clarification, like the renames of of_irq_map_*, some to tighten up the API by using
of_phandle_args, and some to prepare for the last patch in the series.
Quoted 7 lines
Of all these patches, the last one is probably the only one likely to be controversial. It adds a new way of specifying interrupts. If a device gets wired up to multiple interrupt controllers, the interrupts-extended property allows the device to specify multiple connections without redirecting through an interrupt-map node which can be rather difficult to understand. In a lot of cases, an interrupts-extended property is a whole lot easier to use.
Oh that's too diplomatic :) How about something like this instead:
"Device tree is currently badly broken where in order to support
interrupts from multiple interrupt controllers the device needs to do the opposite of describing hardware, and lie about itself being an interrupt controller to use the interrupt-map property."
Anyways, gave this series a try, and the interrupts-extended binding works for me for the multiple interrupt controllers issue :)
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html