Skip to contentSkip to conversation

drivers: hv: Fix wrong check for synic_event_page

PATCH In review Felipe Pena 2 participants 2 messages Oct 15, 2013 Hyper-V/Azure core and drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: hv: Fix wrong check for synic_event_page

The check for calling free_page() on hv_context.synic_event_page[cpu] is the same for hv_context.synic_message_page[cpu], like a copy-paste error.

---
 drivers/hv/hv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hv/hv.c +1 -1
index 88f4096..f0c5e07 100644
@@ -304,7 +304,7 @@ err:
 void hv_synic_free_cpu(int cpu)
 {
 	kfree(hv_context.event_dpc[cpu]);
-	if (hv_context.synic_message_page[cpu])
+	if (hv_context.synic_event_page[cpu])
 		free_page((unsigned long)hv_context.synic_event_page[cpu]);
 	if (hv_context.synic_message_page[cpu])
 		free_page((unsigned long)hv_context.synic_message_page[cpu]);
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Felipe Pena [mailto:[email protected]]
Sent: Tuesday, October 15, 2013 4:23 PM
To: KY Srinivasan; Haiyang Zhang
Cc: [email protected]; [email protected]; Felipe Pena
Subject: [PATCH 1/1] drivers: hv: Fix wrong check for synic_event_page

Quoted 4 lines

The check for calling free_page() on hv_context.synic_event_page[cpu] is the same for hv_context.synic_message_page[cpu], like a copy-paste error.

Thanks Felipe.

K. Y

Quoted 20 lines
---
 drivers/hv/hv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hv/hv.c +1 -1
index 88f4096..f0c5e07 100644
@@ -304,7 +304,7 @@ err:
 void hv_synic_free_cpu(int cpu)
 {
 	kfree(hv_context.event_dpc[cpu]);
-	if (hv_context.synic_message_page[cpu])
+	if (hv_context.synic_event_page[cpu])
 		free_page((unsigned long)hv_context.synic_event_page[cpu]);
 	if (hv_context.synic_message_page[cpu])
 		free_page((unsigned

long)hv_context.synic_message_page[cpu]);
--
1.7.10.4