Skip to contentSkip to conversation

packagegroup-core-basic: libuser has a hard depenency on libpam

PATCH In review Saul Wold 4 participants 6 messages Oct 15, 2013 – Oct 16, 2013

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 packagegroup-core-basic: libuser has a hard depenency on libpam

Since libpam is only built when DISTRO_FEATURES pam is enabled we should not be trying to build libuser also.

[YOCTO #4949]

Signed-off-by Saul Wold <[email protected]>
---
 meta/recipes-extended/packagegroups/packagegroup-core-basic.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-extended/packagegroups/packagegroup-core-basic.bb +1 -1
index 2e6f576..596fede 100644
@@ -107,7 +107,7 @@ RDEPENDS_packagegroup-core-initscripts = "\
 RDEPENDS_packagegroup-core-multiuser = "\
     cracklib \
     gzip \
-    libuser \
+    ${@base_contains('DISTRO_FEATURES', 'pam', 'libuser', '', d)} \
     shadow \
     sudo \
     "
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 2 lines · On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:

Since libpam is only built when DISTRO_FEATURES pam is enabled we should not be trying to build libuser also.

Should this packagegroup be bringing in libraries such as this at all, given that libraries are generally pulled in as dependencies of applications that link to them?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#2 lore raw

Op 16 okt. 2013, om 12:25 heeft Paul Eggleton <[email protected]> het volgende geschreven:

Quoted 7 lines · On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
Quoted 2 lines

Since libpam is only built when DISTRO_FEATURES pam is enabled we should not be trying to build libuser also.

Should this packagegroup be bringing in libraries such as this at all, given that libraries are generally pulled in as dependencies of applications that link to them?

If it is a pure library, no. But libuser doesn't seem to be a pure library package:

[koen@rrMBP libuser]$ cat libuser/latest
PV = 0.58
PR = r0
PKGR = r0.0
RPROVIDES =
RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam (>= 1.1.6) popt (>= 1.16)
RRECOMMENDS =
PKGSIZE = 283679
FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/* /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1 /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod

regards,

Koen

#3 lore raw
Quoted 23 lines · On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:

Op 16 okt. 2013, om 12:25 heeft Paul Eggleton <[email protected]> het volgende geschreven:

Quoted 7 lines · On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
Quoted 2 lines

Since libpam is only built when DISTRO_FEATURES pam is enabled we should not be trying to build libuser also.

Should this packagegroup be bringing in libraries such as this at all, given that libraries are generally pulled in as dependencies of applications that link to them?

If it is a pure library, no. But libuser doesn't seem to be a pure library package:

[koen@rrMBP libuser]$ cat libuser/latest
PV = 0.58
PR = r0
PKGR = r0.0
RPROVIDES =
RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
PKGSIZE = 283679
FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d

Quoted 8 lines

/usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/* /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1 /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod

Right, in that case, ignore me :)

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#4 lore raw

Op 16 okt. 2013, om 13:47 heeft Paul Eggleton <[email protected]> het volgende geschreven:

Quoted 33 lines · On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:
Quoted 23 lines

Op 16 okt. 2013, om 12:25 heeft Paul Eggleton <[email protected]> het volgende geschreven:

Quoted 7 lines · On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
Quoted 2 lines

Since libpam is only built when DISTRO_FEATURES pam is enabled we should not be trying to build libuser also.

Should this packagegroup be bringing in libraries such as this at all, given that libraries are generally pulled in as dependencies of applications that link to them?

If it is a pure library, no. But libuser doesn't seem to be a pure library package:

[koen@rrMBP libuser]$ cat libuser/latest
PV = 0.58
PR = r0
PKGR = r0.0
RPROVIDES =
RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
PKGSIZE = 283679
FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d

Quoted 8 lines

/usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/* /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1 /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod

Quoted 1 line

Right, in that case, ignore me :)

But I still don't know what it does and why it needs to be in packagegroup-core-basic, though.

regards,

Koen

#5 lore raw
Quoted 35 lines · Koen Kooi

Op 16 okt. 2013, om 13:47 heeft Paul Eggleton <[email protected]> het volgende geschreven:

Quoted 33 lines · On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:
Quoted 31 lines

Op 16 okt. 2013, om 12:25 heeft Paul Eggleton <[email protected]> het volgende geschreven:

Quoted 7 lines · On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
Quoted 2 lines

Since libpam is only built when DISTRO_FEATURES pam is enabled we should not be trying to build libuser also.

Should this packagegroup be bringing in libraries such as this at all, given that libraries are generally pulled in as dependencies of applications that link to them?

If it is a pure library, no. But libuser doesn't seem to be a pure library package:

[koen@rrMBP libuser]$ cat libuser/latest
PV = 0.58
PR = r0
PKGR = r0.0
RPROVIDES =
RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
PKGSIZE = 283679
FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/* /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1 /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod

Quoted 3 lines
Quoted 1 line

Right, in that case, ignore me :)

But I still don't know what it does and why it needs to be in packagegroup-core-basic, though.

Looks like it has a number of pam user tools (groupadd, useradd and so on) and this goes with the other contents of packagegroup-core-multiuser...

Cheers,

Richard