Bluetooth: Socket address parameter for CID is in little endian
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/1 Bluetooth: Socket address parameter for CID is in little endian
The L2CAP socket parameter for CID are actually provided in little endian. So convert our constants into little endian before comparing them.
Signed-off-by Marcel Holtmann <[email protected]>
--- net/bluetooth/l2cap_sock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/bluetooth/l2cap_sock.c +2 -2
@@ -77,7 +77,7 @@ static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)if (la.l2_psm)return -EINVAL ;/* We only allow ATT user space socket */ -if (la.l2_cid !=L2CAP_CID_ATT ) +if (la.l2_cid !=__constant_cpu_to_le16 (L2CAP_CID_ATT ))return -EINVAL ; }
@@ -170,7 +170,7 @@ static int l2cap_sock_connect(struct socket *sock, struct sockaddr *addr,if (la.l2_psm)return -EINVAL ;/* We only allow ATT user space socket */ -if (la.l2_cid !=L2CAP_CID_ATT ) +if (la.l2_cid !=__constant_cpu_to_le16 (L2CAP_CID_ATT ))return -EINVAL ; }
Signature · 1 line
1.8.3.1
Johan Hedberg
AppliedHi Marcel,
Quoted 8 lines · Marcel Holtmann
The L2CAP socket parameter for CID are actually provided in little endian. So convert our constants into little endian before comparing them.
Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/l2cap_sock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied. Thanks.
Johan