Skip to contentSkip to conversation

mtd: nand: omap: optimize and clean-up of OMAP NAND driver

PATCH Superseded Pekon Gupta 6 participants 24 messages Oct 10, 2013 – Nov 20, 2013 1 message not in the archive

Subsystems (3)

v8 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

*changes in v8*
[PATCH 1/5] incorporated following feedbacks from Scott Wood <[email protected]>
- using symbolic names (enums) as values of CONFIG_NAND_OMAP_ECCSCHEME
- updated omap_select_ecc_scheme(): perform ecc-scheme compatibility checks before updating nand_chip.ecc fields. This avoids corrupting of existing ecc-scheme in case of switching failures.
- code clean-up (removed fall-back on omap_select_ecc_scheme() failures)
[PATCH 2/5], [PATCH 3/5], [PATCH 4/5] minor code clean-up
[PATCH 5/5] <no update>

*changes in v7*
[PATCH 1/5]
- omap_gpmc.c: fix: free bytes in OOB (ecclayout->oobfree[0].length)
- omap_gpmc.c: cleanup: redundant code added in previous patch versions
- am335x_evm.h: cleanup: redundant code added in previous patch versions
- tricorder.h: fix: CONFIG_NAND_OMAP_ECCSCHEME
[PATCH 2/5] removed: re-configuration of gpmc.config1[dev_width] added in
previous version of patch
[PATCH 3/5] <no update>
[PATCH 4/5] <no update>
[PATCH 5/5] minor fix: missing '$' in ${loadaddr}

*changes in v6*
[PATCH 1/5] incorporated feedbacks from Scott Wood <[email protected]>
- renamed CONFIG_SYS_NAND_ECCSCHEME to CONFIG_NAND_OMAP_ECCSCHEME
- updated omap_select_ecc_scheme() to handle error conditions without depending on caller.
- renamed OMAP_ECC_HAM1_CODE_HW_ROMCODE to OMAP_ECC_HAM1_CODE_HW to keep it naming compatible to linux kernel
- updated doc/README.nand and doc/README.omap3
[PATCH 2/5] minor code clean-up
[PATCH 3/5] minor code clean-up
[PATCH 4/5] <no update>
[PATCH 5/5] <moved CONFIG_NAND_OMAP_ECCSCHEME description to README.nand>

*changes in v5*
This version of patch is tested on am335x-evm with x8 NAND device, and boots SPL and u-boot from NAND
[PATCH 1/5]
- re-added omap_read_page_bch(): needed proper sequence of while reading DATA and ECC from NAND page, so that calc_ecc generated from GPMC is understood by ELM.
- added check to see if NAND OOB can accomodate ECC for entire page
[PATCH 2/5] fixed device-width in GPMC_CONFIG1_X to support x16 devices [PATCH 3/5] code clean-up for OMAP_ECC_BCH8_CODE_HW_DETECTION_SW mode [PATCH 4/5]
- fixed omap_correct_data_bch() for correcting bit-flips using ELM
- code-cleanup + added omap_reverse_list()
[PATCH 5/5] incorporated feedbacks from Peter Korsgaard <[email protected]>

*changes in v4*
[PATCH 1/5]
- removed omap_read_page_bch(): chip->ecc.read_page uses default API nand_read_page_hwecc() in nand_base.c
- updated tricorder.h: added new CONFIGS for ECCSCHEME & ONFI_DETECTION
- converted printf("ECC-SCHEME") to debug("ECC-SCHEME")
[PATCH 2/5] minor code clean-up
[PATCH 3/5] <no update>
[PATCH 4/5] <no update>
[PATCH 5/5] updated README as per feedbacks from trini at ti.com

*changes in v3*
[PATCH 1/5] (complete change)
- ecc-scheme is selection is controller by s/w, not CONFIG_NAND_xx
- added omap_select_ecc_scheme(), as common function to handle all ecc-scheme related configurations for both board_nand_init() & omap_nand_switch_ecc().
- removed un-used defines from asm/arch-am33xx/omap_gpmc.h
- updated doc/REAME.nand
[PATCH 2/5] removed un-used defines from asm/omap_gpmc.h [PATCH 3/5] removed omap_calculate_ecc_bch_sw() and omap_calculate_ecc()
and merged their logic into omap_calculate_ecc_bch()
[PATCH 4/5] updated return error-code in-case of invalid conditions [PATCH 5/5] (new) for board/ti/am335x/README

*changes in v2*
- added documentation for CONFIG_NAND_OMAP_xx in doc/README.nand
- added CONFIG_BCH along with CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW_DETECTION_SW to include software library lib/bch.c
- fixed board_nand_init() and omap_enable_hwecc()

*original v1*
This patch series updates BCH8_ECC schemes in mtd/nand/omap_gpmc.c driver
- adds scalability for higher ECC schemes in future.
- removes CONFIG_AM335x and it makes it generic for all platforms.
- optimizes read_data paths

Pekon Gupta (5):
[PATCH 1/5] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform [PATCH 2/5] mtd: nand: omap: optimize chip->ecc.hwctl() for H/W ECC schemes [PATCH 3/5] mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC schemes [PATCH 4/5] mtd: nand: omap: optimized chip->ecc.correct() for H/W ECC schemes [PATCH 5/5] board/ti/am335x/README: update for NAND boot

 arch/arm/include/asm/arch-am33xx/omap_gpmc.h |  52 +-
 arch/arm/include/asm/omap_gpmc.h             |   7 -
 board/ti/am335x/README                       |  53 +-
 doc/README.nand                              |  38 ++
 doc/README.omap3                             |   4 +-
 drivers/mtd/nand/omap_gpmc.c                 | 843 +++++++++++----------------
 include/configs/am335x_evm.h                 |  11 +-
 include/configs/tricorder.h                  |   3 +-
 8 files changed, 446 insertions(+), 565 deletions(-)
Signature · 1 line
1.8.1
#1 lore raw

PATCH v8 1/5 mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

BCH8_ECC scheme implemented in omap_gpmc.c driver has following favours

+-----------------------------------+-----------------+-----------------+
|ECC Scheme                         | ECC Calculation | Error Detection |
+-----------------------------------+-----------------+-----------------+
|OMAP_ECC_BCH8_CODE_HW              |GPMC             |ELM H/W engine   |
|OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |GPMC             |S/W BCH library  |
+-----------------------------------+-----------------+-----------------+

Current implementation limits the BCH8_CODE_HW only for AM33xx device family. (using CONFIG_AM33XX). However, other SoC families (like TI81xx) also have ELM hardware module, and can support ECC error detection using ELM.

This patch
- removes CONFIG_AM33xx
Thus this driver can be reused by all devices having ELM h/w engine.
- removes CONFIG_NAND_OMAP_BCH8 and adds new CONFIG_NAND_OMAP_ECCSCHEME CONFIG_NAND_OMAP_ECCSCHEME determines ecc-scheme to be used refer doc/README.nand and board/ti/am335x/README
- adds omap_select_ecc_scheme()
A common function to handle ecc-scheme related configurations. This can be used both during device-probe and via user-space u-boot commads to change ecc-scheme. During device probe ecc-scheme is selected based on CONFIG_NAND_OMAP_ECCSCHEME.
- enables CONFIG_BCH
S/W library (lib/bch.c) required by OMAP_ECC_BCH8_CODE_HW_DETECTION_SW is enabled by CONFIG_BCH.
- enables CONFIG_SYS_NAND_ONFI_DETECTION
for auto-detection of ONFI compliant NAND devices
- updates following README doc

	doc/README.nand
	board/ti/am335x/README
	doc/README.omap3
---
 arch/arm/include/asm/arch-am33xx/omap_gpmc.h |  52 ++---
 doc/README.nand                              |  38 ++++
 doc/README.omap3                             |   4 +-
 drivers/mtd/nand/omap_gpmc.c                 | 305 ++++++++++++++++-----------
 include/configs/am335x_evm.h                 |  11 +-
 include/configs/tricorder.h                  |   3 +-
 6 files changed, 242 insertions(+), 171 deletions(-)
arch/arm/include/asm/arch-am33xx/omap_gpmc.h +15 -37
index 00ad1d0..62f608e 100644
@@ -7,42 +7,20 @@
 #ifndef __ASM_ARCH_OMAP_GPMC_H
 #define __ASM_ARCH_OMAP_GPMC_H
 
-/* These GPMC_NAND_HW_BCHx_ECC_LAYOUT defines are based on AM33xx ELM */
-#define GPMC_NAND_HW_BCH4_ECC_LAYOUT {\
-	.eccbytes = 32,\
-	.eccpos = {2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15,\
-				16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27,\
-				28, 29, 30, 31, 32, 33},\
-	.oobfree = {\
-		{.offset = 34,\
-		 .length = 30 } } \
-}
+enum omap_ecc {
+	/* 1-bit  ECC calculation by Software, Error detection by Software */
+	OMAP_ECC_HAM1_CODE_SW = 1, /* avoid un-initialized int can be 0x0 */
+	/* 1-bit  ECC calculation by GPMC, Error detection by Software */
+	/* ECC layout compatible to legacy ROMCODE. */
+	OMAP_ECC_HAM1_CODE_HW,
+	/* 4-bit  ECC calculation by GPMC, Error detection by Software */
+	OMAP_ECC_BCH4_CODE_HW_DETECTION_SW,
+	/* 4-bit  ECC calculation by GPMC, Error detection by ELM */
+	OMAP_ECC_BCH4_CODE_HW,
+	/* 8-bit  ECC calculation by GPMC, Error detection by Software */
+	OMAP_ECC_BCH8_CODE_HW_DETECTION_SW,
+	/* 8-bit  ECC calculation by GPMC, Error detection by ELM */
+	OMAP_ECC_BCH8_CODE_HW,
+};
 
-#define GPMC_NAND_HW_BCH8_ECC_LAYOUT {\
-	.eccbytes = 56,\
-	.eccpos = {2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15,\
-				16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27,\
-				28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39,\
-				40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51,\
-				52, 53, 54, 55, 56, 57},\
-	.oobfree = {\
-		{.offset = 58,\
-		 .length = 6 } } \
-}
-
-#define GPMC_NAND_HW_BCH16_ECC_LAYOUT {\
-	.eccbytes = 104,\
-	.eccpos = {2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15,\
-				16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27,\
-				28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39,\
-				40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51,\
-				52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63,\
-				64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75,\
-				76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87,\
-				88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99,\
-				100, 101, 102, 103, 104, 105},\
-	.oobfree = {\
-		{.offset = 106,\
-		 .length = 8 } } \
-}
 #endif /* __ASM_ARCH_OMAP_GPMC_H */
doc/README.nand +38 -0
index 913e9b5..5a04d42 100644
@@ -169,6 +169,44 @@ Configuration Options:
       Please convert your driver even if you don't need the extra
       flexibility, so that one day we can eliminate the old mechanism.
 
+   CONFIG_SYS_NAND_ONFI_DETECTION
+	Enables detection of ONFI compliant devices during probe.
+	And fetching device parameters flashed on device, by parsing
+	ONFI parameter page.
+
+   CONFIG_BCH
+	Enables software based BCH ECC algorithm present in lib/bch.c
+	This is used by SoC platforms which do not have built-in ELM
+	hardware engine required for BCH ECC correction.
+
+Platform specific options
+=========================
+
+   CONFIG_NAND_OMAP_ECCSCHEME
+	On OMAP platforms, this CONFIG specifies NAND ECC scheme.
+	It can take following values:
+
+	OMAP_ECC_HAM1_CODE_SW
+		1-bit Hamming code using software lib.
+		(for legacy devices only)
+	OMAP_ECC_HAM1_CODE_HW
+		1-bit Hamming code using GPMC hardware.
+		(for legacy devices only)
+	OMAP_ECC_BCH4_CODE_HW_DETECTION_SW
+		4-bit BCH code (unsupported)
+	OMAP_ECC_BCH4_CODE_HW
+		4-bit BCH code (unsupported)
+	OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
+		8-bit BCH code with
+		- ecc calculation using GPMC hardware engine,
+		- error detection using software library.
+		- requires CONFIG_BCH to enable software BCH library
+		(For legacy device which do not have ELM h/w engine)
+	OMAP_ECC_BCH8_CODE_HW
+		8-bit BCH code with
+		- ecc calculation using GPMC hardware engine,
+		- error detection using ELM hardware engine.
+
 NOTE:
 =====
 
doc/README.omap3 +2 -2
index 1fbe79d..fd85b22 100644
@@ -161,8 +161,8 @@ BCH8
 
 To enable hardware assisted BCH8 (8-bit BCH [Bose, Chaudhuri, Hocquenghem]) on
 OMAP3 devices we can use the BCH library in lib/bch.c. To do so add CONFIG_BCH
-to enable the library and CONFIG_NAND_OMAP_BCH8 to to enable hardware assisted
-syndrom generation to your board config.
+to enable the library and set CONFIG_NAND_OMAP_ECCSCHEME=5 (as per README.nand)
+to enable BCH8_SW ecc scheme.
 The NAND OOB layout is the same as in linux kernel, if the linux kernel BCH8
 implementation for OMAP3 works for you so the u-boot version should also.
 When you require the SPL to read with BCH8 there are two more configs to
drivers/mtd/nand/omap_gpmc.c +180 -125

429 lines not on this page · raw message

include/configs/am335x_evm.h +5 -6
index f746e48..7bc7feb 100644
@@ -222,11 +222,11 @@
 
 #ifdef CONFIG_NAND
 #define CONFIG_SYS_NAND_5_ADDR_CYCLE
-#define CONFIG_SYS_NAND_PAGE_COUNT	(CONFIG_SYS_NAND_BLOCK_SIZE / \
-					 CONFIG_SYS_NAND_PAGE_SIZE)
+#define CONFIG_SYS_NAND_BLOCK_SIZE	131072
 #define CONFIG_SYS_NAND_PAGE_SIZE	2048
 #define CONFIG_SYS_NAND_OOBSIZE		64
-#define CONFIG_SYS_NAND_BLOCK_SIZE	(128*1024)
+#define CONFIG_SYS_NAND_PAGE_COUNT	(CONFIG_SYS_NAND_BLOCK_SIZE / \
+					 CONFIG_SYS_NAND_PAGE_SIZE)
 #define CONFIG_SYS_NAND_BAD_BLOCK_POS	NAND_LARGE_BADBLOCK_POS
 #define CONFIG_SYS_NAND_ECCPOS		{ 2, 3, 4, 5, 6, 7, 8, 9, \
 					 10, 11, 12, 13, 14, 15, 16, 17, \
@@ -238,9 +238,8 @@
 
 #define CONFIG_SYS_NAND_ECCSIZE		512
 #define CONFIG_SYS_NAND_ECCBYTES	14
-
-#define CONFIG_SYS_NAND_U_BOOT_START	CONFIG_SYS_TEXT_BASE
-#define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
+#define CONFIG_SYS_NAND_ONFI_DETECTION
+#define CONFIG_NAND_OMAP_ECCSCHEME	OMAP_ECC_BCH8_CODE_HW
 #endif
 #endif
 
include/configs/tricorder.h +2 -1
index a9b2714..e2fd978 100644
@@ -110,7 +110,6 @@
 
 #define CONFIG_SYS_MAX_NAND_DEVICE	1		/* Max number of NAND */
 							/* devices */
-#define CONFIG_NAND_OMAP_BCH8
 #define CONFIG_BCH
 
 /* commands to include */
@@ -298,6 +297,8 @@
 
 #define CONFIG_SYS_NAND_ECCSIZE		512
 #define CONFIG_SYS_NAND_ECCBYTES	13
+#define CONFIG_NAND_OMAP_ECCSCHEME	OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
+#define CONFIG_SYS_NAND_ONFI_DETECTION
 
 #define CONFIG_SYS_NAND_U_BOOT_START	CONFIG_SYS_TEXT_BASE
 
Signature · 1 line
1.8.1
#2 lore raw

PATCH v8 1/5 mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

Quoted 17 lines · Pekon Gupta
drivers/mtd/nand/omap_gpmc.c +3 -3
-#ifdef CONFIG_AM33XX
-	wr_mode = BCH_WRAPMODE_1;
+	if (bch->ecc_scheme == OMAP_ECC_BCH8_CODE_HW) {
+		wr_mode = BCH_WRAPMODE_1;
 
 	switch (bch->nibbles) {
 	case ECC_BCH4_NIBBLES:
@@ -320,7 +317,7 @@ static void omap_hwecc_init_bch(struct nand_chip *chip, int32_t mode)
 		val |= (unused_length << 22);
 		break;
 	}
-#else
+	} else {
 	/*
 	 * This ecc_size_config setting is for BCH sw library.
 	 *

drivers/mtd/nand/omap_gpmc.c static void omap_hwecc_init_bch(struct nand_chip *chip, int32_t mode) · line 333

Quoted 5 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
@@ -333,7 +330,7 @@ static void omap_hwecc_init_bch(struct nand_chip *chip, int32_t mode)
 	 *  size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area)
 	 */
 	val = (32 << 22) | (0 << 12);
-#endif
+	}

Either indentation or braces are wrong above. If it's just the indentation that's wrong, let me know and I can fix up when applying.

drivers/mtd/nand/omap_gpmc.c static void __maybe_unused omap_free_bch(struct mtd_info *mtd) · line 760

Quoted 9 lines
drivers/mtd/nand/omap_gpmc.c +9 -0
+/**
+ * omap_select_ecc_scheme - configures driver for particular ecc-scheme
+ * @nand: NAND chip device structure
+ * @ecc_scheme: ecc scheme to configure
+ * @pagesize: number of main-area bytes per page of NAND device
+ * @oobsize: number of OOB/spare bytes per page of NAND device
+ */
+static int omap_select_ecc_scheme(struct nand_chip *nand,
+	enum omap_ecc ecc_scheme, unsigned int pagesize, unsigned int oobsize) {

Brace goes on its own line for function definitions. Again, I can fix this while applying.

-Scott

#3 lore raw

PATCH v8 1/5 mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

Quoted 2 lines

From: Scott Wood [mailto:scottwood at freescale.com] On Thu, 2013-10-10 at 16:30 +0530, Pekon Gupta wrote:

[snip]

Quoted 7 lines

drivers/mtd/nand/omap_gpmc.c static void omap_hwecc_init_bch(struct nand_chip

Quoted 6 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
-#else
+	} else {
 	/*
 	 * This ecc_size_config setting is for BCH sw library.
 	 *
@@ -333,7 +330,7 @@ static void omap_hwecc_init_bch(struct nand_chip

*chip, int32_t mode)

Quoted 9 lines

drivers/mtd/nand/omap_gpmc.c static void omap_hwecc_init_bch(struct nand_chip *chip, int32_t mode) · line 333

Quoted 5 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
 	 *  size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area)
 	 */
 	val = (32 << 22) | (0 << 12);
-#endif
+	}

Either indentation or braces are wrong above. If it's just the indentation that's wrong, let me know and I can fix up when applying.

Yes, thanks. I did run checkpatch.pl but may be because code here is not part of the changed lines, so it did not give the indentation warning.

Quoted 11 lines

drivers/mtd/nand/omap_gpmc.c static void __maybe_unused omap_free_bch(struct mtd_info *mtd)

Quoted 9 lines
drivers/mtd/nand/omap_gpmc.c +9 -0
+/**
+ * omap_select_ecc_scheme - configures driver for particular ecc-scheme
+ * @nand: NAND chip device structure
+ * @ecc_scheme: ecc scheme to configure
+ * @pagesize: number of main-area bytes per page of NAND device
+ * @oobsize: number of OOB/spare bytes per page of NAND device
+ */
+static int omap_select_ecc_scheme(struct nand_chip *nand,
+	enum omap_ecc ecc_scheme, unsigned int pagesize, unsigned int

oobsize) {

Quoted 3 lines

Brace goes on its own line for function definitions. Again, I can fix this while applying.

Yes please if you can fix this while applying it would be helpful.

Sorry But here also I din't get the any warning from checkpatch.pl. But I remember checkpatch used to check this rule earlier.
-------------

$linux_mainline/scripts/checkpatch.pl --strict \
	tmp/0001-mtd-nand-omap-enable-BCH-ECC-scheme-using-ELM-for-ge.patch

total: 0 errors, 0 warnings, 0 checks, 580 lines checked

NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO\
MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE
-----------------

Do we have any checkpatch utility for u-boot ?

Thank You for help.
with regards, pekon

#4 lore raw

PATCH v8 1/5 mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

Quoted 19 lines · Pekon
Quoted 2 lines

From: Scott Wood [mailto:scottwood at freescale.com] On Thu, 2013-10-10 at 16:30 +0530, Pekon Gupta wrote:

[snip]

Quoted 7 lines

drivers/mtd/nand/omap_gpmc.c static void omap_hwecc_init_bch(struct nand_chip

Quoted 6 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
-#else
+	} else {
 	/*
 	 * This ecc_size_config setting is for BCH sw library.
 	 *
@@ -333,7 +330,7 @@ static void omap_hwecc_init_bch(struct nand_chip

*chip, int32_t mode)

Quoted 9 lines

drivers/mtd/nand/omap_gpmc.c static void omap_hwecc_init_bch(struct nand_chip *chip, int32_t mode) · line 333

Quoted 5 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
 	 *  size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area)
 	 */
 	val = (32 << 22) | (0 << 12);
-#endif
+	}

Either indentation or braces are wrong above. If it's just the indentation that's wrong, let me know and I can fix up when applying.

Quoted 2 lines

Yes, thanks. I did run checkpatch.pl but may be because code here is not part of the changed lines, so it did not give the indentation warning.

It seems that checkpatch.pl only checks the indentation of the first line of the if-body, and not the subsequent lines or anything in the else-body.

Quoted 1 line

Do we have any checkpatch utility for u-boot ?

tools/checkpatch.pl

-Scott

#5 lore raw

PATCH v8 1/5 mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

Hi,

Quoted 20 lines

From: Scott Wood [scottwood at freescale.com]

Quoted 2 lines
Quoted 1 line

From: Scott Wood [mailto:scottwood at freescale.com]

On Thu, 2013-10-10 at 16:30 +0530, Pekon Gupta wrote:

[snip]

Quoted 16 lines

drivers/mtd/nand/omap_gpmc.c static void omap_hwecc_init_bch(struct nand_chip

Quoted 6 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
-#else
+ } else {
  /*
   * This ecc_size_config setting is for BCH sw library.
   *
@@ -333,7 +330,7 @@ static void omap_hwecc_init_bch(struct nand_chip

*chip, int32_t mode)

drivers/mtd/nand/omap_gpmc.c static void omap_hwecc_init_bch(struct nand_chip *chip, int32_t mode) · line 333

Quoted 5 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
   *  size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area)
   */
  val = (32 << 22) | (0 << 12);
-#endif
+ }

Either indentation or braces are wrong above. If it's just the indentation that's wrong, let me know and I can fix up when applying.

Please let me know if you can pick this series, Or if you want me to fix indentation. I would be sending another series which also has some of your feedbacks.

with regards, pekon

#6 lore raw

PATCH v8 1/5 mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

Quoted 19 lines · Pekon

Hi,

Quoted 17 lines

From: Scott Wood [scottwood at freescale.com]

Quoted 2 lines
Quoted 1 line

From: Scott Wood [mailto:scottwood at freescale.com]

On Thu, 2013-10-10 at 16:30 +0530, Pekon Gupta wrote:

[snip]

Quoted 13 lines

drivers/mtd/nand/omap_gpmc.c static void omap_hwecc_init_bch(struct nand_chip

Quoted 6 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
-#else
+ } else {
  /*
   * This ecc_size_config setting is for BCH sw library.
   *
@@ -333,7 +330,7 @@ static void omap_hwecc_init_bch(struct nand_chip

*chip, int32_t mode)

Quoted 5 lines
drivers/mtd/nand/omap_gpmc.c +1 -1
   *  size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area)
   */
  val = (32 << 22) | (0 << 12);
-#endif
+ }
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines

Either indentation or braces are wrong above. If it's just the indentation that's wrong, let me know and I can fix up when applying.

Please let me know if you can pick this series, Or if you want me to fix indentation. I would be sending another series which also has some of your feedbacks.

I'll take it, but I probably won't have a chance to apply U-Boot patches until at least the week after next (I'm attending conferences next week, and this week I need to process Linux patches since those have an earlier deadline for making the next release).

-Scott

#7 lore raw

PATCH v8 1/5 mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

Quoted 12 lines

From: Scott Wood [mailto:scottwood at freescale.com]

Quoted 3 lines · Pekon

Please let me know if you can pick this series, Or if you want me to fix

indentation.

Quoted 1 line

I would be sending another series which also has some of your feedbacks.

I'll take it, but I probably won't have a chance to apply U-Boot patches until at least the week after next (I'm attending conferences next week, and this week I need to process Linux patches since those have an earlier deadline for making the next release).

Thank you for accepting.
But, I'll re-post another version fixing minor issue which broke the build of other TI platforms 're-using' this driver. (as pointed by Tom Rini below)

----------- x------------ x---

Quoted 4 lines

From: Tom Rini
OK, with this series applied, please build all of the OMAP platforms, and fix the various build problems that are introduced by this.

Quoted 8 lines

I see problems with: am3517_crane am335x_boneblack rut igep0020_nand omap3_zoom2 omap3_overo dig297 omap3_evm omap3_logic igep0033 tricorder
mcx igep0030_nand twister pxm2 omap3_evm_quick_nand am43xx_evm mt_ventoux ti816x_evm am335x_evm_spiboot pcm051 dxr2 eco5pk devkit8000
am3517_evm cm_t35 omap3_beagle omap3_zoom1 omap3_pandora

----------- x------------ x---

Apologies for not build testing all platforms. Next time I'll be more cautious..

Also using updated version as base, I'll re-work on next series which also has some feedbacks.

with regards, pekon

#8 lore raw

PATCH v8 2/5 mtd: nand: omap: optimize chip->ecc.hwctl() for H/W ECC schemes

In reply to Pekon Gupta

chip->ecc.hwctl() is used for preparing the H/W controller before read/write NAND accesses (like assigning data-buf, enabling ECC scheme configs, etc.)

Though all ECC schemes in OMAP NAND driver use GPMC controller for generating ECC syndrome (for both Read/Write accesses). But but in current code HAM1_ECC and BCHx_ECC schemes implement individual function to achieve this. This patch
(1) removes omap_hwecc_init() and omap_hwecc_init_bch()
as chip->ecc.hwctl will re-initializeGPMC before every read/write call. omap_hwecc_init_bch() -> omap_enable_ecc_bch()

(2) merges the GPMC configuration code for all ECC schemes into single omap_enable_hwecc(), thus adding scalability for future ECC schemes. omap_enable_hwecc() + omap_enable_ecc_bch() -> omap_enable_hwecc()

---
 arch/arm/include/asm/omap_gpmc.h |   7 --
 drivers/mtd/nand/omap_gpmc.c     | 192 +++++++++++----------------------------
 2 files changed, 54 insertions(+), 145 deletions(-)
arch/arm/include/asm/omap_gpmc.h +0 -7
index dd40cb6..9660842 100644
@@ -14,13 +14,6 @@
 #define GPMC_BUF_EMPTY	0
 #define GPMC_BUF_FULL	1
 
-#define ECCCLEAR	(0x1 << 8)
-#define ECCRESULTREG1	(0x1 << 0)
-#define ECCSIZE512BYTE	0xFF
-#define ECCSIZE1	(ECCSIZE512BYTE << 22)
-#define ECCSIZE0	(ECCSIZE512BYTE << 12)
-#define ECCSIZE0SEL	(0x000 << 0)
-
 /* Generic ECC Layouts */
 /* Large Page x8 NAND device Layout */
 #ifdef GPMC_NAND_ECC_LP_x8_LAYOUT
drivers/mtd/nand/omap_gpmc.c +54 -138

243 lines not on this page · raw message

Signature · 1 line
1.8.1
#9 lore raw

PATCH v8 3/5 mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC schemes

In reply to Pekon Gupta

chip->ecc.calculate() is used for calculating and fetching of ECC syndrome by processing the data passed during Read/Write accesses.

All H/W based ECC schemes use GPMC controller to calculate ECC syndrome. But each BCHx_ECC scheme has its own implemetation of post-processing and fetching ECC syndrome from GPMC controller.

This patch updates OMAP_ECC_BCH8_CODE_HW ECC scheme in following way:
- merges multiple chip->calculate API for different ECC schemes omap_calculate_ecc() + omap_calculate_ecc_bch() + omap_calculate_ecc_bch_sw()

				==> omap_calculate_ecc()

- removes omap_ecc_disable() and instead uses it as inline.

---
 drivers/mtd/nand/omap_gpmc.c | 223 ++++++++++++-------------------------------
 1 file changed, 62 insertions(+), 161 deletions(-)
drivers/mtd/nand/omap_gpmc.c +62 -161
index e7687c7..af2f149 100644
@@ -21,7 +21,10 @@
 #define SECTOR_BYTES		512
 #define ECCCLEAR		(0x1 << 8)
 #define ECCRESULTREG1		(0x1 << 0)
-
+#ifdef CONFIG_BCH
+static u8  bch8_polynomial[] = {0xef, 0x51, 0x2e, 0x09, 0xed, 0x93, 0x9a, 0xc2,
+				0x97, 0x79, 0xe5, 0x24, 0xb5};
+#endif
 static uint8_t cs;
 static __maybe_unused struct nand_ecclayout omap_ecclayout;
 
@@ -143,42 +146,6 @@ static int __maybe_unused omap_correct_data(struct mtd_info *mtd, uint8_t *dat,
 }
 
 /*
- *  omap_calculate_ecc - Generate non-inverted ECC bytes.
- *
- *  Using noninverted ECC can be considered ugly since writing a blank
- *  page ie. padding will clear the ECC bytes. This is no problem as
- *  long nobody is trying to write data on the seemingly unused page.
- *  Reading an erased page will produce an ECC mismatch between
- *  generated and read ECC bytes that has to be dealt with separately.
- *  E.g. if page is 0xFF (fresh erased), and if HW ECC engine within GPMC
- *  is used, the result of read will be 0x0 while the ECC offsets of the
- *  spare area will be 0xFF which will result in an ECC mismatch.
- *  @mtd:	MTD structure
- *  @dat:	unused
- *  @ecc_code:	ecc_code buffer
- */
-static int __maybe_unused omap_calculate_ecc(struct mtd_info *mtd,
-		const uint8_t *dat, uint8_t *ecc_code)
-{
-	u_int32_t val;
-
-	/* Start Reading from HW ECC1_Result = 0x200 */
-	val = readl(&gpmc_cfg->ecc1_result);
-
-	ecc_code[0] = val & 0xFF;
-	ecc_code[1] = (val >> 16) & 0xFF;
-	ecc_code[2] = ((val >> 8) & 0x0F) | ((val >> 20) & 0xF0);
-
-	/*
-	 * Stop reading anymore ECC vals and clear old results
-	 * enable will be called if more reads are required
-	 */
-	writel(0x000, &gpmc_cfg->ecc_config);
-
-	return 0;
-}
-
-/*
  * Generic BCH interface
  */
 struct nand_bch_priv {
@@ -194,12 +161,7 @@ struct nand_bch_priv {
 #define ECC_BCH8	1
 #define ECC_BCH16	2
 
-/* GPMC ecc engine settings */
-#define BCH_WRAPMODE_1		1	/* BCH wrap mode 1 */
-#define BCH_WRAPMODE_6		6	/* BCH wrap mode 6 */
-
 /* BCH nibbles for diff bch levels */
-#define NAND_ECC_HW_BCH ((uint8_t)(NAND_ECC_HW_OOB_FIRST) + 1)
 #define ECC_BCH4_NIBBLES	13
 #define ECC_BCH8_NIBBLES	26
 #define ECC_BCH16_NIBBLES	52
@@ -211,7 +173,6 @@ struct nand_bch_priv {
  * When some users with other BCH strength will exists this have to change!
  */
 static __maybe_unused struct nand_bch_priv bch_priv = {
-	.mode = NAND_ECC_HW_BCH,
 	.type = ECC_BCH8,
 	.nibbles = ECC_BCH8_NIBBLES,
 	.control = NULL
@@ -280,54 +241,74 @@ static void omap_enable_hwecc(struct mtd_info *mtd, int32_t mode)
 }
 
 /*
- * omap_ecc_disable - Disable H/W ECC calculation
- *
- * @mtd:	MTD device structure
- */
-static void __maybe_unused omap_ecc_disable(struct mtd_info *mtd)
-{
-	writel((readl(&gpmc_cfg->ecc_config) & ~0x1), &gpmc_cfg->ecc_config);
-}
-
-/*
- * BCH support using ELM module
- */
-/*
- * omap_read_bch8_result - Read BCH result for BCH8 level
+ *  omap_calculate_ecc - Read ECC result
+ *  @mtd:	MTD structure
+ *  @dat:	unused
+ *  @ecc_code:	ecc_code buffer
  *
- * @mtd:	MTD device structure
- * @big_endian:	When set read register 3 first
- * @ecc_code:	Read syndrome from BCH result registers
+ *  Using noninverted ECC can be considered ugly since writing a blank
+ *  page ie. padding will clear the ECC bytes. This is no problem as
+ *  long nobody is trying to write data on the seemingly unused page.
+ *  Reading an erased page will produce an ECC mismatch between
+ *  generated and read ECC bytes that has to be dealt with separately.
+ *  E.g. if page is 0xFF (fresh erased), and if HW ECC engine within GPMC
+ *  is used, the result of read will be 0x0 while the ECC offsets of the
+ *  spare area will be 0xFF which will result in an ECC mismatch.
  */
-static void omap_read_bch8_result(struct mtd_info *mtd, uint8_t big_endian,
+static int omap_calculate_ecc(struct mtd_info *mtd, const uint8_t *dat,
 				uint8_t *ecc_code)
 {
-	uint32_t *ptr;
+	struct nand_chip *chip = mtd->priv;
+	struct nand_bch_priv *bch = chip->priv;
+	uint32_t *ptr, val = 0;
 	int8_t i = 0, j;
 
-	if (big_endian) {
+	switch (bch->ecc_scheme) {
+	case OMAP_ECC_HAM1_CODE_HW:
+		val = readl(&gpmc_cfg->ecc1_result);
+		ecc_code[0] = val & 0xFF;
+		ecc_code[1] = (val >> 16) & 0xFF;
+		ecc_code[2] = ((val >> 8) & 0x0F) | ((val >> 20) & 0xF0);
+		break;
+#ifdef CONFIG_BCH
+	case OMAP_ECC_BCH8_CODE_HW_DETECTION_SW:
+#endif
+	case OMAP_ECC_BCH8_CODE_HW:
 		ptr = &gpmc_cfg->bch_result_0_3[0].bch_result_x[3];
-		ecc_code[i++] = readl(ptr) & 0xFF;
+		val = readl(ptr);
+		ecc_code[i++] = (val >>  0) & 0xFF;
 		ptr--;
 		for (j = 0; j < 3; j++) {
-			ecc_code[i++] = (readl(ptr) >> 24) & 0xFF;
-			ecc_code[i++] = (readl(ptr) >> 16) & 0xFF;
-			ecc_code[i++] = (readl(ptr) >>  8) & 0xFF;
-			ecc_code[i++] = readl(ptr) & 0xFF;
+			val = readl(ptr);
+			ecc_code[i++] = (val >> 24) & 0xFF;
+			ecc_code[i++] = (val >> 16) & 0xFF;
+			ecc_code[i++] = (val >>  8) & 0xFF;
+			ecc_code[i++] = (val >>  0) & 0xFF;
 			ptr--;
 		}
-	} else {
-		ptr = &gpmc_cfg->bch_result_0_3[0].bch_result_x[0];
-		for (j = 0; j < 3; j++) {
-			ecc_code[i++] = readl(ptr) & 0xFF;
-			ecc_code[i++] = (readl(ptr) >>  8) & 0xFF;
-			ecc_code[i++] = (readl(ptr) >> 16) & 0xFF;
-			ecc_code[i++] = (readl(ptr) >> 24) & 0xFF;
-			ptr++;
-		}
-		ecc_code[i++] = readl(ptr) & 0xFF;
-		ecc_code[i++] = 0;	/* 14th byte is always zero */
+		break;
+	default:
+		return -EINVAL;
 	}
+	/* ECC scheme specific syndrome customizations */
+	switch (bch->ecc_scheme) {
+	case OMAP_ECC_HAM1_CODE_HW:
+		break;
+#ifdef CONFIG_BCH
+	case OMAP_ECC_BCH8_CODE_HW_DETECTION_SW:
+
+		for (i = 0; i < chip->ecc.bytes; i++)
+			*(ecc_code + i) = *(ecc_code + i) ^
+						bch8_polynomial[i];
+		break;
+#endif
+	case OMAP_ECC_BCH8_CODE_HW:
+		ecc_code[chip->ecc.bytes - 1] = 0x00;
+		break;
+	default:
+		return -EINVAL;
+	}
+	return 0;
 }
 
 /*
@@ -366,35 +347,6 @@ static void omap_rotate_ecc_bch(struct mtd_info *mtd, uint8_t *calc_ecc,
 }
 
 /*
- *  omap_calculate_ecc_bch - Read BCH ECC result
- *
- *  @mtd:	MTD structure
- *  @dat:	unused
- *  @ecc_code:	ecc_code buffer
- */
-static int omap_calculate_ecc_bch(struct mtd_info *mtd, const uint8_t *dat,
-				uint8_t *ecc_code)
-{
-	struct nand_chip *chip = mtd->priv;
-	struct nand_bch_priv *bch = chip->priv;
-	uint8_t big_endian = 1;
-	int8_t ret = 0;
-
-	if (bch->type == ECC_BCH8)
-		omap_read_bch8_result(mtd, big_endian, ecc_code);
-	else /* BCH4 and BCH16 currently not supported */
-		ret = -1;
-
-	/*
-	 * Stop reading anymore ECC vals and clear old results
-	 * enable will be called if more reads are required
-	 */
-	omap_ecc_disable(mtd);
-
-	return ret;
-}
-
-/*
  * omap_fix_errors_bch - Correct bch error in the data
  *
  * @mtd:	MTD device structure
@@ -549,57 +501,6 @@ static int omap_read_page_bch(struct mtd_info *mtd, struct nand_chip *chip,
  * OMAP3 BCH8 support (with BCH library)
  */
 #ifdef CONFIG_BCH
-/*
- *  omap_calculate_ecc_bch_sw - Read BCH ECC result
- *
- *  @mtd:	MTD device structure
- *  @dat:	The pointer to data on which ecc is computed (unused here)
- *  @ecc:	The ECC output buffer
- */
-static int omap_calculate_ecc_bch_sw(struct mtd_info *mtd, const uint8_t *dat,
-				uint8_t *ecc)
-{
-	int ret = 0;
-	size_t i;
-	unsigned long nsectors, val1, val2, val3, val4;
-
-	nsectors = ((readl(&gpmc_cfg->ecc_config) >> 4) & 0x7) + 1;
-
-	for (i = 0; i < nsectors; i++) {
-		/* Read hw-computed remainder */
-		val1 = readl(&gpmc_cfg->bch_result_0_3[i].bch_result_x[0]);
-		val2 = readl(&gpmc_cfg->bch_result_0_3[i].bch_result_x[1]);
-		val3 = readl(&gpmc_cfg->bch_result_0_3[i].bch_result_x[2]);
-		val4 = readl(&gpmc_cfg->bch_result_0_3[i].bch_result_x[3]);
-
-		/*
-		 * Add constant polynomial to remainder, in order to get an ecc
-		 * sequence of 0xFFs for a buffer filled with 0xFFs.
-		 */
-		*ecc++ = 0xef ^ (val4 & 0xFF);
-		*ecc++ = 0x51 ^ ((val3 >> 24) & 0xFF);
-		*ecc++ = 0x2e ^ ((val3 >> 16) & 0xFF);
-		*ecc++ = 0x09 ^ ((val3 >> 8) & 0xFF);
-		*ecc++ = 0xed ^ (val3 & 0xFF);
-		*ecc++ = 0x93 ^ ((val2 >> 24) & 0xFF);
-		*ecc++ = 0x9a ^ ((val2 >> 16) & 0xFF);
-		*ecc++ = 0xc2 ^ ((val2 >> 8) & 0xFF);
-		*ecc++ = 0x97 ^ (val2 & 0xFF);
-		*ecc++ = 0x79 ^ ((val1 >> 24) & 0xFF);
-		*ecc++ = 0xe5 ^ ((val1 >> 16) & 0xFF);
-		*ecc++ = 0x24 ^ ((val1 >> 8) & 0xFF);
-		*ecc++ = 0xb5 ^ (val1 & 0xFF);
-	}
-
-	/*
-	 * Stop reading anymore ECC vals and clear old results
-	 * enable will be called if more reads are required
-	 */
-	omap_ecc_disable(mtd);
-
-	return ret;
-}
-
 /**
  * omap_correct_data_bch_sw - Decode received data and correct errors
  * @mtd: MTD device structure
@@ -748,7 +649,7 @@ static int omap_select_ecc_scheme(struct nand_chip *nand,
 		nand->ecc.bytes		= 13;
 		nand->ecc.hwctl		= omap_enable_hwecc;
 		nand->ecc.correct	= omap_correct_data_bch_sw;
-		nand->ecc.calculate	= omap_calculate_ecc_bch_sw;
+		nand->ecc.calculate	= omap_calculate_ecc;
 		/* define ecc-layout */
 		ecclayout->eccbytes	= nand->ecc.bytes * eccsteps;
 		for (i = 0; i < ecclayout->eccbytes; i++)
@@ -778,7 +679,7 @@ static int omap_select_ecc_scheme(struct nand_chip *nand,
 		nand->ecc.bytes		= 14;
 		nand->ecc.hwctl		= omap_enable_hwecc;
 		nand->ecc.correct	= omap_correct_data_bch;
-		nand->ecc.calculate	= omap_calculate_ecc_bch;
+		nand->ecc.calculate	= omap_calculate_ecc;
 		nand->ecc.read_page	= omap_read_page_bch;
 		/* define ecc-layout */
 		ecclayout->eccbytes	= nand->ecc.bytes * eccsteps;
Signature · 1 line
1.8.1
#10 lore raw

PATCH v8 4/5 mtd: nand: omap: optimized chip->ecc.correct() for H/W ECC schemes

In reply to Pekon Gupta

chip->ecc.correct() is used for detecting and correcting bit-flips during read operations. In omap-nand driver it implemented as:
(a) omap_correct_data(): for h/w based ECC_HAM1 scheme
(b) omap_correct_data_bch() + CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW_DETECTION_SW for ECC_BCH8 scheme using GPMC and software lib/bch.c
(c) omap_correct_data_bch() + CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW for ECC_BCH8 scheme using GPMC and ELM

This patch updates (c)
- checks for calc_ecc[]==0x00 so that error_correction is not required for known good pages.
- adds scalability for other ECC_BCHx scheme by merging following omap_rotate_ecc_bch() + omap_fix_errors_bch() => omap_correct_data_bch()
- fixing logic for bit-flip correction based on error_loc[count]

---
 drivers/mtd/nand/omap_gpmc.c | 161 +++++++++++++++++++------------------------
 1 file changed, 71 insertions(+), 90 deletions(-)
drivers/mtd/nand/omap_gpmc.c +71 -90
index af2f149..ffd743d 100644
@@ -21,6 +21,9 @@
 #define SECTOR_BYTES		512
 #define ECCCLEAR		(0x1 << 8)
 #define ECCRESULTREG1		(0x1 << 0)
+/* 4 bit padding to make byte aligned, 56 = 52 + 4 */
+#define BCH4_BIT_PAD		4
+
 #ifdef CONFIG_BCH
 static u8  bch8_polynomial[] = {0xef, 0x51, 0x2e, 0x09, 0xed, 0x93, 0x9a, 0xc2,
 				0x97, 0x79, 0xe5, 0x24, 0xb5};
@@ -179,6 +182,23 @@ static __maybe_unused struct nand_bch_priv bch_priv = {
 };
 
 /*
+ * omap_reverse_list - re-orders list elements in reverse order [internal]
+ * @list:	pointer to start of list
+ * @length:	length of list
+*/
+void omap_reverse_list(u8 *list, unsigned int length)
+{
+	unsigned int i, j;
+	unsigned int half_length = length / 2;
+	u8 tmp;
+	for (i = 0, j = length - 1; i < half_length; i++, j--) {
+		tmp = list[i];
+		list[i] = list[j];
+		list[j] = tmp;
+	}
+}
+
+/*
  * omap_enable_hwecc - configures GPMC as per ECC scheme before read/write
  * @mtd:	MTD device structure
  * @mode:	Read/Write mode
@@ -312,77 +332,6 @@ static int omap_calculate_ecc(struct mtd_info *mtd, const uint8_t *dat,
 }
 
 /*
- * omap_rotate_ecc_bch - Rotate the syndrome bytes
- *
- * @mtd:	MTD device structure
- * @calc_ecc:	ECC read from ECC registers
- * @syndrome:	Rotated syndrome will be retuned in this array
- *
- */
-static void omap_rotate_ecc_bch(struct mtd_info *mtd, uint8_t *calc_ecc,
-		uint8_t *syndrome)
-{
-	struct nand_chip *chip = mtd->priv;
-	struct nand_bch_priv *bch = chip->priv;
-	uint8_t n_bytes = 0;
-	int8_t i, j;
-
-	switch (bch->type) {
-	case ECC_BCH4:
-		n_bytes = 8;
-		break;
-
-	case ECC_BCH16:
-		n_bytes = 28;
-		break;
-
-	case ECC_BCH8:
-	default:
-		n_bytes = 13;
-		break;
-	}
-
-	for (i = 0, j = (n_bytes-1); i < n_bytes; i++, j--)
-		syndrome[i] =  calc_ecc[j];
-}
-
-/*
- * omap_fix_errors_bch - Correct bch error in the data
- *
- * @mtd:	MTD device structure
- * @data:	Data read from flash
- * @error_count:Number of errors in data
- * @error_loc:	Locations of errors in the data
- *
- */
-static void omap_fix_errors_bch(struct mtd_info *mtd, uint8_t *data,
-		uint32_t error_count, uint32_t *error_loc)
-{
-	struct nand_chip *chip = mtd->priv;
-	struct nand_bch_priv *bch = chip->priv;
-	uint8_t count = 0;
-	uint32_t error_byte_pos;
-	uint32_t error_bit_mask;
-	uint32_t last_bit = (bch->nibbles * 4) - 1;
-
-	/* Flip all bits as specified by the error location array. */
-	/* FOR( each found error location flip the bit ) */
-	for (count = 0; count < error_count; count++) {
-		if (error_loc[count] > last_bit) {
-			/* Remove the ECC spare bits from correction. */
-			error_loc[count] -= (last_bit + 1);
-			/* Offset bit in data region */
-			error_byte_pos = ((512 * 8) -
-					(error_loc[count]) - 1) / 8;
-			/* Error Bit mask */
-			error_bit_mask = 0x1 << (error_loc[count] % 8);
-			/* Toggle the error bit to make the correction. */
-			data[error_byte_pos] ^= error_bit_mask;
-		}
-	}
-}
-
-/*
  * omap_correct_data_bch - Compares the ecc read from nand spare area
  * with ECC registers values and corrects one bit error if it has occured
  *
@@ -398,40 +347,72 @@ static int omap_correct_data_bch(struct mtd_info *mtd, uint8_t *dat,
 {
 	struct nand_chip *chip = mtd->priv;
 	struct nand_bch_priv *bch = chip->priv;
-	uint8_t syndrome[28];
-	uint32_t error_count = 0;
+	uint32_t eccbytes = chip->ecc.bytes;
+	uint32_t error_count = 0, error_max;
 	uint32_t error_loc[8];
-	uint32_t i, ecc_flag;
+	uint32_t i, ecc_flag = 0;
+	uint8_t count, err = 0;
+	uint32_t byte_pos, bit_pos;
 
+	/* check calculated ecc */
+	for (i = 0; i < chip->ecc.bytes && !ecc_flag; i++) {
+		if (calc_ecc[i] != 0x00)
+			ecc_flag = 1;
+	}
+	if (!ecc_flag)
+		return 0;
+
+	/* check for whether its a erased-page */
 	ecc_flag = 0;
-	for (i = 0; i < chip->ecc.bytes; i++)
+	for (i = 0; i < chip->ecc.bytes && !ecc_flag; i++) {
 		if (read_ecc[i] != 0xff)
 			ecc_flag = 1;
-
+	}
 	if (!ecc_flag)
 		return 0;
 
-	elm_reset();
-	elm_config((enum bch_level)(bch->type));
-
 	/*
 	 * while reading ECC result we read it in big endian.
 	 * Hence while loading to ELM we have rotate to get the right endian.
 	 */
-	omap_rotate_ecc_bch(mtd, calc_ecc, syndrome);
-
+	switch (bch->ecc_scheme) {
+	case OMAP_ECC_BCH8_CODE_HW:
+		omap_reverse_list(calc_ecc, eccbytes - 1);
+		break;
+	default:
+		return -EINVAL;
+	}
 	/* use elm module to check for errors */
-	if (elm_check_error(syndrome, bch->nibbles, &error_count,
-				error_loc) != 0) {
-		printf("ECC: uncorrectable.\n");
-		return -1;
+	elm_config((enum bch_level)(bch->type));
+	if (elm_check_error(calc_ecc, bch->nibbles, &error_count, error_loc)) {
+		printf("nand: error: uncorrectable ECC errors\n");
+		return -EINVAL;
 	}
-
 	/* correct bch error */
-	if (error_count > 0)
-		omap_fix_errors_bch(mtd, dat, error_count, error_loc);
-
-	return 0;
+	for (count = 0; count < error_count; count++) {
+		switch (bch->type) {
+		case ECC_BCH8:
+			/* 14th byte in ECC is reserved to match ROM layout */
+			error_max = SECTOR_BYTES + (eccbytes - 1);
+			break;
+		default:
+			return -EINVAL;
+		}
+		byte_pos = error_max - (error_loc[count] / 8) - 1;
+		bit_pos  = error_loc[count] % 8;
+		if (byte_pos < SECTOR_BYTES) {
+			dat[byte_pos] ^= 1 << bit_pos;
+			printf("nand: bit-flip corrected @data=%d\n", byte_pos);
+		} else if (byte_pos < error_max) {
+			read_ecc[byte_pos - SECTOR_BYTES] = 1 << bit_pos;
+			printf("nand: bit-flip corrected @oob=%d\n", byte_pos -
+								SECTOR_BYTES);
+		} else {
+			err = -EBADMSG;
+			printf("nand: error: invalid bit-flip location\n");
+		}
+	}
+	return (err) ? err : error_count;
 }
 
 /**
Signature · 1 line
1.8.1
#11 lore raw

PATCH v8 5/5 board/ti/am335x/README: update for NAND boot

In reply to Pekon Gupta

NAND boot mode on AM335x EVM has been verified, and steps to use it has been documented and update in this README

---
 board/ti/am335x/README | 53 ++++++++++++++++++++++++++++++++++----------------
 1 file changed, 36 insertions(+), 17 deletions(-)
board/ti/am335x/README +36 -17
index 2a30ab8..947305b 100644
@@ -46,23 +46,42 @@ NAND
 The AM335x GP EVM ships with a 256MiB NAND available in most profiles.  In
 this example to program the NAND we assume that an SD card has been
 inserted with the files to write in the first SD slot and that mtdparts
-have been configured correctly for the board.  As a time saving measure we
-load MLO into memory in one location, copy it into the three locatations
-that the ROM checks for additional valid copies, then load U-Boot into
-memory.  We then write that whole section of memory to NAND.
-
-U-Boot # mmc rescan
-U-Boot # env default -f -a
-U-Boot # nand erase.chip
-U-Boot # saveenv
-U-Boot # load mmc 0 81000000 MLO
-U-Boot # cp.b 81000000 81020000 20000
-U-Boot # cp.b 81000000 81040000 20000
-U-Boot # cp.b 81000000 81060000 20000
-U-Boot # load mmc 0 81080000 u-boot.img
-U-Boot # nand write 81000000 0 260000
-U-Boot # load mmc 0 ${loadaddr} uImage
-U-Boot # nand write ${loadaddr} kernel 500000
+have been configured correctly for the board. All images are first loaded
+into memory, then written to NAND.
+
+Step-1: Building u-boot for NAND boot
+	Set following CONFIGxx options for NAND device.
+	CONFIG_SYS_NAND_PAGE_SIZE	number of main bytes in NAND page
+	CONFIG_SYS_NAND_OOBSIZE		number of OOB bytes in NAND page
+	CONFIG_SYS_NAND_BLOCK_SIZE	number of bytes in NAND erase-block
+	CONFIG_SYS_NAND_ECCPOS		ECC map for NAND page
+	CONFIG_NAND_OMAP_ECCSCHEME	(refer doc/README.nand)
+
+Step-2: Flashing NAND via MMC/SD
+	# select BOOTSEL to MMC/SD boot and boot from MMC/SD card
+	U-Boot # mmc rescan
+	# erase flash
+	U-Boot # nand erase.chip
+	U-Boot # env default -f -a
+	U-Boot # saveenv
+	# flash MLO. Redundant copies of MLO are kept for failsafe
+	U-Boot # load mmc 0 0x82000000 MLO
+	U-Boot # nand write 0x82000000 0x00000 0x20000
+	U-Boot # nand write 0x82000000 0x20000 0x20000
+	U-Boot # nand write 0x82000000 0x40000 0x20000
+	U-Boot # nand write 0x82000000 0x60000 0x20000
+	# flash u-boot.img
+	U-Boot # load mmc 0 0x82000000 u-boot.img
+	U-Boot # nand write 0x82000000 0x80000 0x60000
+	# flash kernel image
+	U-Boot # load mmc 0 0x82000000 uImage
+	U-Boot # nand write 0x82000000 ${nandsrcaddr} ${nandimgsize}
+	# flash filesystem image
+	U-Boot # load mmc 0 0x82000000 filesystem.img
+	U-Boot # nand write 0x82000000 ${loadaddress} 0x300000
+
+Step-3: Set BOOTSEL pin to select NAND boot, and POR the device.
+	The device should boot from images flashed on NAND device.
 
 NOR
 ===
Signature · 1 line
1.8.1
#12 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

In reply to Pekon Gupta
Quoted 9 lines · Pekon Gupta

*changes in v8*
[PATCH 1/5] incorporated following feedbacks from Scott Wood <[email protected]>
- using symbolic names (enums) as values of CONFIG_NAND_OMAP_ECCSCHEME
- updated omap_select_ecc_scheme(): perform ecc-scheme compatibility checks before updating nand_chip.ecc fields. This avoids corrupting of existing ecc-scheme in case of switching failures.
- code clean-up (removed fall-back on omap_select_ecc_scheme() failures)
[PATCH 2/5], [PATCH 3/5], [PATCH 4/5] minor code clean-up
[PATCH 5/5] <no update>

Oops, I meant to reply before to v8, not v7 as I see those problems with v8.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131017/f06e8047/attachment.pgp>
#13 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

In reply to Pekon Gupta

Hi Pekon,

should I consider the U-Boot and Linux am335x NAND implementation to be compatible? So are the ECC schemes in a way identical that I can nandwrite a kernel image from Linux and "nand read" it from U-Boot? I tested with the 3.8.13 beaglebone kernel (which is of course not very representative) and it does not work. If it should work, do you know it that was already the case before your patches and with which Linux kernel?

Regards,
Matthias

Quoted 111 lines · Pekon Gupta

*changes in v8*
[PATCH 1/5] incorporated following feedbacks from Scott Wood <[email protected]>
- using symbolic names (enums) as values of CONFIG_NAND_OMAP_ECCSCHEME
- updated omap_select_ecc_scheme(): perform ecc-scheme compatibility checks before updating nand_chip.ecc fields. This avoids corrupting of existing ecc-scheme in case of switching failures.
- code clean-up (removed fall-back on omap_select_ecc_scheme() failures)
[PATCH 2/5], [PATCH 3/5], [PATCH 4/5] minor code clean-up
[PATCH 5/5] <no update>

*changes in v7*
[PATCH 1/5]
- omap_gpmc.c: fix: free bytes in OOB (ecclayout->oobfree[0].length)
- omap_gpmc.c: cleanup: redundant code added in previous patch versions
- am335x_evm.h: cleanup: redundant code added in previous patch versions
- tricorder.h: fix: CONFIG_NAND_OMAP_ECCSCHEME
[PATCH 2/5] removed: re-configuration of gpmc.config1[dev_width] added in
previous version of patch
[PATCH 3/5] <no update>
[PATCH 4/5] <no update>
[PATCH 5/5] minor fix: missing '$' in ${loadaddr}

*changes in v6*
[PATCH 1/5] incorporated feedbacks from Scott Wood <[email protected]>
- renamed CONFIG_SYS_NAND_ECCSCHEME to CONFIG_NAND_OMAP_ECCSCHEME
- updated omap_select_ecc_scheme() to handle error conditions without depending on caller.
- renamed OMAP_ECC_HAM1_CODE_HW_ROMCODE to OMAP_ECC_HAM1_CODE_HW to keep it naming compatible to linux kernel
- updated doc/README.nand and doc/README.omap3
[PATCH 2/5] minor code clean-up
[PATCH 3/5] minor code clean-up
[PATCH 4/5] <no update>
[PATCH 5/5] <moved CONFIG_NAND_OMAP_ECCSCHEME description to README.nand>

*changes in v5*
This version of patch is tested on am335x-evm with x8 NAND device, and boots SPL and u-boot from NAND
[PATCH 1/5]
- re-added omap_read_page_bch(): needed proper sequence of while reading DATA and ECC from NAND page, so that calc_ecc generated from GPMC is understood by ELM.
- added check to see if NAND OOB can accomodate ECC for entire page
[PATCH 2/5] fixed device-width in GPMC_CONFIG1_X to support x16 devices [PATCH 3/5] code clean-up for OMAP_ECC_BCH8_CODE_HW_DETECTION_SW mode [PATCH 4/5]
- fixed omap_correct_data_bch() for correcting bit-flips using ELM
- code-cleanup + added omap_reverse_list()
[PATCH 5/5] incorporated feedbacks from Peter Korsgaard <[email protected]>

*changes in v4*
[PATCH 1/5]
- removed omap_read_page_bch(): chip->ecc.read_page uses default API nand_read_page_hwecc() in nand_base.c
- updated tricorder.h: added new CONFIGS for ECCSCHEME & ONFI_DETECTION
- converted printf("ECC-SCHEME") to debug("ECC-SCHEME")
[PATCH 2/5] minor code clean-up
[PATCH 3/5] <no update>
[PATCH 4/5] <no update>
[PATCH 5/5] updated README as per feedbacks from trini at ti.com

*changes in v3*
[PATCH 1/5] (complete change)
- ecc-scheme is selection is controller by s/w, not CONFIG_NAND_xx
- added omap_select_ecc_scheme(), as common function to handle all ecc-scheme related configurations for both board_nand_init() & omap_nand_switch_ecc().
- removed un-used defines from asm/arch-am33xx/omap_gpmc.h
- updated doc/REAME.nand
[PATCH 2/5] removed un-used defines from asm/omap_gpmc.h [PATCH 3/5] removed omap_calculate_ecc_bch_sw() and omap_calculate_ecc()
and merged their logic into omap_calculate_ecc_bch()
[PATCH 4/5] updated return error-code in-case of invalid conditions [PATCH 5/5] (new) for board/ti/am335x/README

*changes in v2*
- added documentation for CONFIG_NAND_OMAP_xx in doc/README.nand
- added CONFIG_BCH along with CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW_DETECTION_SW to include software library lib/bch.c
- fixed board_nand_init() and omap_enable_hwecc()

*original v1*
This patch series updates BCH8_ECC schemes in mtd/nand/omap_gpmc.c driver
- adds scalability for higher ECC schemes in future.
- removes CONFIG_AM335x and it makes it generic for all platforms.
- optimizes read_data paths

Pekon Gupta (5):
[PATCH 1/5] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform [PATCH 2/5] mtd: nand: omap: optimize chip->ecc.hwctl() for H/W ECC schemes [PATCH 3/5] mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC schemes [PATCH 4/5] mtd: nand: omap: optimized chip->ecc.correct() for H/W ECC schemes [PATCH 5/5] board/ti/am335x/README: update for NAND boot

 arch/arm/include/asm/arch-am33xx/omap_gpmc.h |  52 +-
 arch/arm/include/asm/omap_gpmc.h             |   7 -
 board/ti/am335x/README                       |  53 +-
 doc/README.nand                              |  38 ++
 doc/README.omap3                             |   4 +-
 drivers/mtd/nand/omap_gpmc.c                 | 843 +++++++++++----------------
 include/configs/am335x_evm.h                 |  11 +-
 include/configs/tricorder.h                  |   3 +-
 8 files changed, 446 insertions(+), 565 deletions(-)
#14 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Pekon,
Thanks to Tom Rini's hint I have tried to execute your patch sets (
http://patchwork.ozlabs.org/project/uboot/list/?submitter=17320&state=*) in order to get Linux and U-Boot working with same NAND flash. Set-up is pretty much like Mathias has before in this chain. Latest problem I faced with is that last versions of 1) "[U-Boot,v8,3/5] mtd: nand: omap:
optimize chip->ecc.calculate() for H/W ECC schemes<http://patchwork.ozlabs.org/patch/282206/>"
and 2)
"[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC - NAND driver updates" <http://patchwork.ozlabs.org/patch/273769> are not compatible any more. As I told in
https://groups.google.com/forum/#!topic/beagleboard/7ofbE_Rrn_s versions v5..v7 of 1) could possibly be compatible.
Regards,
Matti

2013/11/1 Matthias Fuchs <[email protected]>

Quoted 155 lines

Hi Pekon,

should I consider the U-Boot and Linux am335x NAND implementation to be compatible?
So are the ECC schemes in a way identical that I can nandwrite a kernel image from
Linux and "nand read" it from U-Boot? I tested with the 3.8.13 beaglebone kernel (which
is of course not very representative) and it does not work. If it should work,
do you know it that was already the case before your patches and with which Linux kernel?

Regards,
Matthias

Quoted 2 lines · Pekon Gupta

*changes in v8*
[PATCH 1/5] incorporated following feedbacks from Scott Wood <

scottwood at freescale.com>

Quoted 1 line

- using symbolic names (enums) as values of

CONFIG_NAND_OMAP_ECCSCHEME

Quoted 1 line

- updated omap_select_ecc_scheme(): perform ecc-scheme

compatibility

Quoted 2 lines

checks before updating nand_chip.ecc fields. This avoids corrupting of existing ecc-scheme in case of switching

failures.

Quoted 1 line

- code clean-up (removed fall-back on omap_select_ecc_scheme()

failures)

Quoted 7 lines

[PATCH 2/5], [PATCH 3/5], [PATCH 4/5] minor code clean-up [PATCH 5/5] <no update>

*changes in v7*
[PATCH 1/5]
- omap_gpmc.c: fix: free bytes in OOB

(ecclayout->oobfree[0].length)

Quoted 1 line

- omap_gpmc.c: cleanup: redundant code added in previous patch

versions

Quoted 1 line

- am335x_evm.h: cleanup: redundant code added in previous patch

versions

Quoted 10 lines

- tricorder.h: fix: CONFIG_NAND_OMAP_ECCSCHEME
[PATCH 2/5] removed: re-configuration of gpmc.config1[dev_width] added in
previous version of patch
[PATCH 3/5] <no update>
[PATCH 4/5] <no update>
[PATCH 5/5] minor fix: missing '$' in ${loadaddr}

*changes in v6*
[PATCH 1/5] incorporated feedbacks from Scott Wood <

scottwood at freescale.com>

Quoted 2 lines

- renamed CONFIG_SYS_NAND_ECCSCHEME to CONFIG_NAND_OMAP_ECCSCHEME
- updated omap_select_ecc_scheme() to handle error conditions

without

Quoted 10 lines

depending on caller.
- renamed OMAP_ECC_HAM1_CODE_HW_ROMCODE to OMAP_ECC_HAM1_CODE_HW to keep it naming compatible to linux kernel
- updated doc/README.nand and doc/README.omap3
[PATCH 2/5] minor code clean-up
[PATCH 3/5] minor code clean-up
[PATCH 4/5] <no update>
[PATCH 5/5] <moved CONFIG_NAND_OMAP_ECCSCHEME description to README.nand>

Quoted 2 lines

*changes in v5*
This version of patch is tested on am335x-evm with x8 NAND device, and

boots

Quoted 3 lines

SPL and u-boot from NAND
[PATCH 1/5]
- re-added omap_read_page_bch(): needed proper sequence of while

reading

Quoted 9 lines

DATA and ECC from NAND page, so that calc_ecc generated from GPMC is understood by ELM.
- added check to see if NAND OOB can accomodate ECC for entire page
[PATCH 2/5] fixed device-width in GPMC_CONFIG1_X to support x16 devices [PATCH 3/5] code clean-up for OMAP_ECC_BCH8_CODE_HW_DETECTION_SW mode [PATCH 4/5]
- fixed omap_correct_data_bch() for correcting bit-flips using ELM
- code-cleanup + added omap_reverse_list()
[PATCH 5/5] incorporated feedbacks from Peter Korsgaard <

jacmet at sunsite.dk>

Quoted 5 lines

*changes in v4*
[PATCH 1/5]
- removed omap_read_page_bch(): chip->ecc.read_page uses default

API

Quoted 2 lines

nand_read_page_hwecc() in nand_base.c
- updated tricorder.h: added new CONFIGS for ECCSCHEME &

ONFI_DETECTION

Quoted 22 lines

- converted printf("ECC-SCHEME") to debug("ECC-SCHEME")
[PATCH 2/5] minor code clean-up
[PATCH 3/5] <no update>
[PATCH 4/5] <no update>
[PATCH 5/5] updated README as per feedbacks from trini at ti.com

*changes in v3*
[PATCH 1/5] (complete change)
- ecc-scheme is selection is controller by s/w, not CONFIG_NAND_xx
- added omap_select_ecc_scheme(), as common function to handle all ecc-scheme related configurations for both board_nand_init() & omap_nand_switch_ecc().
- removed un-used defines from asm/arch-am33xx/omap_gpmc.h
- updated doc/REAME.nand
[PATCH 2/5] removed un-used defines from asm/omap_gpmc.h [PATCH 3/5] removed omap_calculate_ecc_bch_sw() and omap_calculate_ecc()
and merged their logic into omap_calculate_ecc_bch()
[PATCH 4/5] updated return error-code in-case of invalid conditions [PATCH 5/5] (new) for board/ti/am335x/README

Quoted 3 lines

*changes in v2*
- added documentation for CONFIG_NAND_OMAP_xx in doc/README.nand
- added CONFIG_BCH along with

CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW_DETECTION_SW

Quoted 4 lines

to include software library lib/bch.c
- fixed board_nand_init() and omap_enable_hwecc()

Quoted 8 lines

*original v1*
This patch series updates BCH8_ECC schemes in mtd/nand/omap_gpmc.c driver
- adds scalability for higher ECC schemes in future.
- removes CONFIG_AM335x and it makes it generic for all platforms.
- optimizes read_data paths

Pekon Gupta (5):
[PATCH 1/5] mtd: nand: omap: enable BCH ECC scheme using ELM for generic

platform

Quoted 1 line

[PATCH 2/5] mtd: nand: omap: optimize chip->ecc.hwctl() for H/W ECC

schemes

Quoted 1 line

[PATCH 3/5] mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC

schemes

Quoted 1 line

[PATCH 4/5] mtd: nand: omap: optimized chip->ecc.correct() for H/W ECC

schemes

Quoted 8 lines

[PATCH 5/5] board/ti/am335x/README: update for NAND boot

 arch/arm/include/asm/arch-am33xx/omap_gpmc.h |  52 +-
 arch/arm/include/asm/omap_gpmc.h             |   7 -
 board/ti/am335x/README                       |  53 +-
 doc/README.nand                              |  38 ++
 doc/README.omap3                             |   4 +-
 drivers/mtd/nand/omap_gpmc.c                 | 843

+++++++++++----------------

Quoted 4 lines
 include/configs/am335x_evm.h                 |  11 +-
 include/configs/tricorder.h                  |   3 +-
 8 files changed, 446 insertions(+), 565 deletions(-)

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

A message that is not in the archive (sent off-list or not yet received): [email protected]

#16 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Matti and Matthias

Sorry I was away from my mailbox so couldn't reply you earlier. I'm still away from my setup and other boards, so cannot replicate the issue below until early next week. But I'll surely do so asap..

However, please see my replies below, which might help you someway.

Quoted 4 lines

From: matti kaasinen [mailto:matti.kaasinen at gmail.com] Hi Pekon,
Thanks to Tom Rini's hint I have tried to execute your patch sets
(http://patchwork.ozlabs.org/project/uboot/list/?submitter=17320&state=*)

Quoted 8 lines

in order to get Linux and U-Boot working with same NAND flash.
Set-up is pretty much like Mathias has before in this chain.
Latest problem I faced with is that last versions of
1) "[U-Boot,v8,3/5] mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC schemes" and 2) "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC - NAND driver updates"
are not compatible any more. As I told in
https://groups.google.com/forum/#!topic/beagleboard/7ofbE_Rrn_s
versions v5..v7 of 1) could possibly be compatible.

There is no change in ECC layout or other functional updates between v7 and v8 of this patch, so if there is any incompatibility then it would be in all versions of the patch..
Few questions..
(1) Which ECC scheme are you using ?
- u-boot

	CONFIG_NAND_OMAP_ECCSCHEME as per doc/README.nand
	http://lists.denx.de/pipermail/u-boot/2013-October/164646.html

- kernel
OMAP_ECC_BCH8_CODE_HW
OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
Or any other..

(2) Is the problem related to incorrect read/write access to x16 NAND ? Or
Is it incompatibility in ecc.layout ?
You can check this by dumping raw nand page via 'nand dump' command from both u-boot and kernel.

(3) you should not pick BCH16 patch-series
- because I have not rebased this patch, and re-tested since other base patch-series on which BCH16 will be build, is still not accepted.
- Also BCH16 ecc scheme would work only for
NAND device with pagesize=4K and oobsize=224.
whereas current beaglebone capes have
NAND device with pagesize=2K and oobsize=64, so you can only use BCH8 with current NAND capes (for now)..

Quoted 10 lines
Quoted 10 lines

2013/11/1 Matthias Fuchs <[email protected]>
Hi Pekon,

should I consider the U-Boot and Linux am335x NAND implementation to be compatible? So are the ECC schemes in a way identical that I can nandwrite a kernel image from Linux and "nand read" it from U-Boot? I tested with the 3.8.13 beaglebone kernel (which is of course not very representative)
and it does not work. If it should work, do you know it that was
already the case before your patches and with which Linux kernel?

I don't think any earlier kernel versions ever supported beaglebone Its only recently that a major patch-series of NAND driver was accepted and tested on beaglebone.
The patches are currently in l2-mtd.git tree which should make into 3.13 kernel, before being in linux-next for sometime.
(a) Reference:
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049462.html

(b) In addition to above series, you might need beaglebone DTS updates which you can refer from below ..
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049438.html

with regards, pekon

#17 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Pekon,
Thank you for your answers. Please find my answers/comments to your questions below.

2013/11/6 Gupta, Pekon <[email protected]>

Quoted 20 lines

Hi Matti and Matthias

Sorry I was away from my mailbox so couldn't reply you earlier. I'm still away from my setup and other boards, so cannot replicate the issue below until early next week. But I'll surely do so asap..

However, please see my replies below, which might help you someway.

Quoted 4 lines

From: matti kaasinen [mailto:matti.kaasinen at gmail.com] Hi Pekon,
Thanks to Tom Rini's hint I have tried to execute your patch sets
(http://patchwork.ozlabs.org/project/uboot/list/?submitter=17320&state=*

)

Quoted 4 lines

in order to get Linux and U-Boot working with same NAND flash.
Set-up is pretty much like Mathias has before in this chain. Latest problem I faced with is that last versions of
1) "[U-Boot,v8,3/5] mtd: nand: omap: optimize chip->ecc.calculate()

for H/W ECC schemes"

Quoted 1 line

and 2) "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC -

Quoted 9 lines

NAND driver updates"

Quoted 3 lines

are not compatible any more. As I told in
https://groups.google.com/forum/#!topic/beagleboard/7ofbE_Rrn_s
versions v5..v7 of 1) could possibly be compatible.

There is no change in ECC layout or other functional updates between v7 and v8 of this patch, so if there is any incompatibility then it would be in all versions of the patch..

I did not mean "ECC layout-wisely" incompatible but "patching-wisely" incompatible. Patching 2) v2 after 1) v8 stops to errors and it seems that with 1) v7 it could (possibly) succeed.

Few questions..

Quoted 2 lines

(1) Which ECC scheme are you using ?

Now I'm talking Linux 3.8.13 - U-Boot 10.04 combination that I have as currently as "working" environment. I have not managed getting above patches successfully through.

Quoted 4 lines

- u-boot
CONFIG_NAND_OMAP_ECCSCHEME as per doc/README.nand
http://lists.denx.de/pipermail/u-boot/2013-October/164646.html

U-Boot 10.04 does not seem to have such choices and in fact I have not selected it.

Quoted 5 lines

- kernel
OMAP_ECC_BCH8_CODE_HW
OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
Or any other..

I believe OMAP_ECC_BCH8_CODE_HW gets selected with following options from kernel.

CONFIG_MTD_NAND_OMAP2
CONFIG_MTD_NAND_OMAP_BCH
CONFIG_MTD_NAND_OMAP_BCH8

... and selecting following choice

ti,nand-ecc-opt = "bch8"

in device tree.

With these options boot process reports;

[    1.128154] enabling NAND BCH ecc with 8-bit correction
[    1.133985] ONFI param page 0 valid
[    1.137662] ONFI flash detected
[    1.140985] NAND device: Manufacturer ID: 0x2c, Chip ID: 0xda (Micron

MT29F2G08AAD), 256MiB, page size: 2048, OOB size: 64

First line seems coming from drivers/nand/mtd/omap2.c:omap3_init_bch that gets printed in this from only if OMAP_ECC_BCH8_CODE_HW == platform_data.ecc_opt

I printed nand.ecc.layout.eccbytes = 52 ( from from drivers/nand/mtd/omap2.c:omap3_init_bch_tail ) and
nand.ecc.layout->eccpos[] = 12..63

BTW it seems that similar layout has been defined in u-boot arch/arm/include/asm/arch-omap3/omap_gpmc.h
There is one exception, though: eccbytes have been set 54 instead of 52 that seems to be in linux (and correct I suppose).

Quoted 4 lines

(2) Is the problem related to incorrect read/write access to x16 NAND ?

No using x8 NAND

Quoted 3 lines

Or
Is it incompatibility in ecc.layout ?

You can check this by dumping raw nand page via 'nand dump' command

Quoted 3 lines

from both u-boot and kernel.

I'll try to check this

Quoted 1 line

(3) you should not pick BCH16 patch-series

Quoted 8 lines

- because I have not rebased this patch, and re-tested since other base patch-series on which BCH16 will be build, is still not accepted.
- Also BCH16 ecc scheme would work only for
NAND device with pagesize=4K and oobsize=224.
whereas current beaglebone capes have
NAND device with pagesize=2K and oobsize=64, so you can only use BCH8 with current NAND capes (for now)..

This is perfectly fine with me. This set seems to block patching. I need only BCH8 and if this patch set provides only BCH16 functionality and nothing else, I need not using it.

Quoted 24 lines
Quoted 8 lines
Quoted 8 lines

2013/11/1 Matthias Fuchs <[email protected]>
Hi Pekon,

Quoted 7 lines
Quoted 7 lines

should I consider the U-Boot and Linux am335x NAND implementation to be compatible? So are the ECC schemes in a way identical that I can nandwrite a kernel image from Linux and "nand read" it from U-Boot? I tested with the 3.8.13 beaglebone kernel (which is of course not very representative)
and it does not work. If it should work, do you know it that was
already the case before your patches and with which Linux kernel?

I don't think any earlier kernel versions ever supported beaglebone Its only recently that a major patch-series of NAND driver was accepted and tested on beaglebone.
The patches are currently in l2-mtd.git tree which should make into 3.13 kernel, before being in linux-next for sometime.
(a) Reference:
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049462.html

Quoted 5 lines

(b) In addition to above series, you might need beaglebone DTS updates which you can refer from below ..
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049438.html

So, you mean that it should not be possible to access beaglebone (alike)

board NAND with Linux 3.8.13. However, it seems that I can access it from Linux (well, I have done some patching for IO and mux and device tree). Problem really is that U-Boot and Linux handle it in different ways so that if I create e.g. ubifs volume in Linux, that works quite fine. I can rean/write it quite fine. However, if I mount it from U-boot, it get tons of ecc error messages and as a result it gets corrupted. After that also Linux side prints tons of ecc error messages while acessing it.

Quoted 2 lines

with regards, pekon

Thanks,
Matti

#18 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Pekon,
Please find the nand dumps from oob area below. UBIFS volume created and edited in Linux.

Linux:
OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff 5c 87 73 23 OOB Data: ae 36 a6 16 fc 81 dd 8e f0 ff ff ff ff ff ff ff OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff

U-Boot:
OOB:
ff ff ff ff ff ff ff ff
ff ff ff ff 90 df 27 b0
f7 8c db 4c 0e 76 25 7e
a9 ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff

Best regards,
Matti

2013/11/7 matti kaasinen <[email protected]>

Quoted 169 lines

Hi Pekon,
Thank you for your answers. Please find my answers/comments to your questions below.

2013/11/6 Gupta, Pekon <[email protected]>

Hi Matti and Matthias

Quoted 19 lines

Sorry I was away from my mailbox so couldn't reply you earlier. I'm still away from my setup and other boards, so cannot replicate the issue below until early next week. But I'll surely do so asap..

However, please see my replies below, which might help you someway.

Quoted 4 lines

From: matti kaasinen [mailto:matti.kaasinen at gmail.com] Hi Pekon,
Thanks to Tom Rini's hint I have tried to execute your patch sets (

http://patchwork.ozlabs.org/project/uboot/list/?submitter=17320&state=*)

Quoted 4 lines

in order to get Linux and U-Boot working with same NAND flash.
Set-up is pretty much like Mathias has before in this chain. Latest problem I faced with is that last versions of
1) "[U-Boot,v8,3/5] mtd: nand: omap: optimize chip->ecc.calculate()

for H/W ECC schemes"

Quoted 1 line

and 2) "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC -

Quoted 9 lines

NAND driver updates"

Quoted 3 lines

are not compatible any more. As I told in
https://groups.google.com/forum/#!topic/beagleboard/7ofbE_Rrn_s
versions v5..v7 of 1) could possibly be compatible.

There is no change in ECC layout or other functional updates between v7 and v8 of this patch, so if there is any incompatibility then it would be in all versions of the patch..

I did not mean "ECC layout-wisely" incompatible but "patching-wisely" incompatible. Patching 2) v2 after 1) v8 stops to errors and it seems that with 1) v7 it could (possibly) succeed.

Few questions..

Quoted 2 lines

(1) Which ECC scheme are you using ?

Now I'm talking Linux 3.8.13 - U-Boot 10.04 combination that I have as currently as "working" environment. I have not managed getting above patches successfully through.

Quoted 4 lines

- u-boot
CONFIG_NAND_OMAP_ECCSCHEME as per doc/README.nand
http://lists.denx.de/pipermail/u-boot/2013-October/164646.html

U-Boot 10.04 does not seem to have such choices and in fact I have not selected it.

Quoted 5 lines

- kernel
OMAP_ECC_BCH8_CODE_HW
OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
Or any other..

I believe OMAP_ECC_BCH8_CODE_HW gets selected with following options from kernel.

CONFIG_MTD_NAND_OMAP2
CONFIG_MTD_NAND_OMAP_BCH
CONFIG_MTD_NAND_OMAP_BCH8

... and selecting following choice

ti,nand-ecc-opt = "bch8"

in device tree.

With these options boot process reports;

[    1.128154] enabling NAND BCH ecc with 8-bit correction
[    1.133985] ONFI param page 0 valid
[    1.137662] ONFI flash detected
[    1.140985] NAND device: Manufacturer ID: 0x2c, Chip ID: 0xda (Micron

MT29F2G08AAD), 256MiB, page size: 2048, OOB size: 64

First line seems coming from drivers/nand/mtd/omap2.c:omap3_init_bch that gets printed in this from only if OMAP_ECC_BCH8_CODE_HW == platform_data.ecc_opt

I printed nand.ecc.layout.eccbytes = 52 ( from from drivers/nand/mtd/omap2.c:omap3_init_bch_tail ) and
nand.ecc.layout->eccpos[] = 12..63

BTW it seems that similar layout has been defined in u-boot arch/arm/include/asm/arch-omap3/omap_gpmc.h
There is one exception, though: eccbytes have been set 54 instead of 52 that seems to be in linux (and correct I suppose).

Quoted 4 lines

(2) Is the problem related to incorrect read/write access to x16 NAND ?

No using x8 NAND

Quoted 3 lines

Or
Is it incompatibility in ecc.layout ?

You can check this by dumping raw nand page via 'nand dump' command

Quoted 3 lines

from both u-boot and kernel.

I'll try to check this

Quoted 1 line

(3) you should not pick BCH16 patch-series

Quoted 8 lines

- because I have not rebased this patch, and re-tested since other base patch-series on which BCH16 will be build, is still not accepted.
- Also BCH16 ecc scheme would work only for
NAND device with pagesize=4K and oobsize=224.
whereas current beaglebone capes have
NAND device with pagesize=2K and oobsize=64, so you can only use BCH8 with current NAND capes (for now)..

This is perfectly fine with me. This set seems to block patching. I need only BCH8 and if this patch set provides only BCH16 functionality and nothing else, I need not using it.

Quoted 24 lines
Quoted 8 lines
Quoted 8 lines

2013/11/1 Matthias Fuchs <[email protected]>
Hi Pekon,

Quoted 7 lines
Quoted 7 lines

should I consider the U-Boot and Linux am335x NAND implementation to be compatible? So are the ECC schemes in a way identical that I can nandwrite a kernel image from Linux and "nand read" it from U-Boot? I tested with the 3.8.13 beaglebone kernel (which is of course not very representative)
and it does not work. If it should work, do you know it that was
already the case before your patches and with which Linux kernel?

I don't think any earlier kernel versions ever supported beaglebone Its only recently that a major patch-series of NAND driver was accepted and tested on beaglebone.
The patches are currently in l2-mtd.git tree which should make into 3.13 kernel, before being in linux-next for sometime.
(a) Reference:
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049462.html

Quoted 5 lines

(b) In addition to above series, you might need beaglebone DTS updates which you can refer from below ..
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049438.html

So, you mean that it should not be possible to access beaglebone (alike)

board NAND with Linux 3.8.13. However, it seems that I can access it from Linux (well, I have done some patching for IO and mux and device tree). Problem really is that U-Boot and Linux handle it in different ways so that if I create e.g. ubifs volume in Linux, that works quite fine. I can rean/write it quite fine. However, if I mount it from U-boot, it get tons of ecc error messages and as a result it gets corrupted. After that also Linux side prints tons of ecc error messages while acessing it.

Quoted 2 lines

with regards, pekon

Thanks,
Matti

#19 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Pekon,
It seems after patching without BCH16 patches that at least OMAP_ECC_BCH8_CODE_HW can't be compatible with Linux 3.8.13 mode. U-Boot drivers/mtd/nand/omap_gpmc.c:omap_select_ecc_scheme states that nand->ecc.bytes = 14 whereas in OMAP_ECC_BCH8_CODE_HW_DETECTION_SW mode setting seems to be 13. Therefore, OMAP_ECC_BCH8_CODE_HW_DETECTION_SW could possibly be compatible.

I have not got change to try it, though as I do have Angstrom related problems (I need to fix license path/md5 checksum to get build pass).

-Matti

2013/11/7 matti kaasinen <[email protected]>

Quoted 198 lines

Pekon,
Please find the nand dumps from oob area below. UBIFS volume created and edited in Linux.

Linux:
OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff 5c 87 73 23 OOB Data: ae 36 a6 16 fc 81 dd 8e f0 ff ff ff ff ff ff ff OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff

U-Boot:
OOB:
ff ff ff ff ff ff ff ff
ff ff ff ff 90 df 27 b0
f7 8c db 4c 0e 76 25 7e
a9 ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff

Best regards,
Matti

2013/11/7 matti kaasinen <[email protected]>

Quoted 169 lines

Hi Pekon,
Thank you for your answers. Please find my answers/comments to your questions below.

2013/11/6 Gupta, Pekon <[email protected]>

Hi Matti and Matthias

Quoted 19 lines

Sorry I was away from my mailbox so couldn't reply you earlier. I'm still away from my setup and other boards, so cannot replicate the issue below until early next week. But I'll surely do so asap..

However, please see my replies below, which might help you someway.

Quoted 4 lines

From: matti kaasinen [mailto:matti.kaasinen at gmail.com] Hi Pekon,
Thanks to Tom Rini's hint I have tried to execute your patch sets (

http://patchwork.ozlabs.org/project/uboot/list/?submitter=17320&state=*)

Quoted 4 lines

in order to get Linux and U-Boot working with same NAND flash.
Set-up is pretty much like Mathias has before in this chain. Latest problem I faced with is that last versions of
1) "[U-Boot,v8,3/5] mtd: nand: omap: optimize chip->ecc.calculate()

for H/W ECC schemes"

Quoted 1 line

and 2) "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC -

Quoted 9 lines

NAND driver updates"

Quoted 3 lines

are not compatible any more. As I told in
https://groups.google.com/forum/#!topic/beagleboard/7ofbE_Rrn_s
versions v5..v7 of 1) could possibly be compatible.

There is no change in ECC layout or other functional updates between v7 and v8 of this patch, so if there is any incompatibility then it would be in all versions of the patch..

I did not mean "ECC layout-wisely" incompatible but "patching-wisely" incompatible. Patching 2) v2 after 1) v8 stops to errors and it seems that with 1) v7 it could (possibly) succeed.

Few questions..

Quoted 2 lines

(1) Which ECC scheme are you using ?

Now I'm talking Linux 3.8.13 - U-Boot 10.04 combination that I have as currently as "working" environment. I have not managed getting above patches successfully through.

Quoted 4 lines

- u-boot
CONFIG_NAND_OMAP_ECCSCHEME as per doc/README.nand
http://lists.denx.de/pipermail/u-boot/2013-October/164646.html

U-Boot 10.04 does not seem to have such choices and in fact I have not selected it.

Quoted 5 lines

- kernel
OMAP_ECC_BCH8_CODE_HW
OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
Or any other..

I believe OMAP_ECC_BCH8_CODE_HW gets selected with following options from kernel.

CONFIG_MTD_NAND_OMAP2
CONFIG_MTD_NAND_OMAP_BCH
CONFIG_MTD_NAND_OMAP_BCH8

... and selecting following choice

ti,nand-ecc-opt = "bch8"

in device tree.

With these options boot process reports;

[    1.128154] enabling NAND BCH ecc with 8-bit correction
[    1.133985] ONFI param page 0 valid
[    1.137662] ONFI flash detected
[    1.140985] NAND device: Manufacturer ID: 0x2c, Chip ID: 0xda (Micron

MT29F2G08AAD), 256MiB, page size: 2048, OOB size: 64

First line seems coming from drivers/nand/mtd/omap2.c:omap3_init_bch that gets printed in this from only if OMAP_ECC_BCH8_CODE_HW == platform_data.ecc_opt

I printed nand.ecc.layout.eccbytes = 52 ( from from drivers/nand/mtd/omap2.c:omap3_init_bch_tail ) and
nand.ecc.layout->eccpos[] = 12..63

BTW it seems that similar layout has been defined in u-boot arch/arm/include/asm/arch-omap3/omap_gpmc.h
There is one exception, though: eccbytes have been set 54 instead of 52 that seems to be in linux (and correct I suppose).

Quoted 4 lines

(2) Is the problem related to incorrect read/write access to x16 NAND ?

No using x8 NAND

Quoted 3 lines

Or
Is it incompatibility in ecc.layout ?

You can check this by dumping raw nand page via 'nand dump' command

Quoted 3 lines

from both u-boot and kernel.

I'll try to check this

Quoted 1 line

(3) you should not pick BCH16 patch-series

Quoted 8 lines

- because I have not rebased this patch, and re-tested since other base patch-series on which BCH16 will be build, is still not accepted.
- Also BCH16 ecc scheme would work only for
NAND device with pagesize=4K and oobsize=224.
whereas current beaglebone capes have
NAND device with pagesize=2K and oobsize=64, so you can only use BCH8 with current NAND capes (for now)..

This is perfectly fine with me. This set seems to block patching. I need only BCH8 and if this patch set provides only BCH16 functionality and nothing else, I need not using it.

Quoted 24 lines
Quoted 8 lines
Quoted 8 lines

2013/11/1 Matthias Fuchs <[email protected]>
Hi Pekon,

Quoted 7 lines
Quoted 7 lines

should I consider the U-Boot and Linux am335x NAND implementation to be compatible? So are the ECC schemes in a way identical that I can nandwrite a kernel image from Linux and "nand read" it from U-Boot? I tested with the 3.8.13 beaglebone kernel (which is of course not very representative)
and it does not work. If it should work, do you know it that was
already the case before your patches and with which Linux kernel?

I don't think any earlier kernel versions ever supported beaglebone Its only recently that a major patch-series of NAND driver was accepted and tested on beaglebone.
The patches are currently in l2-mtd.git tree which should make into 3.13 kernel, before being in linux-next for sometime.
(a) Reference:
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049462.html

Quoted 5 lines

(b) In addition to above series, you might need beaglebone DTS updates which you can refer from below ..
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049438.html

So, you mean that it should not be possible to access beaglebone (alike)

board NAND with Linux 3.8.13. However, it seems that I can access it from Linux (well, I have done some patching for IO and mux and device tree). Problem really is that U-Boot and Linux handle it in different ways so that if I create e.g. ubifs volume in Linux, that works quite fine. I can rean/write it quite fine. However, if I mount it from U-boot, it get tons of ecc error messages and as a result it gets corrupted. After that also Linux side prints tons of ecc error messages while acessing it.

Quoted 2 lines

with regards, pekon

Thanks,
Matti

#20 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Matti,

I have recently posted another version of patch-set, (splitting the patch series into two parts).

I was able to boot kernel on beaglebone-LT (white) + x16 NAND cape,

using UBIFS flashed via u-boot using following updates:

(a) Patch to add beaglebone pin-mux support

                http://lists.denx.de/pipermail/u-boot/2013-September/163881.html

(b) Hack in board-file to configure GPMC for x16 device

--------------

arch/arm/cpu/armv7/am33xx/mem.c +0 -0

index 56c9e7d..b166a94 100644

--- a/arch/arm/cpu/armv7/am33xx/mem.c

+++ b/arch/arm/cpu/armv7/am33xx/mem.c

@@ -64,7 +64,7 @@ void gpmc_init(void)

        u32 base = CONFIG_SYS_FLASH_BASE;

#elif defined(CONFIG_NAND)

/* configure GPMC for NAND */

- const u32 gpmc_regs[GPMC_MAX_REG] = { M_NAND_GPMC_CONFIG1,

+ const u32 gpmc_regs[GPMC_MAX_REG] = { M_NAND_GPMC_CONFIG1 | 0x1000,

M_NAND_GPMC_CONFIG2,

M_NAND_GPMC_CONFIG3,

M_NAND_GPMC_CONFIG4,

--------------

I followed following steps to boot beaglebone from ubifs image..

                /* Step-1: flash boot-loader on NAND from MMC */

                fatload mmc 0 0x82000000 MLO

                nand erase 0x0000 0x20000

                nand write 0x82000000 0x00000 0x20000

                fatload mmc 0 0x82000000 u-boot.img

                nand erase 0x80000 0x60000

                nand write 0x82000000 0x80000 0x60000



                /* Step-2: flash file-system on NAND from MMC */

                fatload mmc 0 0x82000000 ubifs.img

                nand erase 0x780000 0xf880000

                nand write 0x82000000 0x780000 <file-system image size>



                /*Step-3: set boot args */

                setenv bootargs 'console=ttyO0,115200n8 noinitrd mem=256M root=ubi0 \

                                                rw rootfstype=ubifs ubi.mtd=7,2048 ip=off init=/init'



                /* Step-4: load kernel from MMC and boot */

                fatload mmc 0 0x82000000 uImage

                bootm 0x82000000

Important: I'm using 'OMAP_ECC_BCH8_CODE_HW' as ecc-scheme for

both kernel and u-boot. (ecc.bytes=14)

Please let me know if it works for you...

with regards, pekon

________________________________
From: matti kaasinen [matti.kaasinen at gmail.com]
Sent: Thursday, November 07, 2013 6:11 PM
To: Gupta, Pekon
Cc: Matthias Fuchs; Rini, Tom; scottwood at freescale.com; u-boot at lists.denx.de; Balbi, Felipe
Subject: Re: [U-Boot] [PATCH v8 0/5] mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Pekon,
It seems after patching without BCH16 patches that at least OMAP_ECC_BCH8_CODE_HW can't be compatible with Linux 3.8.13 mode. U-Boot drivers/mtd/nand/omap_gpmc.c:omap_select_ecc_scheme states that nand->ecc.bytes = 14 whereas in OMAP_ECC_BCH8_CODE_HW_DETECTION_SW mode setting seems to be 13. Therefore, OMAP_ECC_BCH8_CODE_HW_DETECTION_SW could possibly be compatible.

I have not got change to try it, though as I do have Angstrom related problems (I need to fix license path/md5 checksum to get build pass).

-Matti

2013/11/7 matti kaasinen <matti.kaasinen at gmail.com<mailto:[email protected]>> Pekon,
Please find the nand dumps from oob area below. UBIFS volume created and edited in Linux.

Linux:
OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff 5c 87 73 23 OOB Data: ae 36 a6 16 fc 81 dd 8e f0 ff ff ff ff ff ff ff OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff

U-Boot:
OOB:
ff ff ff ff ff ff ff ff
ff ff ff ff 90 df 27 b0
f7 8c db 4c 0e 76 25 7e
a9 ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff

Best regards,
Matti

2013/11/7 matti kaasinen <matti.kaasinen at gmail.com<mailto:[email protected]>> Hi Pekon,
Thank you for your answers. Please find my answers/comments to your questions below.

2013/11/6 Gupta, Pekon <pekon at ti.com<mailto:[email protected]>>

Hi Matti and Matthias

Sorry I was away from my mailbox so couldn't reply you earlier. I'm still away from my setup and other boards, so cannot replicate the issue below until early next week. But I'll surely do so asap..

However, please see my replies below, which might help you someway.

Quoted 4 lines

From: matti kaasinen [mailto:matti.kaasinen at gmail.com<mailto:[email protected]>] Hi Pekon,
Thanks to Tom Rini's hint I have tried to execute your patch sets
(http://patchwork.ozlabs.org/project/uboot/list/?submitter=17320&state=*)

Quoted 8 lines

in order to get Linux and U-Boot working with same NAND flash.
Set-up is pretty much like Mathias has before in this chain.
Latest problem I faced with is that last versions of
1) "[U-Boot,v8,3/5] mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC schemes" and 2) "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC - NAND driver updates"
are not compatible any more. As I told in
https://groups.google.com/forum/#!topic/beagleboard/7ofbE_Rrn_s
versions v5..v7 of 1) could possibly be compatible.

There is no change in ECC layout or other functional updates between v7 and v8 of this patch, so if there is any incompatibility then it would be in all versions of the patch..

I did not mean "ECC layout-wisely" incompatible but "patching-wisely" incompatible. Patching 2) v2 after 1) v8 stops to errors and it seems that with 1) v7 it could (possibly) succeed.

Few questions..
(1) Which ECC scheme are you using ?

Now I'm talking Linux 3.8.13 - U-Boot 10.04 combination that I have as currently as "working" environment. I have not managed getting above patches successfully through.
- u-boot
CONFIG_NAND_OMAP_ECCSCHEME as per doc/README.nand
http://lists.denx.de/pipermail/u-boot/2013-October/164646.html
U-Boot 10.04 does not seem to have such choices and in fact I have not selected it.
- kernel
OMAP_ECC_BCH8_CODE_HW
OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
Or any other..

I believe OMAP_ECC_BCH8_CODE_HW gets selected with following options from kernel.

CONFIG_MTD_NAND_OMAP2
CONFIG_MTD_NAND_OMAP_BCH
CONFIG_MTD_NAND_OMAP_BCH8

... and selecting following choice

ti,nand-ecc-opt = "bch8"

in device tree.

With these options boot process reports;

[    1.128154] enabling NAND BCH ecc with 8-bit correction
[    1.133985] ONFI param page 0 valid
[    1.137662] ONFI flash detected
[    1.140985] NAND device: Manufacturer ID: 0x2c, Chip ID: 0xda (Micron MT29F2G08AAD), 256MiB, page size: 2048, OOB size: 64

First line seems coming from drivers/nand/mtd/omap2.c:omap3_init_bch that gets printed in this from only if OMAP_ECC_BCH8_CODE_HW == platform_data.ecc_opt

I printed nand.ecc.layout.eccbytes = 52 ( from from drivers/nand/mtd/omap2.c:omap3_init_bch_tail ) and
nand.ecc.layout->eccpos[] = 12..63

BTW it seems that similar layout has been defined in u-boot arch/arm/include/asm/arch-omap3/omap_gpmc.h
There is one exception, though: eccbytes have been set 54 instead of 52 that seems to be in linux (and correct I suppose).

(2) Is the problem related to incorrect read/write access to x16 NAND ? No using x8 NAND
Or
Is it incompatibility in ecc.layout ?
You can check this by dumping raw nand page via 'nand dump' command from both u-boot and kernel.

I'll try to check this

(3) you should not pick BCH16 patch-series
- because I have not rebased this patch, and re-tested since other
base patch-series on which BCH16 will be build, is still not accepted.
- Also BCH16 ecc scheme would work only for
NAND device with pagesize=4K and oobsize=224.
whereas current beaglebone capes have
NAND device with pagesize=2K and oobsize=64, so you can only use
BCH8 with current NAND capes (for now)..
This is perfectly fine with me. This set seems to block patching. I need only BCH8 and if this patch set provides only BCH16 functionality and nothing else, I need not using it.

Quoted 10 lines
Quoted 10 lines

2013/11/1 Matthias Fuchs <mfuchs at ma-fu.de<mailto:[email protected]>> Hi Pekon,

should I consider the U-Boot and Linux am335x NAND implementation to be compatible? So are the ECC schemes in a way identical that I can nandwrite a kernel image from Linux and "nand read" it from U-Boot? I tested with the 3.8.13 beaglebone kernel (which is of course not very representative)
and it does not work. If it should work, do you know it that was
already the case before your patches and with which Linux kernel?

I don't think any earlier kernel versions ever supported beaglebone Its only recently that a major patch-series of NAND driver was accepted and tested on beaglebone.
The patches are currently in l2-mtd.git tree which should make into 3.13 kernel, before being in linux-next for sometime.
(a) Reference:
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049462.html

(b) In addition to above series, you might need beaglebone DTS updates which you can refer from below ..
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049438.html

So, you mean that it should not be possible to access beaglebone (alike) board NAND with Linux 3.8.13. However, it seems that I can access it from Linux (well, I have done some patching for IO and mux and device tree). Problem really is that U-Boot and Linux handle it in different ways so that if I create e.g. ubifs volume in Linux, that works quite fine. I can rean/write it quite fine. However, if I mount it from U-boot, it get tons of ecc error messages and as a result it gets corrupted. After that also Linux side prints tons of ecc error messages while acessing it.

with regards, pekon
Thanks,
Matti

#21 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Pekon,
Great to hear that you have managed in that. I tried that with previous patch sets (and re-writing beaglebone paches). Result was such that oob printout from u-boot had full of ff.
Well, partition map was different on u-boot and Linux sides. However, partition that I tried to acces was in the same physical address (partition 8 in u-boot and partition 7 in Linux). It somewhat lame down my mood... Anyway, sounds that you have written those beaglebone patches, too- so that I need not re-writing them again. I'll come back when I have something to report.

You mentioned, that OMAP_ECC_BCH8_CODE_HW mode and ecc.bytes=14 has to be used. I suppose that at least the former option requires kernel patching like explained in
http://processors.wiki.ti.com/index.php/AM35x-OMAP35x-PSP_04.02.00.07_UserGuide#Selecting_NAND_ECC_scheme_for_Linux_Kernel
In any case I did not find configuration option in menuconfig for that. Will "ecc.bytes=14" setting be taken care by that selection, too? -Matti

2013/11/15 Gupta, Pekon <[email protected]>

Quoted 347 lines

Hi Matti,

I have recently posted another version of patch-set, (splitting the patch series into two parts).

I was able to boot kernel on beaglebone-LT (white) + x16 NAND cape,

using UBIFS flashed via u-boot using following updates:

(a) Patch to add beaglebone pin-mux support

http://lists.denx.de/pipermail/u-boot/2013-September/163881.html

(b) Hack in board-file to configure GPMC for x16 device

--------------

arch/arm/cpu/armv7/am33xx/mem.c +0 -0

index 56c9e7d..b166a94 100644

--- a/arch/arm/cpu/armv7/am33xx/mem.c

+++ b/arch/arm/cpu/armv7/am33xx/mem.c

arch/arm/cpu/armv7/am33xx/mem.c +1 -1
@@ -64,7 +64,7 @@ void gpmc_init(void)
 
        u32 base = CONFIG_SYS_FLASH_BASE;
 
 #elif defined(CONFIG_NAND)
 
 /* configure GPMC for NAND */
 
-       const u32  gpmc_regs[GPMC_MAX_REG] = {  M_NAND_GPMC_CONFIG1,
 
+       const u32  gpmc_regs[GPMC_MAX_REG] = {  M_NAND_GPMC_CONFIG1 |

0x1000,

M_NAND_GPMC_CONFIG2,

M_NAND_GPMC_CONFIG3,

M_NAND_GPMC_CONFIG4,

--------------

I followed following steps to boot beaglebone from ubifs image..

                /* Step-1: flash boot-loader on NAND from MMC */

                fatload mmc 0 0x82000000 MLO

                nand erase 0x0000 0x20000

                nand write 0x82000000 0x00000 0x20000

                fatload mmc 0 0x82000000 u-boot.img

                nand erase 0x80000 0x60000

                nand write 0x82000000 0x80000 0x60000



                /* Step-2: flash file-system on NAND from MMC */

                fatload mmc 0 0x82000000 ubifs.img

                nand erase 0x780000 0xf880000

                nand write 0x82000000 0x780000 <file-system image size>



                /*Step-3: set boot args */

                setenv bootargs 'console=ttyO0,115200n8 noinitrd mem=256M

root=ubi0 \

rw rootfstype=ubifs
ubi.mtd=7,2048 ip=off init=/init'

                /* Step-4: load kernel from MMC and boot */

                fatload mmc 0 0x82000000 uImage

                bootm 0x82000000

Important: I'm using 'OMAP_ECC_BCH8_CODE_HW' as ecc-scheme for

both kernel and u-boot. (ecc.bytes=14)

Please let me know if it works for you...

with regards, pekon

------------------------------
*From:* matti kaasinen [matti.kaasinen at gmail.com] *Sent:* Thursday, November 07, 2013 6:11 PM
*To:* Gupta, Pekon
*Cc:* Matthias Fuchs; Rini, Tom; scottwood at freescale.com; u-boot at lists.denx.de; Balbi, Felipe
*Subject:* Re: [U-Boot] [PATCH v8 0/5] mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Pekon,
It seems after patching without BCH16 patches that at least
OMAP_ECC_BCH8_CODE_HW can't be compatible with Linux 3.8.13 mode. U-Boot drivers/mtd/nand/omap_gpmc.c:omap_select_ecc_scheme states that nand->ecc.bytes = 14 whereas in OMAP_ECC_BCH8_CODE_HW_DETECTION_SW mode setting seems to be 13. Therefore, OMAP_ECC_BCH8_CODE_HW_DETECTION_SW could possibly be compatible.

I have not got change to try it, though as I do have Angstrom related
problems (I need to fix license path/md5 checksum to get build pass).

-Matti

2013/11/7 matti kaasinen <[email protected]>

Quoted 201 lines

Pekon,
Please find the nand dumps from oob area below. UBIFS volume created and
edited in Linux.

Linux:
OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff 5c 87 73 23 OOB Data: ae 36 a6 16 fc 81 dd 8e f0 ff ff ff ff ff ff ff OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff

U-Boot:
OOB:
ff ff ff ff ff ff ff ff
ff ff ff ff 90 df 27 b0
f7 8c db 4c 0e 76 25 7e
a9 ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ff

Best regards,
Matti

2013/11/7 matti kaasinen <[email protected]>

Quoted 172 lines

Hi Pekon,
Thank you for your answers. Please find my answers/comments to your
questions below.

2013/11/6 Gupta, Pekon <[email protected]>

Hi Matti and Matthias

Quoted 21 lines

Sorry I was away from my mailbox so couldn't reply you earlier. I'm still away from my setup and other boards, so cannot replicate the issue below until early next week. But I'll surely do so asap..

However, please see my replies below, which might help you someway.

Quoted 4 lines

From: matti kaasinen [mailto:matti.kaasinen at gmail.com] Hi Pekon,
Thanks to Tom Rini's hint I have tried to execute your patch sets (

http://patchwork.ozlabs.org/project/uboot/list/?submitter=17320&state=*
)

Quoted 4 lines

in order to get Linux and U-Boot working with same NAND flash.
Set-up is pretty much like Mathias has before in this chain. Latest problem I faced with is that last versions of
1) "[U-Boot,v8,3/5] mtd: nand: omap: optimize chip->ecc.calculate()

for H/W ECC schemes"

Quoted 1 line

and 2) "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC -

NAND driver updates"

Quoted 9 lines
Quoted 3 lines

are not compatible any more. As I told in
https://groups.google.com/forum/#!topic/beagleboard/7ofbE_Rrn_s
versions v5..v7 of 1) could possibly be compatible.

There is no change in ECC layout or other functional updates between
v7 and v8 of this patch, so if there is any incompatibility then it would
be in all versions of the patch..

I did not mean "ECC layout-wisely" incompatible but "patching-wisely"
incompatible. Patching 2) v2 after 1) v8 stops to errors and it seems that with 1) v7 it could (possibly) succeed.

Few questions..

Quoted 2 lines

(1) Which ECC scheme are you using ?

Now I'm talking Linux 3.8.13 - U-Boot 10.04 combination that I have as currently as "working" environment. I have not managed getting above patches successfully through.

Quoted 4 lines

- u-boot
CONFIG_NAND_OMAP_ECCSCHEME as per doc/README.nand
http://lists.denx.de/pipermail/u-boot/2013-October/164646.html

U-Boot 10.04 does not seem to have such choices and in fact I have
not selected it.

Quoted 5 lines

- kernel
OMAP_ECC_BCH8_CODE_HW
OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
Or any other..

I believe OMAP_ECC_BCH8_CODE_HW gets selected with following options from kernel.

CONFIG_MTD_NAND_OMAP2
CONFIG_MTD_NAND_OMAP_BCH
CONFIG_MTD_NAND_OMAP_BCH8

... and selecting following choice

ti,nand-ecc-opt = "bch8"

in device tree.

With these options boot process reports;

[    1.128154] enabling NAND BCH ecc with 8-bit correction
[    1.133985] ONFI param page 0 valid
[    1.137662] ONFI flash detected
[    1.140985] NAND device: Manufacturer ID: 0x2c, Chip ID: 0xda (Micron

MT29F2G08AAD), 256MiB, page size: 2048, OOB size: 64

First line seems coming from drivers/nand/mtd/omap2.c:omap3_init_bch that gets printed in this from only if OMAP_ECC_BCH8_CODE_HW ==
platform_data.ecc_opt

I printed nand.ecc.layout.eccbytes = 52 ( from from
drivers/nand/mtd/omap2.c:omap3_init_bch_tail ) and
nand.ecc.layout->eccpos[] = 12..63

BTW it seems that similar layout has been defined in u-boot arch/arm/include/asm/arch-omap3/omap_gpmc.h
There is one exception, though: eccbytes have been set 54 instead of
52 that seems to be in linux (and correct I suppose).

Quoted 4 lines

(2) Is the problem related to incorrect read/write access to x16 NAND ?

No using x8 NAND

Quoted 3 lines

Or
Is it incompatibility in ecc.layout ?

You can check this by dumping raw nand page via 'nand dump' command

Quoted 3 lines

from both u-boot and kernel.

I'll try to check this

Quoted 1 line

(3) you should not pick BCH16 patch-series

Quoted 9 lines

- because I have not rebased this patch, and re-tested since other base patch-series on which BCH16 will be build, is still not
accepted.
- Also BCH16 ecc scheme would work only for
NAND device with pagesize=4K and oobsize=224.
whereas current beaglebone capes have
NAND device with pagesize=2K and oobsize=64, so you can only use BCH8 with current NAND capes (for now)..

This is perfectly fine with me. This set seems to block patching. I
need only BCH8 and if this patch set provides only BCH16 functionality and nothing else, I need not using it.

Quoted 24 lines
Quoted 8 lines
Quoted 8 lines

2013/11/1 Matthias Fuchs <[email protected]>
Hi Pekon,

Quoted 7 lines
Quoted 7 lines

should I consider the U-Boot and Linux am335x NAND implementation to be compatible? So are the ECC schemes in a way identical that I can nandwrite a kernel image from Linux and "nand read" it from U-Boot? I tested with the 3.8.13 beaglebone kernel (which is of course not very representative)
and it does not work. If it should work, do you know it that was
already the case before your patches and with which Linux kernel?

I don't think any earlier kernel versions ever supported beaglebone
Its only recently that a major patch-series of NAND driver was accepted and tested on beaglebone.
The patches are currently in l2-mtd.git tree which should make into 3.13 kernel, before being in linux-next for sometime.
(a) Reference:
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049462.html

Quoted 5 lines

(b) In addition to above series, you might need beaglebone DTS updates which you can refer from below ..
http://lists.infradead.org/pipermail/linux-mtd/2013-October/049438.html

So, you mean that it should not be possible to access beaglebone

(alike) board NAND with Linux 3.8.13. However, it seems that I can access it from Linux (well, I have done some patching for IO and mux and device tree). Problem really is that U-Boot and Linux handle it in different ways so that if I create e.g. ubifs volume in Linux, that works quite fine. I can rean/write it quite fine. However, if I mount it from U-boot, it get tons of ecc error messages and as a result it gets corrupted. After that also Linux side prints tons of ecc error messages while acessing it.

Quoted 2 lines

with regards, pekon

Thanks,
Matti

#22 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Quoted 1 line

From: matti kaasinen [matti.kaasinen at gmail.com]

[...]

Quoted 8 lines

You mentioned, that OMAP_ECC_BCH8_CODE_HW mode and ecc.bytes=14 has to be used. I suppose that at least the former option requires kernel patching like explained in
http://processors.wiki.ti.com/index.php/AM35x-OMAP35x
PSP_04.02.00.07_UserGuide#Selecting_NAND_ECC_scheme_for_Linux_Kernel

In any case I did not find configuration option in menuconfig for that. Will "ecc.bytes=14" setting be taken care by that selection, too?

Yes, the selection of "BCH8" along with "H/W ECC for OMAP devices" should automatically select (OMAP_ECC_BCH8_CODE_HW) which implicitly would configure chip->ecc.bytes = 14.

The layout will also be selected automatically, and this all is in accordance to NAND boot as documented in AM335x TRM [1].
- http://www.ti.com/product/am3359
- [1] latest AM3359 TRM
http://www.ti.com/litv/pdf/spruh73i

(a) Section: 26.1.7.4 NAND
- This section explains ROM code behavior for booting from NAND. ROM code also fetches device geometry from ONFI params. In addition there is a separate boot mode (called NANDI2C) where device parameters can be fetched from on-board EEPROM.

(b) Figure 26-15. ECC Data Mapping for 2 KB Page and 8b BCH Encoding
- This figure explains ecc layout used by ROM code, which is what I'm using as reference for BCH8_HW algorithm.

with regards, pekon

#23 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Pekon,
Thank you for you advices.
http://processors.wiki.ti.com/index.php/AM35x-OMAP35x-PSP_04.02.00.07_UserGuide#Selecting_NAND_ECC_scheme_for_Linux_Kernelacvices
selecting "Selecting NAND ECC scheme for Linux Kernel" by editing:
arch/arm/mach-omap2/board-flash.c
and
drivers/mtd/nand/omap2.c
I try to use Angstrom distribution as a base for my design. Angstrom provides 3.8.13 kernel for beaglebone. There drivers/mtd/nand/omap2.c seems pretty demanding as far as changing chip->ecc.bytes configuration is concerned. That feature seems hard-coded with numeric literal 13 everywhere in that file. So, changing that to 14 does not seem too good idea with my understanding level of that module operation.

Thanks anyway,
Matti

2013/11/18 Gupta, Pekon <[email protected]>

Quoted 37 lines
Quoted 1 line

From: matti kaasinen [matti.kaasinen at gmail.com]

[...]

Quoted 8 lines

You mentioned, that OMAP_ECC_BCH8_CODE_HW mode and ecc.bytes=14 has to be used. I suppose that at least the former option requires kernel patching like explained in
http://processors.wiki.ti.com/index.php/AM35x-OMAP35x
PSP_04.02.00.07_UserGuide#Selecting_NAND_ECC_scheme_for_Linux_Kernel

In any case I did not find configuration option in menuconfig for that. Will "ecc.bytes=14" setting be taken care by that selection,

too?

Yes, the selection of "BCH8" along with "H/W ECC for OMAP devices" should automatically select (OMAP_ECC_BCH8_CODE_HW) which implicitly would configure chip->ecc.bytes = 14.

The layout will also be selected automatically, and this all is in accordance
to NAND boot as documented in AM335x TRM [1].
- http://www.ti.com/product/am3359
- [1] latest AM3359 TRM
http://www.ti.com/litv/pdf/spruh73i

(a) Section: 26.1.7.4 NAND
- This section explains ROM code behavior for booting from NAND. ROM code also fetches device geometry from ONFI params. In addition there is a separate boot mode (called NANDI2C) where device parameters can be fetched from on-board EEPROM.

(b) Figure 26-15. ECC Data Mapping for 2 KB Page and 8b BCH Encoding
- This figure explains ecc layout used by ROM code, which is what I'm using as reference for BCH8_HW algorithm.

with regards, pekon

#24 lore raw

v8 cover mtd: nand: omap: optimize and clean-up of OMAP NAND driver

Hi Matti,

Quoted 3 lines

From: matti kaasinen [mailto:matti.kaasinen at gmail.com]
I try to use Angstrom distribution as a base for my design. Angstrom provides 3.8.13 kernel for beaglebone. There drivers/mtd/nand/omap2.c seems pretty demanding as far as changing chip->ecc.bytes configuration is concerned. That feature seems hard-coded with numeric literal 13 everywhere in that file. So, changing that to 14 does not seem too good idea with my understanding level of that module operation.

I have no clue about 3.8.13 kernel provided along with SDK, as there is as separate team in TI to support that. However I know is that beaglebone with NAND cape was not up on that kernel becoz many of the DT and GPMC updates were not present in that kernel version. So even if you take my patches (of u-boot), I doubt that you would be able to boot kernel from beaglebone.

If you need support for 3.8.13 kernel, I suggest you refer to post a query to e2e.ti.com forum. I don't know if you would be able to get any help in this maillist.

But if you plan to use mainline. These patches work fine.

with regards, pekon